[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 Rafael Lima changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 --- Comment #10 from Rafael Lima --- > Not sure if all this helps ;-) It helped me start from a different angle, then after a some time I managed to find where it is. Thanks! Actually the code that creates the default template is hard-coded in the method SdDrawDocument::CreateLayoutTemplates() inside the file: /core/sd/source/core/drawdoc4.cxx I changed the default template and tested if it breaks compatibility with files created with the current build. Fortunately the styles are saved inside the .odp file and compatibility is not broken. I'll submit the patch to Gerrit for review. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 --- Comment #9 from Heiko Tietze --- (In reply to Rafael Lima from comment #8) > Hi! I am interested in fixing this issue. I just need some help with code > pointers. Described my approach in https://design.blog.documentfoundation.org/2018/02/22/easyhacking-set-environment/ I search for the string "_Word wrap text in shape", find cui/uiconfig/ui/textattrtabpage.ui, search for TSB_WORDWRAP_TEXT and find m_xTsbWordWrapText, get its state from SDRATTR_TEXT_WORDWRAP. Atr this point it becomes a bit time-consuming, for example this is misleading svx/source/svdraw/svdattr.cxx has rPoolDefaults[SDRATTR_TEXT_WORDWRAP -SDRATTR_START]=new SdrOnOffItem(SDRATTR_TEXT_WORDWRAP, true); Not sure if all this helps ;-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 --- Comment #8 from Rafael Lima --- Hi! I am interested in fixing this issue. I just need some help with code pointers. I was browsing the code to search where the default template is located. At first I was looking for some .otp file (Impress Template File), but could not find any. After some searching, it seems that the template is actually hard-coded at: /core/xmloff/source/draw/XMLGraphicsDefaultStyle.cxx Can anyone confirm if this is the file I should be working on to fix this issue? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #7 from Heiko Tietze --- We discussed the RFE in the design meeting and agree that having text wrapped by default makes sense. It might be an easyhack. Implementation should check the patch to not affect existing documents. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl Version|7.0.0.0.beta1+ |Inherited From OOo --- Comment #6 from Cor Nouws --- I think it is more occurring that people want text wrapped, also in shapes, then run out. So IMO good to change this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #5 from V Stuart Foote --- Wait, for these controls on all Draw shape objects, their Text... dialog, Text tab, Custom Shape text--doesn't the outcome of 'Word wrap text in shape' interact with 'Resize shape to fit text' control? Both are disabled by default for new draw shape text. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #4 from Regina Henschel --- If word wrap is enabled in the default-style, then it would likely solve bug 113926 too. [It is not duplicate, because different kind of shapes are affected.] ODF has no explicit default value, the underlying XSL has "wrap" as initial value. Current MS Office uses "wrap" as default. I think, it would be good to use "wrap" as default in LibreOffice too. (In reply to Heiko Tietze from comment #3) > Any potential side-effect of having word wrap on by default? I don't know. But fixing the problem should include examining the imports/exports, especially with OOXML and with binary MS Office formats, whether they presume any default. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Severity|normal |enhancement CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Summary|Text does not wrap in |Enable word-wrap by default |Callouts in Impress |for shapes --- Comment #3 from Heiko Tietze --- Any potential side-effect of having word wrap on by default? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
