[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 steve changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #39 from steve --- Verified as per https://bugs.documentfoundation.org/show_bug.cgi?id=145843#c37 Thanks Patrick for the fix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #38 from Commit Notification --- Patrick Luby committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/1f58b2e0d941cfb8be10a5068b41096a06b078a6 tdf#145843 Do not use CGBitmapContextCreate() to create a bitmap context It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 |target:7.4.0.0.beta2|target:7.4.0.0.beta2 |target:7.6.0|target:7.6.0 ||target:7.5.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 Patrick Luby changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #37 from Telesto --- (In reply to Patrick Luby from comment #35) > I have uploaded "Patchset 3" to the following link: > > https://bugs.documentfoundation.org/show_bug.cgi?id=145843 > > @Telesto > > Patchset 3 fixes the crash when running Skia/Raster on my macOS 12.6.2 Intel > laptop. Does Patchset 3 fix the crash on your machine? Working like a charm Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 102846d45cb9660805e209b6954c7b8d707b8288 CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Raster; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #36 from Commit Notification --- Patrick Luby committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9ec57a3dc7925d6f86a19d0e179e065df53e542f tdf#145843 Do not use CGBitmapContextCreate() to create a bitmap context It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 |target:7.4.0.0.beta2|target:7.4.0.0.beta2 ||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #35 from Patrick Luby --- I have uploaded "Patchset 3" to the following link: https://bugs.documentfoundation.org/show_bug.cgi?id=145843 @Telesto Patchset 3 fixes the crash when running Skia/Raster on my macOS 12.6.2 Intel laptop. Does Patchset 3 fix the crash on your machine? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #34 from Patrick Luby --- (In reply to Patrick Luby from comment #33) > I have posted the following patch that fixes this bug for on my macOS 12.6.2 > Intel machine: > > https://gerrit.libreoffice.org/c/core/+/144194 > > @Telesto, > > Does the patch fix the bug for you? If no, I have another fix that I can try > to work around the "read past the end of the bitmap buffer" bug that Luboš > Luňák's found in CGBitmapContextCreate(). Ignore the above patch. CGBitmapContextCreateWithData() crashes as well just not as frequently as CGBitmapContextCreate(). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #33 from Patrick Luby --- I have posted the following patch that fixes this bug for on my macOS 12.6.2 Intel machine: https://gerrit.libreoffice.org/c/core/+/144194 @Telesto, Does the patch fix the bug for you? If no, I have another fix that I can try to work around the "read past the end of the bitmap buffer" bug that Luboš Luňák's found in CGBitmapContextCreate(). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #32 from Patrick Luby --- (In reply to Telesto from comment #30) > > Whole problem, I can create the issue with a few steps.. somehow, but not > everybody else does. > > Comment 8 works pretty reliable for me > > Alternative > 1. Open Impress from Start Center > 2. Double click BeeHive template > 3. LibreOffice -> About Window -> Press Copy About > 4. Close the dialog > 5. Enter Click to add title > 6. CMD+V > 7. LibreOffice -> About Window -> Press Copy about -> Might crash here > 8. Close the dialog > 9. Go to slide 2 > 10. CMD+V > 11. LibreOffice -> About Window -> Press Copy about -> Crash > > Alternative -> even less predictable > 1. Open Writer from Start Center > 2. LibreOffice -> Preferences -> View > 3. Uncheck Use Skia for all rendering > 4. Hoover over the Apply/ OK buttons.. Press Apply button. Close the restart > button. Press Cancel in the Preference dialog > > It appears Window related, the dialogs appear like tip of the day/ template > manager/ about window/ preference the often it happens. > > But will there some kind of timing element.. > > Sidenote: the patch attachment 181096 [details] authored by Luboš Luňák - > received by email - solves the issue. However a different patch got pushed > at comment 24 for unknown reasons Thank you for the steps. I can now reproduce the crash using your first alternative. I now understand why the patch in attachment 181096 was not used: it makes a copy of the bitmap in memory. It fixes the crashing, but it would require a lot more memory and frequently copying of bitmaps. I added the debug patch in attachment 184138 and I noticed the following debug output immediately before the crash: debug:2178:56744: XXX:0x63e71e00 709x464*2R::1418x928::2::244x232@(399,156) 798,312,488,464::5672::6 2::6 2 debug:2178:56744: XXX:0x63e71e00 709x464*2R::1418x928::2::200x145@(509,319) 1018,638,400,290::5672::6 2::6 22022-12-14 08:57:10.358900-0500 soffice[2178:56744] [org.libreoffice.script] copy_read_only: vm_copy failed: status 1. Note that the first line doesn't crash and the second one crashes. Both are taking a small subarea of the same bitmap. The difference is that the subarea in the second one aligns with the bottom, right edges of the bitmap. >From the above, I think that Luboš Luňák's "HACK for tdf#145843" in vcl/skia/osx/gdiimpl.cxx now makes sense to me. His fix is just missing cases like this. I will see if I am able to expand his fix to handle this case. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #31 from Telesto --- Created attachment 184138 --> https://bugs.documentfoundation.org/attachment.cgi?id=184138=edit Debug patch attachment 181096 is based on output of debug code, attached. Output at that point in time (7 februari 2022) > debug:12486:654528: XXX:0x63e8e700 > 841x570*2R::1682x1140::2::289x143@(550,427) 1100,854,578,286::6728::6 2::6 > 2 > > 2022-02-07 17:21:50.812613+0100 soffice[12486:654528] > [org.libreoffice.script] copy_read_only: vm_copy failed: status 1. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #30 from Telesto --- (In reply to Patrick Luby from comment #29) > I was able to reproduce this bug with Skia/Raster. Unfortunately I was only > able to reproduce one time. That was on my macOS Intel running macOS > Monterey 12.6.2. > > I am testing by running a local build (checked out from master earlier > today) in lldb. Does anyone have any other steps that they use to trigger > this crash? Whole problem, I can create the issue with a few steps.. somehow, but not everybody else does. Comment 8 works pretty reliable for me Alternative 1. Open Impress from Start Center 2. Double click BeeHive template 3. LibreOffice -> About Window -> Press Copy About 4. Close the dialog 5. Enter Click to add title 6. CMD+V 7. LibreOffice -> About Window -> Press Copy about -> Might crash here 8. Close the dialog 9. Go to slide 2 10. CMD+V 11. LibreOffice -> About Window -> Press Copy about -> Crash Alternative -> even less predictable 1. Open Writer from Start Center 2. LibreOffice -> Preferences -> View 3. Uncheck Use Skia for all rendering 4. Hoover over the Apply/ OK buttons.. Press Apply button. Close the restart button. Press Cancel in the Preference dialog It appears Window related, the dialogs appear like tip of the day/ template manager/ about window/ preference the often it happens. But will there some kind of timing element.. Sidenote: the patch attachment 181096 authored by Luboš Luňák - received by email - solves the issue. However a different patch got pushed at comment 24 for unknown reasons -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #29 from Patrick Luby --- (In reply to Telesto from comment #28) > @Patrick Luby > Thanks for all the patches in the macOS area. I'm bit opportunistic here.. > this bug is still bothering me. LibreOffice crashes regularly with Skia > Raster enabled (no issue with Vulkan) > > Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community > Build ID: da3dd48eaf9086f8ab28d6a6655f9a638e51433a > CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Raster; VCL: osx > Locale: nl-NL (nl_NL.UTF-8); UI: en-US > Calc: threaded I was able to reproduce this bug with Skia/Raster. Unfortunately I was only able to reproduce one time. That was on my macOS Intel running macOS Monterey 12.6.2. I am testing by running a local build (checked out from master earlier today) in lldb. Does anyone have any other steps that they use to trigger this crash? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster (STR comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 Telesto changed: What|Removed |Added CC||plub...@neooffice.org Summary|Incidental Crash on macOS |Incidental Crash on macOS |with skia raster|with skia raster (STR ||comment 8) --- Comment #28 from Telesto --- @Patrick Luby Thanks for all the patches in the macOS area. I'm bit opportunistic here.. this bug is still bothering me. LibreOffice crashes regularly with Skia Raster enabled (no issue with Vulkan) Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: da3dd48eaf9086f8ab28d6a6655f9a638e51433a CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Raster; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
