[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Julien Nabet changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #20 from Julien Nabet --- Since 7.2 branch is EOL (see https://wiki.documentfoundation.org/ReleasePlan/7.2) let's consider this one as FIXED. If someone finds GDI leaks with LO 7.3.4 min, don't hesitate to reopen this tracker. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Mike Kaganski changed: What|Removed |Added CC||luca.mangane...@comune.tren ||to.it --- Comment #19 from Mike Kaganski --- *** Bug 135844 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 --- Comment #18 from Julien Nabet --- Jan-Marek: can we put this one as FIXED or do you want first cherry-pick your patch on 7.2 branch? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 --- Comment #17 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c2a581ffc1f4e3888c5c243932b71c3d96e8ba8f tdf#62812 WIN use a compatible DC for font funcs It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Julien Nabet changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|serval2...@yahoo.fr |libreoffice-b...@lists.free ||desktop.org --- Comment #16 from Julien Nabet --- I unassigned myself since I abandoned my patch. Good news is Jan-Marek is preparing a far better patch here: https://gerrit.libreoffice.org/c/core/+/125652 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #15 from Julien Nabet --- I gave a try with https://gerrit.libreoffice.org/c/core/+/125636, I don't see the leaks anymore with GDIView. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812
--- Comment #14 from Julien Nabet ---
Thanks to
https://www.codeproject.com/Articles/5306193/Find-GDI-Leaks-With-Windows-Debugger,
I found some GDI leaks when exporting in PDF.
Here are 2 parts of bts retrieved from Windbg.
Since the pb was font GDIs, I used the line of the quoted website:
bm gdi32!createfont* "kp"
1)
00 00ac`99380e38 7ffd`34f3d2e1 GDI32!CreateFontIndirectW
01 00ac`99380e40 7ffd`34f3cc26
vclplug_winlo!WinSalGraphics::ImplDoSetFont(class vcl::font::FontSelectPattern
* i_rFont = 0x00ac`99381000, class vcl::font::PhysicalFontFace *
i_pFontFace = 0x01e8`6b09c880, struct HFONT__ ** o_rOldFont =
0x00ac`99380f98)+0x61
[C:\cygwin\home\serva\lode\dev\core\vcl\win\gdi\salfont.cxx @ 823]
02 00ac`99380f40 7ffd`3ebb6002
vclplug_winlo!WinSalGraphics::GetGlyphWidths(class vcl::font::PhysicalFontFace
* pFont = 0x01e8`6b09c880, bool bVertical = false, class
std::vector > * rWidths = 0x01e8`20aa6ad0, class
std::map,std::allocator > > * rUnicodeEnc = 0x01e8`20aa6af0)+0xa6
[C:\cygwin\home\serva\lode\dev\core\vcl\win\gdi\salfont.cxx @ 1650]
2)
00 00ac`9937f5a8 7ffd`34f3d2e1 GDI32!CreateFontIndirectW
01 00ac`9937f5b0 7ffd`34f3a760
vclplug_winlo!WinSalGraphics::ImplDoSetFont(class vcl::font::FontSelectPattern
* i_rFont = 0x00ac`9937f7f0, class vcl::font::PhysicalFontFace *
i_pFontFace = 0x01e8`65620770, struct HFONT__ ** o_rOldFont =
0x00ac`9937f798)+0x61
[C:\cygwin\home\serva\lode\dev\core\vcl\win\gdi\salfont.cxx @ 823]
02 00ac`9937f6b0 7ffd`3ec480d4
vclplug_winlo!WinSalGraphics::CreateFontSubset(class rtl::OUString * rToFile =
0x00ac`9937f978 "file:///C:/cygwin/tmp/5330.tmp", class
vcl::font::PhysicalFontFace * pFont = 0x01e8`65620770, unsigned short *
pGlyphIds = 0x00ac`99381340, unsigned char * pEncoding =
0x00ac`99381240 "", long * pGlyphWidths = 0x00ac`99380e40, int
nGlyphCount = 0n4, class FontSubsetInfo * rInfo = 0x00ac`9937fb80)+0xc0
[C:\cygwin\home\serva\lode\dev\core\vcl\win\gdi\salfont.cxx @ 1554]
If we focus on first bt, we have in WinSalGraphics::GetGlyphWidths:
1646 HFONT hOldFont = nullptr;
1647 ImplDoSetFont(aIFSD, pFont, hOldFont);
See
https://opengrok.libreoffice.org/xref/core/vcl/win/gdi/salfont.cxx?r=3f5fb075#1647
But let's take a look at ImplDoSetFont
818 HFONT hNewFont = nullptr;
...
823 hNewFont = ::CreateFontIndirectW( &aLogFont );
...
855 return hNewFont;
See
https://opengrok.libreoffice.org/xref/core/vcl/win/gdi/salfont.cxx?r=3f5fb075&mo=24673&fi=814#814
So ImplDoSetFont creates a GDI font object and returns it.
In our case, we don't retrieve the value so it leaks.
Now, let's search calls to ImplDoSetFont in Opengrok.
https://opengrok.libreoffice.org/s?refs=ImplDoSetFont&project=core
It's been called in 3 different locations in salfont.cxx
1) CreateFontSubset() (the second bt)
2) GetEmbedFontData()
3) GetGlyphWidths() (the first bt we focused)
It's also called in WinFontInstance::SetGraphics() from
/vcl/win/gdi/winlayout.cxx
but here we got:
m_hFont = m_pGraphics->ImplDoSetFont(GetFontSelectPattern(), GetFontFace(),
hOrigFont);
and its destruction is managed in dtor:
115 WinFontInstance::~WinFontInstance()
116 {
117 if (m_hFont)
118 ::DeleteFont(m_hFont);
119 }
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 --- Comment #13 from Buovjaga --- (In reply to Buovjaga from comment #12) > (In reply to Julien Nabet from comment #11) > > Any update with LO 6.4.3 > > Still repro with steps from comment 4 > > Arch Linux 64-bit > Version: 7.0.0.0.alpha1+ > Build ID: 809ddff82dc9a28051d8f6b0d6513b1824ba0ab9 > CPU threads: 8; OS: Linux 5.6; UI render: default; VCL: kf5; > Locale: fi-FI (fi_FI.UTF-8); UI: en-US > Calc: threaded > Built on 19 May 2020 Bleh, make that Version: 7.0.0.0.alpha1+ (x64) Build ID: 4804d969bacd25ad586b3bf70d3dc8c27adb48ef CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: fi-FI (fi_FI); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Buovjaga changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #12 from Buovjaga --- (In reply to Julien Nabet from comment #11) > Any update with LO 6.4.3 Still repro with steps from comment 4 Arch Linux 64-bit Version: 7.0.0.0.alpha1+ Build ID: 809ddff82dc9a28051d8f6b0d6513b1824ba0ab9 CPU threads: 8; OS: Linux 5.6; UI render: default; VCL: kf5; Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 19 May 2020 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Julien Nabet changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #11 from Julien Nabet --- Any update with LO 6.4.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 --- Comment #10 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Aron Budea changed: What|Removed |Added Blocks||105469 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105469 [Bug 105469] [META] Bugs hitting limit for GDI objects in Windows -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #9 from Xisco Faulí --- Some fixes have been done to the GDI handles recently. Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ? You can install it alongside the standard version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Buovjaga changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #8 from Buovjaga --- (In reply to Julien Nabet from comment #7) > Any better with last stable LO version 5.2.2? Still growing. Win 7 Pro 64-bit Version: 5.3.0.0.alpha1+ Build ID: 63bd9cf4ad268d83677baf99ec509ef67b5de08a CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; TinderBox: Win-x86@39, Branch:master, Time: 2016-11-07_01:55:57 Locale: fi-FI (fi_FI); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Julien Nabet changed: What|Removed |Added Status|NEW |NEEDINFO CC||serval2...@yahoo.fr --- Comment #7 from Julien Nabet --- Any better with last stable LO version 5.2.2? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 Xisco Faulí changed: What|Removed |Added Keywords||filter:pdf Blocks||103378 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.documentfoundation.org/show_bug.cgi?id=62812 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.4 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-12-20 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.freedesktop.org/show_bug.cgi?id=62812 Beluga changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #5 from Beluga --- I did as instructed in comment 4 and observed the font count increase after every PDF export, so I'm setting this as NEW. Version: 4.4.0.0.alpha1+ Build ID: a8c24b25fd9fb21097a08a22797bf61b59099ea1 TinderBox: Win-x86@39, Branch:master, Time: 2014-10-21_06:33:33 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.freedesktop.org/show_bug.cgi?id=62812 Michael Stahl changed: What|Removed |Added Attachment #77103|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.freedesktop.org/show_bug.cgi?id=62812 Joel Madero changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.freedesktop.org/show_bug.cgi?id=62812 --- Comment #4 from flajs.em...@centrum.cz --- Simplest scenario for a reproduction bug: 1) Execute LibreOffice 4.0.1.2 on Windows 7 2) Create new document in Writer 3) write several words with fonts Arial, Arial Bold, Times New Roman etc 4) Run GDIView - applikaction for monitoring windows objects resources DC, Fonts, etc. http://www.nirsoft.net/utils/gdi_handles.html 5) Export this document to PDF 6) Check GDIView (F5 refresh) on soffice.bin process -> Font object growth 7) repeat steps 5,6 It's info OK ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.freedesktop.org/show_bug.cgi?id=62812 Joel Madero changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Severity|critical|normal CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #3 from Joel Madero --- This is not a critical bug if it exists. Also what are you using to do your batch conversion? Marking as NEEDINFO as we need more explicit steps on how to reproduce the bug. Please be as explicit as possible when describing steps for a bug, especially slightly more complicated bugs that include batch changes. Once you provide steps please mark as UNCONFIRMED and we shall try to triage the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.freedesktop.org/show_bug.cgi?id=62812 --- Comment #2 from flajs.em...@centrum.cz --- files are closed, other formats (txt...) ... OK -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62812] writer_pdf_Export Font GDI handle leaks
https://bugs.freedesktop.org/show_bug.cgi?id=62812 --- Comment #1 from flajs.em...@centrum.cz --- Created attachment 77104 --> https://bugs.freedesktop.org/attachment.cgi?id=77104&action=edit attachment with good mimetype -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
