[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #18 from QA Administrators  ---
Dear Harald Koester,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #17 from QA Administrators  ---
Dear Harald Koester,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|easyHack, needsDevEval  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0343

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1566

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #16 from Harald Koester  ---
(In reply to Heiko Tietze from comment #15)
> (In reply to Mike Kaganski from comment #14)
> > Cancelling the dialog is a valid way to tell "this time no need to edit
> > properties" - this does not (and should not) cancel the save.
> 
> True. Actually the whole option is nonsense - for what purpose a user wants
> to edit properties with every save? If empty, yes, but not always.

The dialogue "Properties..." is only displayed if the document is saved the
first time or it is saved with a different name. Hence it is not correct that
the dialogue is displayed with every save.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #15 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #14)
> Cancelling the dialog is a valid way to tell "this time no need to edit
> properties" - this does not (and should not) cancel the save.

True. Actually the whole option is nonsense - for what purpose a user wants to
edit properties with every save? If empty, yes, but not always.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #14 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #13)

Cancelling the dialog is a valid way to tell "this time no need to edit
properties" - this does not (and should not) cancel the save.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #13 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #11)
> (In reply to Timur from comment #1)
> > Actually, the document is saved BEFORE document properties dialog appears.
> 
> This is incorrect. And one can easily check that: while the properties
> dialog still open, use a file manager to check if the file has been updated
> ...

If you cancel the properties dialog the file shows up anyway. Of course it
might be two independent procedures but OTOH the file saving could also not
have been finalized.

Anyway, the best solution is to show properties before save. The cancel thing
is relevant for both solutions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #12 from Mike Kaganski  ---
A code pointer: SfxStoringHelper::GUIStoreModel in
sfx2/source/doc/guisaveas.cxx (see the "if ( aOptions.IsDocInfoSave() ..."
condition).

In my opinion, more easy and safe would be to keep the order, but just augment
the aModelData.ShowDocumentInfoDialog() with required arguments to override
some displayed properties (which otherwise are taken from current media, which
is not the new file at the moment of the dialog execution).

The other option (to show the dialog prior to file picker) possibly needs more
work, e.g. careful cleanup after user has canceled the save operation in file
picker (I am not sure if there is such code currently in case of failed save
operation). Or may not, depending on if you consider setting the properties as
part of save or not (a separate editing operation).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #11 from Mike Kaganski  ---
(In reply to Timur from comment #1)
> Actually, the document is saved BEFORE document properties dialog appears.

This is incorrect. And one can easily check that: while the properties dialog
still open, use a file manager to check if the file has been updated (check
file modification time); even better it's seen when a file is created/saved as:
the new file is simply absent yet.

> Solution should be either:
> - Rename "Edit document properties BEFORE saving" to "Edit document
> properties AFTER saving" and display saved properties in the  properties
> dialog OR

So - this is a wrong option (wrt that "AFTER").

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #10 from Heiko Tietze  ---
(In reply to Mihir from comment #9)
> I would like to work on this bug if it is open. Can I get an idea, where I
> can start?

Searching for "Edit document properties before saving" [1] I get EditProperty,
which in turn brings "EOption::DocInfSave" that would be the internal variable
for this option. Maybe you can make your way through the code with this info.
Otherwise dev wisdom is needed.

[1]
https://opengrok.libreoffice.org/search?project=core=%22Edit+document+properties+before+saving%22=
[2]
https://opengrok.libreoffice.org/search?project=core=EditProperty=

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #9 from Mihir  ---
I would like to work on this bug if it is open. Can I get an idea, where I can
start?
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |easyHack, needsDevEval
 CC||tietze.he...@gmail.com
  Component|UI  |LibreOffice
   Severity|minor   |normal

--- Comment #8 from Heiko Tietze  ---
The option "Tools > Options > Load/Save > Edit document properties before
saving" shows the document properties dialog on saving with the issue that the
entered filename is not taken into it. The proposed solution to show properties
first and save subsequently makes sense from UX POV (Timur points out comment 1
that the file is saved after the first dialog, so the alternative solution is
not ideal).

This change is likely an easy hack.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

Timur  changed:

   What|Removed |Added

   Keywords||needsUXEval

--- Comment #7 from Timur  ---
Need UX eval to decide on opted solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

Harald Koester  changed:

   What|Removed |Added

 Blocks||108747

--- Comment #6 from Harald Koester  ---
Bug still exists with version 5.4.2 (64 Bit, Win 10).


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108747
[Bug 108747] [META] File properties/settings (meta data) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #5 from Xisco Faulí  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of
LibreOffice 
(5.4.1 or 5.3.6  https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of
LibreOffice and 
your operating system, and any changes you see in the bug behavior

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave 
a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword


Feel free to come ask questions or to say hello in our QA chat:
http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug-20170929

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #4 from Harald Koester  ---
Bug still exists in version 5.2.1 with Win7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of
LibreOffice 
(5.1.5 or 5.2.1  https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of
LibreOffice and 
your operating system, and any changes you see in the bug behavior

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave 
a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword


Feel free to come ask questions or to say hello in our QA chat:
http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug-20160920

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

Beluga todven...@suomi24.fi changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #2 from Beluga todven...@suomi24.fi ---
Reproduced.

Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+
Build ID: 9de1d53a2ce3ee7036b4688b373db7b2235af4d9
TinderBox: Win-x86@39, Branch:master, Time: 2015-05-14_00:07:12
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

Timur gti...@gmail.com changed:

   What|Removed |Added

 CC||gti...@gmail.com
Version|4.4.3.2 rc  |Inherited From OOo
 OS|Windows (All)   |All
   Severity|normal  |minor

--- Comment #1 from Timur gti...@gmail.com ---
I confirm, but I'll let someone else to confirm. I set as inherited from OO.

(In reply to Harald Koester from comment #0)
 Comment: You can argue, that the displayed information of file name, file
 type and location are correct, hence the document has not been saved yet.
Actually, the document is saved BEFORE document properties dialog appears.
Also, if we save the document (new or save as), and cancel the (empty or
existing) properties dialog, and then close and reopen the document, it will
have the correct (new or saved as) properties. 

Solution should be either:
- Rename Edit document properties BEFORE saving to Edit document properties
AFTER saving and display saved properties in the  properties dialog OR
- Change the order of both dialogues, first display the “Properties...”
dialogue and then the “Save as...” dialogue (as proposed by submitter).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs