[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | --- Comment #16 from Justin L --- I missed the note in comment 7 that this is clearly a regression from 2014-01-23. I looked at the import code for inspiration (oox/source/drawingxml/shape.cxx Shape::createAndInsert). I found nothing in there to suggest that there is anything special about rotation == 180. So I think Luke was correct in his comment 5 suggestion. I promised myself that I would not do any more shape-related commits, but this saga already has my name in it, so I can't resist another try... Luke, the testing that you did with grouping - was that all with .docx? It looks like this rotation block should be avoided if DocumentType == DOCX (similar qualifications found elsewhere in the code). But I should test with grouped shapes, custom shapes, and line shapes to see if it is only a subset of DOCX. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 --- Comment #15 from Justin L --- *** Bug 119000 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 --- Comment #14 from Luke --- I just checked and I can confirm that this bug was originally fixed with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9ae1e094 PPTX export: correct position of rotated groups It regressed again with https://cgit.freedesktop.org/libreoffice/core/commit/?id=ee45d881 tdf#114845 sd: only shift rotated group items -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 Paul Trojahn changed: What|Removed |Added Assignee|paul.troj...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 Paul Trojahn changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |paul.troj...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 Luke changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2861 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 --- Comment #10 from Luke --- Tamás Zolnai, Not at the moment, so it would be great if you could take a stab at it. Using pShape->GetUpGroup() to test group membership didn't produce the correct results, so there's something wrong with my analysis or my code. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 --- Comment #9 from Tamás Zolnai --- Hi Luke, Are you still working on this issue? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 --- Comment #8 from Miklos Vajna --- You already have access to the SdrObject representing the shape in question. Try using SdrObject::GetUpGroup() to test if it's a standalone shape or it's inside a group. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 Luke changed: What|Removed |Added Keywords|filter:docx |bisected, regression Version|unspecified |4.2.8.2 release --- Comment #7 from Luke --- Version: 4.2.8.2 correctly exports the test file, while 4.3.7.2 suffers from this regression. Marking as bisected since reverting https://cgit.freedesktop.org/libreoffice/core/commit/?id=60635557 fixes this issue. Miklos, I assume the issue is the check for 180 should only apply to members of a group. Any code pointers? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 --- Comment #6 from Luke --- The build is failing in Linux because sw/qa/extras/ooxmlexport/data/dml-textshape.docx has a connector that is rotated 180 deg. When I ungroup that connector, it is not shifted on roundtrip. I made some more test cases and found that my patch fails when a group of shapes have members that are rotated 180 deg. Should the 180 deg check only be applied to members of a group? Or is there something else going on here? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 --- Comment #5 from Luke --- Patch on gerrit here: https://gerrit.libreoffice.org/#/c/40689/ Miklos could you please take a look at this? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip
https://bugs.documentfoundation.org/show_bug.cgi?id=91999 Luke changed: What|Removed |Added Summary|FILESAVE: Inverted Shapes |FILESAVE: Shapes Rotated |Moved on Round-Trip |180 Moved on Round-Trip -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs