Re: [Libreoffice-qa] [ANN] Referencing bugs in commits

2012-02-17 Thread Lionel Elie Mamane
On Tue, Feb 14, 2012 at 04:16:33PM +0100, Jan Holesovsky wrote:

 whenever you are committing / pushing to git, and you
 reference the bugs.freedesktop.org bug in the commit message, it will
 automatically appear as a comment in the bug :-)

It seems not to happen this morning. In general, after how much time
after commit should we get worried and report it?

 - 8 -
 fdo#45748: Don't use empty pages for computing the page break position
 - 8 -

 It will result in the following comment in bugzilla:

 https://bugs.freedesktop.org/show_bug.cgi?id=45748#c7

It says:

 $AUTHOR commited a patch related to this issue to $BRANCH

That's misleading. See e.g.
https://bugs.freedesktop.org/show_bug.cgi?id=45748#c9
and
http://cgit.freedesktop.org/libreoffice/core/commit/?id=66cf06ebdd4eeb95e801de114af06b49119fc7feg=libreoffice-3-5
Committed by Tor, but authored by Cédric. The message in the bug says
Cédric committed.

I would suggest one of:

 A patch by $AUTHOR related to this issue was committed to $BRANCH

(should it be has been committed maybe?)

or

 $COMMITTER committed a patch by $AUTHOR related to this issue to $BRANCH

or
 $AUTHOR's patch related to this issue was/has been committed to $BRANCH

-- 
Lionel
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


Re: [Libreoffice-qa] Relase_Criteria wiki page change request

2012-02-17 Thread Nino Novak
On Thursday 16 February 2012, Petr Mladek wrote:

 Nino Novak píše v Čt 16. 02. 2012 v 02:01 +0100:

  [Transclusion] 

 Sounds wonderful! I was not aware of such feature.

oh, there are still many unused wiki features left ;-)
 

  For conveniance, I've attached a patch, hopefully it works ;-)
 
 I have done the changes. I hope that correctly ;-)

Yepp, thanks, works fine :-)


 Anyway, feel free to do such changes yourself. If it works as you say,
 it is just a great improvement.

There must have been a (cache?) problem with exactly this page as I was not 
allowed to edit it (always getting the browse source response only, telling 
me that my email has not been verified yet).

Now I tried again and it finally worked  :-)

Nino
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [ANN] Referencing bugs in commits

2012-02-17 Thread Jan Holesovsky
Hi Lionel,

Lionel Elie Mamane píše v Pá 17. 02. 2012 v 09:23 +0100:

  whenever you are committing / pushing to git, and you
  reference the bugs.freedesktop.org bug in the commit message, it will
  automatically appear as a comment in the bug :-)
 
 It seems not to happen this morning. In general, after how much time
 after commit should we get worried and report it?

fdo seems to have some problems (terribly slow today), and it has been
timing out.  Generally, the comments should appear at the same time the
CIAbot reports appear on IRC.

 That's misleading. See e.g.
 https://bugs.freedesktop.org/show_bug.cgi?id=45748#c9
 and
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=66cf06ebdd4eeb95e801de114af06b49119fc7feg=libreoffice-3-5
 Committed by Tor, but authored by Cédric. The message in the bug says
 Cédric committed.

I've now changed it to:

- 8 -
$author committed a patch related to this issue.
It has been pushed to $branch:

... etc., as before ...
- 8 -

Any further tweaks possible, if it is still confusing.

Regards,
Kendy

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [ANN] Referencing bugs in commits

2012-02-17 Thread Markus Mohrhard
Hey,

2012/2/17 Lionel Elie Mamane lio...@mamane.lu:
 On Tue, Feb 14, 2012 at 04:16:33PM +0100, Jan Holesovsky wrote:

 whenever you are committing / pushing to git, and you
 reference the bugs.freedesktop.org bug in the commit message, it will
 automatically appear as a comment in the bug :-)

 It seems not to happen this morning. In general, after how much time
 after commit should we get worried and report it?


This one was my mistake. It is quite difficult to test this scricpt so
that sometimes after a change or a new situation it does not update
the bug (please watch next week with pushing bugs to 3-5 and 3-5-1).
If you see a commit with a bug number announced by CIA bot and the
script did not update the bug drop Kendy and me a short note.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/