Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
On Tue, Feb 14, 2012 at 04:16:33PM +0100, Jan Holesovsky wrote: whenever you are committing / pushing to git, and you reference the bugs.freedesktop.org bug in the commit message, it will automatically appear as a comment in the bug :-) It seems not to happen this morning. In general, after how much time after commit should we get worried and report it? - 8 - fdo#45748: Don't use empty pages for computing the page break position - 8 - It will result in the following comment in bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45748#c7 It says: $AUTHOR commited a patch related to this issue to $BRANCH That's misleading. See e.g. https://bugs.freedesktop.org/show_bug.cgi?id=45748#c9 and http://cgit.freedesktop.org/libreoffice/core/commit/?id=66cf06ebdd4eeb95e801de114af06b49119fc7feg=libreoffice-3-5 Committed by Tor, but authored by Cédric. The message in the bug says Cédric committed. I would suggest one of: A patch by $AUTHOR related to this issue was committed to $BRANCH (should it be has been committed maybe?) or $COMMITTER committed a patch by $AUTHOR related to this issue to $BRANCH or $AUTHOR's patch related to this issue was/has been committed to $BRANCH -- Lionel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
Hi Lionel, Lionel Elie Mamane píše v Pá 17. 02. 2012 v 09:23 +0100: whenever you are committing / pushing to git, and you reference the bugs.freedesktop.org bug in the commit message, it will automatically appear as a comment in the bug :-) It seems not to happen this morning. In general, after how much time after commit should we get worried and report it? fdo seems to have some problems (terribly slow today), and it has been timing out. Generally, the comments should appear at the same time the CIAbot reports appear on IRC. That's misleading. See e.g. https://bugs.freedesktop.org/show_bug.cgi?id=45748#c9 and http://cgit.freedesktop.org/libreoffice/core/commit/?id=66cf06ebdd4eeb95e801de114af06b49119fc7feg=libreoffice-3-5 Committed by Tor, but authored by Cédric. The message in the bug says Cédric committed. I've now changed it to: - 8 - $author committed a patch related to this issue. It has been pushed to $branch: ... etc., as before ... - 8 - Any further tweaks possible, if it is still confusing. Regards, Kendy ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
Hey, 2012/2/17 Lionel Elie Mamane lio...@mamane.lu: On Tue, Feb 14, 2012 at 04:16:33PM +0100, Jan Holesovsky wrote: whenever you are committing / pushing to git, and you reference the bugs.freedesktop.org bug in the commit message, it will automatically appear as a comment in the bug :-) It seems not to happen this morning. In general, after how much time after commit should we get worried and report it? This one was my mistake. It is quite difficult to test this scricpt so that sometimes after a change or a new situation it does not update the bug (please watch next week with pushing bugs to 3-5 and 3-5-1). If you see a commit with a bug number announced by CIA bot and the script did not update the bug drop Kendy and me a short note. Regards, Markus ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
Hi Lionel, On 2012-02-16 at 14:11 +0100, Lionel Elie Mamane wrote: It seems to set target:3.6 for commits to master. As per http://wiki.documentfoundation.org/BugReport_Details, this should be 3.6.0. Fixed :-) Regards, Kendy ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
On Tue, Feb 14, 2012 at 07:49:04PM +0100, Jan Holesovsky wrote: Ivan Timofeev píše v Út 14. 02. 2012 v 20:33 +0400: Is it possible somehow include the information about a target version? Oh - great idea :-) Added that to the script; it does some best-effort guess, (...) Please test that it works :-) It seems to set target:3.6 for commits to master. As per http://wiki.documentfoundation.org/BugReport_Details, this should be 3.6.0. -- Lionel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote: Markus has implemented a nice feature that should help keeping the bugs up to date: whenever you are committing / pushing to git, and you ooh ! really lovely :-) Great work Markus ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
On 14.02.2012 19:31, Michael Meeks wrote: On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote: Markus has implemented a nice feature that should help keeping the bugs up to date: whenever you are committing / pushing to git, and you ooh ! really lovely :-) Great work Markus ! Indeed!!! :) I'm always exceedingly amazed at the work Markus do as a free-time contributor. Just a question: Is it possible somehow include the information about a target version? Best Regards, Ivan ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
hello, The bug reference has to have fdo#ABCDE form (where ABCDE is the bug number), and has to be at the first line of the commit (it does not matter where on that line). Sorry, one point is for me not clear: by the first line, do you mean title line or would it works also as first line of the comment (hence not being into the title) ? Thanks Pierre-André ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] Referencing bugs in commits
On Tue, 2012-02-14 at 20:33 +0400, Ivan Timofeev wrote: Is it possible somehow include the information about a target version? I guess that -should- be implicit in the branch it is committed to, so - sounds feasible ;-) at least - the expert eye can see that information there already. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
