[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #30 from Heiko Tietze  ---
(In reply to Commit Notification from comment #29)
> ...we can do this with a sizegroup

And I was so proud of my first code ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #29 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6efdd843c831527b2880959746c302fca87c40db

Related: tdf#105371 we can do this with a sizegroup

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

Heiko Tietze  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #28 from Heiko Tietze  ---
No crash anymore, either solved with other code or I just had to compile
everything.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #27 from Commit Notification 
 ---
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=789ed159fb03eef26c991f361380d0eb7b509cd9

tdf#105371, tdf#99456 Alignment in find & replace dialog

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

Heiko Tietze  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

Heiko Tietze  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

--- Comment #26 from Heiko Tietze  ---
(In reply to poma from comment #25)
> Thank you for participating!

The patch for the labels is still pending. The dialog crashes LibO on my system
when closed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

poma  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #25 from poma  ---
What a pity!
However, at least we tried to solve it.

Thank you for participating!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #15 from poma  ---
If there is value, be free to apply a patch to the tree, you or someone else
who can.

There are also other fine adjustments which can be applied within various Glade
files,
in 'svx/uiconfig/ui/', however more on that in another bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #24 from Heiko Tietze  ---
(In reply to poma from comment #23)
> - PPI (aka DPI): 200

Sounds like a WONTFIX. We would need to make the dialog larger for those
unusual resolutions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #23 from poma  ---
Created attachment 130749
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130749=edit
LO 5.3.0.3 - Boutons Rechercher

UI language French,
dialog "Rechercher & remplacer" (en. "Find & Replace"),
text "Rechercher le précédant" (en. "Find Previous") of the label within the
button "backsearch",
and text "Rechercher le suivant" (en. "Find Next") of the label within the
button "search",
need more horizontal space.

The relevant settings are:
- Font size: 12
- PPI (aka DPI): 200
- Desktop enviroment: Xfce
- Desktop theme: Darkgrey
- VCL UI interfaces: GTK+ 3

Tested with:
libreoffice --version
LibreOffice 5.3.0.3 30(Build:3)
patched with:
"tdf#105371, tdf#99456 Alignment in find & replace dialog"
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=8e96cc8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #22 from poma  ---
Heiko, thank you for the welcome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

Heiko Tietze  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED
   Assignee|libreoffice-b...@lists.free |tietze.he...@gmail.com
   |desktop.org |

--- Comment #21 from Heiko Tietze  ---
Created attachment 130597
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130597=edit
Reworked dialog on gtk3

Removed the fix width (both 80 and 120px are bad) and added some code in order
to set the width on runtime in respect to the longest text. Took me a while to
find out why the buttons were squeezed- the code is uncommented now. And
finally I unset the resizable flag for this dialog.

Changes are in https://gerrit.libreoffice.org/#/c/33370/1. Unfortunately there
is something wrong with my code, it's my first real code contribution, which
leads to a crash when the dialog is closed. Hope to get a solution from the
reviewers.

PS: Learn more about how to submit patches at
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch Your
contribution is very welcome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #20 from poma  ---
(In reply to Heiko Tietze from comment #19)
> (In reply to poma from comment #18)
> > Heiko, you can test patch yourself, without compiling an entire libreoffice,
> > just (re)start it after changing 'findreplacedialog.ui'.
> 
> Please submit the patch to gerrit to allow cherrypicking. 

http://devcentral.libreoffice.org

Gerrit is the tool LibreOffice developers use for code review. This is where
developers submit and review patches.


This looks like a tool exclusively for developers, not for users.

> The screenshot looks good. But I'm afraid you place controls at a fix
> position, and that won't work for all label sizes, screen resolutions, and
> font scaling.

Can you share your patch here, because in itself a comment is not clear enough.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #19 from Heiko Tietze  ---
(In reply to poma from comment #18)
> Heiko, you can test patch yourself, without compiling an entire libreoffice,
> just (re)start it after changing 'findreplacedialog.ui'.

Please submit the patch to gerrit to allow cherrypicking. 
The screenshot looks good. But I'm afraid you place controls at a fix position,
and that won't work for all label sizes, screen resolutions, and font scaling.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #18 from poma  ---
As a reference,
after Wine (https://winehq.org) installs 'LibreOffice_5.3.0.2_Win_x86.msi',
"Find & Replace" UI config file is parked here:
~/.wine/drive_c/Program\ Files/LibreOffice\
5/share/config/soffice.cfg/svx/ui/findreplacedialog.ui
linked as:
~/.wine/dosdevices/c\:/Program\ Files/LibreOffice\
5/share/config/soffice.cfg/svx/ui/findreplacedialog.ui

Heiko, you can test patch yourself, without compiling an entire libreoffice,
just (re)start it after changing 'findreplacedialog.ui'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #17 from poma  ---
Created attachment 130563
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130563=edit
Wine 2.0-rc4 - Find & Replace - LibreOffice 5.3.0.2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

--- Comment #16 from poma  ---
Created attachment 130562
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130562=edit
Find & Replace: Make room for the longest translated labels, Similarities and
Sounds buttons

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

poma  changed:

   What|Removed |Added

Summary|Labels "Find:" and  |Find & Replace Dialog: tune
   |"Replace:" need more width  |up

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 105371] Find & Replace Dialog: tune up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105371

poma  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise