[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #21 from V Stuart Foote  ---
Created attachment 183988
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183988=edit
old above and new below showing increased ruler element contrast

upper clip from 20221201 nightly

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: ce60a3dd4dbff0dcb5b82c9053ae5d90f8ac929d
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

below clip from 20221204 nightly

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: c50cf1883af26daebdfc9d796ced3c20c222f43b
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

Caolán McNamara  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #20 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8d66d1f270b1f3fdb76d749fa92189d669ea436d

Resolves: tdf#152284 pull Shadow and DarkShadow from theme

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #19 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/fa98397842f42a9741f1e6b110d7feebec994e3d

Resolves: tdf#152284 pull Shadow and DarkShadow from theme

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0 target:7.4.4

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #18 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1e222575a3b637398b5b2d8e3172f12538ff34e3

Related: tdf#152284 use a different macOS DarkShadow

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #17 from Caolán McNamara  ---
Created attachment 183956
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183956=edit
windows after proposed change

with patch at https://gerrit.libreoffice.org/c/core/+/143594

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #16 from Caolán McNamara  ---
Created attachment 183955
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183955=edit
windows before change

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

--- Comment #15 from Caolán McNamara  ---
I see a plausible setting on windows to get something meaningful from the theme

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #14 from Caolán McNamara  ---
Created attachment 183953
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183953=edit
macOS after proposed change

with this patch https://gerrit.libreoffice.org/c/core/+/143573

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #13 from Caolán McNamara  ---
Created attachment 183952
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183952=edit
macOS before

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #12 from Caolán McNamara  ---
I think the specific color at issue here is vcl's "DarkShadowColor"

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

V Stuart Foote  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #11 from V Stuart Foote  ---
@Caolán, see any *simple* solution here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #10 from dhina  ---
(In reply to TorrAB from comment #9)
> (In reply to V Stuart Foote from comment #7)
> 
> > In truth the indent markers and the tab stops are perfectly readable.
> ● Honestly?

I think it depends of the screen brightness and people's eyes. Above 30%
brightness on my laptop, I can see them enough. But I think they should be
visible even for low-brightness and  then I agree the contrast between them and
their background should be increased.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #9 from tor...@yahoo.com ---
(In reply to V Stuart Foote from comment #7)

> In truth the indent markers and the tab stops are perfectly readable.
● Honestly?

> The tics, tab marks and margin settings become simple White on black marks.
● ‘White on black’ would be good; but they really are dark-grey on black

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

--- Comment #8 from V Stuart Foote  ---
Created attachment 183905
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183905=edit
Win10 os/DE in dark color mode, default LibreOffice "automatic" color scheme
vs. LibreOffice Dark color scheme with fixed colors

So Windows, and macOS benefit from the kludged fixed color 'LibreOffice Dark'
color scheme shown here on Windows 10 in os/DE dark color mode.  

In current master against 7.5.0 the default white on black UI toggle is on top.

On bottom is same install with the 'LibreOffice Dark' color scheme enabled,
showing the altered fixed color for Document background and Application
background  which though constrained are visually more appealing.

Without major rework of the Application Colors frame work to more granularly
define the UI not clear more can be done for Windows and macOS.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 152284] Increase contrast of the ruler elements when os/DE is in a Dark color mode

2022-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152284

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Blocks||150915, 118017, 103184
 Ever confirmed|1   |0
Version|7.4.3.2 release |7.5.0.0 alpha0+ Master
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
Summary|Indent markers are almost   |Increase contrast of the
   |invisible in DarkMode   |ruler elements when os/DE
   ||is in a Dark color mode
 Status|REOPENED|UNCONFIRMED
   Severity|normal  |enhancement

--- Comment #7 from V Stuart Foote  ---
Hmm, kind of subjective.

In truth the indent markers and the tab stops are perfectly readable. The
default black on white/black on gray for traditional os/DE 'Light' color theme
is toggled for the os/DE 'Dark' color theme. The tics, tab marks and margin
settings become simple White on black marks.  They are readable.

Could they have higher contrast? Sure. And could the ruler bar have better
contrast to background? Sure.

Would require refactoring of the ruler object to pick up additional theme
color(s).


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103184
[Bug 103184] [META] UI theming bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118017
[Bug 118017] [META] macOS Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150915
[Bug 150915] [META] Windows Dark Mode bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.