Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-15 Thread Stephan Bergmann
On 02/14/2012 02:33 PM, Michael Meeks wrote: On Tue, 2012-02-14 at 23:07 +1030, Josh Heidenreich wrote: What is the markup format to be used in the READMEs? It's a loose copy of the wikimedia syntax used in the wiki, so: - Paragraphs are separated by a blank line. - Headings are in the form

Re: [ANN] Referencing bugs in commits

2012-02-15 Thread Pierre-André Jacquod
hello, The bug reference has to have fdo#ABCDE form (where ABCDE is the bug number), and has to be at the first line of the commit (it does not matter where on that line). Sorry, one point is for me not clear: by the first line, do you mean title line or would it works also as first line of

input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Pierre-André Jacquod
hello, I have quickly investigated the crash in fdo#45779 when saving an impress document. The reason of the crash is in basegfx/inc/basegfx/point/b2dpoint.hxx (line 82) where this is called: 2DPoint::B2DPoint (this=0xbfffc850, rPoint=...) : B2DTuple(rPoint) (from back-trace) It

Re: one-big library approach of mozilla ...

2012-02-15 Thread Taras Glek
On 2/14/2012 4:24 AM, Michael Meeks wrote: Hi Taras, We're running into some fun performance development iteration problems with LibreOffice as we plan to merge more libraries together; and I was wondering - how does Mozilla deal with that ? How long does it take your

Re: [Libreoffice-commits] Remove unused VolumeDevice functions and related code

2012-02-15 Thread Francois Tigeot
On Tue, Feb 14, 2012 at 06:18:52PM +0100, Stephan Bergmann wrote: On 02/05/2012 09:52 PM, François Tigeot wrote: Remove unused VolumeDevice functions and related code [...] diff --git a/sal/util/sal.map b/sal/util/sal.map index 472ea8f..338854d 100644 --- a/sal/util/sal.map +++

Re: poor little bug

2012-02-15 Thread Cedric Bosdonnat
On Tue, 2012-02-14 at 20:06 +0100, Luc Castermans wrote: I'm this poor little bug left alone in the corner. When will I be solved ? Feel free to have a look at the code! You seem to forget that I already spent days for a first fix that improves the situation. That's not the way I was told to say

Re: No page and Columns boundaries in 3.5

2012-02-15 Thread Cedric Bosdonnat
That was a design choice that was started long ago in the OpenOffice.org times, discussed at least lively with Christoph Noack (and most probably on the ux-advise list) a few months ago... I don't really like being asked to get some different feature back right after the release when people have

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-15 Thread Thorsten Behrens
Stephan Bergmann wrote: I wonder whether there's not some package to translate one of those newfangled lightweight markups into HTML which could be reused here? Sure - e.g. http://search.cpan.org/~rwstauner/Pod-Markdown-1.20/lib/Pod/Markdown.pm or http://pypi.python.org/pypi/Markdown

Re: [Libreoffice-commits] Remove unused VolumeDevice functions and related code

2012-02-15 Thread Michael Meeks
On Wed, 2012-02-15 at 09:05 +0100, Francois Tigeot wrote: I may have been a bit too enthusiastic with sal.map; feel free to add the entries back if you think they are needed. Heh - so, we should of course leave the functions there so linking continues to work, but have dummy

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-15 Thread Michael Meeks
On Tue, 2012-02-14 at 23:01 +0100, Stephan Bergmann wrote: On 02/14/2012 10:39 PM, Josh Heidenreich wrote: Do we need licence blocks in a README? Can we just write the licence in on all pages generated by the script? My (naive?) take on it is that, technically, all the files committed to

Re: .: bin/get-bugzilla-attachments-by-mimetype

2012-02-15 Thread Michael Stahl
On 21/11/11 11:18, Caolán McNamara wrote: On Mon, 2011-11-21 at 02:04 +0100, Miklos Vajna wrote: On Mon, Nov 14, 2011 at 02:37:07AM -0800, Caolán McNamara cao...@kemper.freedesktop.org wrote: add script to download documents from various bugzillas i've pimped it a bit and it can now

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Thorsten Behrens
Pierre-André Jacquod wrote: B2DTuple(const B2DTuple rTup) ... Here you dereference the null pointer, which crash. Ok, the basic attitude would be to let B2DTuple be Null-pointer consistent: (checking that rTup is not NULL), but is it really a good idea? Hi Pierre-André, no, what's

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-15 Thread Caolán McNamara
On Tue, 2012-02-14 at 12:01 +, Caolán McNamara wrote: On Tue, 2012-02-14 at 09:45 +0100, G.H.M.Valkenhoef, van wrote: Yes, I found that java code (the HelpIndexer I refer to). I'll work on a patch to replace the XInvocations of the Java code with calls to my code. I can try and

Re: .: bin/get-bugzilla-attachments-by-mimetype

2012-02-15 Thread Caolán McNamara
On Wed, 2012-02-15 at 11:06 +0100, Michael Stahl wrote: that's the only thing that's still missing... should i file an easy hack? :) Indeed, that probably makes sense. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED-3-5] fdo#45995 fdo#45992

2012-02-15 Thread Noel Power
On 14/02/12 19:17, Petr Mladek wrote: It did not work because the test document used linked picture. It works well with the updated test document. The changes look reasonable. They work well = I have pushed them into the 3-5 branch, see

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Thorsten Behrens
Or should I look higher in the hierarchy, saying that a NULL point in a B2DPolygon has nothing to do and disallow it ? Yes, the calling code somehow accesses invalid elements. Let me have a look. Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you like, would be cool to

[REVIEW-3-5] Fix for fdo#45779

2012-02-15 Thread Thorsten Behrens
Hi there, could someone please review cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 for -3-5? TIA, -- Thorsten pgpMmILR9mq7a.pgp Description: PGP signature ___ LibreOffice mailing list

Re: No page and Columns boundaries in 3.5

2012-02-15 Thread Tommy
On Tue, 14 Feb 2012 19:16:56 +0100, Fernand Vanrie s...@pmgroup.be wrote: On the user lists the first complaints about no page and column boundaries for LO Writer 3.5 are comming in. For some documents the new corner layout can be helpfull but without visible page and column boundaries it

Re: linking performance

2012-02-15 Thread Michael Stahl
On 14/02/12 13:30, Mark Wielaard wrote: Hi, Added Tom to the CC, see thread here: http://thread.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/24055/focus=24096 (Although it seems posts from non-subscribers, aka me, are not allowed, so you won't see my earlier reply there. I'll

Re: README.cross patch [REJECTED]

2012-02-15 Thread Tor Lillqvist
Ther autogen.lastrun samples in README.cross are *examples*. If should be obvious that: --with-android-ndk=/home/tml/android-ndk-r7 is an example and not to be used literally. Replacing it with --with-android-ndk= Location of ndk download doesn't really help much. Especially as ndk download

[PUSHED] Re: [REVIEW-3-5] Fix for fdo#45779

2012-02-15 Thread Michael Stahl
On 15/02/12 11:32, Thorsten Behrens wrote: Hi there, could someone please review cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 for -3-5? hmm.. dividing by 0 considered harmful indeed

[REVIEW] fdo#45553 fix RTF import of space-before/after tokens

2012-02-15 Thread Miklos Vajna
Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=c32b9cd2139249f0c680f664a0ceac3702dd0e73 Could someone review and cherry-pick to -3-5, please? Thanks, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

2012-02-15 Thread Jan Holesovsky
Hi Winfried, Winfried Donkers píše v St 15. 02. 2012 v 07:27 +0100: Pushed that, thank you a lot for that! http://cgit.freedesktop.org/libreoffice/core/commit/?id=80a72c4cc7edc6b4c0b88d841500617cd733cbf7 Kendy To my horror the behaviour of the pushed patch is not identical to the patch I

[PUSHED] Turn on strictures for some installer Perl modules

2012-02-15 Thread Michael Meeks
Hi Tim ! On Tue, 2012-02-14 at 23:02 +, Tim Retout wrote: I'd like to try to clean up some of the code in the solenv Perl modules Cool ! it is long overdue. - as a first task, I want to turn on 'use strict', which I'd consider a bare minimum for maintainable Perl. Longer-term,

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

2012-02-15 Thread Winfried Donkers
Kendy wrote (15-02-2012 12.34) I only changed some (leading) tabs to spaces, it should not affect anything. But to be sure, just take the patch from git and diff it with your patch that works for you, and look at the differences. I thought so, but you never know. Thanks for checking. should I

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Tor Lillqvist
On 14 February 2012 19:23, Tor Lillqvist t...@iki.fi wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). Hmm, I experimented with this but apparently didn't commit and then did a git reset and lost the changes, or something. Will have a look again if I still have the

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

2012-02-15 Thread Jan Holesovsky
Hi Winfried, Winfried Donkers píše v St 15. 02. 2012 v 13:15 +0100: should I revert the patch in the meantime? I understood from Markus Mohrhard that Tor had fixed the git/qa problem. I intend to look into it later this afternoon (UTC); I don't think reverting the patch is necessary, it's

connectivity::ORowSetValue cleanup and behaviour

2012-02-15 Thread Lionel Elie Mamane
Hi, The connectivity contains a ORowSetValue class, to hold a database value, along with its type. Obviously this class is used all over the place in our database-related code. I'm itching to change it in non-trivial ways, and I've hit some WTFs, so I thought I'd check if someone knows a good

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Matúš Kukan
On 15 February 2012 13:35, Tor Lillqvist t...@iki.fi wrote: On 14 February 2012 19:23, Tor Lillqvist t...@iki.fi wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). Hmm, I experimented with this but apparently didn't commit and then did a git reset and lost the

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-15 Thread Caolán McNamara
On Tue, 2012-02-14 at 22:27 +0100, Gert van Valkenhoef wrote: 1. how to convert the rtl::UOString to the TCHAR* that CLucene needs. 2. In xmlhelp/source/cxxhelp/provider/makefile.mk, I've hacked the include path to include l10ntools/source/help Attached patch hopefully basically takes care

[PUSHED 3-5] Re: [REVIEW][3-5] Re: Bug 45530 - Accessibility does not work

2012-02-15 Thread Jan Holesovsky
Hi Michael, Michael Stahl píše v St 15. 02. 2012 v 13:35 +0100: please somebody review and backport the following to libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=fbe60c962259ae0449acd65e74fd790530045e93

Re: [PUSHED][PATCH] unusedcode.easy: Removed unused code

2012-02-15 Thread Caolán McNamara
On Fri, 2012-02-10 at 17:39 +0100, Alexander Bergmann wrote: --- editeng/source/editeng/editdoc.cxx |8 editeng/source/editeng/editdoc.hxx |1 - pushed this now, thanks for this. C. ___ LibreOffice mailing list

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Tor Lillqvist
It was something more than this: ? Umm, no, that was it. Now I am confused, why don't I see that in my master checkout after merging the branch to master? Git is a mystery. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Lionel Elie Mamane
On Wed, Feb 15, 2012 at 01:46:55PM +0100, Philipp Weissenbacher wrote: So, any developer wishes on what to translate next? In general, dbaccess/ and connectivity/ are the two modules of particular interest to me. I get the impression I'll have to dig into forms/ in the next months, just today,

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Stephan Bergmann
On 02/14/2012 06:23 PM, Tor Lillqvist wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, to reduce the overall number of dynamic libraries. But for other

Re: [PUSHED] Remove unused methods from PDFI

2012-02-15 Thread Michael Meeks
On Mon, 2012-02-13 at 19:48 +, Kate Goss wrote: I'm also contemplating tackling bugs in bugzilla assistant, if that would be helpful. Oh ! cool :-) yes very much so, Rainer has a number of tweaks and issues in there queued up for fixing if I remember correctly, it'd be just lovely

Re: [PATCH] [PUSHED] Translate German comments - final patch

2012-02-15 Thread Stefan Knorr (Astron)
Hi, pushed this with minor modifications. Thanks a lot for your work, Philipp! I hope you weren't already on this, Lionel... if yes, sorry. Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PUSHED] Re: [PATCH] Help - minor updates

2012-02-15 Thread Jan Holesovsky
Hi Stanislav, Radek Doulik píše v Út 14. 02. 2012 v 17:53 +0100: Makes sense, thanks for clarification. Pushed. (master and 3-5 branches) Marking the thread as [PUSHED] :-) BTW - it is great that you are working on the help! Do you want to continue? I think some of the new 3.5 features

Re: changes in profile path in release notes for 3.5

2012-02-15 Thread Cor Nouws
Stephan Bergmann wrote (13-02-12 10:06) Introduced with http://cgit.freedesktop.org/libreoffice/core/commit/?id=9276f7d5740a28b342db2a9bcd8644ff2f4f5742 fdo#32263; should affect all Linux desktops. Thanks for the info, Stephan, -- - Cor - http://nl.libreoffice.org

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Michael Meeks
On Wed, 2012-02-15 at 13:46 +0100, Philipp Weissenbacher wrote: Find attached the patch that finalises my efforts to get rid of the German comments in sw/source/core/doc. Wonderful ! :-) Thanks Michael BTW for the mention in your Easy Hacks talk at FOSDEM. Much appreciated!

Re: connectivity::ORowSetValue cleanup and behaviour

2012-02-15 Thread Lionel Elie Mamane
On Wed, Feb 15, 2012 at 01:55:34PM +0100, Lionel Elie Mamane wrote: 2) Signed integers and unsigned integers never compare equal. But an unsigned integer compares equal to the corresponding float... Errr... They obviously should? I misread the code... Need coffee. integers never

[REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-15 Thread Stephan Bergmann
As per https://bugs.freedesktop.org/show_bug.cgi?id=45696#c3 Importing uno bindings in python causes crash the master commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b1be1ce0e0ac7b34c4b73d53f4bf32ec5df7290 Reintroduce pyuno.so wrapper around libpyuno.so should please be

Re: [PUSHED] Code removal, first contribution

2012-02-15 Thread Jan Holesovsky
Hi Catalin Catalin Iacob píše v Po 13. 02. 2012 v 22:09 +0100: So it sounds like you did an excellent job; what's next ? an easy hack perhaps ? or more unused code ? :-) It would be cool to try an easy hack If you haven't chosen yet, the Easy Hack landing page is here:

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Philipp Weissenbacher
On 15 February 2012 14:56, Michael Meeks michael.me...@suse.com wrote: So, any developer wishes on what to translate next?        Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Luc Castermans
2012/2/15 Philipp Weissenbacher p.weissenbac...@gmail.com: On 15 February 2012 14:56, Michael Meeks michael.me...@suse.com wrote: So, any developer wishes on what to translate next?        Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Nicolas Christener
Hi On Wed, 2012-02-15 at 13:56 +, Michael Meeks wrote: [...] So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Nicolas Christener
Hi On Wed, 2012-02-15 at 13:56 +, Michael Meeks wrote: [...] So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Stephan Bergmann
On 02/15/2012 03:11 PM, Tor Lillqvist wrote: I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, Well, --enable-mergelibs is probably actually intended for Android only, I think? I wasn't sure about the status of --enable-mergelibs,

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Tor Lillqvist
I wasn't sure about the status of --enable-mergelibs, whether it is only something Android-specific or whether it is also used to enable that general merge/LTO endeavor. I don't know either, really. But anyway, I will make the sal_textenc+sal merge Android-specific and not mergelibs-specific;)

[PATCH] Translate German comments

2012-02-15 Thread Philipp Weissenbacher
Hi all, Lionel, Here are the files you mentioned earlier. Hope quality didn't suffer with this quick job. You might want to take a look at line num 2185 in DatabaseForm.cxx. Looks like commented out code. If you still find any German strings, please contact me and I'll help you. Cheers,

[PUSHED] Re: [PATCH] Remove unused code

2012-02-15 Thread Jan Holesovsky
Just adding [PUSHED] :-) Radek Doulik píše v Út 14. 02. 2012 v 19:03 +0100: Hi Santiago, thanks for you patch, pushed. Cheers Radek On Mon, 2012-02-13 at 21:55 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy

Re: [PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

2012-02-15 Thread Noel Grandin
Hi Updated patch implementing Ivan's suggestion. Passes make and make check. Convert tools/table.hxx usage in editeng/inc/editeng/forbiddencharacterstable.hxx to std::map Contributed under LGPLv3+ / MPL 1.1 or later. (And my license statement is on file in the wiki) Regards, Noel. On

JRE warning on startup ...

2012-02-15 Thread Michael Meeks
Hi guys, There have been a number of complaints about JRE's being required during install, with the infamous and horribly unpleasant: LibreOffice requires a Java runtime environment (JRE) to perform this task. Please install a JRE and restart LibreOffice

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Philipp Weissenbacher
      Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. I'm already working on this and will provide patches in a few days :) So I think we'll wait for that,

Re: [PATCH] SwDocStub now prints out parameters

2012-02-15 Thread Markus Mohrhard
Hey, thanks a lot for your great work here. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Luc Castermans
2012/2/15 Philipp Weissenbacher p.weissenbac...@gmail.com:       Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. I'm already working on this and will

Re: JRE warning on startup ...

2012-02-15 Thread Caolán McNamara
On Wed, 2012-02-15 at 15:13 +, Michael Meeks wrote: Since we switched ~everything to passive registration, I believe this comes from the bundled extension help indexing on very-first-start. So, if its the case that its from extension help indexing, then this would probably be from

javadep.c Java 7

2012-02-15 Thread Ivan Timofeev
Hi, I found soltools/javadep/javadep.c that contains a very simple parser for java class files. The problem is that it is old, at least it does not handle the class files generated by Java 7: as far as I remember, java guys added the new types of constant pool entries, but... javadep.c:520:

RE: qa-build errros on clean code

2012-02-15 Thread Winfried Donkers
Tor already fixed it and after a pull you should be able to build. (http://cgit.freedesktop.org/libreoffice/core/commit/?id=49a4b4c32bda86b97ef48d1d2ce9bf8f02d3e2e3) Hope that your next build succeeds. Markus No such luck :( After git pull -r, the first clean build went ok, but the next build

more (caligra) test files ...

2012-02-15 Thread Michael Meeks
On Wed, 2012-02-15 at 10:15 +, Caolán McNamara wrote: On Wed, 2012-02-15 at 11:06 +0100, Michael Stahl wrote: that's the only thing that's still missing... should i file an easy hack? :) Indeed, that probably makes sense. If we're doing this systematically, we should prolly

Re: poor little bug

2012-02-15 Thread Michael Meeks
On Tue, 2012-02-14 at 20:06 +0100, Luc Castermans wrote: I'm this poor little bug left alone in the corner. When will I be solved ? This is in pretty poor taste, and doesn't belong on the developers list - which is for discussion of constructive development: hacking on fixes, code

Re: qa-build errros on clean code

2012-02-15 Thread Riccardo Magliocchetti
Hi Winfried, Il 15/02/2012 16:30, Winfried Donkers ha scritto: Value: 8 33formel: =A1+B1 3 ucalc.cxx:2924:Assertion Test name: N12_GLOBAL__N_14TestE::testPostIts assertion failed - Expression: m_pDoc-GetNote(rAddr) == NULL - note hasn't moved Any suggestions? I have this very same failure

RE: qa-build errros on clean code

2012-02-15 Thread Winfried Donkers
Riccardo Magliocchetti wrote (15 februari 2012) ucalc.cxx:2924:Assertion I have this very same failure plus another connectivity related, building with this patch applied to at least finish the build: http://paste.ubuntu.com/843064/ Yes, I'll also disable the tests that produce assertions.

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-15 Thread Michael Meeks
On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As per https://bugs.freedesktop.org/show_bug.cgi?id=45696#c3 Importing uno bindings in python causes crash the master commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b1be1ce0e0ac7b34c4b73d53f4bf32ec5df7290

Re: [PATCH] Remove unused code from gtkframe

2012-02-15 Thread Michael Meeks
Hi Kate, On Tue, 2012-02-14 at 21:33 +, Kate Goss wrote: Please find attached a patch to remove a couple of methods listed in unusedcode.easy, from gtkframe. Sadly they are used - but only for the gtk3 mode that caolan is not compiling. Perhaps instead if you could move up the #if

Re: javadep.c Java 7

2012-02-15 Thread Stephan Bergmann
On 02/15/2012 04:31 PM, Ivan Timofeev wrote: I found soltools/javadep/javadep.c that contains a very simple parser for java class files. The problem is that it is old, at least it does not handle the class files generated by Java 7: as far as I remember, java guys added the new types of constant

Re: .: 2 commits - configure.in sw/source

2012-02-15 Thread Michael Stahl
On 13/02/12 09:39, Tor Lillqvist wrote: commit b7980663f0866629e7c54a085f31dba3d9c26b26 Author: Tor Lillqvist tlillqv...@suse.com Date: Mon Feb 13 09:42:39 2012 +0200 WaE: type name first seen using 'class' now seen using 'struct' IMHO this is an utterly pointless warning, because

[RFC] x11 / cairo-less build try #3

2012-02-15 Thread Riccardo Magliocchetti
Hello, this is another update on building libreoffice without need to link against X11 or toolkits in general. The aim is to ease the deploy server side where less dependencies needed the better. As you can see the vcl/headless/headlessinst.cxx has been shamelessly copied from Android, you can

Re: javadep.c Java 7

2012-02-15 Thread Ivan Timofeev
On 15.02.2012 20:41, Stephan Bergmann wrote: Apparently only remaining use is in the old build system (see solenv/inc/rules.mk, where it is called STARDEP). So I would not bother to invest any time in it -- as long as its shortcomings do not actually cause problems (which I don't quite get from

Re: .: 2 commits - configure.in sw/source

2012-02-15 Thread Stephan Bergmann
On 02/15/2012 05:48 PM, Michael Stahl wrote: WaE: type name first seen using 'class' now seen using 'struct' IMHO this is an utterly pointless warning, because the only difference between class and struct is the default visibility of the members, and a forward declaration doesn't declare

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

2012-02-15 Thread Ivan Timofeev
Hi Noel, On 15.02.2012 19:01, Noel Grandin wrote: Updated patch implementing Ivan's suggestion. Passes make and make check. Convert tools/table.hxx usage in editeng/inc/editeng/forbiddencharacterstable.hxx to std::map Looks good to me, pushed (without GetCharInfo - it was unused):

Re: qa-build errros on clean code

2012-02-15 Thread Markus Mohrhard
Hey, 2012/2/15 Riccardo Magliocchetti riccardo.magliocche...@gmail.com: Hi Winfried, Il 15/02/2012 16:30, Winfried Donkers ha scritto: Value: 8 33formel: =A1+B1 3 ucalc.cxx:2924:Assertion Test name: N12_GLOBAL__N_14TestE::testPostIts assertion failed - Expression:

Re: qa-build errros on clean code

2012-02-15 Thread Riccardo Magliocchetti
Hi Markus, Il 15/02/2012 19:05, Markus Mohrhard ha scritto: Hey, 2012/2/15 Riccardo Magliocchettiriccardo.magliocche...@gmail.com: Hi Winfried, Il 15/02/2012 16:30, Winfried Donkers ha scritto: Value: 8 33formel: =A1+B1 3 ucalc.cxx:2924:Assertion Test name:

Re: .: 2 commits - configure.in sw/source

2012-02-15 Thread Tor Lillqvist
I completely fail to see what actual problem could be caused by this. And how is that relevant? By the same logic, you could write code that just knows that ints are always 32 bits and whatnot. MSVC mangles struct and class differently (just one char difference, see

Re: .: 2 commits - configure.in sw/source

2012-02-15 Thread Michael Stahl
On 15/02/12 19:28, Tor Lillqvist wrote: I completely fail to see what actual problem could be caused by this. And how is that relevant? By the same logic, you could write code that just knows that ints are always 32 bits and whatnot. but no applicable standard requires ints to be 32 bits,

dbaccess_macros_test: no orderly shutdown

2012-02-15 Thread Stephan Bergmann
Hi all, Just experienced a spurious crash of cppunittester when executing Cppunit_dbaccess_macros_test, see backtraces below: * Thread 5 is the main thread, already in exit(3). * Thread 1 is executing a FastLoader thread (dbaccess/source/filter/xml/xmlfilter.cxx), and that code indeed has

Re: [PATCH] Remove unused code from gtkframe

2012-02-15 Thread Kate Goss
Hi Michael, Caolan, How accurate/ up to date is unusedcode.easy? Is there a way to make sure the methods I'm removing are genuinely unused? Am I just doing it wrong and removing the wrong things? : ) Kate On 15 February 2012 16:01, Michael Meeks michael.me...@suse.com wrote: Hi Kate, On

[PATCH] Remove unused (hopefully!) methods from l10ntools Export

2012-02-15 Thread Kate Goss
Hi, Another patch to remove methods listed as unused in unusedcode.easy Kate From e1934638ebc6f8456921c3b371997e878b414b28 Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Wed, 15 Feb 2012 20:19:18 + Subject: [PATCH] Remove unused code from l10ntools Export Remove

Re: Hosting LibreOffice online

2012-02-15 Thread drew
On Mon, 2012-02-13 at 12:24 +, Michael Meeks wrote: On Mon, 2012-02-13 at 11:43 +0100, Andor E wrote: https://wiki.documentfoundation.org/Using_LibreOffice_in_a_Web_Browser As promised I have created a first version of the Wiki page. I hope it is not too awful. Thanks for

Refactor installer::sorter

2012-02-15 Thread Tim Retout
Hi! Here are a few patches related to installer::sorter. I've tried to keep them low-risk, because much of the code is called during Windows builds, which I'm not yet testing. I think the sort algorithm used currently in installer::sorter must be equivalent to bubble sort; in any case, I

License of my contributions

2012-02-15 Thread Stanislav Horáček
Hi, I confirm that all my past, present and future contributions to the LibreOffice project are licensed under the MPL / LGPLv3+. Regards, Stanislav Horacek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] [core/fpicker/source/win32/filepicker/asynceventnotifier.cxx:243]: (performance) Possible inefficient checking for 'm_EventList' emptiness.

2012-02-15 Thread Mariusz Dykierek
-- Pozdrawiam, Mariusz Dykerek diff --git a/fpicker/source/win32/filepicker/asynceventnotifier.cxx b/fpicker/source/win32/filepicker/asynceventnotifier.cxx index a155f8b..748e5ac 100644 --- a/fpicker/source/win32/filepicker/asynceventnotifier.cxx +++

[PATCH] [core/dtrans/source/win32/dtobj/FetcList.cxx:123]: (performance) Possible inefficient checking for 'm_FormatMap' emptiness.

2012-02-15 Thread Mariusz Dykierek
-- Pozdrawiam, Mariusz Dykerek diff --git a/dtrans/source/win32/dtobj/FetcList.cxx b/dtrans/source/win32/dtobj/FetcList.cxx index 3bb3beb..3599da8 100644 --- a/dtrans/source/win32/dtobj/FetcList.cxx +++ b/dtrans/source/win32/dtobj/FetcList.cxx @@ -120,7 +120,7 @@ sal_Bool

Re: [PUSHED] Re: [PATCH] Help - minor updates

2012-02-15 Thread Stanislav Horáček
Dne 15.2.2012 14:45, Jan Holesovsky napsal(a): BTW - it is great that you are working on the help! Do you want to continue? I think some of the new 3.5 features might need an update in the help too - would that be interesting for you? Hi Kendy, you know that I would make no contribution

[PATCH] [core/dtrans/source/win32/dtobj/FmtFilter.cxx:485]: (performance) Possible inefficient checking for 'fileList' emptiness.

2012-02-15 Thread Mariusz Dykierek
-- Regards, Mariusz Dykerek diff --git a/dtrans/source/win32/dtobj/FmtFilter.cxx b/dtrans/source/win32/dtobj/FmtFilter.cxx index c012115..4093e92 100644 --- a/dtrans/source/win32/dtobj/FmtFilter.cxx +++ b/dtrans/source/win32/dtobj/FmtFilter.cxx @@ -482,7 +482,7 @@ typedef Sequencesal_Int8

[REVIEW-3-5] Fix some apparent misuses of RTL_CONSTASCII_USTRINGPARAM

2012-02-15 Thread Stephan Bergmann
The attached core-0001-Fix-some-apparent-misuses-of-RTL_CONSTASCII_USTRINGP.patch and binfilter-0001-Fix-some-apparent-misuses-of-RTL_CONSTASCII_USTRINGP.patch extract those parts of the master commits 9ab0b38e95133dab720408cc2c80093b8a201c10 and 715ac8c1b402e33930317a69bbdd61ad88133740

[PATCH] [core/linguistic/source/dlistimp.*:*]: (performance) Possible inefficient checking for 'aDicList' emptiness.

2012-02-15 Thread Mariusz Dykierek
-- Pozdrawiam, Mariusz Dykerek diff --git a/linguistic/source/dlistimp.cxx b/linguistic/source/dlistimp.cxx index e824888..316d86d 100644 --- a/linguistic/source/dlistimp.cxx +++ b/linguistic/source/dlistimp.cxx @@ -608,7 +608,7 @@ void SAL_CALL pDicEvtLstnrHelper-DisposeAndClear(

Re: Master fails to compile with cclan in moz module

2012-02-15 Thread julien2412
Hi, I'm still trying to compile with llvm/cclang. I disabled mozilla compilation and it compiled until cairo. I attached all the raw logs I had until now there : https://bugs.freedesktop.org/attachment.cgi?id=57120 If someone has an idea about this cairo problem Hope these raw logs help a

[PATCH] [core/vcl/source/window/splitwin.cxx:2047] - [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else.

2012-02-15 Thread Mariusz Dykierek
+ some simplification -- Regards, Mariusz Dykerek diff --git a/vcl/source/window/splitwin.cxx b/vcl/source/window/splitwin.cxx index f5da206..09ad468 100644 --- a/vcl/source/window/splitwin.cxx +++ b/vcl/source/window/splitwin.cxx @@ -2035,17 +2035,9 @@ void SplitWindow::ImplDrawFadeIn(

[PATCH] cppcheck's (portability) Extra qualification 'class_name::' unnecessary and considered an error by many compilers.

2012-02-15 Thread Mariusz Dykierek
-- Regards, Mariusz Dykerek diff --git a/cli_ure/source/uno_bridge/cli_bridge.h b/cli_ure/source/uno_bridge/cli_bridge.h index 0306e4d..b9297d0 100644 --- a/cli_ure/source/uno_bridge/cli_bridge.h +++ b/cli_ure/source/uno_bridge/cli_bridge.h @@ -96,7 +96,7 @@ struct Bridge System::Object*

[PATCH] [core/editeng/source/items/borderline.cxx:514] - [core/editeng/source/items/borderline.cxx:509]: (style) Found duplicate branches for if and else.

2012-02-15 Thread Mariusz Dykierek
-- Regards, Mariusz Dykerek diff --git a/editeng/source/items/borderline.cxx b/editeng/source/items/borderline.cxx index b617ff4..1677141 100644 --- a/editeng/source/items/borderline.cxx +++ b/editeng/source/items/borderline.cxx @@ -492,29 +492,20 @@ bool SvxBorderLine::HasPriority( const

Re: feature/gbuild_java is finished

2012-02-15 Thread Matúš Kukan
On 14 February 2012 06:55, David Tardon dtar...@redhat.com wrote: On Mon, Dec 26, 2011 at 01:33:57PM +0100, David Tardon wrote: I have converted 6 modules to gbuild on branch feature/gbuild_java: javaunohelper, jurt, jvmaccess, jvmfwk, ridljar and unoil. It builds fine here and smoketest

Mail Merge Functionality

2012-02-15 Thread J B
Hello, I like to say the LibreOffice just keeps getting better and better, keep up the good work. One item I would like to see improved is the Mail Merge, namely the address labels. When viewing the forms it would be nice to see the actual names and addresses in the sheet as well, just as a

Re: Hosting LibreOffice online

2012-02-15 Thread drew
On Wed, 2012-02-15 at 16:10 -0500, drew wrote: On Mon, 2012-02-13 at 12:24 +, Michael Meeks wrote: On Mon, 2012-02-13 at 11:43 +0100, Andor E wrote: https://wiki.documentfoundation.org/Using_LibreOffice_in_a_Web_Browser As promised I have created a first version of the Wiki page.

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Pierre-André Jacquod
hello, Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you thanks import creates polygons with empty sub-paths, that looks like a worthwhile optimization - code is around filter/source/msfilter/msdffimp.cxx probably. as soon as I have more spare time, I will have a try.

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

2012-02-15 Thread Ivan Timofeev
Whoa, I seem to be too naive for patch-reviewing... Is it a safe code? pForbiddenCharacters = maMap[ nLanguage ]; return pForbiddenCharacters; Will pForbiddenCharacters point to the deleted object, after the return? Terribly sorry for such a question... Regards, Ivan

RE: qa-build errros on clean code

2012-02-15 Thread Winfried Donkers
Markus Mohrhard wrote (15 februari 2012 19:05) Since you now disabled the test can you at least check after a full build that if you start calc insert a note in B2 and then insert a column before B2 the note is moved to C2. Ideally you would even check that inserting a row will move the note to

Help authoring

2012-02-15 Thread Jan Holesovsky
Hi Stanislav, Stanislav Horáček píše v St 15. 02. 2012 v 23:24 +0100: Yes, I would like to be involved, supposing that someone could check my suggestions (my English is not good enough for that). Great! So I think for proof-reads of the texts, you could CC:

[PATCH] EasyHack 42790: get rid of PRODUCT define/build system variable

2012-02-15 Thread jumbo444
Hello, This is my first patch, so please let me know if I did something wrong. :) Preprocessor constant PRODUCT is replaced by !DBG_UTIL Contributed under LGPLv3+ / MPL 1.1 or later. Laurent BP http://nabble.documentfoundation.org/file/n3749409/0001-EasyHack-42790-get-rid-of-PRODUCT.patch

[Libreoffice-commits] .: basegfx/source

2012-02-15 Thread Thorsten Behrens
basegfx/source/tools/unotools.cxx | 113 +++--- 1 file changed, 58 insertions(+), 55 deletions(-) New commits: commit d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 Author: Thorsten Behrens tbehr...@suse.com Date: Wed Feb 15 11:25:57 2012 +0100 Fix fdo#45779 -

  1   2   3   4   >