Re: [Libreoffice] [PATCH] Simplify a function returning the temporary directory name

2011-07-15 Thread Tor Lillqvist
> Would that be more acceptable ? Well, I am not saying they are unacceptable. I just wanted a bit of discussion with perhaps somebody actually clueful about security issues giving their opinion;) Quite possibly the checks make good sense, and are not a risk as nobody is going to run LibreOff

Re: [Libreoffice] [REVIEW] Fix for fdo#36688

2011-07-15 Thread Tor Lillqvist
>> Review, sign-off etc appreciated. /me raises hand. One more needed for the 3-4-2 branch. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] Properly determine number of CPUs on FreeBSD

2011-07-15 Thread Norbert Thiebaud
On Fri, Jul 15, 2011 at 12:43 AM, Mike Eberdt wrote: > Greetings, > > This started as a simple and obvious one-liner, but somehow the code morphed > into something that seems a bit more clear (to me, at least). Sanity-checked > on FreeBSD and Ubuntu.  Contributed under LGPL3+/MPL. Thanks, Pushed

[Libreoffice] LibreOffice Python -- how to create a simple inputbox?

2011-07-15 Thread Stanislav Pika
Hi! How to create an inputbox in LibreOffice Python? I've spent many days trying to figure that out, and it seems that while there is an interface XMessageBoxFactory, there is nothing like XInputBox. That is, something that allows user text input. XMessageBoxFactory allows only the following mess

Re: [Libreoffice] [REVIEW] Fix for fdo#36688

2011-07-15 Thread Noel Power
On 15/07/11 08:27, Tor Lillqvist wrote: Review, sign-off etc appreciated. /me raises hand. One more needed for the 3-4-2 branch. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libre

Re: [Libreoffice] [REVIEW] Fix for fdo#37767

2011-07-15 Thread Noel Power
On 14/07/11 23:42, Kohei Yoshida wrote: Hi there, I would like to commit the attached change to the -3-4 branch and hopefully to the 3-4-2 branch as well. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=37767 The refresh of data pilot table (or pivot table) was broken from the UNO API

Re: [Libreoffice] LibreOffice Python -- how to create a simple inputbox?

2011-07-15 Thread Xisco Faulí
you can use the model com.sun.star.awt.UnoControlEditModel. Take a look to this page: http://wiki.services.openoffice.org/wiki/ES/Desarrollo/Add-on_de_Soporte . I couldn't find it in english but the code fits your needs pretty well ;) Greetings 2011/7/15 Stanislav Pika > Hi! > > How to create a

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #1

Re: [Libreoffice] [ANN] LibreOffice 3.4.2 RC1 available

2011-07-15 Thread Yifan Jiang
Hi, I've been running smoketest module on the build on SLED 11 sp1 i586, and tried to manually launch and did some random test. All pass :) Best wishes, Yifan On Thu, Jul 14, 2011 at 02:29:53PM +0200, Florian Effenberger wrote: > Hi *, > > for 3.4.2 rc1, we're now uploading builds to a public

Re: [Libreoffice] How to add a unit test?

2011-07-15 Thread Lubos Lunak
On Monday 11 of July 2011, Caolán McNamara wrote: > On Mon, 2011-07-11 at 15:32 +0200, Lubos Lunak wrote: > > Hello, > > > > who knows how to add a unit test? > > > > http://wiki.documentfoundation.org/Development/Unit_Tests is incomplete > > (what if there is no qa/makefile.mk?) and obsolete (it

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #166 from Regina Henschel 2011-07-15 03:52:06 PDT --- I just tested LO3.4.2rc1 and now wmf-pictures print fine for me. So I cancel the nomination. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- Y

Re: [Libreoffice] [PATCH] starmath: check for existing edit window

2011-07-15 Thread Jonas Finnemann Jensen
Hi, Your patch looks good, have you pushed it? - Otherwise please do, my LibreOffice clone isn't up to date at the moment :( in case my patch would just hide a deeper problem. I don't think it hides a deeper problem (except lack of comments :) ), as far as I remember there're other places where

Re: [Libreoffice] DDEInitiate bug

2011-07-15 Thread Knut Olav Bøhmer
2011/7/13 Michael Meeks : > Hi Knut, > > On Wed, 2011-07-13 at 16:54 +0200, Knut Olav Bøhmer wrote: >> Now, fight! :D > >        This is a developers forum, not a place for sending E-mails about > reported bugs :-) It is only on-topic if you have a patch, or you want > advice and code pointers to h

Re: [Libreoffice] DDEInitiate bug

2011-07-15 Thread Knut Olav Bøhmer
On 14 July 2011 10:27, Chr. Rossmanith wrote: > Hi, http://openoffice.org/bugzilla/show_bug.cgi?id=118283 vs. https://bugs.freedesktop.org/show_bug.cgi?id=39194 Now, fight! :D >>> >>> If there is a relation we try to avoid with OOo developers, then that's >>> fighting, I t

Re: [Libreoffice] [PATCH] Simplify a function returning the temporary directory name

2011-07-15 Thread Caolán McNamara
On Wed, 2011-07-13 at 18:48 +0200, Francois Tigeot wrote: > On Wed, Jul 13, 2011 at 09:16:33AM -0600, Tor Lillqvist wrote: > Do we > really want to have those access() checks there? > > I am not evil > enough to think of a way to abuse that code (insert maniacal > laughter), but in general, isn'

Re: [Libreoffice] [MHST] Problem with building Libreoffice after modifying some trivial code

2011-07-15 Thread Caolán McNamara
On Thu, 2011-07-14 at 20:57 +0200, Matúš Kukan wrote: > On 14 July 2011 20:33, Ta Duc Tung wrote: > > Hi, > > > > I've run make clean and make but still failed, same error: > > > Is it possible you did git pull -r in libs-gui but not in ure ? > > 'Exception on createRegistryServiceFactory > file:

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on||33593 --- Comment #167 from Rainer Bi

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on||33379 --- Comment #168 from Rainer Bi

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on||37499 --- Comment #169 from Rainer Bi

Re: [Libreoffice] How to add a unit test?

2011-07-15 Thread Caolán McNamara
On Fri, 2011-07-15 at 12:29 +0200, Lubos Lunak wrote: > is there really supposed to be one CppunitTest*mk per > unittest? This way module toplevel directories are going to be full of these > files if we one day get to having a decent unittest coverage. Well, one .mk per output test library anywa

[Libreoffice] patch for preserving the table alignment

2011-07-15 Thread Noel Power
Hi Caolán could you have a look at this patch http://cgit.freedesktop.org/libreoffice/writer/commit/?id=95351a519bec2833f5d936c20e3916a4e283b0f6 This should be a nice stroll down memory lane for you as it seems related to http://openoffice.org/bugzilla/show_bug.cgi?id=1291, yes issue #1291 !!

[Libreoffice] feature/gnumake4

2011-07-15 Thread Matúš Kukan
Hi all, I have some questions about feature/gnumake4 branch. It can now start. I'm sending two more patches. First needs review, the second should be good but I did not push that either. There was some issue with creating ..Env.Set.sh. What's the plan with that branch? Just to merge and then dele

Re: [Libreoffice] [PATCH] starmath: check for existing edit window

2011-07-15 Thread Miklos Vajna
Hi Jonas, On Fri, Jul 15, 2011 at 01:45:42PM +0200, Jonas Finnemann Jensen wrote: > Your patch looks good, have you pushed it? I just did so. > I don't think it hides a deeper problem (except lack of comments :) ), as > far as I remember there're other places where pViewShell->GetEditWindow()

[Libreoffice] [PATCH][REVIEW] SetNamedRanges speedup fdo#35357

2011-07-15 Thread Laurent Godard
Hi all Here is my first patch and want at first thanks a lot everybody who helped me starting my build and especially Kohei for his patience and deep knowledge in calc. Kohei is a great mentor :-) The purpose of this patch is to speed up things when sheet.link is used. It is based on the 3.4 bran

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on||39236 --- Comment #170 from Rainer Bi

[Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-15 Thread Mike Eberdt
Greetings, Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD /bin/sh is not synonymous with bash. Therefore, bash-isms in configure.in can be problematic. This patch eliminates a "test: : bad number" diagnostic on FreeBSD. Contributed under LGPL3+/MPL. Thanks, Mike E

[Libreoffice] make error: Fetching dependencies for module l10n from solver... failed

2011-07-15 Thread Nguyen Vu Hung (KiEi)
Hello all, I had followed the build instruction[1] and setup my environment for a few weeks ago. As I thought the code was a little out of date, so I have tried to pull the latest code and make, but it seems that wget could not wget a dependency. I am not sure what it is. Any help is appreciate

Re: [Libreoffice] [PATCH] starmath: check for existing edit window

2011-07-15 Thread Jonas Finnemann Jensen
> > Please let me know if it looks problematic Looks great :) -- Regards Jonas Finnemann Jensen. On Fri, Jul 15, 2011 at 18:25, Miklos Vajna wrote: > Hi Jonas, > > On Fri, Jul 15, 2011 at 01:45:42PM +0200, Jonas Finnemann Jensen < > jop...@gmail.com> wrote: > > Your patch looks good, have you

Re: [Libreoffice] make error: Fetching dependencies for module l10n from solver... failed

2011-07-15 Thread Norbert Thiebaud
2011/7/15 Nguyen Vu Hung (KiEi) : > Hello all, > > I had followed the build instruction[1] and setup my environment for a few > weeks ago. > > As I thought the code was a little out of date, so I have tried to pull the > latest code > and make, but it seems that wget could not wget a dependency. >

Re: [Libreoffice] make error: Fetching dependencies for module l10n from solver... failed

2011-07-15 Thread Nguyen Vu Hung (KiEi)
(2011/07/16 7:46), Norbert Thiebaud wrote: 2011/7/15 Nguyen Vu Hung (KiEi): Hello all, I had followed the build instruction[1] and setup my environment for a few weeks ago. As I thought the code was a little out of date, so I have tried to pull the latest code and make, but it seems that wget

Re: [Libreoffice] [PATCH] [PUSHED] Simplify a function returning the temporary directory name

2011-07-15 Thread Francois Tigeot
On Fri, Jul 15, 2011 at 02:19:26PM +0100, Caolán McNamara wrote: > On Wed, 2011-07-13 at 18:48 +0200, Francois Tigeot wrote: > > > > Caolán, is there a special reason you added the access() checks ? > > Yes, so that you don't end up using a tmp dir you're not able to write > to and probably fall