[Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

2011-08-16 Thread Markus Mohrhard
Hello, this patch might be a bit to big for 3-4, but who knows: http://cgit.freedesktop.org/libreoffice/core/commit/?id=04d2e6469529b6187900659517d6f6dd5ea2cca5 We have three related problems: -database range tokens must be adjusted when we copy between different documents -global/local range

Re: [Libreoffice] How to call from one component to another (sw-starmath)

2011-08-16 Thread Lubos Lunak
On Monday 15 of August 2011, Miklos Vajna wrote: On Mon, Aug 15, 2011 at 05:16:17PM +0200, Lubos Lunak l.lu...@suse.cz wrote: I'm implementing .docx OOXML support for writing math formulas. As this is something that could be used not only by Writer but also by other components, I want to

Re: [Libreoffice] [PATCH] Remove duplicated chunk in windows.mk

2011-08-16 Thread Tor Lillqvist
Attached patch will remove the duplicated chunk from windows.mk. The original one is above my delete. Applied, and pushed, thanks! --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] UNO API reference?

2011-08-16 Thread Cor Nouws
Hi Kevin, Kevin Hunter wrote (16-08-11 01:07) Do we have, or is there a canonical reference for the UNO API? Specifically with Python bindings? The various references I've been able to find online seem haphazard at best. Is that what we have to work with, or is there an obvious link I've

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-16 Thread Noel Power
Hello Lionel On 15/08/11 13:10, Lionel Elie Mamane wrote: When the Standard Basic Macro Library for the document is loaded (which happens implicitly as soon as a macro is executed), but not the Standard Dialog Library, the File / Save action (or the equivalent toolbar button) does nothing,

Re: [Libreoffice] [PATCH] Updated extensions

2011-08-16 Thread Petr Mladek
Kálmán „KAMI” Szalai píše v Po 15. 08. 2011 v 18:41 +0200: Hi Petr, AFAIK the LO is not affected by these changes. None of these extensions is packed by LibreOffice. They might be already used by distro builds. Your changes might bring them regressions. How much did you test the new

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-16 Thread Noel Power
probably I should have read further before replying ;-) ( sorry excuse for a mind is elsewhere at the moment ) On 15/08/11 13:10, Lionel Elie Mamane wrote: So probably what happened is that the // Can we simply copy the storage? optimisation / fast path was added and suddenly

Re: [Libreoffice] [PATCH] [PUSHED] Remove duplicated chunk in windows.mk

2011-08-16 Thread Tor Lillqvist
Add PUSHED tag to subject... ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] How to call from one component to another (sw-starmath)

2011-08-16 Thread Caolán McNamara
On Mon, 2011-08-15 at 17:16 +0200, Lubos Lunak wrote: Hello, I'm implementing .docx OOXML support for writing math formulas. As this is something that could be used not only by Writer but also by other components, I want to implement the writing of the formula in Starmath. And even if I

Re: [Libreoffice] How to call from one component to another (sw-starmath)

2011-08-16 Thread Lubos Lunak
On Tuesday 16 of August 2011, Caolán McNamara wrote: On Mon, 2011-08-15 at 17:16 +0200, Lubos Lunak wrote: I already have a pointer to SmModel and SmDocShell (I can get it the same way the .doc code does) and just need to call their method, passing the XML serializer object as an argument,

Re: [Libreoffice] Fix crash when selecting target after inserting hyperlink to database document

2011-08-16 Thread Caolán McNamara
On Fri, 2011-07-08 at 12:25 -0700, Skeld Stu wrote: Creating,an hyperlink to a document in a FTP... That is probably/hopefully related to a different ftp specific thing, e.g. https://bugs.freedesktop.org/show_bug.cgi?id=39376 https://bugs.freedesktop.org/show_bug.cgi?id=34880 i.e. if the file

[Libreoffice] [review] load of ftp-hosted documents fails

2011-08-16 Thread Caolán McNamara
i.e. http://cgit.freedesktop.org/libreoffice/core/commit/?id=3ae98a0ca5329a0205728a46b4e5dd0d4b46a9f3 proposing for 3-4 old code will basically not distinguish between eof and error, and throw an exception on all short reads. probably fixes https://bugs.freedesktop.org/show_bug.cgi?id=34880 and

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-16 Thread Michael Meeks
Hi Josh, On Thu, 2011-08-11 at 12:29 +0930, Josh Heidenreich wrote: I have made some additional changes to the dialog. I am considering these changes stage 1 of the process. wow - this is cool :-) I've hated that dialog with a passion for its highly confusing choice, and the text above

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36547, which changed state. Bug 36547 Summary: Impress: Rendering problems with some .odp files https://bugs.freedesktop.org/show_bug.cgi?id=36547 What|Old Value |New Value

Re: [Libreoffice] [PATCH] Improve the alien save dialog (part one)

2011-08-16 Thread Josh Heidenreich
       By which (I hope) you mean: LGPLv3+/MPL ? :-) Yes, my bad. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-16 Thread cbosdonnat
Caolán McNamara wrote: On Thu, 2011-08-11 at 15:36 +0200, Cedric Bosdonnat wrote: I fixed fdo#37403 a while ago, and Rainer asked if we could cherry-pick http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=21ec661d09ed9d7bbbec5e52ee2b382d8c465324 to 3.4.2. Forgot all about that

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-08-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #187 from Olivier Hallot olivier.hal...@documentfoundation.org 2011-08-16 05:53:54 PDT --- Nominate bug 40113 in 3.4.x branch. Spreadsheet header/footer background does not display color or image. -- Configure bugmail:

[Libreoffice] [GSoc] Mentors: Final Evaluation Questions

2011-08-16 Thread Cedric Bosdonnat
Hello fellow mentors, I'm just forwarding you an email from Carol Smith handling the GSoc at Google. It contains all the questions for the final evaluation if you want to think about them in advance. Remember: the final evaluations are next week from Monday to Friday. Forwarded Message

Re: [Libreoffice] How to call from one component to another (sw-starmath)

2011-08-16 Thread Michael Meeks
Hi Lubos, On Tue, 2011-08-16 at 12:09 +0200, Lubos Lunak wrote: No, starmath doesn't need to call back to writer. The problem is that this is still needlessly complicated. How about the attached patch? I like it's simplicity personally :-) though of course we should use

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-16 Thread Lubos Lunak
On Tuesday 16 of August 2011, cbosdonnat wrote: Caolán McNamara wrote: On Thu, 2011-08-11 at 15:36 +0200, Cedric Bosdonnat wrote: Indeed that remembers me of a discussion like that with Lubos... though I'm not good enough in C++ to see those subtleties. I reverted the above mentioned patch

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-16 Thread Caolán McNamara
On Tue, 2011-08-16 at 05:48 -0700, cbosdonnat wrote: All is now working fine, and that later commit could be applied to 3.4 safely. Sorry, not trying to be a pain or anything, but that assignment operator now leaks the original mpXPoly of the SdrRectObj that's assigned to if there was one. C.

Re: [Libreoffice] l10n and translations

2011-08-16 Thread Michael Meeks
On Thu, 2011-08-04 at 13:38 +0400, Dmitry A. Ashkadov wrote: I don't understand what is a difference between «l10n» and «translations» repositories. Can You explain me? I plan to go through add update the repo descriptions to add this information there at some stage soon :-)

[Libreoffice] Template for copyright headers is cumbersome (was Re: How to call from one component to another (sw-starmath))

2011-08-16 Thread Lubos Lunak
On Tuesday 16 of August 2011, Michael Meeks wrote: Hi Lubos, On Tue, 2011-08-16 at 12:09 +0200, Lubos Lunak wrote: No, starmath doesn't need to call back to writer. The problem is that this is still needlessly complicated. How about the attached patch? I like it's simplicity

[Libreoffice] development summary: year 2011, week 31

2011-08-16 Thread Petr Mladek
Hi, this time a brief summary of what happened during the 31th week in 2011 on LibreOffice repositories and the living branches: + master:LO-3.5 development + libreoffice-3-3: fixes for LO-3.3.4 bug fix release + libreoffice-3-4: fixes for LO-3.4.2 bug fix

[Libreoffice] development summary: year 2011, week 32

2011-08-16 Thread Petr Mladek
Hi, this time a brief summary of what happened during the 32nd week in 2011 on LibreOffice repositories and the living branches: + master:LO-3.5 development + libreoffice-3-3: fixes for LO-3.3.4 bug fix release + libreoffice-3-4: fixes for LO-3.4.2 bug fix

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-16 Thread Michael Meeks
On Thu, 2011-08-11 at 16:55 +0200, Thorsten Behrens wrote: It's unclear to me, how valuable it is to fix-up tools/time.hxx all client code, vs. to use e.g. http://www.boost.org/doc/libs/1_47_0/doc/html/chrono.html when you need a sane implementation in new code ... Huh - it is

Re: [Libreoffice] [REVIEW] 4 minutes 27 seconds - 11 seconds

2011-08-16 Thread Thorsten Behrens
Caolan McNamara wrote: I'm *sure* its good, but the scale of speed-up from 4 minutes 27 seconds to 11 seconds is massively more than I expected. Especially as the insert point is at the end, rather than at the beginning or middle which would have required a lot of memmove type operations.

[Libreoffice] Help for a newbie

2011-08-16 Thread Olivier Hallot
Hi Can one of the Masters of the Code tell me where should I start digging to fix bug 40113 (spreadsheet header/footer backgorund image/color does not show). Thanks in advance. -- Olivier Hallot Founder and Steering Commitee Member The Document Foundation

Re: [Libreoffice] [REVIEW] 4 minutes 27 seconds - 11 seconds

2011-08-16 Thread Caolán McNamara
On Tue, 2011-08-16 at 16:14 +0200, Thorsten Behrens wrote: Played with it today, surely ::append is on a critical path, but beats me why exactly this is so much faster. Surely it saves some temporary B2DPolygon instances... Were you able to reproduce the difference yourself ? IIRC I sent a

Re: [Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

2011-08-16 Thread Markus Mohrhard
Hello Eike, 2011/8/16 Eike Rathke o...@erack.de Hi Markus, On Tuesday, 2011-08-16 08:07:20 +0200, Markus Mohrhard wrote: this patch might be a bit to big for 3-4, but who knows: http://cgit.freedesktop.org/libreoffice/core/commit/?id=04d2e6469529b6187900659517d6f6dd5ea2cca5 First

Re: [Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

2011-08-16 Thread Eike Rathke
Hi Markus, On Tuesday, 2011-08-16 16:25:22 +0200, Markus Mohrhard wrote: First thing that caught my eye: using toAsciiUpperCase() (or any other ASCII method) on anything that the user inputs as names is a no-no as it doesn't handle Unicode. Use ScGlobal::pCharClass-upper() instead. I

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-16 Thread Thorsten Behrens
Michael Meeks wrote: Huh - it is -extremely- valuable to do global cleans that remove unpleasant and hard-to-grok implementations from the code. Sure. Just using the latest/newest/trendiest 'time' class from A.B.C. place de jour in new code is a(nother) maintenance nightmare waiting

Re: [Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

2011-08-16 Thread Markus Mohrhard
Hello Eike, 2011/8/16 Eike Rathke o...@erack.de Hi Markus, On Tuesday, 2011-08-16 16:25:22 +0200, Markus Mohrhard wrote: First thing that caught my eye: using toAsciiUpperCase() (or any other ASCII method) on anything that the user inputs as names is a no-no as it doesn't handle

Re: [Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

2011-08-16 Thread Eike Rathke
Hi Markus, On Tuesday, 2011-08-16 17:08:53 +0200, Markus Mohrhard wrote: The change to the ScFormulaCell ctor apparently unconditionally tries to adjust name tokens, this is completely unnecessary in most situations and should be triggered only if the sheets of new and old position

Re: [Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

2011-08-16 Thread Eike Rathke
Hi Markus, On Tuesday, 2011-08-16 17:31:10 +0200, Eike Rathke wrote: No, no new member variable, what I was thinking of is to detect whether the original source document of the clipboard document is identical to the current document. There is a way via the document pool, I'll dig out

Re: [Libreoffice] Graphite 1.0.1

2011-08-16 Thread Michael Meeks
On Mon, 2011-08-15 at 16:11 +0200, Petr Mladek wrote: I guess that you need it with the md5sum prefix, so I uploaded it as http://download.go-oo.org/src/3c6b8de6b75eee445b29f1de5fe01f02-graphite2-1.0.1.tgz Shame - I guess this missed the 3.4.3 release deadline (unless we can get the

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-16 Thread Terrence Enger
On Tue, 2011-08-16 at 15:13 +0100, Michael Meeks wrote: Hi Terry, If you're discussing code in detail you're much more than welcome here[1] :-) really looking forward to your first patch - do you have problems building that we can help out with ? Harrumph. I started last week to do a

Re: [Libreoffice] [PUSHED] Series of fixes and migration to One Git for contrib/dev-tools/ubuntu-jenkins

2011-08-16 Thread Michael Meeks
Hi Henrik, On Mon, 2011-08-15 at 23:40 +0100, Henrik Jensen wrote: Feel free to commit to the dev-tools repo directly, improving the jenkins setup even more would be awesome! I appreciate the trust Bjoern :-), but I don't have an freedesktop.org/Libreoffice account yet. Hey -

[Libreoffice] [ANNOUNCE] libreoffice-3.4.3.1 tag created (3.4.3-rc1)

2011-08-16 Thread Petr Mladek
Hi, there have been created the libreoffice-3.4.3.1 tag for 3.4.3-rc1 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.4.2-final. I am going to create the libreoffice-3-4-3 branch for the final stabilization. You

Re: [Libreoffice] [GSOC] how to call python code from the menu

2011-08-16 Thread Caolán McNamara
On Mon, 2011-08-15 at 19:02 +0200, Xisco Faulí wrote: Hello everybody, before I merge the gsoc branch into master I'd like to integrate the python code into libo and get rid of the java code. I know i have to edit this file

Re: [Libreoffice] [PUSHED] fix xml2cmp build with svn gcc

2011-08-16 Thread Michael Meeks
Hi Tom, First - really wonderful to see you here, and a big welcome :-) I'm so sorry you got screwed over by our big one-shot git repository transition / migration. Hopefully the change, while painful in the short term, will make things much easier for new contributors going forward

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-16 Thread Lionel Elie Mamane
On Tue, Aug 16, 2011 at 09:41:43AM +0100, Noel Power wrote: On 15/08/11 13:10, Lionel Elie Mamane wrote: When the Standard Basic Macro Library for the document is loaded (which happens implicitly as soon as a macro is executed), but not the Standard Dialog Library, the File / Save action (or

Re: [Libreoffice] [GSOC] how to call python code from the menu

2011-08-16 Thread Xisco Faulí
Thank you for pointing out this file but I don't really understand how it works. The wizard is called here : http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu#441 where MailMergeWizard is the service register in Writer.xcu (

[Libreoffice] [GSoC] merged library

2011-08-16 Thread Matúš Kukan
Hi there, I'm trying to allow using one bigger shared library instead of more, often used small ones. Something like described here: http://tools.openoffice.org/build_env_param.html search for BIG_SVX parameter at the top. Was it ever possible to do one shared library? I'm attaching diff

[Libreoffice] make check failed because no rule to create the target

2011-08-16 Thread Julien Nabet
Hello, With make check, here's what I got at the end : [ build SCK ] framework make[1]: *** Pas de règle pour fabriquer la cible « /home/maryline/compile-libreoffice/libo/linguistic/qa/unoapi/Test.java », nécessaire pour «

Re: [Libreoffice] Graphite 1.0.1

2011-08-16 Thread Martin Hosken
Dear Michael, Shame - I guess this missed the 3.4.3 release deadline (unless we can get the patch, and triple review it soon); but we can get it in for 3.4.4 no doubt - and clearly pushing to master is easy enough. I enclose the patch. It is a simple patch in that it removes the

Re: [Libreoffice] [PATCH] for Bug 32719

2011-08-16 Thread jeffrey chang
Hi Thorsten, Jan, and Co. Sorry for the delay. Here is the revised patch that fixes the dimension problem without all the rough scratch work/comments from last time. I will look into Rainer's comment. Jeffrey On Thu, Aug 11, 2011 at 1:50 AM, Thorsten Behrens t...@documentfoundation.org wrote:

[Libreoffice] Need advice on #34697: Print Current Page in Print dialog - Calc, Draw, Impress

2011-08-16 Thread Nguyen Vu Hung
Hello all, For the easy hack mentioned in the subject of this email, the tatung has done it for the writer. # The coding style must be adapted though. The next steps are hacking the similar codes for calc and impress. Can anyone shed us a light on how to do that? cf. The bug:

Re: [Libreoffice] [REVIEW] fix for fdo#39850 and fdo#39820: update range names and database ranges in formula cells

2011-08-16 Thread Markus Mohrhard
Hello Eike, 2011/8/17 Eike Rathke o...@erack.de Hi Markus, With your latest commit 74070a021389534b9e791980bd33ede45be9fd81 copying to another sheet within the same document to me doesn't work as expected: On Sheet1 on cell B3 define a sheet local range name AAA for that cell