Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Tor Lillqvist
Has the time come to get rid of the delivering step for public headers? I.e. for a header MODULE/BAR.hxx, instead of having it in MODULE/inc/MODULE/BAR.hxx and then copying it to solver/INPATH/inc/MODULE/BAR.hxx as part of the make of MODULE, it could be directly in a new top-level inc directory,

Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-21 Thread Michael Meeks
On Mon, 2012-02-20 at 21:24 +0100, Stephan Bergmann wrote: On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote: WaE: add missing sal and cppunit dependencies causing tinderbox failure ... Yes, as you say - it was for the unit test that was failing to compile without

Re: [PUSHED] Remove unused methods from PDFI

2012-02-21 Thread Kate Goss
Hi, On 20 February 2012 11:00, Michael Meeks michael.me...@suse.com wrote: On Sat, 2012-02-18 at 21:18 +, Kate Goss wrote: Quick question - Can anyone point me to list of supported browsers for the bug submission assistant? I don't believe we have one :-) but I would say -

The new global -DHEADLESS should be namespaced surely?

2012-02-21 Thread Tor Lillqvist
Do we really want to use a generic and potentially clash-prone word like HEADLESS? Isn't the normal software engineering practise to use some package-specific prefix for global C-level identifiers like this? We already have -DLIBO_WERROR to indicate when --enable-werror is in force, and

Re: The new global -DHEADLESS should be namespaced surely?

2012-02-21 Thread Riccardo Magliocchetti
Hello, Il 21/02/2012 09:27, Tor Lillqvist ha scritto: Do we really want to use a generic and potentially clash-prone word like HEADLESS? Isn't the normal software engineering practise to use some package-specific prefix for global C-level identifiers like this? We already have -DLIBO_WERROR to

Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:21 AM, Michael Meeks wrote: On Mon, 2012-02-20 at 21:24 +0100, Stephan Bergmann wrote: On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote: WaE: add missing sal and cppunit dependencies causing tinderbox failure ... Yes, as you say - it was for the unit

WaE prefix in git commit comment (was: WaE: add missing sal and cppunit dependencies causing tinderbox failure)

2012-02-21 Thread Tor Lillqvist
I thinki it was Caolán that started using the WaE: prefix in git commits, and when I asked him what it means indeed it is Warnings are Errors. As I have understood it the intent is that commits that fix warnings (which are treated as errors if --enable-werror is used) use the WaE: prefix. --tml

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-21 Thread G.H.M.Valkenhoef, van
Great to hear that it works that it will make it into master :-). Any thoughts on this one:  3) When creating the CLucene FileReader (HelpIndexer.cxx), the path is converted to plain ASCII, that's probably dangerous. There is probably a way to work around this, but I haven't gotten around to

Re: Disappearing graphics in Write: where to look (bug 33393)

2012-02-21 Thread Jan Holesovsky
Hi Cor, all, On 2012-02-20 at 17:11 +0100, Cor Nouws wrote: Having a well formed, and reproducible bug report would be rather useful :-) Yes, I think we realise that :-) Therefore I added some comments on how I can reliably reproduce (more opening the doc and doing some random work

Re: Building LibreOffice on Windows

2012-02-21 Thread Randall G. Arnold
On February 17, 2012 at 11:22 AM Tor Lillqvist t...@iki.fi wrote: Projects like this have to battle the embrace, extend, extinguish philosophy of commercial interests. What makes you think only commercial entities have that philosophy? As far as I know Linux, also embraces and extends

Changes toward bug #39468

2012-02-21 Thread Tom Thorogood
In order to commit and run git diff, I had to fix some trailing whitespace in unrelated files. The only files in the git diff digest which are actually changed are those in core/comphelper. *Completed translation of the core/comphelper directory and subs. -Tom diff --git

Re: Building LibreOffice on Windows

2012-02-21 Thread Noel Grandin
We have 233000 lines of makefile code using a mix of dmake and gmake. Good luck converting that to cmake. On 2012-02-20 09:52, Josh Heidenreich wrote: Hi, Okay so it might be nuts, but has anyone tried creating a native VS solution/projects, which ruins inside the ide? Could one be created

License Statement

2012-02-21 Thread Stefan Heinemann
Hello All All my contributions to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Best Regards Stefan Heinemann -- Web: senseless.codedump.ch Jabber/XMPP: stefa...@jabber.ccc.de signature.asc Description: PGP signature ___

MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Helmar Spangenberg
Hello List, I have a working Qt/C++ application connecting to the office using ::cppu::bootstrap(). After porting this application to MinGW, I got a BootstrapException saying unexpected UNO exception caught: component context fails to supply service com.sun.star.bridge.UnoUrlResolver of type

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Tor Lillqvist
I'm using the MinGW-LibreOffice from the daily-build-service (2012-02-20); the MinGW itself is the cross tool chain from SuSE 12.1. I *think* it would be better to just use a normal stable (MSVC-built) LibreOffice version, not the experimental MinGW build. I hope it doesn't matter that *your*

Re: [PUSHED][3-5] fix for fdo#46332, crash while opening xls file

2012-02-21 Thread Petr Mladek
Markus Mohrhard píše v Út 21. 02. 2012 v 03:27 +0100: Hey, this patch ([1]) fixes the crash while opening the test document. The file contains 5 empty categories while we assume that all categories are non empty which results in a crash in

[PUSHED] Re: [REVIEW-3-5] fdo#40665 use CJKAnalyzer for ko, zh-CN, and zh-TW, too

2012-02-21 Thread Jan Holesovsky
Just marking the thread [PUSHED] :-) On 2012-02-17 at 21:12 +, Michael Meeks wrote: On Fri, 2012-02-17 at 21:49 +0100, Andras Timar wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7636d37f8f9c53d694c4fe38581f3b495d53670e Caolán suggested this fix in the CLucene thread. I

[PATCH] Put HEADLESS definition under LIBO namespace

2012-02-21 Thread Riccardo Magliocchetti
Hello, tml reminds us that use a generic and potentially clash-prone word like HEADLESS as preprocessor defintion is pretty lame. He suggests to put it under the already used LIBO namespace. To sum it up let's do a s/HEADLESS/LIBO_HEADLESS/g. This has been done manually fixing the occurencies

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Helmar Spangenberg
Am Dienstag, 21. Februar 2012, 12:29:58 schrieb Tor Lillqvist: I'm using the MinGW-LibreOffice from the daily-build-service (2012-02-20); the MinGW itself is the cross tool chain from SuSE 12.1. I *think* it would be better to just use a normal stable (MSVC-built) LibreOffice version, not

[PATCH] desktop: Don't call setIniFilename() for LIBO_HEADLESS

2012-02-21 Thread Riccardo Magliocchetti
Hello, mmeeks suggests we don't want setIniFilename(), who am i to disagree? :) For now avoid to catch uno exceptions, will probably change opinion when i'll see them. thanks -- Riccardo Magliocchetti From a08e56e1d0db3a48cad8c7566370410b6287 Mon Sep 17 00:00:00 2001 From: Riccardo

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Michael Meeks
Hi Tor, On Tue, 2012-02-21 at 10:02 +0200, Tor Lillqvist wrote: solver/INPATH/inc/MODULE/BAR.hxx as part of the make of MODULE, it could be directly in a new top-level inc directory, in inc/MODULE/BAR.hxx all the time. (Obviously -I$(SRC_ROOT)/inc would have to be added to the compilation

Re: [PATCH] [PUSHED] Put HEADLESS definition under LIBO namespace

2012-02-21 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Tor Lillqvist
I would love to use the MSVC version - however my application is based on some essential MinGW parts, and until now I have not found a way to link my application against the MSVC-DLLs coming with the LibreOffice SDK. Hmm, ah, yes silly me, the joys of mixing compilers when using C++ APIs.

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Tor Lillqvist
I wonder how bad the alternative of adding -I$S/svx/inc -I$S/vcl/inc etc. etc. is for command-line length ? Probably not a problem considering that we compile just one file at a time anyway. But might it not be the case that we in some cases (or often even) have non-public headers in MODULE/inc

[PATCH v2] desktop: Don't call setIniFilename() for LIBO_HEADLESS

2012-02-21 Thread Riccardo Magliocchetti
Il 21/02/2012 11:54, Riccardo Magliocchetti ha scritto: Hello, mmeeks suggests we don't want setIniFilename(), who am i to disagree? :) For now avoid to catch uno exceptions, will probably change opinion when i'll see them. thanks Hey, this time with one that does actually compile.

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-21 Thread Noel Grandin
Hi Thanks, that was just the suggestion I needed! Converted patch to use boost:ptr_map. Regards, Noel Grandin On 2012-02-20 17:17, Ivan Timofeev wrote: On 20.02.2012 19:12, Noel Grandin wrote: The error was sourced several levels down in the boost stuff, and the originating point was

Re: windows / cygwin - unable to start build

2012-02-21 Thread Noel Power
Hi Walter On Thu, 2012-02-16 at 11:42 +0100, walter wrote: I have installed the last version of Cygwin: [...] Please see logs AT http://pastebin.com/u/walterLO if gcc -DHAVE_CONFIG_H -I. -I. -I. -I. -I. -I./unix/cygwin -I./unix -I./unix/cygwin/gnu -I./unix/cygwin -I./unix -g -O2 -MT

Building with --disable-database-connectivity

2012-02-21 Thread Riccardo Magliocchetti
Hello, git master (from yesterday) does not compile for me with --disable-database-connectivity, attached a patch that tries to fix the easy stuff. Is it ok to disable the form stuff, is this only base related? Then there is svx faling in tail_build: http://pastebin.com/HbD64M2V Do you

Re: Disappearing graphics in Write: where to look (bug 33393)

2012-02-21 Thread Michael Meeks
On Tue, 2012-02-21 at 10:36 +0100, Jan Holesovsky wrote: So - I have already spent some 4 hours, or more, trying to fix this one. I spent a little time too ;-) cf. my comments in the bug. IMHO the lifecycle of images is highly non-intuitive there, I have high hopes

[REVIEW 3-5] patch for later cygwins that have a different locaton for process.h

2012-02-21 Thread Noel Power
There is a real sucky problem that will especially affect new Windows libreoffice developers, namely *real* early there is a big fat build failure. I came across this as I completely started from scratch creating a build environment [*] ( as I managed to bork my windows xp installation )

Re: Building with --disable-database-connectivity

2012-02-21 Thread Riccardo Magliocchetti
Hi Tor, Il 21/02/2012 12:38, Tor Lillqvist ha scritto: git master (from yesterday) does not compile for me with --disable-database-connectivity, It's experimental, don't try to use it. (It's mainly for non-desktop OSes where it probably makes less sense to provide such functionality. And

Re: Building with --disable-database-connectivity

2012-02-21 Thread Tor Lillqvist
I share your very same sentiments with my --headless work, no need for db stuff here. So I'd try to find some time to play with this even if it is experimental. OK. But I am just hacking on it so don't try to work on it right now;) --tml ___

Re: [PATCH] [PUSHED:3-5] fdo#46163 database form listbox only for VARCHAR

2012-02-21 Thread Petr Mladek
Lionel Elie Mamane píše v Čt 16. 02. 2012 v 13:57 +0100: Just reported and fixed fdo#46163. A list box is a control that is supposed to match two sets of data: An entry in the list content property is matched to the corresponding entry in the list entries property (yeah, that's rather

Re: Building with --disable-database-connectivity

2012-02-21 Thread Riccardo Magliocchetti
Hi Tor, Il 21/02/2012 12:57, Tor Lillqvist ha scritto: I share your very same sentiments with my --headless work, no need for db stuff here. So I'd try to find some time to play with this even if it is experimental. OK. But I am just hacking on it so don't try to work on it right now;) --tml

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #192 from Timur gti...@gmail.com 2012-02-21 05:13:53 PST --- @ Orwel, Michael Meeks: There is already a bug for Advanced printing capabilities of comments in Writer [PRINTING] at https://bugs.freedesktop.org/show_bug.cgi?id=36815.

[NAK] Re: [REVIEW 3-5] fdo#39006 Layout loop fixed

2012-02-21 Thread Michael Stahl
On 08/02/12 20:40, Cedric Bosdonnat wrote: Hi all, I just fixed a nasty layout loop. Could someone review and cherry-pick this commit to 3-5 branch? http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a22e664811e10ca58ec66ba8fd10b1a6185c178 FYI, I tested the change also with the

Re: [PATCH] [PUSHED:3-5] fdo#46163 database form listbox only for VARCHAR

2012-02-21 Thread Lionel Elie Mamane
On Tue, Feb 21, 2012 at 01:03:09PM +0100, Petr Mladek wrote: Lionel Elie Mamane píše v Čt 16. 02. 2012 v 13:57 +0100: Just reported and fixed fdo#46163. A list box is a control that is supposed to match two sets of data: An entry in the list content property is matched to the

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Timur gti...@gmail.com changed: What|Removed |Added Depends on||39006 --- Comment #193 from

Re: [PATCH][PUSHED] LibreOffice 3.6.0alpha built on clang

2012-02-21 Thread Khoo Wei Ming
Julien, On pc Debian x86-64, I've got this kind of errors : /home/julien/compile- libreoffice/libo/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx:51:23: error: ISO C++ forbids declaration of 'typeof' with no type [-fpermissive] Could you try this patch and see if it

Re: [PUSHED] Building with --disable-database-connectivity

2012-02-21 Thread Tor Lillqvist
Hmm, I am not sure. I still think it might be too early to start trying to use --disable-database-connectivity for normal OSes. (Even if building for headless). But what the heck, pushed it anyway, with a slight modification: instead of introducing conditionals in Library_sc.mk to bypass just one

Re: [PATCH][PUSHED] LibreOffice 3.6.0alpha built on clang

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 02:36 PM, Khoo Wei Ming wrote: On pc Debian x86-64, I've got this kind of errors : /home/julien/compile- libreoffice/libo/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx:51:23: error: ISO C++ forbids declaration of 'typeof' with no type [-fpermissive] Could

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||43932

Re: [PUSHED] Building with --disable-database-connectivity

2012-02-21 Thread Riccardo Magliocchetti
Hi Tor, Il 21/02/2012 14:38, Tor Lillqvist ha scritto: Hmm, I am not sure. I still think it might be too early to start trying to use --disable-database-connectivity for normal OSes. (Even if building for headless). But what the heck, pushed it anyway, with a slight modification: instead of

[PATCH] headless: more work in vcl

2012-02-21 Thread Riccardo Magliocchetti
Hello, provide HeadlessSalSystem::ShowNativeDialog() instead of having it if-zeroed. Then remove LIBO_HEADLESS ifdefery from unx/generic/plugadapt/salplug.cxx which we are not building anymore. Please review -- Riccardo Magliocchetti From dbf94f72ab9bcf472e59daf4229ade6eb9f5d584 Mon Sep 17

Re: [PUSHED] x11 / cairo-less build try #3

2012-02-21 Thread Riccardo Magliocchetti
Hello Michael, first of all thanks for pushing the stuff to master :) Il 17/02/2012 17:52, Michael Meeks ha scritto: Fair enough. I suspect that for the native-dialog implementation in headlessinst.cxx we want to go for an fprintf with some parse-able syntax to the console, and then

Re: [PATCH] [PUSHED:3-5] SQL parser bugs

2012-02-21 Thread Petr Mladek
Lionel Elie Mamane píše v Pá 17. 02. 2012 v 07:35 +0100: Attached patches fix two SQL parser bugs: fdo#46206 - SQL: INSERT accepts only VALUES, not arbitrary SELECT query fdo#46198 - SQL: NULL not accepted in place of column name in SELECT statement I was not able to test it easily. If I

[REVIEW] add test case for old password algorithm, fdo#45171

2012-02-21 Thread Markus Mohrhard
Hey, normally I would not ask if we could add a test case to the 3-5 branch but fdo#45171 seems to be a distro build problem and I hope that we can prevent this problem in the 3-5 branch with this test case. If the maintainer is executing subsequenttest after the build he will immediately know if

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Eike Rathke
Hi Tor, On Tuesday, 2012-02-21 10:02:50 +0200, Tor Lillqvist wrote: Has the time come to get rid of the delivering step for public headers? I.e. for a header MODULE/BAR.hxx, instead of having it in MODULE/inc/MODULE/BAR.hxx and then copying it to solver/INPATH/inc/MODULE/BAR.hxx as part of

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Tor Lillqvist
Maybe we need a new directory for exported header files. $MODULE/exported Well, isn't that what $MODULE/inc is *supposed* to be? Are there many cases where also private headers (which don't get delivered) are in $MODULE/inc ? I honestly don't know; on one hand I am a pessimist and assume there

Re: UI question regarding SfxToolBoxControls

2012-02-21 Thread Michael Meeks
Hi there, On Tue, 2012-02-21 at 08:52 +0100, Winfried Donkers wrote: Presently, the last used colour is stored within the control (mLastColor) and in the shell (e.g. ScFormatShell, SwTextShell) where the execute function is. Riight - that doesn't seem so optimal :-) I would like to

[PUSHED] fdo44611 writer paragraph background color picker with split button

2012-02-21 Thread Michael Meeks
On Mon, 2012-02-20 at 17:45 +0100, Winfried Donkers wrote: Attached patch addresses the first fix for fdo45671, the rest will follow one by one. Nice :-) This patch is a bit more elaborate than I expect the rest to be as I prepared the code for the patches to follow, i.e. for the

Re: [REVIEW 3-5] patch for later cygwins that have a different locaton for process.h

2012-02-21 Thread Noel Power
On 21/02/12 11:50, Noel Power wrote: There is a real sucky problem that will especially affect new Windows libreoffice developers, namely *real* early there is a big fat build failure. I came across this as I completely started from scratch creating a build environment [*] ( as I managed to

[PUSHED] headless: more work in vcl

2012-02-21 Thread Michael Meeks
On Tue, 2012-02-21 at 15:00 +0100, Riccardo Magliocchetti wrote: provide HeadlessSalSystem::ShowNativeDialog() instead of having it if-zeroed. Pushed - good to see that cleaned up :-) Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant

Re: [PUSHED] x11 / cairo-less build try #3

2012-02-21 Thread Michael Meeks
On Mon, 2012-02-20 at 09:21 +0100, Stephan Bergmann wrote: Nice - IMHO this is all a bit silly - the 'main' has no wrapper 'catch' around it, so if we get an un-caught exception we bomb out in a very unpleasant way for no particularly good reason. ... Stephan - is there a reason

Re: [PATCH] Translated german comments in sw/source/core/layout/

2012-02-21 Thread Philipp Weissenbacher
Started from the other end, patch 22 and 21 are pushed to master. Nice! Attached are my reviewed patches (don't have commit access :-( ). It's my first review, hopefully I did everything right. I also replaced the bits that seemed like too literal translation with. And an extra kudos for

R: [REVIEW 3-5] patch for later cygwins that have a different location for process.h

2012-02-21 Thread walter
Hi, read this before apply the patch, file moved back (?) http://www.mail-archive.com/cygwin@cygwin.com/msg120501.html http://www.mail-archive.com/cygwin@cygwin.com/msg120501.html Best, walter Da: libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.org

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Michael Stahl
On 21/02/12 15:41, Tor Lillqvist wrote: Maybe we need a new directory for exported header files. $MODULE/exported Well, isn't that what $MODULE/inc is *supposed* to be? Are there many cases where also private headers (which don't get delivered) are in $MODULE/inc ? I honestly don't know;

[PUSHED 3-5] patch for later cygwins that have a different locaton for process.h

2012-02-21 Thread Michael Meeks
On Tue, 2012-02-21 at 11:50 +, Noel Power wrote: There is a real sucky problem that will especially affect new Windows libreoffice developers, namely *real* early there is a big fat build failure. Cool - thanks for fixing this :-) Note: I didn't attach the generated ( but

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Michael Meeks
Hi Helmar, On Tue, 2012-02-21 at 11:53 +0100, Helmar Spangenberg wrote: I would love to use the MSVC version - however my application is based on some essential MinGW parts, and until now I have not found a way to link my application against the MSVC-DLLs coming with the LibreOffice SDK.

Re: [PATCH] Translated german comments in sw/source/core/layout/

2012-02-21 Thread David Vogt
On 21/02/12 16:09, Philipp Weissenbacher wrote: Started from the other end, patch 22 and 21 are pushed to master. Nice! Attached are my reviewed patches (don't have commit access :-( ). It's my first review, hopefully I did everything right. I also replaced the bits that seemed like too

[PUSHED] add basegfx::fround to unittest (was: basegfx::fround and friends seems needed in windows build)

2012-02-21 Thread Michael Meeks
On Tue, 2012-02-21 at 21:24 +0700, Korrawit Pruegsanusak wrote: Now I attach a patch for reviewing. Lovely - pushed it :-) OK, I have to confess that I've shamelessly copy-n'-pasted the whole things from the adjacent ones, and made some modifications on top of it. There is

Re: [PATCH] Translated german comments in sw/source/core/layout/

2012-02-21 Thread Philipp Weissenbacher
Just asking: Is there a specific reason to highlight negations with capital letters (e.g. NOT)? Not really. It is mainly a habit of mine because I sometimes overread such things when tired or in a hurry and thus interpret them totally wrong. You may of course use normal case if you think

[PUSHED] Translated german comments in sw/source/core/layout/

2012-02-21 Thread Michael Meeks
Hi Philipp, First - thanks for helping with the patch review load, that's much appreciated. On Tue, 2012-02-21 at 16:09 +0100, Philipp Weissenbacher wrote: Attached are my reviewed patches (don't have commit access :-( ). Can you create a bug following this flow:

Re: [PUSHED 3-5] patch for later cygwins that have a different locaton for process.h

2012-02-21 Thread Petr Mladek
Michael Meeks píše v Út 21. 02. 2012 v 15:12 +: On Tue, 2012-02-21 at 11:50 +, Noel Power wrote: There is a real sucky problem that will especially affect new Windows libreoffice developers, namely *real* early there is a big fat build failure. Cool - thanks for fixing

Re: [PUSHED] add basegfx::fround to unittest (was: basegfx::fround and friends seems needed in windows build)

2012-02-21 Thread Korrawit Pruegsanusak
Hello Michael, On Tue, Feb 21, 2012 at 22:28, Michael Meeks michael.me...@suse.com wrote:        Drat, I just did that for you :-) Thanks for this :) Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list

ODF 1.1 and 1.2

2012-02-21 Thread Luc Castermans
Gents, It looks like users compatibility experience problems between LibreOffice and MSO due to different speeds at which ODF 1.1 and 1.2 formats are implemented in both packages. A fellow supporter has complained in Brussels at the European Commission. Before he reacts he likes to have some

Re: [PUSHED] x11 / cairo-less build try #3

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 04:07 PM, Michael Meeks wrote: On Mon, 2012-02-20 at 09:21 +0100, Stephan Bergmann wrote: Nice - IMHO this is all a bit silly - the 'main' has no wrapper 'catch' around it, so if we get an un-caught exception we bomb out in a very unpleasant way for no particularly good

Re: [PUSHED] Remove unused methods from PDFI

2012-02-21 Thread Thorsten Behrens
Kate Goss wrote: On Sat, 2012-02-18 at 21:18 +, Kate Goss wrote: Quick question - Can anyone point me to list of supported browsers for the bug submission assistant? I didn't find a list of target browser Loic designed this for, but looking into

Re: [PUSHED][PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-21 Thread Ivan Timofeev
On 21.02.2012 15:09, Noel Grandin wrote: Thanks, that was just the suggestion I needed! Converted patch to use boost:ptr_map. Great! Pushed, thanks for it. Could you prepare your future patches using 'git format-patch', please? Best Regards, Ivan

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 03:39 PM, Michael Stahl wrote: would need to try that out on Windows, but my guess is that even if it doesn't blow out command line length limits (which could be worked around with a response file) it'll make the Windows build a lot slower because compiler has to try out all

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 04:15 PM, Michael Meeks wrote: On Tue, 2012-02-21 at 11:53 +0100, Helmar Spangenberg wrote: I would love to use the MSVC version - however my application is based on some essential MinGW parts, and until now I have not found a way to link my application against the MSVC-DLLs

A nasty bug in 3.5 - Writer corrupts document that worked fine in 3.4

2012-02-21 Thread Mariusz Dykierek
How do I report? -- Regards, Mariusz Dykerek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: A nasty bug in 3.5 - Writer corrupts document that worked fine in 3.4

2012-02-21 Thread Michael Meeks
On Tue, 2012-02-21 at 18:07 +0100, Mariusz Dykierek wrote: How do I report? http://bugs.freedesktop.org/ If it is really serious, and it's not related to the .svm image loss that we're seeing elsewhere, then it should be flagged in:

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Bjoern Michaelsen
On Tue, Feb 21, 2012 at 03:39:25PM +0100, Michael Stahl wrote: On 21/02/12 11:59, Michael Meeks wrote: would need to try that out on Windows, but my guess is that even if it doesn't blow out command line length limits (which could be worked around with a response file) it'll make the Windows

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Bjoern Michaelsen
On Tue, Feb 21, 2012 at 04:41:33PM +0200, Tor Lillqvist wrote: $MODULE/exported Well, isn't that what $MODULE/inc is *supposed* to be? yes. well: $MODULE/inc/$MODULE is exported headers. Best, Bjoern ___ LibreOffice mailing list

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Helmar Spangenberg
Am Dienstag, 21. Februar 2012, 15:15:56 schrieb Michael Meeks: Hi Helmar, On Tue, 2012-02-21 at 11:53 +0100, Helmar Spangenberg wrote: I would love to use the MSVC version - however my application is based on some essential MinGW parts, and until now I have not found a way to link my

Re: A nasty bug in 3.5 - Writer corrupts document that worked fine in 3.4

2012-02-21 Thread Petr Mladek
Michael Meeks píše v Út 21. 02. 2012 v 17:12 +: On Tue, 2012-02-21 at 18:07 +0100, Mariusz Dykierek wrote: How do I report? http://bugs.freedesktop.org/ If it is really serious, and it's not related to the .svm image loss that we're seeing elsewhere, then it should be

Re: ODF 1.1 and 1.2

2012-02-21 Thread Petr Mladek
Luc Castermans píše v Út 21. 02. 2012 v 16:54 +0100: Gents, It looks like users compatibility experience problems between LibreOffice and MSO due to different speeds at which ODF 1.1 and 1.2 formats are implemented in both packages. A fellow supporter has complained in Brussels at the

Re: R: [REVIEW 3-5] patch for later cygwins that have a different location for process.h

2012-02-21 Thread Petr Mladek
walter píše v Út 21. 02. 2012 v 16:10 +0100: Hi, read this before apply the patch, file moved back (?) http://www.mail-archive.com/cygwin@cygwin.com/msg120501.html anyway right? The patch added a check if the header was moved and used the new location when it was moved. Everything will

Re: libmerged and related thoughts

2012-02-21 Thread Matúš Kukan
On 20 February 2012 14:40, Caolán McNamara caol...@redhat.com wrote: On Mon, 2012-02-20 at 00:31 +0100, Matúš Kukan wrote: It fails in testtools/source/bridgetest/ And removing the unxlng* in testtools are forcing a rebuild there doesn't help ?, i.e. this might be an unrelated thing with a

Re: [Libreoffice-qa] [PATCH] Make Bugzilla Assistant tests pass in IE8

2012-02-21 Thread Thorsten Behrens
Kate Goss wrote: I have checked the tests in Chrome, Firefox and Safari, and they seem unaffected by the changes, however it might be good if someone familiar with the code ensures that the tweaks to the tests don't accidentally cause them to pass when they should genuinely fail, or cause them

Re: [REVIEW] add test case for old password algorithm, fdo#45171

2012-02-21 Thread Rene Engelhard
On Tue, Feb 21, 2012 at 03:23:23PM +0100, Markus Mohrhard wrote: but fdo#45171 seems to be a distro build problem and I hope that we can prevent this problem in the 3-5 branch with this test case. If the maintainer is executing subsequenttest after the build he will immediately know if his

[no subject]

2012-02-21 Thread Bartolomé Sánchez Salado
Hello All. All my contributions to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Best Regards Bartolomé Sánchez Salado. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

License statement

2012-02-21 Thread Bartolomé Sánchez Salado
Hello All. All my contributions to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Best Regards Bartolomé Sánchez Salado. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED] Removed unused code from avmedia module

2012-02-21 Thread Bartolomé Sánchez Salado
Hello Michael. I added myself in the wiki as you requested and I'll take a look at those virtual methods. I hope to contribute with a second patch soon. Thank you very much! El día 18 de febrero de 2012 10:58, Michael Meeks michael.me...@suse.com escribió: Hi there, On Sat, 2012-02-18 at

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 06:31 PM, Helmar Spangenberg wrote: actually the SAL C API seems to work nicely - after Tor's remarks I re-installed the MSVC-SDK and tried to link my MinGW-code against ist. However, the CPPU interface denies the linking - I observe undefined references to cppu::bootstrap(),

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Helmar Spangenberg
Am Dienstag, 21. Februar 2012, 19:37:14 schrieb Stephan Bergmann: On 02/21/2012 06:31 PM, Helmar Spangenberg wrote: actually the SAL C API seems to work nicely - after Tor's remarks I re-installed the MSVC-SDK and tried to link my MinGW-code against ist. However, the CPPU interface denies

Re: [PATCH][PUSHED] LibreOffice 3.6.0alpha built on clang

2012-02-21 Thread julien2412
Hi, I git updated and it failed again the same way. With Khoo's patch, it worked. Then I removed his patch and tried again, it failed again. /home/julien/compile-libreoffice/libo/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx:52:23: error: ISO C++ forbids declaration of

Re: [PUSHED][PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-21 Thread Noel Grandin
On Tue, Feb 21, 2012 at 18:06, Ivan Timofeev timofeev@gmail.com wrote: Could you prepare your future patches using 'git format-patch', please? Will do! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-21 Thread Chr. Rossmanith
Hi, during code cleanup I came across badly readable RTL_CONSTASCII_USTRINGPARAM(bla) lines. I could replace them with bla which should be possible with Lubos patch removing the need for The macro... I wouldn't do it across the whole code base. Only if I come across instances of The macro.

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:05 PM, Helmar Spangenberg wrote: Yes exactly, that is my problem. That's why I am bound to the MinGW port of LibreOffice, but somehow the URE part has some problems. Yeah, sorry, but I fear I have no idea for you there. UnoUrlResolver is probably the first service that shall

Re: [PATCH][PUSHED] LibreOffice 3.6.0alpha built on clang

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:09 PM, julien2412 wrote: I git updated and it failed again the same way. With Khoo's patch, it worked. Then I removed his patch and tried again, it failed again. [...] Each test made like this : make connectivity.clean make connectivity Should I have recompiled another

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:29 PM, Chr. Rossmanith wrote: during code cleanup I came across badly readable RTL_CONSTASCII_USTRINGPARAM(bla) lines. I could replace them with bla which should be possible with Lubos patch removing the need for The macro... But Lobos's patch is not yet in? (And it would

Re: [Libreoffice-commits] .:

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 08:57 PM, Thomas Arnhold wrote: commit 45ad6029e1422c659e627bb30ecda50ccb61060c Author: Thomas Arnholdtho...@arnhold.org Date: Tue Feb 21 19:46:36 2012 +0100 WaE: duplicateBranch and use sal_False diff --git a/sc/source/core/data/dptabres.cxx

[PATCH] Some more work for --disable-database-connectivity

2012-02-21 Thread Riccardo Magliocchetti
Hello, some more work towards a working disable-database-connectivity. We now compile fine but fail with: solenv/gbuild/ComponentTarget.mk:56: *** gb_Deliver_deliver: file does not exist in solver, and cannot be delivered:

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-21 Thread Stephan Bergmann
On 02/16/2012 06:21 PM, Stephan Bergmann wrote: On 02/16/2012 05:12 PM, Stephan Bergmann wrote: On 02/16/2012 04:50 PM, Stephan Bergmann wrote: On 02/15/2012 04:54 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-21 Thread Lubos Lunak
On Tuesday 21 of February 2012, Stephan Bergmann wrote: On 02/21/2012 09:29 PM, Chr. Rossmanith wrote: during code cleanup I came across badly readable RTL_CONSTASCII_USTRINGPARAM(bla) lines. I could replace them with bla which should be possible with Lubos patch removing the need for The

Getting debug symbols from single module

2012-02-21 Thread Albert Thuswaldner
Hi, The old way of getting debug symbols from just a single module: http://wiki.documentfoundation.org/Development/How_to_debug#Debugging_symbols i.e cd module make -sr clean make -srj4 debug=t doesn't seem to work anymore. I've tried various combinations like: make module -sr debug=t make

[PATCH]Bug 46399 - EasyHack: vcl - cleanup empty methods ...

2012-02-21 Thread greggory...@gmail.com
Hey everyone, I've attached a patch to resolve the easy hack referenced in the subject (pretty straight forward, though I wouldn't put it past me to miss something little). I'm very new to libreoffice development and I'm excited to contribute as much as possible. This is my first attempt at that.

[PATCH]Bug 37210 - UI: Calc usability improvement: Merge cells on right mouse click

2012-02-21 Thread greggory...@gmail.com
Hello again, This is my second patch I've attempted (this is getting fun). I've also attached the patch to the bug. Is there a standard approach to this? Should I only attach in one place or another? Anyway, hopefully this is a tiny bit of useful code. made available under the MPL/LGPLv3+

  1   2   3   >