RE: [PATCH]bug 44516 improved label and business card document creation

2012-02-27 Thread Winfried Donkers
Norbert Thiebaud wrote (27 februari 2012 08:26) With hindsight it would probably have been better to make a constant for this colour. It is not good practice to leave such colour definitions in the code. yes, my point exactly :-) It is not too late to do the 'Right Thing'(tm) including in

Re: Most elegant way to disable all BASIC functionality?

2012-02-27 Thread Tor Lillqvist
The 'disabling' of interpreter is not technically inherent to IOS, nor is it necessarily the only platform concerned by it. Indeed; 4c737b647078f35a2435e27d9f7f94039db9d6c3 --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] Replace getLength() with isEmpty() where appropriate

2012-02-27 Thread Chr. Rossmanith
Hi, some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. Christina From c77cd19f5ebbd2fffc5a44886b5f22abc87d78c7 Mon Sep 17 00:00:00 2001 From: Christina Rossmanith chrrossman...@web.de Date: Tue, 21 Feb 2012 20:57:21 +0100 Subject: [PATCH] Replace

Re: [Libreoffice-commits] .: Makefile

2012-02-27 Thread Norbert Thiebaud
On 2/26/12 13:00 , Peter Foley wrote: Makefile |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit a75873dea15719b5216cfd0476d30003ffc76e80 Author: Peter Foley pefol...@verizon.net Date: Sun Feb 26 13:53:09 2012 -0500 allow autogen.sh to be run

Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText()

2012-02-27 Thread Chr. Rossmanith
Hi, the method GlyphSet::DrawGlyphs() is nearly a total subset of GlyphSet::ImplDrawText(). The only difference is the declaration of OString aGlyphSetName(GetGlyphSetName(*aSet)); -- DrawGlyphs() vs. OString aGlyphSetName(GetCharSetName(*aSet)); -- ImplDrawText() DrawGlyphs() is only rarely

[PATCH] 39468 Translate German comments

2012-02-27 Thread Tom Thorogood
Hello, git diff attached for comphelper directory. Sent this in last week but looks like the message got flagged somehow. This is my first submission; please let me know if I've done something incorrectly! -Tom Thorogood (do you need GPL stuff for comments? If so: I'm submitting this under the

Disabling Temporary Files?

2012-02-27 Thread Marc-André Laverdière
Hello everybody, I am working on something for which we want the document to stay in memory, with no temp file on disk. So far, we open the file as such: com.sun.star.beans.PropertyValue[] args = new com.sun.star.beans.PropertyValue[] { new PropertyValue(ReadOnly, -1, true,

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||44664 -- Configure

Re: Question: How do I rasterize an SVG to a BitmapEx

2012-02-27 Thread Thorsten Behrens
Andrew Higginson wrote: I can see there are various classes (i.e. vcl::SVGReader and vcl::RenderGraphicRasterizer) which may do the job, however I need to rasterize it to a specific resolution (pretty much what vcl::RenderGraphicRasterizer::Rasterize does) however I don't want to duplicate

Re: Most elegant way to disable all BASIC functionality?

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 10:14 +0200, Tor Lillqvist wrote: The 'disabling' of interpreter is not technically inherent to IOS, nor is it necessarily the only platform concerned by it. Indeed; 4c737b647078f35a2435e27d9f7f94039db9d6c3 Looks ok to me; I guess what this really means is

Re: Most elegant way to disable all BASIC functionality?

2012-02-27 Thread Tor Lillqvist
       Looks ok to me; I guess what this really means is disable scripting right ? That's better, yes. Will do s/interpreters/scripting --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-27 Thread Michael Meeks
On Sat, 2012-02-25 at 17:21 +0100, Tommy wrote: do u have many autocorrect entries as well? ... as I said before in my experience OOo/LibO performances gets worse when you have a lot of autocorrect items. Dezsi has a patch to fix the horrible slow-down when selecting large

Re: [Libreoffice-commits] .: Makefile

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 09:28 AM, Norbert Thiebaud wrote: On 2/26/12 13:00 , Peter Foley wrote: Makefile |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit a75873dea15719b5216cfd0476d30003ffc76e80 Author: Peter Foleypefol...@verizon.net Date: Sun Feb 26 13:53:09

Re: [PUSHED] Reduced loadtime of autocorrect tables

2012-02-27 Thread Andras Timar
2012/2/24 Dézsi Szabolcs dezsisz...@hotmail.com: There was an issue with acor_* files containing lots of entries (takes forever to load in Autocorrection options). With a small modification in cui/source/tabpages/autocdlg.cxx the issue seems to be gone. Thanks Michael Meeks! I tested it with

Re: Google Summer of Code

2012-02-27 Thread Michael Meeks
Hi Giorik, On Sun, 2012-02-26 at 16:02 +0200, Giorik Giorik wrote: I'm Thanasis from Greece and I study computer science in TEI of Athens. Great to meet you :-) I want to participate in Google Summer of Code and I would like some help to get me started. Sure - so, I would

Re: [PATCH] Reduced loadtime of autocorrect tables

2012-02-27 Thread Tommy
On Fri, 24 Feb 2012 16:52:20 +0100, Dézsi Szabolcs dezsisz...@hotmail.com wrote: Hello! There was an issue with acor_* files containing lots of entries (takes forever to load in Autocorrection options). With a small modification in cui/source/tabpages/autocdlg.cxx the issue seems to be

Re: [PUSHED] Reduced loadtime of autocorrect tables

2012-02-27 Thread Tommy
On Mon, 27 Feb 2012 11:12:50 +0100, Andras Timar tima...@gmail.com wrote: 2012/2/24 Dézsi Szabolcs dezsisz...@hotmail.com: I tested it with the attached acor_it-IT.dat file. Autocorrection worked, and it loaded all entries. Load time before patch: ? minutes (didn't wait) Load time after

RE: [PATCH] Reduced loadtime of autocorrect tables

2012-02-27 Thread Dézsi Szabolcs
great!!! I love you!!! the huge acor_ file you used is mine!!! I'm the one who opened this issue: https://issues.apache.org/ooo/show_bug.cgi?id=101726 Yes, I used that file, hope it's not a problem :) I know that i could generate an xml file with random entries (with a script), but

Re: [REVIEW 3-5-1] Reduced loadtime of autocorrect tables

2012-02-27 Thread Andras Timar
2012/2/27 Dézsi Szabolcs dezsisz...@hotmail.com: Btw. I sent this letter a few days ago, but the message body was too big, so it had to wait for moderator's approval. And yes it would be great to see this in final. I cherry picked it to libreoffice-3-5 branch.

Re: JUnit sc_complex fails in Localized enviroment

2012-02-27 Thread Michael Meeks
Hi there, On Sat, 2012-02-25 at 17:52 +0100, Maciej Rumianowski wrote: I hjave discovered a problem when checking libreoffice build (master), below is log. It seems that test is not fully localized. Interesting - what locale are you using out of interest ? Is make check meant to work

REVIEW 3-5, 3-5-1

2012-02-27 Thread Fridrich Strba
Please review these three patches that are needed currently for the build of 3.5.1-rc1 with internal libxml on MacOSX 10.4 PPC Cheers F. From 9a36bae8ff7fcf3ee901b6b7b0c3198914ae2c37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fridrich=20=C5=A0trba?= fridrich.st...@bluewin.ch Date: Sun, 26 Feb 2012

Re: [PUSHED][REVIEW-3-5, 3-5-1] fdo#46571 add Gurmukhi MT to pa-IN font list

2012-02-27 Thread Caolán McNamara
On Fri, 2012-02-24 at 23:21 +0100, Andras Timar wrote: Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=1e343276ecb7e88482e0dd8b2a1e170dbffbe8ba done for 3-5 and 3-5-1 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

ByteString finally gone

2012-02-27 Thread Caolán McNamara
After a long 12+ year illness ByteString finally went away this morning C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Removed unused code

2012-02-27 Thread Caolán McNamara
On Thu, 2012-02-23 at 22:54 +0100, Dézsi Szabolcs wrote: Hi! I removed the following unused functions: ye gads!, that's a mega-patch. Thanks for this, pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[REVIEW:3-5, 3-4-5] do not pack stdlibs twice (fdo#46658)

2012-02-27 Thread Petr Mladek
Hi, we moved the stdlibs into separate optional package for LO-3.5.1-rc1. Unfortunately, the related gid entries were still listed in the the ure module in scp2. It causes installation conflicts, see https://bugs.freedesktop.org/show_bug.cgi?id=46658 It should get fixed by

Re: [PATCH] Reduced loadtime of autocorrect tables

2012-02-27 Thread Tommy
On Mon, 27 Feb 2012 11:44:10 +0100, Dézsi Szabolcs dezsisz...@hotmail.com wrote: great!!! I love you!!! the huge acor_ file you used is mine!!! I'm the one who opened this issue: https://issues.apache.org/ooo/show_bug.cgi?id=101726 Yes, I used that file, hope it's not a problem :) I

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-27 Thread Tommy
On Mon, 27 Feb 2012 10:49:09 +0100, Michael Meeks michael.me...@suse.com wrote: On Sat, 2012-02-25 at 17:21 +0100, Tommy wrote: do u have many autocorrect entries as well? ... as I said before in my experience OOo/LibO performances gets worse when you have a lot of autocorrect items.

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-27 Thread Helmar Spangenberg
Am Donnerstag, 23. Februar 2012, 12:49:13 schrieb Michael Stahl: (...) earlier this week i bootstrapped a little python thingy on Linux with these variables (found by trial and error, not by actual understanding), perhaps URE_BOOTSTRAP could be of interest to you: I tried it - unfortunately

Re: [REVIEW 3-5-1] Reduced loadtime of autocorrect tables

2012-02-27 Thread Caolán McNamara
On Mon, 2012-02-27 at 11:57 +0100, Andras Timar wrote: I cherry picked it to libreoffice-3-5 branch. http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=3a90b7fea7de8860dfdb92925df39dac3d0ed4fc 2 more signoffs needed for libreoffice-3-5-1. Looks safe to me, +1 C.

[REVIEW 3-5] duplicate fonts, one broken, one not, results in neither being detected

2012-02-27 Thread Caolán McNamara
i.e. https://bugs.freedesktop.org/show_bug.cgi?id=42901 and this commit to fix: http://cgit.freedesktop.org/libreoffice/core/commit/?id=65a3ec97b5032d1748c8f84eeb0b8656e1c25918 broken duplicate seen before working duplicate, first rejected for being broken, second rejected for being a duplicate.

User installation migrated onto itself

2012-02-27 Thread Stephan Bergmann
I wondered why https://bugs.freedesktop.org/show_bug.cgi?id=46074 FILEOPEN: No Recent Documents... reportedly hits Mac and Windows users going from LO 3.4 to 3.5, when it should only hit in cases where the user installation is migrated (which happens on Linux when going from LO 3.4 to 3.5,

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 46144, which changed state. Bug 46144 Summary: Distributy Columns Evenly does not work with the selected columns, but affects all columns in the table https://bugs.freedesktop.org/show_bug.cgi?id=46144 What

Re: ByteString finally gone

2012-02-27 Thread Chr. Rossmanith
Then it can be removed from the wiki (Development/String Classes) http://wiki.documentfoundation.org/Development/String_Classes#Cross_reference_for_OString.2FOUString_vs._String.2FByteString.2FUniString as well? Christina Am 27.02.2012 12:13, schrieb Caolán McNamara: After a long 12+ year

Ligatures in arabic fonts

2012-02-27 Thread Tomáš Chvátal
Hello guys, I have bug reported at gentoo [1] which I am not entirely sure how to sort out. I suspected graphite2 to be the culprit but it is indeed broken with both system and internal one. Also if I build the libreoffice on the same machine with generic ./autogen.sh build which pulls most of

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-27 Thread Helmar Spangenberg
Am Donnerstag, 23. Februar 2012, 11:24:00 schrieb Michael Meeks: On Thu, 2012-02-23 at 11:07 +0100, Helmar Spangenberg wrote: In the meantime I am a step further - having found some very annoying things: The recent MinGW cross tool chain supplied for SuSE 12.1 (64bit) seems to be broken -

Weird undefined symbol: ReferenceXInterface::operator ReferenceXInterface const() const

2012-02-27 Thread Tor Lillqvist
Anybody have a clue what might cause this (in a build for the iOS simulator, using the llvm-g++ 4.2.1 in Xcode 4.3): Undefined symbols for architecture i386: com::sun::star::uno::Referencecom::sun::star::uno::XInterface::operator com::sun::star::uno::Referencecom::sun::star::uno::XInterface

Re: Ligatures in arabic fonts

2012-02-27 Thread Khaled Hosny
On Mon, Feb 27, 2012 at 01:11:03PM +0100, Tomáš Chvátal wrote: Hello guys, I have bug reported at gentoo [1] which I am not entirely sure how to sort out. I suspected graphite2 to be the culprit but it is indeed broken with both system and internal one. Also if I build the libreoffice on

Re: [REVIEW 3-5-1] Reduced loadtime of autocorrect tables

2012-02-27 Thread Tommy
On Mon, 27 Feb 2012 12:47:43 +0100, Caolán McNamara caol...@redhat.com wrote: On Mon, 2012-02-27 at 11:57 +0100, Andras Timar wrote: I cherry picked it to libreoffice-3-5 branch. http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=3a90b7fea7de8860dfdb92925df39dac3d0ed4fc

Re: Java issues ...

2012-02-27 Thread libreoffice...@gmail.com
Dear Michael, Thank you very much for your response. Yes I am aware that we need OpenOffice/ LO to be installed on local machine in order to run it in applet. This is not a good option but do we have others? Code is exactly same as described in the sample. I will try it myself first and

[REVIEW:3-5,3-5-1] PostgreSQL regression wrt 3.5.0: privileges via groups

2012-02-27 Thread Lionel Elie Mamane
Attached patch fixes fdo#46675, a regression in 3.5.1rc1 wrt to 3.5.0 introduced in the fix for fdo#45254. It is a backport of my corresponding commit in master; in 3.5.1 only getTablePrivileges is affected, not getColumnPrivileges. A PostgreSQL role can be member of another role. Think of the

[PATCH][REVIEW 3-4] fdo#31966: do not create an empty slide when printing handouts

2012-02-27 Thread Ivan Timofeev
Hi, https://bugs.freedesktop.org/show_bug.cgi?id=31966 This bug was fixed in 3-5, but I didn't propose it for 3-4, and that was confusing to the bug reporter. So, taking into account the simplicity of the patch, I'd like to see it in 3-4. The patch for the impress repository is attached.

Re: [REVIEWED 3-5-1] Reduced loadtime of autocorrect tables

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 11:47 +, Caolán McNamara wrote: Looks safe to me, +1 And of course I love it ;-) so ... I cherry-picked it - thanks Szabolcs :-) Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot

REVISED PATCH [REVIEW:3-5,3-5-1] PostgreSQL regression wrt 3.5.0: privileges via groups

2012-02-27 Thread Lionel Elie Mamane
Forgot to regenerate the patch after last-minute fix before sending email... Missing closing parenthesis in previous patch. New patch attached. On Mon, Feb 27, 2012 at 01:41:21PM +0100, Lionel Elie Mamane wrote: Attached patch fixes fdo#46675, a regression in 3.5.1rc1 wrt to 3.5.0 introduced in

Re: ByteString finally gone

2012-02-27 Thread Caolán McNamara
On Mon, 2012-02-27 at 13:10 +0100, Chr. Rossmanith wrote: Then it can be removed from the wiki (Development/String Classes) as well? Sure, go for it. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [REVIEWED 3-5-1] Reduced loadtime of autocorrect tables

2012-02-27 Thread Tommy
On Mon, 27 Feb 2012 13:40:21 +0100, Michael Meeks michael.me...@suse.com wrote: On Mon, 2012-02-27 at 11:47 +, Caolán McNamara wrote: Looks safe to me, +1 And of course I love it ;-) so ... I cherry-picked it - thanks Szabolcs :-) Thanks, Michael.

Re: Windows tinderbox on private branch

2012-02-27 Thread Lionel Elie Mamane
On Thu, Feb 23, 2012 at 10:11:19AM +0100, Jan Holesovsky wrote: On 2012-02-20 at 13:24 +0100, Lionel Elie Mamane wrote: Would it be possible to have a Windows tinderbox build a private branch of mine? It would roughly be libreoffice-3-5 plus most of my commits to master. As we talked on the

Re: [Pushed] [PATCH] Replace getLength() with isEmpty() where appropriate

2012-02-27 Thread Muthu Subramanian K
Pushed. Thank you! On 02/27/2012 01:52 PM, Chr. Rossmanith wrote: Hi, some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. Christina ___ LibreOffice mailing list

Re: [PATCH] Replace getLength() with isEmpty() where appropriate

2012-02-27 Thread Ivan Timofeev
Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has not the isEmpty method IIRC, only the string classes have it.

Re: [Pushed] [PATCH] Removed unused code

2012-02-27 Thread Muthu Subramanian K
Pushed. Thank you! On 02/26/2012 05:47 AM, Petr Vorel wrote: Another patch removing some unused methods. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEWED 3-5-1] Reduced loadtime of autocorrect tables

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 13:48 +0100, Tommy wrote: just one more question: will it be in 3.5.1 or 3.5.2? 3.5.1 out in around a week. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___

[REVIEW][3-5][3-5-1] paste into draw from writer if writer doc has tables in header/footer - kaboom

2012-02-27 Thread Caolán McNamara
Fix for https://bugs.freedesktop.org/show_bug.cgi?id=46038 proposed is http://cgit.freedesktop.org/libreoffice/core/commit/?id=15547450bdba10959473c2cb5891f29ad5053b09 pasting any content from a writer document to draw *if* the source writer document has a table in a header/footer (even if not

Re: [PATCH] Replace getLength() with isEmpty() where appropriate

2012-02-27 Thread Ivan Timofeev
On 27.02.2012 16:59, Ivan Timofeev wrote: Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has not the isEmpty

Re: [PUSHED 3-5] [REVIEW 3.5; 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Korrawit Pruegsanusak
Hello Norbert, Ivan, On Mon, Feb 27, 2012 at 13:53, Norbert Thiebaud nthieb...@gmail.com wrote: On Sun, Feb 26, 2012 at 9:39 AM, Ivan Timofeev timofeev@gmail.com wrote: Fixed invalid conversion from SvUShorts to std::vector... *sigh* Please, pick to the appropriate branches. I pushed it

[REVIEW:3-5-1] PostgreSQL regression wrt 3.5.0: privileges via groups

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 13:45 +0100, Lionel Elie Mamane wrote: Forgot to regenerate the patch after last-minute fix before sending email... Missing closing parenthesis in previous patch. New patch attached. :-) so, since you're the expert here, and the patch looks sane to me - I pushed

[REVIEWED 3-4] fdo#31966: do not create an empty slide when printing handouts

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 16:41 +0400, Ivan Timofeev wrote: This bug was fixed in 3-5, but I didn't propose it for 3-4, and that was confusing to the bug reporter. So, taking into account the simplicity of the patch, I'd like to see it in 3-4. The patch for the impress repository is attached.

Re: [libreoffice-l10n] [ANN] LibreOffice 3.5.1 RC1 available

2012-02-27 Thread khagaroth
The options tree in Writer in Czech language is completely messed up after the re-added basic fonts options, but this is probably just because the translations weren't updated yet (which they should be, at least in Czech language, considering the added strings were translated the same day they

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 13:07 +0100, Helmar Spangenberg wrote: Checking a little further, it seems that the file uno.ini in my actual working directory is analyzed to set up te local context (unfortunately I do not understand the entries in that file - any hint?) :-) So there are two

Re: [libreoffice-projects] [ANN] LibreOffice 3.5.1 RC1 available

2012-02-27 Thread Volker Merschmann
Hi, 2012/2/26 Thorsten Behrens t...@documentfoundation.org: for the upcoming new version 3.5.1, the RC1 builds now start to be available on pre-releases. This build is slated to be one of two release candidate builds on the way towards 3.5.1, please refer to our release plan timings here:  

Re: [PATCH] Replace getLength() with isEmpty() where appropriate

2012-02-27 Thread Muthu Subramanian K
@Ivan: Thanks! I missed that one. On 02/27/2012 06:45 PM, Ivan Timofeev wrote: On 27.02.2012 16:59, Ivan Timofeev wrote: Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. at least,

Re: User installation migrated onto itself

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 12:52 +0100, Stephan Bergmann wrote: So I dug a little deeper and noticed that, at least on Mac, the first start of LO 3.5 (or later) migrates any existing user installation in ~/Library/Application Support/LibreOffice/3 onto itself. Ho hum, migrating itself

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 12:45 +0100, Tommy wrote: i write a word then hit space... the cursor seems frozen for 5 to 9 seconds (depending how fast is the machine i'm working with) and then moves to the space and let you write other words. That -really- still sounds like the Java

Re: [REVIEW:3-5, 3-5-1][PUSHED-3-5] do not pack stdlibs twice (fdo#46658)

2012-02-27 Thread Stephan Bergmann
[Petr, I assume you meant 3-5-1 instead of 3-4-5 in the subject; changed.] On 02/27/2012 12:33 PM, Petr Mladek wrote: we moved the stdlibs into separate optional package for LO-3.5.1-rc1. Unfortunately, the related gid entries were still listed in the the ure module in scp2. It causes

[REVIEWED] 3-5

2012-02-27 Thread Michael Meeks
Hi Fridrich, You have my ack for -3-5, the librsvg bit looked curios, but ... ;-) correct when I dug further. Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing

Re: Disabling Temporary Files?

2012-02-27 Thread Michael Meeks
Hi Marc, On Mon, 2012-02-27 at 04:15 -0500, Marc-André Laverdière wrote: I am working on something for which we want the document to stay in memory, with no temp file on disk. Ho hum ;-) And the result is that we have a temporary file in C:\Users\meh\AppData|local\Temp\

Re: Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText()

2012-02-27 Thread Michael Meeks
Hi Christina, On Mon, 2012-02-27 at 09:49 +0100, Chr. Rossmanith wrote: the method GlyphSet::DrawGlyphs() is nearly a total subset of GlyphSet::ImplDrawText(). The only difference is the declaration of Ah - there are two of these ImplDrawText's and the latter (as you say) does look

Re: [PATCH] Replace getLength() with isEmpty() where appropriate

2012-02-27 Thread Chr. Rossmanith
Am 27.02.2012 13:59, schrieb Ivan Timofeev: Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has not the isEmpty

[PUSHED] Re: [PATCH] Translated german comments in sw/source/core/layout/

2012-02-27 Thread Jan Holesovsky
Hi David, all, On 2012-02-17 at 11:26 +0100, David Vogt wrote: As Nicolas Christener and I promised to Cedric at FOSDEM, we set sail to translate the german comments in the sw/source/core/layout/ directory. We're still not quite done, but here's what we have so far. This, and any future

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #201 from Vossman vossma...@yahoo.com 2012-02-27 06:23:34 PST --- I would like to nominate confirmed bug #44937 for 'most annoying'. As a professor, I was using the 3.5 series, but I cannot give my lectures because of the above bug,

[PUSHED] Removed unused code

2012-02-27 Thread Michael Meeks
On Sat, 2012-02-25 at 19:59 +0100, Bartolomé Sánchez Salado wrote: I've removed some unused virtual methods inside backends as Michael Meeks requested me: Thanks :-) we can update the unpublished interface to only implement what is actually used. Pushed,

[PATCH] convert SbxFactory in BASIC module from SV_DECL_PTRARR_DEL to boost::ptr_vector

2012-02-27 Thread Noel Grandin
Hi License is on file. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html From dcb00e7ca3c52d3c371eeb614629e3bcb4861e8b Mon Sep 17 00:00:00 2001 From: Noel Grandin n...@peralex.com Date: Mon, 27 Feb 2012 16:26:41 +0200 Subject: [PATCH] Convert SbxFactory from

Re: Question: How do I rasterize an SVG to a BitmapEx

2012-02-27 Thread Andrew Higginson
Hi, const ::vcl::RenderGraphicRasterizer aRaster( image/svg+xml, aSvgData.getLength(), aSvgData.getConstArray() ); BitmapEx aBmpEx = aRaster.Rasterize( Size(200,300) ); Thanks, and finally, how do I get the aSvgData? -- Andrew Higginson

re-doing git patches

2012-02-27 Thread Noel Grandin
Hi Is there some easier git-magic available for working on and re-submitting a patch? Using git-rebase seems incredibly fragile and hacky. Regards, Noel. On 2012-02-17 17:27, Michael Meeks wrote: Pushed, Thanks, all the patches are nice cleanups. Another thing that would help,

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #202 from Petr Mladek pmla...@suse.cz 2012-02-27 06:57:46 PST --- (In reply to comment #201) I would like to nominate confirmed bug #44937 for 'most annoying'. As a professor, I was using the 3.5 series, but I cannot give my

Re: [PUSHED] Change Windows newline to Unix newline

2012-02-27 Thread Korrawit Pruegsanusak
Hello Michael, On Tue, Nov 8, 2011 at 16:19, Michael Meeks michael.me...@suse.com wrote:        Nice to clean things up, I wonder if we could grep all of the code for any remaining instances of this fix them ? First, sorry for this 3-months backlog. :( For the record, I've done this at

Sophie Gautier/license statement

2012-02-27 Thread Sophie Gautier
Hi all, All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license until further notice. Kind regards Sophie -- Founding member of The Document Foundation ___ LibreOffice mailing list

[REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 00:53 -0600, Norbert Thiebaud wrote: Fixed invalid conversion from SvUShorts to std::vector... *sigh* Please, pick to the appropriate branches. I pushed it on the 3.5 branch. With one more review (preferably from a writer maintainer) we're good for 3.5.1 I

Re: Question: How do I rasterize an SVG to a BitmapEx

2012-02-27 Thread Thorsten Behrens
Andrew Higginson wrote: Thanks, and finally, how do I get the aSvgData? Just load your file into that - this RenderGraphic just wants a const sal_uInt8* ptr with the utf-8 encoded xml stream. ;) Cheers, -- Thorsten pgpMWjjjB12TW.pgp Description: PGP signature

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||44135 --- Comment #203

Re: re-doing git patches

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 16:49 +0200, Noel Grandin wrote: Is there some easier git-magic available for working on and re-submitting a patch? Oh ! so, if the patch is the latest / top patch on your queue - then 'git commit --amend' will re-write the top commit on the stack - that of

[PATCH] fdo44516 cleanup of direct use of RGD color in code

2012-02-27 Thread Winfried Donkers
Thanks to Norbert Thiebauld a small patch to remove direct use of an RGB-colour from the code. WinfriedFrom 31348488869937de80ed78f49730538919f1d3be Mon Sep 17 00:00:00 2001 From: Winfried Donkers o...@dci-electronics.nl Date: Mon, 27 Feb 2012 16:21:33 +0100 Subject: [PATCH] fdo44516 cleanup of

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||45171 --- Comment #204

Re: Most elegant way to disable all BASIC functionality?

2012-02-27 Thread Tor Lillqvist
So maybe hard-wiring that setting for the App-Store and not offer the dialog would be enough? Yeah, that's a good start, but we would still link in the whole shebang of never reachable BASIC-related code then;) (Static linking is used for iOS.) --tml

Re: Weird undefined symbol: ReferenceXInterface::operator ReferenceXInterface const() const

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 01:20 PM, Tor Lillqvist wrote: Anybody have a clue what might cause this (in a build for the iOS simulator, using the llvm-g++ 4.2.1 in Xcode 4.3): Undefined symbols for architecture i386: com::sun::star::uno::Referencecom::sun::star::uno::XInterface::operator

[REVIEW:3-5-1] do not pack stdlibs twice (fdo#46658)

2012-02-27 Thread Michael Meeks
One more review required. On Mon, 2012-02-27 at 14:44 +0100, Stephan Bergmann wrote: Pushed to libreoffice-3-5 as 216e30277b06124822cccdc2a6d46de57a2f8e6e, more reviews needed for libreoffice-3-5-1. Trivial patch, ack from me. Thanks, Michael. --

Re: [REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Ivan Timofeev
On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ), aMins( aTabCols.Count() + 1, 0 ); Hmm,

Re: [PUSHED] Change Windows newline to Unix newline

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 21:58 +0700, Korrawit Pruegsanusak wrote: On Tue, Nov 8, 2011 at 16:19, Michael Meeks michael.me...@suse.com wrote: Nice to clean things up, I wonder if we could grep all of the code for any remaining instances of this fix them ? First, sorry for this

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 01:07 PM, Helmar Spangenberg wrote: Anyway - using the older toolchain I got a working testing environment and proceded a little bit. I have the impression that the difficulties rise building the local context. As far as I could debug it, everything looks fine until a

Re: Most elegant way to disable all BASIC functionality?

2012-02-27 Thread Andras Timar
Hi, 2012/2/27 Eike Rathke er...@redhat.com: If this is only about no BASIC should be executed, there's the configuration setting behind Tools-Options-Security, Macro Security. If Security Level is set to Very High and no paths are added to Trusted Sources, then no BASIC is executed at all

[REVIEWED] Fix compiling with icecream on ubuntu

2012-02-27 Thread Michael Meeks
Hi Governa, On Sat, 2012-02-25 at 15:34 -0200, Governa wrote: On Ubuntu the icecream GCC_HOME should be /usr/lib/icecc. Added an test to configure.in to use this directory if it exists. Looks lovely, I was just about to commit it, and then ... I noticed that we could really use a full

[REVIEW][3.5]fdo#46531, spell checking display fun

2012-02-27 Thread Cedric Bosdonnat
Hello people, Could someone review and cherry-pick -s this commit into -3-5 branch? http://cgit.freedesktop.org/libreoffice/core/commit/?id=adf45eced404c33be6db884a3e809725e7975872 Thanks, -- Cedric ___ LibreOffice mailing list

Re: [PUSHED:3-5][PUSHED:3-5-1] fix build with internal libxml on MAC PPC

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 05:03 PM, Petr Mladek wrote: Fridrich Strba píše v Po 27. 02. 2012 v 12:00 +0100: Please review these three patches that are needed currently for the build of 3.5.1-rc1 with internal libxml on MacOSX 10.4 PPC The change for libcroco looks a bit hacky. Anyway, all the changes

Re: [libreoffice-l10n] [ANN] LibreOffice 3.5.1 RC1 available

2012-02-27 Thread Petr Mladek
Carlo Strata píše v Po 27. 02. 2012 v 11:48 +0100: just installed on my notebbok upgrading a LibreOffice 3.5.0 RC3, Linux, x86-64. I got this message (I translate it from Italian): carlobook:/home/carlo/Download/office/LibreOffice/LibO_3.5.1rc1_Linux_x86-64_install-rpm_en-US/RPMS # rpm

Re: [REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 19:46 +0400, Ivan Timofeev wrote: On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ),

Re: [PUSHED][REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Caolán McNamara
On Mon, 2012-02-27 at 16:15 +, Michael Meeks wrote: On Mon, 2012-02-27 at 19:46 +0400, Ivan Timofeev wrote: On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want:

[LibreOffice] License statement

2012-02-27 Thread Governa
Hi, all my contributions to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Best Regards, Fernando Governatore ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Ligatures in arabic fonts

2012-02-27 Thread Tomáš Chvátal
Dne Po 27. února 2012 14:27:47, Khaled Hosny napsal(a): This is likely to be an ICU issue, may be it is this issue: https://www.libreoffice.org/bugzilla/show_bug.cgi?id9955 and ICU bug ticket: http://bugs.icu-project.org/trac/ticket/8764 Awesome, it is indeed the fix. Thanks a lot.

[PATCH] Fix compiling with icecream on ubuntu

2012-02-27 Thread Governa
On Ubuntu the icecream GCC_HOME should be /usr/lib/icecc. Added an test to configure.in to use this directory if it exists. Fixed author name and e-mail on the patch. 0001-fix-icecc-compile-in-ubuntu.patch Description: Binary data ___ LibreOffice

Re: [Libreoffice-qa] [ANNOUNCE] libreoffice-3.5.1.1 tag created (3.5.1-rc1)

2012-02-27 Thread Petr Mladek
Michael Stahl píše v Pá 24. 02. 2012 v 17:25 +0100: On 24/02/12 17:19, Petr Mladek wrote: NOTE: The commit deadline for 3.5.1-rc1 is postponed to the following Wedensday/Thursday. We need to give testers some chance to check rc1. you mean the deadline for rc2, right? sure See the

[REVIEWED][3.5]fdo#46531, spell checking display fun

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 17:07 +0100, Cedric Bosdonnat wrote: Could someone review and cherry-pick -s this commit into -3-5 branch? http://cgit.freedesktop.org/libreoffice/core/commit/?id=adf45eced404c33be6db884a3e809725e7975872 Pushed; thanks :-) Michael. --

[PUSHED] fdo44516 cleanup of direct use of RGD color in code

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 16:25 +0100, Winfried Donkers wrote: Thanks to Norbert Thiebauld a small patch to remove direct use of an RGB-colour from the code. Pushed, thanks :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot

  1   2   3   4   5   >