[Libreoffice-commits] core.git: 3 commits - dictionaries filter/source helpcontent2 svx/source

2013-04-02 Thread Armin Le Grand
dictionaries|2 +- filter/source/msfilter/escherex.cxx | 13 - helpcontent2|2 +- svx/source/svdraw/svddrgmt.cxx | 13 + 4 files changed, 27 insertions(+), 3 deletions(-) New commits: commit

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 51/4843f9d4fbd4db287300faa52ca6bda618aea1

2013-04-02 Thread Xisco Fauli
51/4843f9d4fbd4db287300faa52ca6bda618aea1 |1 + 1 file changed, 1 insertion(+) New commits: commit bb41bb3098bab2fa6ff830143dfd913ef7ab67eb Author: Xisco Fauli aniste...@gmail.com Date: Tue Apr 2 07:24:50 2013 +0200 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - c6/302d8cf8522034ab795e13fa6bece88ab9057c

2013-04-02 Thread Xisco Fauli
c6/302d8cf8522034ab795e13fa6bece88ab9057c |1 + 1 file changed, 1 insertion(+) New commits: commit d2f59702fa19203c3af44881f888a9ce12da78ef Author: Xisco Fauli aniste...@gmail.com Date: Tue Apr 2 07:26:56 2013 +0200 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 7d/5520c591922f58a1bef59e39ad9f52d0c99165

2013-04-02 Thread Xisco Fauli
7d/5520c591922f58a1bef59e39ad9f52d0c99165 |1 + 1 file changed, 1 insertion(+) New commits: commit 31e457f255b1649401a91b5ab25b406a71dcaa4d Author: Xisco Fauli aniste...@gmail.com Date: Tue Apr 2 07:29:00 2013 +0200 Notes added by 'git notes add' diff --git

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - ucb/source

2013-04-02 Thread Tor Lillqvist
ucb/source/ucp/webdav-neon/NeonSession.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit be2ce85e9539debc7c40680a6616c7dbe461d74c Author: Tor Lillqvist tlillqv...@suse.com Date: Thu Mar 14 20:47:12 2013 +0200 Turn on Neon debug output (if enabled in

[Libreoffice-commits] core.git: svx/inc svx/source

2013-04-02 Thread David Tardon
svx/inc/svx/graphichelper.hxx |5 + svx/source/core/graphichelper.cxx |4 +++- 2 files changed, 4 insertions(+), 5 deletions(-) New commits: commit f38c4f138c6ec810b26fcf2064f64e64eb14129b Author: David Tardon dtar...@redhat.com Date: Tue Apr 2 07:34:56 2013 +0200 try to

[PATCH] use filelist install method for udkapi and offapi

2013-04-02 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3152 to look at the new patch set (#4). Change subject: use filelist install method for udkapi and offapi ..

[PATCH libreoffice-4-0] Turn on Neon debug output (if enabled in Neon) when building...

2013-04-02 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3166 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3166/1 Turn on Neon debug output (if enabled in Neon) when building for debugging Also add NE_DBG_LOCKS and NE_DBG_SSL

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - ucb/source

2013-04-02 Thread Tor Lillqvist
ucb/source/ucp/webdav-neon/NeonSession.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit fb0cdcb8e3084ac969a8d744e0e55041431b862e Author: Tor Lillqvist tlillqv...@suse.com Date: Thu Mar 14 20:47:12 2013 +0200 Turn on Neon debug output (if enabled in

[PUSHED libreoffice-4-0] Turn on Neon debug output (if enabled in Neon) when building...

2013-04-02 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3166 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3166 To unsubscribe,

[Libreoffice-commits] core.git: filter/source sw/source vcl/source

2013-04-02 Thread Golnaz Irannejad
filter/source/xslt/import/wordml/wordml2ooo_draw.xsl |2 +- sw/source/ui/vba/vbadocumentproperties.cxx |2 +- vcl/source/control/lstbox.cxx|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit

[Libreoffice-commits] core.git: l10ntools/source

2013-04-02 Thread Stephan Bergmann
l10ntools/source/xmlparse.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit a47e50e3386a13a1601b3aa1355de70aa9e056ff Author: Stephan Bergmann sberg...@redhat.com Date: Tue Apr 2 08:47:27 2013 +0200 Prevent asserts from firing ...whether or not

[Libreoffice-commits] core.git: sc/source

2013-04-02 Thread Thomas Arnhold
sc/source/ui/drawfunc/chartsh.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 83810a61bab4fe079de3539dc3489b008e776eaf Author: Thomas Arnhold tho...@arnhold.org Date: Tue Apr 2 08:48:28 2013 +0200 fix build css is ::com::sun::star already

[PUSHED] Fix typo: addtional = additional in the comment.

2013-04-02 Thread Andras Timar (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3165 Approvals: Andras Timar: Verified; Looks good to me, approved Thomas Arnhold: Looks good to me, but someone else must approve -- To

[PATCH] use filelist install method for udkapi and offapi

2013-04-02 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3152 to look at the new patch set (#5). Change subject: use filelist install method for udkapi and offapi ..

Re: GSOC 2013

2013-04-02 Thread Cedric Bosdonnat
Hello José, On Sat, 2013-03-30 at 11:50 -0300, José Guilherme Vanz wrote: Can I try some of these ideias outside gsoc? hehe Sure, you can and it would really be nice ;) Regards, -- Cedric ___ LibreOffice mailing list

Re:

2013-04-02 Thread Cedric Bosdonnat
Hello Sagar, On Sun, 2013-03-31 at 00:16 +0530, Sagar Narang wrote: sir, Sorry, this is a list, not a personal email address ;) I have reviewing a lot about GSoC 2013 and i found your open source project as one of the most interesting. I am really interesting in contributing to it. Can you

Re: Google Summer of Code

2013-04-02 Thread Cedric Bosdonnat
Hello On Mon, 2013-04-01 at 19:28 +0530, Pratyush Nalam wrote: As described in that link, I ran sudo apt-get build-dep libreoffice. The problem is it started installing openjdk and those set of packages. However, I already have Oracle Java installed as per this link

REMINDER: Release 3.6.6.2 from libreoffice-3-6-6 branch

2013-04-02 Thread Petr Mladek
Hi, please note that the commit deadline for 3.6.6.2, aka rc2, is today, April 2, 2013[*]. It will be used as LO-3.6.6 final if no blocker is reported. [*] This time it is really 3.6.6.2 ;-) See also http://wiki.documentfoundation.org/ReleasePlan#3.6_release

[PATCH] remove unused code.

2013-04-02 Thread navin patidar (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3167 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3167/1 remove unused code. A request (rReq) having anyone of following SID SID_ATTR_CHAR_FONTHEIGHT,

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - 5 commits - oox/inc oox/source sw/inc sw/source

2013-04-02 Thread Miklos Vajna
oox/inc/oox/vml/vmlshape.hxx | 15 ++- oox/source/vml/vmlshape.cxx | 23 ++- sw/inc/fldbas.hxx |2 ++ sw/source/core/fields/fldbas.cxx | 15 +++ sw/source/core/layout/trvlfrm.cxx | 19 ++-

Re: Google Summer of Code

2013-04-02 Thread Pratyush Nalam
Thanks! I'll try that Pratyush Nalam Technology. Environment. Inclusive Society. http://www.cse.iitb.ac.in/~pratnala On Tue, Apr 2, 2013 at 1:00 PM, Cedric Bosdonnat cbosdon...@suse.comwrote: Hello On Mon, 2013-04-01 at 19:28 +0530, Pratyush Nalam wrote: As described in that link, I ran

[Libreoffice-commits] core.git: chart2/source chart2/uiconfig

2013-04-02 Thread EricSeynaeve
chart2/source/controller/dialogs/tp_ChartType.cxx | 84 - chart2/source/controller/dialogs/tp_ChartType.hrc | 11 -- chart2/source/controller/dialogs/tp_ChartType.src | 87 -- chart2/uiconfig/ui/smoothlinesdlg.ui | 77

[PUSHED] Converting Smooth Lines dialog to glade

2013-04-02 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3103 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3103 To unsubscribe,

[Libreoffice-commits] core.git: chart2/source chart2/uiconfig

2013-04-02 Thread Caolán McNamara
chart2/source/controller/inc/HelpIds.hrc |1 chart2/uiconfig/ui/smoothlinesdlg.ui | 141 --- 2 files changed, 73 insertions(+), 69 deletions(-) New commits: commit 55f878d7ea532c51c66cc0388ce5b09d42827a26 Author: Caolán McNamara caol...@redhat.com Date:

[Libreoffice-commits] core.git: helpcontent2

2013-04-02 Thread Caolán McNamara
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2f03b448073605b51fa7e1953c815c5b6786dde9 Author: Caolán McNamara caol...@redhat.com Date: Tue Apr 2 10:11:11 2013 +0100 Updated core Project: help 368e41dfa3f5f1d0cd04c9605cf36db49b9d03b3 diff

[Libreoffice-commits] help.git: helpers/help_hid.lst source/text

2013-04-02 Thread Caolán McNamara
helpers/help_hid.lst |5 - source/text/schart/01/smooth_line_properties.xhp | 11 +-- 2 files changed, 5 insertions(+), 11 deletions(-) New commits: commit 368e41dfa3f5f1d0cd04c9605cf36db49b9d03b3 Author: Caolán McNamara caol...@redhat.com Date:

[Libreoffice-commits] core.git: chart2/source chart2/UI_chart2.mk

2013-04-02 Thread Caolán McNamara
chart2/UI_chart2.mk |4 ++-- chart2/source/controller/dialogs/tp_ChartType.cxx |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 641d8eaa980c00802964e07b0397ba3c2884bd7d Author: Caolán McNamara caol...@redhat.com Date: Tue Apr 2

Removing C++ SDK examples, clearly encouraging Python extensions (was: LibreOffice prints on tuesdays)

2013-04-02 Thread Bjoern Michaelsen
Hi, On Mon, Apr 01, 2013 at 06:43:27AM -0400, Dan Lewis wrote: What is the purpose of this extension? Why print only on Tuesdays? The real purpose of this extension is to be an example on how to write a simple extension: https://plus.google.com/101094190333184858950/posts/dpLf3s6C2r5

Re: [PUSHED] fdo#35546, implementing 'Create Photo Album' function

2013-04-02 Thread Andras Timar
Hi Samuel, On 2013.03.30. 9:09, Samuel Mehrbrodt wrote: Why was this merged? It's very uncomplete (I tested it). See TODO in the commit message: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7ef3b46fd5bdfb3a87e9b0a840287fdb6ff4734b and my comments in the bug report:

Research: FLOSS hackers between company and community

2013-04-02 Thread Thomas Zerbach
The University of Koblenz-Landau (Germany) is looking for participants for a research study revolving around the job situation of (professional) open source developers. The goal of the study is to gain insights on the effect of developers' double commitment to the community and the

Wiki pages cruft cleanup

2013-04-02 Thread Bjoern Michaelsen
Hi, I cleaned up: https://wiki.documentfoundation.org/Main_Page https://wiki.documentfoundation.org/Development https://wiki.documentfoundation.org/QA and removed a lot of cruft on these pages. The intention was: - To separate the 'get involved' section from the the 'tips and tricks'-stuff a

Re: Removing C++ SDK examples, clearly encouraging Python extensions (was: LibreOffice prints on tuesdays)

2013-04-02 Thread Cedric Bosdonnat
On Tue, 2013-04-02 at 11:33 +0200, Bjoern Michaelsen wrote: Also -- and this is a proposal for the ESC to discuss: I would like to remove the C++ examples there. Im not kidding, April fools is over in my time zone. I tried hard to make them work and just couldnt get them to build (trying it

Re: reduce some uglyness

2013-04-02 Thread Michael Stahl
On 30/03/13 14:59, Thomas Arnhold wrote: Hi, two weeks ago I did some rearranging of rngitem, but the build broke on the windows tinderbox Win-x86_6 (revert: df8c41cceeca27ae49e9fa6b5cd64c65c8feb218). This was the error message: error C2011: ´SfxRangeItem´ : ´class´ type redefinition

[Libreoffice-commits] core.git: sw/inc sw/source

2013-04-02 Thread Oliver-Rainer Wittmann
sw/inc/doc.hxx | 13 +++ sw/source/core/doc/doclay.cxx | 22 +++- sw/source/core/doc/docnew.cxx |1 sw/source/core/layout/frmtool.cxx | 61 sw/source/filter/basflt/shellio.cxx |6 +-- 5 files

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b4/1eec25c2c6bc44eef55ae1c4ef57b9012fc8e6

2013-04-02 Thread Caolán McNamara
b4/1eec25c2c6bc44eef55ae1c4ef57b9012fc8e6 |1 + 1 file changed, 1 insertion(+) New commits: commit f331a3c27583854a0b7820120f141b814bdb5863 Author: Caolán McNamara caol...@redhat.com Date: Tue Apr 2 10:56:08 2013 +0100 Notes added by 'git notes add' diff --git

Re: Removing C++ SDK examples, clearly encouraging Python extensions

2013-04-02 Thread Stephan Bergmann
On 04/02/2013 11:33 AM, Bjoern Michaelsen wrote: The real purpose of this extension is to be an example on how to write a simple extension: https://plus.google.com/101094190333184858950/posts/dpLf3s6C2r5 Being nonsensical actually help at being an example, because if you write an example

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2013-04-02 Thread Miklos Vajna
sw/qa/extras/ooxmlimport/ooxmlimport.cxx |5 - writerfilter/source/dmapper/DomainMapperTableManager.cxx | 10 ++ writerfilter/source/dmapper/DomainMapperTableManager.hxx |7 +++ 3 files changed, 21 insertions(+), 1 deletion(-) New commits: commit

Re: [Libreoffice-qa] [Moztrap] Some questions to the test cases, particularly #130

2013-04-02 Thread Yifan Jiang
Hi Devs, Sorry to interrupt, just to confirm, were you aware of some changes to the menu item File-Template (it seemed gone since 4.x)? The background is we were talking about vp.6 in a regression test case:

Support of templates and extensions was: Re: Libreoffice-qa Digest, Vol 21, Issue 51

2013-04-02 Thread Petr Mladek
Robinson Tryon píše v So 30. 03. 2013 v 10:55 -0400: From: Joel Madero jmadero@gmail.com 2) An official badge that will be prominently displayed on templates that are: a) bundled with LibreOffice b) Meet some other criteria that is to be determined by QA *the idea is that

Re: Removing C++ SDK examples, clearly encouraging Python extensions (was: LibreOffice prints on tuesdays)

2013-04-02 Thread Bjoern Michaelsen
Hi, On Tue, Apr 02, 2013 at 11:47:18AM +0200, Cedric Bosdonnat wrote: IMHO what would be needed: * make uno-skeletonmaker generate python code skeleton * add python support to ooeclipse using pydev (or add UNO support to a python IDE) I see both not being that essential, to be honest:

[Libreoffice-commits] core.git: chart2/source

2013-04-02 Thread Markus Mohrhard
chart2/source/controller/dialogs/tp_ChartType.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 63f00101c578d019efc5d5f6b9008077e559144f Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Apr 2 11:25:36 2013 +0200 fix the build on

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - connectivity/source

2013-04-02 Thread Fridrich Štrba
connectivity/source/drivers/mozab/MDriver.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit c976cd58b7bee71ea43dd1f4aad3b1c1fcb32516 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Tue Apr 2 12:38:45 2013 +0200 Fix debug build Change-Id:

[PATCH libreoffice-4-0] Fix debug build

2013-04-02 Thread Fridrich Strba (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3168 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3168/1 Fix debug build Change-Id: I1a4db30f4cc33ee99b48a25db6e6fcd600d00ffd --- M

[PUSHED libreoffice-4-0] Fix debug build

2013-04-02 Thread Andras Timar (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3168 Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3168 To unsubscribe,

[Libreoffice-commits] core.git: 2 commits - connectivity/source dbaccess/source offapi/com offapi/type_reference offapi/UnoApi_offapi.mk

2013-04-02 Thread Fridrich Štrba
connectivity/source/drivers/mozab/MDriver.cxx |5 + dbaccess/source/core/api/query.cxx|2 dbaccess/source/core/api/querycontainer.cxx | 10 +-- dbaccess/source/core/dataaccess/commandcontainer.cxx |3

[PUSHED] fdo#46808, convert sdb::QueryDesigner to new style

2013-04-02 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3031 -- To view, visit https://gerrit.libreoffice.org/3031 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

Re: Google Summer of Code

2013-04-02 Thread Pratyush Nalam
Hi I was trying to clone the git repo and I was met with this Cloning into 'libreoffice'... fatal: unable to connect to anongit.freedesktop.org: anongit.freedesktop.org[0: 131.252.210.161]: errno=Connection timed out Doesn't it work behind a HTTP proxy? All my environment variables are fine

[PATCH] Create Photo Album implementation

2013-04-02 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3169 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3169/1 Create Photo Album implementation Added a checkbox to enable/diable Keep Aspect ratio, plus 2 images/slide

Re: Google Summer of Code

2013-04-02 Thread Cedric Bosdonnat
On Tue, 2013-04-02 at 16:39 +0530, Pratyush Nalam wrote: Doesn't it work behind a HTTP proxy? All my environment variables are fine (even the git config variables are fine) Did you try cloning with this URL (mind it's not git://)? http://anongit.freedesktop.org/git/libreoffice/core.git

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - 4 commits - oox/inc oox/source sw/source writerfilter/source

2013-04-02 Thread Cédric Bosdonnat
oox/inc/oox/vml/vmltextbox.hxx |1 + oox/source/vml/vmltextbox.cxx |8 oox/source/vml/vmltextboxcontext.cxx| 11 +++ sw/source/core/text/xmldump.cxx |2 ++ writerfilter/source/dmapper/StyleSheetTable.cxx

Re: Google Summer of Code

2013-04-02 Thread Pratyush Nalam
Yeah this worked. Thanks to Noel! Pratyush Nalam Technology. Environment. Inclusive Society. http://www.cse.iitb.ac.in/~pratnala On Tue, Apr 2, 2013 at 4:53 PM, Cedric Bosdonnat cbosdon...@suse.comwrote: On Tue, 2013-04-02 at 16:39 +0530, Pratyush Nalam wrote: Doesn't it work behind a HTTP

[PATCH] fdo#57950: Chained appends in postgresql driver

2013-04-02 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3170 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3170/1 fdo#57950: Chained appends in postgresql driver While studing the postgresql driver I found these chained

[Libreoffice-commits] core.git: sw/source

2013-04-02 Thread navin patidar
sw/source/ui/shells/textsh1.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit bb920862c02047471f0ac5e78358e8d8fd9b93e7 Author: navin patidar pati...@kacst.edu.sa Date: Mon Apr 1 10:06:12 2013 +0300 fix fdo#40496: don't reset RES_PARATR_ADJUST

[PUSHED] fix fdo#40496: don't reset RES_PARATR_ADJUST RES_FRAMEDIR ...

2013-04-02 Thread Bosdonnat Cedric (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3146 Approvals: Bosdonnat Cedric: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3146 To unsubscribe,

Re: reduce some uglyness

2013-04-02 Thread Thomas Arnhold
On 02.04.2013 11:51, Michael Stahl wrote: it's a mystery why it works on other compilers, because you have removed the header guard #define _SFXRNGITEM_HXX which causes multiple inclusion of the header to define the same types multiple times, which MSVC rightfully complains about. i grant that

[Libreoffice-commits] core.git: svx/source

2013-04-02 Thread Gokul
svx/source/table/tablecontroller.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 635f3da03a09213b3d86ced40e7e280cc03d409e Author: Gokul gswaminat...@kacst.edu.sa Date: Sat Mar 30 09:02:20 2013 +0300 Fix related to fdo#62224. on clicking Cancel

[PUSHED] Fix related to fdo#62224.

2013-04-02 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3092 Approvals: Björn Michaelsen: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3092 To unsubscribe,

[PATCH] Revert Revert reduce some uglyness

2013-04-02 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3171 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/3171/1 Revert Revert reduce some uglyness The header guard seems to solve the problem. This reverts commit

idle comment ;-

2013-04-02 Thread Michael Meeks
Hi Tor, Your comment here is really interesting. http://cgit.freedesktop.org/libreoffice/core/commit/?id=428ae24e55b1b2d7c9578d0e8ac58bb8e202c3be IMHO - one big problem we have with VCL is the total lack of priority for scheduling callbacks. We see this in lots of

Re: [Libreoffice-qa] [Moztrap] Some questions to the test cases, particularly #130

2013-04-02 Thread Petr Mladek
Yifan Jiang píše v Út 02. 04. 2013 v 18:04 +0800: Hi Devs, Sorry to interrupt, just to confirm, were you aware of some changes to the menu item File-Template (it seemed gone since 4.x)? The background is we were talking about vp.6 in a regression test case:

[PATCH] Remove obsolete user-supplied flags

2013-04-02 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3172 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/3172/1 Remove obsolete user-supplied flags Fix TODO - now that we have migrated to gbuild, there is no more need for

[PUSHED] Widget UI for Calc cell alignment page

2013-04-02 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2773 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2773 To unsubscribe,

[Libreoffice-commits] core.git: 2 commits - cui/uiconfig svx/inc svx/source

2013-04-02 Thread Caolán McNamara
cui/uiconfig/ui/cellalignment.ui | 123 +++--- svx/inc/svx/dialcontrol.hxx |3 svx/source/dialog/dialcontrol.cxx | 53 3 files changed, 92 insertions(+), 87 deletions(-) New commits: commit 67e5e3763f31fdc906c8e9b3239b636bce3139ed

Re: minutes of ESC call ...

2013-04-02 Thread Michael Meeks
On Thu, 2013-03-28 at 21:34 +0100, Miklos Vajna wrote: Yes, both cherry-pick and revert should support renames, there is even a testcase for that: ... and it resolved the conflict automatically. Very encouraging ! :-) Thanks, Michael ( who is eager to make

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sfx2/source

2013-04-02 Thread Julien Nabet
sfx2/source/dialog/templdlg.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4bd26ee5f1c16eed69f4521bc4fcedbaa6e1737b Author: Julien Nabet serval2...@yahoo.fr Date: Sat Mar 30 19:42:48 2013 +0100 coverity#441020 Dereference after null check

Re: About coverity 441020 (templdlg.cxx in sfx2)

2013-04-02 Thread cbosdonnat
Salut Julien, On Sat, 2013-03-30 at 12:23 -0700, julien2412 [via Document Foundation Mail Archive] wrote: So I pushed a patch here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=cab7f6476f7d0f17bf2f1400bf93fb1b7fbd1625 - StartListening(*pOldStyleSheetPool); +

[Libreoffice-commits] core.git: 3 commits - drawinglayer/inc drawinglayer/source

2013-04-02 Thread Thomas Arnhold
drawinglayer/inc/drawinglayer/attribute/lineattribute.hxx |6 drawinglayer/inc/drawinglayer/attribute/linestartendattribute.hxx |6 drawinglayer/inc/drawinglayer/attribute/materialattribute3d.hxx |6 drawinglayer/source/attribute/lineattribute.cxx | 84

[PATCH] Easter Bunny brings new redland tarballs

2013-04-02 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3154 to look at the new rebased patch set (#3). Change subject: Easter Bunny brings new redland tarballs

[Libreoffice-commits] core.git: canvas/source

2013-04-02 Thread Stephan Bergmann
canvas/source/factory/cf_service.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 67d724e46579462d906477f52cf7919338bab834 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Apr 2 15:16:22 2013 +0200 Adapt code to IllegalArgumentException being a RuntimeException

Re: $(ISYSTEM) considered harmful

2013-04-02 Thread Stephan Bergmann
On 04/01/2013 01:04 PM, Michael Stahl wrote: On 31/03/13 14:52, Tor Lillqvist wrote: make clean helps. (if you have the patience, you can do make foo.clean for each module that depend on icu.) if make clean helps, most likely something is clearly wrong. in this case apparently the following

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - .gitignore

2013-04-02 Thread Stephan Bergmann
.gitignore |1 + 1 file changed, 1 insertion(+) New commits: commit 9e8115327fac8fe26be8e16e799271650392b785 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Apr 2 15:30:43 2013 +0200 .gitignore config/config_version.h (generated) diff --git a/.gitignore b/.gitignore index

Re: crash in headless/hidden mode when loading fdo#61305-1.docx

2013-04-02 Thread Stephan Bergmann
On 04/02/2013 02:50 PM, Thorsten Behrens wrote: Markus Mohrhard wrote: The line that throws the exception is: ENSURE_ARG_OR_THROW( bHasXRender == true, SpriteCanvas::SpriteCanvas: No RENDER extension ); Do you have an idea how to fix this? I sadly have no clue about canvas or the new style uno

Re: RE : Difficulties to build LO for windows

2013-04-02 Thread Michael Meeks
On Thu, 2013-03-28 at 21:06 +0100, Michael Stahl wrote: that problem sounds familiar. the fix for it is commit 111e10bd401b3fee981f32f5f98fc7512a5c47f8 which is unfortunately not on the libreoffice-3-5 branch. I attach a prototype back-port of that :-) but can't test it here myself;

[PATCH] Allow selecting the tls backend to use in oox from configure

2013-04-02 Thread Miguel Gomez (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3173 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/3173/1 Allow selecting the tls backend to use in oox from configure Change-Id:

[Libreoffice-commits] core.git: codemaker/inc

2013-04-02 Thread Stephan Bergmann
codemaker/inc/codemaker/dependencies.hxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit c1c6feedb3b1f9412f852be06538f0e4c66bb12f Author: Stephan Bergmann sberg...@redhat.com Date: Tue Apr 2 15:34:45 2013 +0200 Sort generated includes lexicographically

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - 4 commits - .gitignore svx/inc svx/source

2013-04-02 Thread Stephan Bergmann
.gitignore |1 svx/inc/svx/dialogs.hrc |2 + svx/source/tbxctrls/tbcontrl.cxx | 43 +++ svx/source/tbxctrls/tbcontrl.src | 10 + 4 files changed, 56 insertions(+) New commits: commit

[Libreoffice-commits] core.git: 2 commits - mdds/UnpackedTarball_mdds.mk solenv/gbuild vigra/UnpackedTarball_vigra.mk

2013-04-02 Thread Michael Stahl
mdds/UnpackedTarball_mdds.mk | 31 -- solenv/gbuild/UnpackedTarball.mk | 19 vigra/UnpackedTarball_vigra.mk | 86 --- 3 files changed, 136 deletions(-) New commits: commit addfe6a68ca9e606c1796954e12621ae951180fc Author:

[Libreoffice-commits] core.git: solenv/gbuild

2013-04-02 Thread Luboš Luňák
solenv/gbuild/gbuild.mk |2 -- 1 file changed, 2 deletions(-) New commits: commit d332c291221df089c2088b4b4239806077d1e9d4 Author: Luboš Luňák l.lu...@suse.cz Date: Tue Apr 2 16:00:42 2013 +0200 remove incorrect todo comments about ENVCFLAGS Actually these variables have

Re: [Libreoffice-commits] core.git: 5 commits - Library_merged.mk sal/osl sfx2/source solenv/gbuild vcl/unx

2013-04-02 Thread Miklos Vajna
Hi Peter, On Sun, Mar 31, 2013 at 08:34:05AM -0700, Peter Foley pefol...@verizon.net wrote: commit 8b561c0012546aabbaff33b32a79833997aa8902 Author: Peter Foley pefol...@verizon.net Date: Sat Mar 30 19:12:22 2013 -0400 If you can't load a shared library it should be a warning

[Libreoffice-commits] core.git: unoidl/source

2013-04-02 Thread Stephan Bergmann
unoidl/source/legacyprovider.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6275ffee61554490af69b51eb669e4a0a0a33eb6 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Apr 2 16:11:46 2013 +0200 types.rdb format flags default service ctors as

Some gerrit love

2013-04-02 Thread Chris Sherlock
Hi folks, Anyone able to give the following some love? https://gerrit.libreoffice.org/#/c/2928/ Seems quite useful. Chris Sherlock ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[ABANDONED] Remove obsolete user-supplied flags

2013-04-02 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Remove obsolete user-supplied flags .. Patch Set 1: Abandoned I'll change the TODO :-) Fair point made! -- To view, visit https://gerrit.libreoffice.org/3172 To

[Libreoffice-commits] core.git: xmlhelp/Library_ucpchelp1.mk xmlhelp/source

2013-04-02 Thread Andras Timar
xmlhelp/Library_ucpchelp1.mk |1 xmlhelp/source/cxxhelp/provider/databases.cxx | 30 +- xmlhelp/source/cxxhelp/provider/databases.hxx |2 - 3 files changed, 22 insertions(+), 11 deletions(-) New commits: commit

[Libreoffice-commits] core.git: l10ntools/source

2013-04-02 Thread Zolnai Tamás
l10ntools/source/xmlparse.cxx | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) New commits: commit 68c72dfb9db5c452bad13203699b17c4f4fcf6cc Author: Zolnai Tamás zolnaitamas2...@gmail.com Date: Tue Apr 2 16:16:12 2013 +0200 Fix assertion in xmlparse and call this

[Libreoffice-commits] core.git: 2 commits - cui/source sysui/desktop

2013-04-02 Thread Caolán McNamara
cui/source/inc/helpid.hrc |3 --- sysui/desktop/menus/startcenter.desktop |1 + 2 files changed, 1 insertion(+), 3 deletions(-) New commits: commit d0fead61293fdcee8ce3f7ed620784cc093a21ea Author: Caolán McNamara caol...@redhat.com Date: Tue Apr 2 15:24:07 2013 +0100

Re: Broken localized build

2013-04-02 Thread Zolnai Tamás
Hi, Yes, that was my commit caused the problem. I forgot test whether the tests work. By now they work well. Regards, Tamás 2013/4/2 Olivier Hallot olivier.hal...@documentfoundation.org -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 After a git pull and make clean, I can't pass through

Re: Some gerrit love

2013-04-02 Thread Riccardo Magliocchetti
Hi Chris, Il 02/04/2013 16:13, Chris Sherlock ha scritto: Hi folks, Anyone able to give the following some love? https://gerrit.libreoffice.org/#/c/2928/ Seems quite useful. thanks for being supportive about this feature. Don't worry, I'll just push it myself if nobody have time to review

Re: [Libreoffice-commits] core.git: 5 commits - Library_merged.mk sal/osl sfx2/source solenv/gbuild vcl/unx

2013-04-02 Thread Michael Stahl
On 02/04/13 16:07, Miklos Vajna wrote: On Sun, Mar 31, 2013 at 08:34:05AM -0700, Peter Foley pefol...@verizon.net wrote: -SAL_INFO_IF( +SAL_WARN_IF( pLib == 0, sal.osl, dlopen( pModuleName , rtld_mode ): dlerror()); Uhm,

[Libreoffice-commits] core.git: starmath/source svtools/inc sw/qa writerfilter/source

2013-04-02 Thread Miklos Vajna
starmath/source/rtfexport.cxx |3 svtools/inc/svtools/rtfkeywd.hxx |1 sw/qa/extras/rtfexport/data/mnor.rtf | 86 + sw/qa/extras/rtfexport/rtfexport.cxx | 10 ++ writerfilter/source/rtftok/rtfdocumentimpl.cxx

[Libreoffice-commits] core.git: sysui/desktop

2013-04-02 Thread Caolán McNamara
sysui/desktop/menus/base.desktop |1 + sysui/desktop/menus/calc.desktop |1 + sysui/desktop/menus/draw.desktop |1 + sysui/desktop/menus/impress.desktop |1 + sysui/desktop/menus/math.desktop |1 + sysui/desktop/menus/printeradmin.desktop |

[PATCH libreoffice-4-0] Adapt code to IllegalArgumentException being a RuntimeExcept...

2013-04-02 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3174 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/3174/1 Adapt code to IllegalArgumentException being a RuntimeException ...since

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - canvas/source

2013-04-02 Thread Stephan Bergmann
canvas/source/factory/cf_service.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 749095a80b526fab01acf8bf5bee824ce7cbb664 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Apr 2 15:16:22 2013 +0200 Adapt code to IllegalArgumentException being a RuntimeException

[Libreoffice-commits] core.git: sysui/desktop

2013-04-02 Thread Caolán McNamara
sysui/desktop/menus/base.desktop |1 + sysui/desktop/menus/calc.desktop |1 + sysui/desktop/menus/draw.desktop |1 + sysui/desktop/menus/impress.desktop |1 + sysui/desktop/menus/math.desktop |1 + sysui/desktop/menus/printeradmin.desktop |

[PUSHED libreoffice-4-0] Adapt code to IllegalArgumentException being a RuntimeExcept...

2013-04-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3174 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3174 To unsubscribe,

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 6a/f6c8049cb337cf5dd3b05ed08759f7e196c70e

2013-04-02 Thread Caolán McNamara
6a/f6c8049cb337cf5dd3b05ed08759f7e196c70e |1 + 1 file changed, 1 insertion(+) New commits: commit 6e8727c9126ea022df458618f3f38266a2fdc3ba Author: Caolán McNamara caol...@redhat.com Date: Tue Apr 2 15:59:59 2013 +0100 Notes added by 'git notes add' diff --git

Re: Broken localized build

2013-04-02 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks Tamás, for fixing it. Em 02-04-2013 11:29, Zolnai Tamás escreveu: Hi, Yes, that was my commit caused the problem. I forgot test whether the tests work. By now they work well. Regards, Tamás - -- Olivier Hallot Founder, Board of

[Libreoffice-commits] core.git: sal/inc vcl/unx

2013-04-02 Thread Thomas Arnhold
sal/inc/sal/log-areas.dox |2 ++ vcl/unx/gtk/app/gtkdata.cxx | 15 +-- vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx |5 + vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx |2 +- vcl/unx/kde/kdedata.cxx | 17

[Libreoffice-commits] core.git: 2 commits - boost/boost.wundef.patch.1 cppunit/Module_cppunit.mk test/Module_test.mk unotest/Module_unotest.mk

2013-04-02 Thread Tor Lillqvist
boost/boost.wundef.patch.1 | 43 +++ cppunit/Module_cppunit.mk |4 test/Module_test.mk|4 unotest/Module_unotest.mk |2 ++ 4 files changed, 53 insertions(+) New commits: commit 07f98c44311464fd7e5f94f569f847e43a0be4a2

[PUSHED] vcl: convert some fprintf to SAL_INFO

2013-04-02 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3143 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3143 To unsubscribe,

  1   2   3   >