Re: minutes of ESC call ...

On 11/2/2017 8:10 PM, Michael Meeks wrote: > * Completed Action Items: > + ship the horror win / VC runtime DLLs with the installer (Cloph) > [ patch appears to work, but we already have them in the installer >if you do an admin-install they are already installed. >

32bitjavacrash workaround?

Hi, As the java's stack management still is the problem for LibreOffice on Linux [1], I had an idea (disclaimer: I use Windows for development, and I have no Java experience, so I don't volunteer for the hardest part): Currently we have a test for working OpenCL implementation, that launches o

Re: Localization issues related to telling users to update after submitting a crash report

On 4/17/2017 1:47 AM, Markus Mohrhard wrote: > we need a way to > notify users that reports for these versions are ignored and that they > should use a newer version. > ... > My problem is now whether we > need to provide a localized version of this string. The string would > come from the server w

Re: LibreOffice Error during make command

On 7/31/2017 11:08 AM, Miklos Vajna wrote: > Hi, > > On Fri, Jul 21, 2017 at 09:24:04PM -0700, sherlock > wrote: >> As It mentioned in the tutorial( >> https://wiki.documentfoundation.org/Development/BuildingForAndroid ), I >> downloaded latest version via this command( git clone >> git://anongi

Re: LO 80731 - Incorrect syntax does compile, MID without end bracket

Hi Pierre, On 8/4/2017 4:26 AM, Pierre Lepage wrote: > I have implemented a new warning option on compilation. I did not go too > far. Great! > A simple checkbox "Warning On" and an "else" in the faulty > structure causing the problem of the closing parenthesis does the trick. > I have includ

C[++]: Normalizing include syntax ("" vs <>)

Hi! Lately, I've pushed some commits ([1], [2], [3]) that change syntax used for some includes. I wanted to share my rationale behind that, along with some notes about past discussion on this topic. The topic is using one of two syntaxes described for #include directive in standard (section [c

Re: C[++]: Normalizing include syntax ("" vs <>)

Hi, 09.10.2017 12:23, Stephan Bergmann пишет: > On 10/09/2017 10:29 AM, Stephan Bergmann wrote: >> On 10/06/2017 11:26 AM, Kaganski Mike wrote: >>> 3. *Always* use "" syntax *only* for includes that refer to headers >>> placed next to the cur

A proposal for separate English localization

Hello! Recently I was approached by members of our local community who manage the translation of LibreOffice UI to Russian. I was told that they have a regularly recurring problem, that each time a developer changes an English string in LibreOffice UI, they have that string untranslated in poo

Re: odt's to image-embedded html's

Hi Nazarii, 17 Июн 2018 г. 17:11 пользователь Nazarii написал: Hello everybody, Sorry for disturbing you but I'm in need of some help (was trying to Google but without much success). Given: * Lubuntu 18.04 * LO 6.0 I have a bunch of odt files (in one folder). I need to convert all o

Re: Cppcheck: Reduction of False Positives with a MSVC Project File

Hi! https://gerrit.libreoffice.org/60119 https://gerrit.libreoffice.org/60122 https://gerrit.libreoffice.org/60120 https://gerrit.libreoffice.org/60121 https://gerrit.libreoffice.org/60123 are meant to take care of those that aren't false positives... -- Best regards, Mike Kaganski

precompiled_basctl is always rebuilt on Windows, even when no edits were made

Hi! Since last few weeks, I see that precompiled_basctl started to get rebuilt every time I do an incremental build on my Win10+VS2015+cygwin64 development box (and, naturally, the dependent module as well). This happens whenever I do make build-nocheck, even when there were no edits to anythi

Re: libreoffice 6.1.0.0.beta1 failing hsqldb test

On 5/31/2018 10:47 AM, Miklos Vajna wrote: > IIRC Rene had SAL_USE_VCLPLUGIN=svp set globally. master had > fixes to tolerate that but not sure if that was cherry-picked to > libreoffice-6-1. The https://gerrit.libreoffice.org/54068 was reverted in https://gerrit.libreoffice.org/54123 after mst f

Re: about basic header files

Hi Rahul Gurung! On 8/8/2018 9:37 AM, Rahul Gurung wrote: > In colleges, we are taught to use header files like iostream.h in cpp to > use various functions, but while diving in LO code (specifically java > and cpp tests)  i found that we don't mention those header files, why so? Please be mor

Re: Windows Debug builds failure: 'DbgGUIInitSolarMutexCheck': identifier not found

Hi! On 8/8/2018 3:56 PM, Stephan Bergmann wrote: > On 07/08/18 18:14, Stephan Bergmann wrote: >> As we speak, I happen to run into your CppunitTest_cppuhelper_qa_misc >> failure with my MSVC build (with latest Visual Studio 2017, see above) >> too, will investigate.  (The test currently only run

Re: Windows Debug builds failure: 'DbgGUIInitSolarMutexCheck': identifier not found

I forgot to mention that the problem with CppunitTest_cppuhelper_qa_misc manifests itself because it happens to have two tests: testCatchThrow first, which triggers the described behaviour and modifies global state, and testgetCaughtException second, that tries to test exception handling and fa

PythonTest_sw_python failure

Since commit 4a290888580474f9542f185091bb2a6fcf4e9a53, PythonTest_sw_python fails on Windows (with VS 15.8.6) in SvtBroadcaster::~SvtBroadcaster() on line 102 while (dest != maDestructedListeners.end() && (*dest < *it)) on second iteration when maListeners contains more than 1 item. The

Re: plural forms translation, ngettext

On 10/5/2018 6:09 PM, Caolán McNamara wrote: > To current NC_(context, string) we add NNC_(context, singular, plural) > when declaring the strings for translation How does it play with other languages, where we might have more complex rules? E.g., in Russian, a "singular" form might be used for a

Re: Build error on Windows

Hi Gabor, On 10/10/2018 10:58 AM, Gabor Kelemen wrote: > We are experiencing a misterious build error with current master branch > on Windows without any code changes. > make distclean does not help. Any idea what could be done here? > > [build DEP] LNK:Library/dbmmlo.dll >    Creating library

Re: Build error on Windows

On 10/10/2018 12:02 PM, Stephan Bergmann wrote: > Looks like a bug in > > > "Implement Windows VCL backend as plugin", which removed the shlwapi > dependency from vcl/Library_vcl.mk but didn't ad

Re: Build error on Windows

On 10/10/2018 8:57 PM, Jan-Marek Glogowski wrote: > I did my build without specifying an SDK, so this uses the newest one on the > system (from VS 2017). > I simply removed all dependencies and added libraries, until linking didn't > fail anymore. > Mike added shlwapi in commit 095caf5c7501 ("Res

Re: Upstream clang compiler plugins, licensing

On 10/10/2018 10:53 PM, Tamás Zolnai wrote: > With this new information I agree that it would be the best to clear the > licensing and use LLVM in every source file under compilerplugins > folder. So the question is what is the best way to do that. What is the > best way to ask every authors for

RE: Future of Java

Hi, IMO, there's nothing requiring "handling". Oracle declared that it will not continue providing patches for *an aging version* (namely, SE 8) of software, unless those who really need that old version are going to pay for the work of supporting that dinosaur. (And if some business needs that

RE: Make clean fails for unpackedTarballs in subpath firebird

Hi Regina; This is the problem with cygwin 2.10, which I had to describe in our wiki: https://wiki.documentfoundation.org/Development/BuildingOnWindows#Install_Cygwin_Requirements: "Cygwin 2.10.0-1 have introduced a breaking change

Re: Assertion Failed!: MSVCP140D.dll , Expression: ploc->_Mbcurmax == 1 || ploc->_Mbcurmax == 2

On 5/6/2018 9:49 PM, himajin10 wrote: > I've updated my Visual Studio 2017 Preview to 15.7.0 Preview 6.0 and > then started to fail to make my own  LibreOffice build with the > following error. > ... I see quite a few changes in the 15.7.0 changelog [1] that might affect us; so - did you ma

Re: Subsequent Test PythonTest_dbaccess_python stuck in Infinite Loop

On 5/10/2018 4:33 PM, Luke Benes wrote: > > When you do a 'make check' under Windows, recent builds never finish. I have > narrowed this regression to commit c0965754df3309c39d316b76b2205af559bd28e3 tries to address that. -- Best regards, Mike Kaganski _

Re: Windows build failure - C2131: expression did not evaluate to a constant

On 04.12.2018 9:30, Noel Grandin wrote: > > >> I'm seeing the following build failure on Windows 32-bit release build: >> D:/core/vcl/source/bitmap/BitmapTools.cxx(1078): error C2131: >> expression did not evaluate to a constant >> D:/core/vcl/source/bitmap/BitmapTools.cxx(1097): error C2131: >

Re: Windows build failure - C2131: expression did not evaluate to a constant

On 04.12.2018 10:37, Stephan Bergmann wrote: > > Our recently-bumped MSVC baseline is Visual Studio 2017 version 15.7 > (the "version 15.7" suffix is important, there are many different > releases of Visual Studio 2017, with ever-increasing C++ standard > compliance).  That should be enforced b

Re: Windows build failure - C2131: expression did not evaluate to a constant

On 04.12.2018 14:17, Kaganski Mike wrote: > > I have just pulled, and I confirm this with 64-bit build, with VS > version 15.9.3. > I mean, I confirm that with my version of compiler, the problem is reproducible. ___ LibreOffice

Re: Trying to create editor using LibreOffice

Hi, On 04.12.2018 13:33, Rohit Garg Satpal Garg wrote: > Hi Team, > > I am trying to create editing application for my one of the research > projects but I am stuck on implementation of  getLinreOfficeKitHandler() > which is missing from the source files. It is not missing. See implementation

Re: Windows build failure - C2131: expression did not evaluate to a constant

On 04.12.2018 14:18, Kaganski Mike wrote: > On 04.12.2018 14:17, Kaganski Mike wrote: >> >> I have just pulled, and I confirm this with 64-bit build, with VS >> version 15.9.3. >> > > I mean, I confirm that with my version of compil

Re: Subsequent Unit Test CppunitTest_sc_ddelinkobj Failing Under Windows

On 12/13/2018 3:05 AM, Jens Carl wrote: > Hello Luke, > > On 12/8/18 7:09 AM, Luke Benes wrote: > >> Would you like any additional debugging info? > > I personally don't have access to any Windows machines and my knowledge > about Windows Devolvement (Virtual Studio) is very limited. So I > un

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

Hi Luke! On 12/16/2018 10:57 PM, Luke Benes wrote: > The fix for *Bug 121685* > , > https://cgit.freedesktop.org/libreoffice/core/commit/?id=7263d223ddf4 > ​ > Is causing the core Unit Test CppunitTest_chart2_xshape to fail when you >

Changing soffice.bin to be console application on Windows

Hi! Currently soffice.bin on Windows is built with subsystem set to GUI. This creates a number of problems, including impossibility to output --version/--help into a text using command like soffice --help > somefile (or do similar things piping the output to other commands in batch files); ab

Re: Changing soffice.bin to be console application on Windows

On 19.11.2018 18:48, Stephan Bergmann wrote: > On 19/11/2018 16:38, Kaganski Mike wrote: >> I have prepared a patch making soffice.bin a proper console Windows >> application: https://gerrit.libreoffice.org/63572. The patch also >> introduces a new launcher soffice.com (in

Re: Unable to build with poppler 0.71.0

On 19.11.2018 16:07, Andrey Cherepanov wrote: > If build with poppler 0.71.0 I get errors for missing type GBool: > > In file included from > /usr/src/RPM/BUILD/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx:20:0: > /usr/src/RPM/BUILD/libreoffice-6.0.7.3/sdext/source/pdfimp

Failing

After last pull, JunitTest_chart2_unoapi reliably fails for me on master on Win10 with this call stack: ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28) ucrtbased.dll!__acrt_report_runtim

Failing JunitTest_framework_complex

JunitTest_framework_complex fails reliably for me on current master with assertion assert( mpWindowContext.is() ); failing at OpenGLSalGraphicsImpl::doFlush(). I could debug it to WinOpenGLContext::ImplInit() having m_aGLWin.hDC == nullptr, thus ChoosePixelFormat fails. The call stack for th

Re: Failing JunitTest_framework_complex

On 21.11.2018 16:37, Jan-Marek Glogowski wrote: > Hi Mike > > Am 21.11.18 um 14:01 schrieb Kaganski Mike: >> JunitTest_framework_complex fails reliably for me on current master with >> assertion >> >>assert( mpWindowContext.is() ); > >

Re: remove followed by a push_back of same var (SwSpellDialogChildWindow)

On 24.11.2018 10:23, julien2412 wrote: > I noticed these lines: > 737 if(pCurrentTextObj) > 738 { > 739 m_pSpellState->m_aTextObjects.remove(pCurrentTextObj); > 740 > m_pSpellState->m_aTextObjects.push_back(pCurrentTextObj); > 741 } > See

Re: Help regarding Transliteration in LO writer

Hi! On 26.11.2018 13:39, Harshad Gorde wrote: > Hello everyone, > > I am interested in introducing transliteration facility (English to > Devnagari) to LibreOffice writer. But, after downloading the huge source > code I am unable to decide where to start. > > Kindly suggest me some initial ste

Re: Crash test update, now with backtraces

On 26.05.2019 17:14, Caolán McNamara wrote: > On Fri, 2019-05-24 at 10:31 +0200, Luboš Luňák wrote: >> Could you please name those .backtrace.txt? I can't view those files >> online, because they get treated as binary files and so Firefox only >> offers to download them. > > Yeah, I changed that

Using Amazon Corretto as Oracle JDK replacement for building LibreOffice on Windows

Hi, Since Oracle JDK versions prior to 12 are now unavailable from the official site [1] for unregistered users (and version 12 is said to still have problems/needs workarounds [2]), I decided to give Amazon Corretto [3] a try. I downloaded and installed the two MSIs listed on that page (amazo

CppunitTest_sc_macros_test hanging indefinitely with font scaling on Windows

Hi! On Windows 10 x64 (1903 build 18362.116), having "all items scaling" set to 150%, with current master (now at b170256fb6ebaf774b02b89835b19d9f3a1afb89) built for x64 in dbgutil config, running > make CppunitTest_sc_macros_test reliably hangs indefinitely. It never returns from Scheduler

Re: Reveal code, old macros convert them to LO

Hi! On 04.07.2019 20:08, Uwe Brauer wrote: > > > From time to time the question pops up whether LO could support > Wordperfects reveal code. Sometimes it is stated that this feature could > be implemented by a macro/extension. > > Now I remember that long time ago such macros existed and using

sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

Hi! I see sw_uiwriter hanging locally in testDateFormFieldCurrentDateInvalidation (added in commit d0ff1090762ac61ce08f54bc76685232699d98a0), never returning from Scheduler::ProcessEventsToIdle. Killing the test after some time produces multiple lines in console: > warn:vcl.schedule:5488:1382

Re: sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

On 14.07.2019 22:23, Jan-Marek Glogowski wrote: > > If you want to debug Windows AnyInput handling, feel free > to contact me on IRC (or even mail), if you have questions. I have tried putting some tracing breakpoints to WinSalInstance::AnyInput, and I can say that at least when the process is

Re: Request for review: Convert Fontwork to TextWarp on export

On 15.06.2019 10:04, Regina Henschel wrote: > My patch would implement the export from "Fontwork" to "TextWarp" > without character fill and outline. My question is, whether you agree, > that such step is useful? Even if character fill and outline will not be > implemented soon? I suppose that

Can mimalloc turn out to be useful for LibreOffice?

MS has released its mimalloc [1] under BSD license as a drop-in replacement for malloc. It is said to have excellent performance. It's also cross-platform. Can it be useful for LibreOffice (on supported platforms)? What is required to actually make LibreOffice use it, and how to test possible p

Re: [GSoC - QR Code] Week Report 5 (June 24 - June 30)

Hi! On 02.07.2019 11:40, shubham goyal wrote: > Status of project > - I will be left with calling QR Code feature in Word/impress/ and other > applications if requires. Not sure that making the feature for Word is within the scope of the project ;-) -- Best regards, Mike Kaganski ___

Re: Review for "improve import/export of line styles"

On 02.09.2019 9:20, Németh László wrote: >> And technical question: What do I need to do locally in Git, so >> that the >> information, that the no longer needed file >> "lo_preset_dashes.odt" has >> to be deleted, is included in my commit? > > > If you

Re: Crash test update

On 27.04.2019 18:33, Caolán McNamara wrote: > On Sat, 2019-04-27 at 00:33 +, Crashtest VM wrote: >> New crashtest update available at >> http://dev-builds.libreoffice.org/crashtest/0b56eb2c10ab4ca027f1a37e04519366b3cd7433/ > > > soffice.bin --headless --convert-to xlsx ooo83250-1.ods > semi-r

Re: libreoffice converstion of egistrymodifications.xcu user items to systemwide xml registry share

See also: https://wiki.documentfoundation.org/Deployment_and_Migration#Post_deployment_configuration https://ask.libreoffice.org/en/question/185522/how-do-i-turn-off-opengl-while-deploying-libreoffice/ https://ask.libreoffice.org/en/question/167622/how-to-disable-java-in-configuration-files/ https

CppunitTest_sc_macros_test fails after commit 7282014e362a1529a36c88eb308df8ed359c2cfa

Hi! After commit 7282014e362a1529a36c88eb308df8ed359c2cfa, now CppunitTest_sc_macros_test fails when testing sc/qa/extras/testdocuments/Window.xls: > C:/lo/src/core/sc/qa/extras/macros-test.cxx(338) : error : Assertion > Test name: ScMacrosTest::testVba > equality assertion failed > - Expected:

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

On 15.04.2019 10:33, Adrien Ollier wrote: > Hello everybody, > > working on bug #74702 >  led me to > read file core/vcl/source/outdev/nativecontrols.cxx. > > I think there is an issue here: > > > > If mpGraphics == nullptr and Acqui

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

On 15.04.2019 10:44, Adrien Ollier wrote: > OutputDevice::AcquireGraphics() is a pure virtual function, so we cannot > know in the general case what it does. > And what is written is not really equivalent to what you wrote because > if AcquireGraphics() is false, there is not a second check for

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

On 15.04.2019 10:44, Adrien Ollier wrote: > And what is written is not really equivalent to what you wrote because > if AcquireGraphics() is false, there is not a second check for mpGraphics Also note that when AcquireGraphics() is false (telling it could not acquire mpGraphics successfully), we

FastSerializerHelper::singleElement/startElement internal API changed

Hi! This is just to notify those who might currently use FastSerializerHelper in patches being prepared. Commit 1fe24bb1e2fbe44a4bf2c03297e259b3a18b1235 has modified the singleElement/startElement[NS] APIs by removing FSEND (which was a remnant of old C-style varargs implementation). So if you

Properly notify gpgme about spawn executable location on Windows

Hi Thorsten, *, When working on a 6-0-based branch on Windows, in make check, two python tests emit modal error dialogs about missing gpgme-w32spawn.exe: > --- > GpgME not installed correctly > --- > gpgme-w32spawn.exe was not found in the detected

Re: Properly notify gpgme about spawn executable location on Windows

Hi Thorsten, Thanks for your analysis! On 21.04.2019 0:22, Thorsten Behrens wrote: > Kaganski Mike wrote: >> However, I suppose that it's possible in theory that some user python >> script could ultimately need initializing gpgme. In that case, the >> problem would hi

Re: Properly notify gpgme about spawn executable location on Windows

On 21.04.2019 0:22, Thorsten Behrens wrote: >> 1. First of all - do I understand it correctly that the problem is real >> - so there are possible scenarios involving e.g. python (or another >> process which executable is not in LO's instdir/program), that might >> need gpgme? >> > See above - but e

Re: bug 74702

Hi Adrien, First of all, it's best to have a tentative change in gerrit, with your proposed changes, to have better overview. Please create if you haven't yet, and post the link here. Thanks! On 22.04.2019 11:58, Adrien Ollier wrote: > 2. In editeng/source/editeng/impedit2.cxx it is required t

Re: bug 74702

Hi Adrien, On 22.04.2019 12:43, Adrien Ollier wrote: > sorry I meant impedit3.cxx, lines 2805 and 2806. > > Ok I'll try to make some changes in gerrit. Nice, looking forward to see it mentioned here in the thread. Please note that answering someone's answer directly, without CCing the mailing

Fwd: Tinderbox failure, Android-ARM@24-Bytemark-Hosting, MASTER, last success: 2019-04-26 20:22:54

Hi! After my commit ac419786b324 "Don't use std::function in scope guard for performance reasons", errors are generated by Android-ARM, as in the forwarded message below. According to https://stackoverflow.com/questions/43514188/lambda-passed-to-template-not-defined, it's https://bugs.llvm.o

Re: is gerrit #26348 still somewhere?

Hi, On 29.04.2019 15:04, Eike Rathke wrote: > Maybe changes marked as abandoned get purged after a while? I don't know. ... but definitely, if a user deletes a draft patch, without publishing it, it is deleted irreversibly (or at least irreversibly for the user). -- Best regards, Mike Kaganski

C++ initialization talk wideo

Hi All, Stephan, Noel, possibly https://youtu.be/2jJumNzcp6Y would have something interesting for you regarding different initialization syntaxes in C++. Personally for me it was really unexpected that using "=default" in method definition is different for inline (inside class definition) and o

Re: Merging feature/commonsallayout branch

Hi Luke, 11/2/2016 3:54 AM, Luke Benes пишет: Us, as in the LibreOffice, the software many of us volunteer to make as good as possible for everyone to enjoy. Should the Chinese IT manager be embarrassed? Maybe, but coming from a First World nation, it’s hard for me to imaging supporting my fam

Re: About replacing some "C-Array" into std::array

On 22.11.2019 18:31, julien2412 wrote: > Taking a look at cppcheck report, I noticed this kind of reports: > vcl/source/treelist/transfer.cxx > 132 useStlAlgorithm 398 style Consider using std::fill algorithm > instead of > a raw loop > > To use std::fill, we'd need to convert the C array

Re: Accessing code for Calc functions

Hi Steve, On 26.11.2019 17:15, Steve Fanning wrote: > I am currently working as a member of the Documentation Team, updating > Chapter 18 of the Calc Guide (Description of Functions). From time to > time during this task, I would benefit from viewing the code that > implements individual functi

Re: Fwd: [comment] uitest for bug tdf#126685

On 20.11.2019 21:58, Crhonek Zdenek wrote: > Probably I found the reason - document is opened with macro warning and > test stuck here. I don't know why it worked on my computer and on gerrit > bots, but now I can reproduce it.  Unfortunately I cannot reproduce the > bug after copy of sheets to

Re: chart2.check fails in testAxisTitlePositionDOCX

On 11.12.2019 1:32, Luke Benes wrote: > I bisected this regression to > https://cgit.freedesktop.org/libreoffice/core/commit/?id=d10db7846602c16701dde019f12f61fd536e9ae4 > > tdf#128133 WIN don't exit after link-output filter I would assume this not to be a regression from that commit, but ra

Re: [libreoffice-design] Minutes from the UX/design meeting 2019-DEC-12

Dear Paul, 12 дек. 2019 г. 17:30 пользователь paul hofseth написал: Sirs, please do not waste scarce coding resources on thoroughly trivial matters like colours and signage, but rather on making the programs more practical to use - such as for instance having the choice of typeface as a sdepar

Re: Avoid "JRE required" msg upon extension installation

Hi Alexis, On 2019-12-25 3:23, Alexis de Lattre wrote: > I developed a LibreOffice Extension that contains a Python macro (and > the required Python libs): > > https://github.com/akretion/factur-x-libreoffice-extension  file > "factur-x_macro.oxt" (source code in "extension/" subdir) > > But,

Re: Failing UI tests on Winx64 build

Hi, On 2019-12-26 22:59, Stepas Toliautas wrote: > I happened to launch some "live" UI tests on my Windows 10 x64 machine > and noticed that some of them keep failing -- all with the same exit > status 3221225477 (0xC005, access violation) and, supposedly, right > at the end of testing, bec

Re: Benchmark results on mdds::multi_type_vector

Hi Kohei, On 2019-12-14 1:38, Kohei Yoshida wrote: > Alright, since now one person is raising objection on hastily > integrating this piece, I should hold on to integrating this piece for > now, and let the discussion continue. If I understand correctly, there was no objections on integrating t

Re: Failing UI tests on Winx64 build

Hi Stepas Toliautas, On 2019-12-30 0:32, Stepas Toliautas wrote: > > However, we're not out of the woods yet, since a single new error of > presumably the same type (access violation at shutdown) cropped up > in impress_demo uitest suite -- at /backgrounds.ImpressBackgrounds/, > i

Re: Print dialog window too big with 6.4.0~rc1

On 2019-12-31 16:32, Paul Menzel wrote: > LibreOffice 6.4.0.1 40(Build:1) seems to have redesigned the print > dialog. The window is too big now, causing the buttons in the bottom not > to be seen on a laptop with 1366x768 resolution and GNOME Shell, which > does not allow you to move the window

Duplicate .uno commands

Hi! In tdf#129549 [1], two .uno commands were identified as duplicating: .uno:BulletsAndNumberingDialog and .uno:OutlineBullet. First of them is Writer-specific [2]; second is not [3]. In Writer, both of them are routed to SwTextShell::ExecEnterNum, and handled identically (in the same switch

Re: Duplicate .uno commands

Hi Miklos, Thanks for your comments! On 2020-01-03 11:28, Miklos Vajna wrote: >> The problem with this, besides duplication itself (including e.g. >> drawing icons), is that both of them appear in customization dialog, and >> that's confusing. > > You can avoid duplicated icons via icon-themes/.

Re: Duplicate .uno commands

Hi Maxim, On 2020-01-05 2:38, Maxim Monastirsky wrote: > The separate .uno:BulletsAndNumberingDialog command predates the > handling of .uno:OutlineBullet in Writer. The latter was introduced > only in 2013 as part of the sidebar feature work (commit > d02f75a8c36705924ddd6a5921fe3012fafce812, "Re

Re: Duplicate .uno commands

On 2020-01-05 17:22, Kaganski Mike wrote: > On 2020-01-05 2:38, Maxim Monastirsky wrote: >> The separate .uno:BulletsAndNumberingDialog command predates the >> handling of .uno:OutlineBullet in Writer. The latter was introduced >> only in 2013 as part of the sidebar

Re: Permission not granted to push my patch

Hi, On 04.05.2019 12:45, Cyrille wrote: > I tried: > git push ssh://lafric...@gerrit.libreoffice.org:29418/dictionaries > HEAD:refs/for/master > > I got now this error: > remote: Resolving deltas: 100% (1/1) > remote: Processing changes: refs: 1, done > remote: ERROR: [b5f81e8] missing Change-Id

Re: Gsoc 2020

Hi! On 2020-01-26 20:18, Ilmari Lauhakangas wrote: > You could try > --with-jdk-home=/cygdrive/c/Program Files/Java/jdk-13.0.1 In cygwin, I usually use forward-slash paths, which are perfectly-valid cygwin paths, like --with-jdk-home=C:/Program Files/Java/jdk-13.0.1 -- Best regards, Mike Kaga

Re: o3tl::make_unsigned

On 2020-01-30 15:30, Stephan Bergmann wrote: > On 30/01/2020 12:56, Luboš Luňák wrote: >> On Thursday 30 of January 2020, Stephan Bergmann wrote: >>> On 29/01/2020 17:14, Luboš Luňák wrote:    Exactly my point. It's just that you seem to find it guaranteed that people won't mess up range

Re: o3tl::make_unsigned

On 2020-01-30 17:25, Luboš Luňák wrote: > On Thursday 30 of January 2020, Kaganski Mike wrote: >> Can the hypothetical make_signed function return a signed integer when >> there's a bigger integer type exist, > > Yes. > >> and a struct with overloaded >&g

Re: build error : 'f__faststorefence': is not a member of 'GrGLInterface::Functions'

On 2020-02-01 8:58, himajin10 wrote: > I'm getting the following error. how should I fix this error?(and why > doesn't Jenkis fail?) > > C:/build/workdir/UnpackedTarball/skia/src/gpu/gl/GrGLGpu.cpp(3771): > error C2039: 'f__faststorefence': is not a member of > 'GrGLInterface::Functions' >

RE: Debugging on Visual Studio (Windows)

On 19.07.2024 11:14, Miklos Vajna wrote: > On Thu, Jul 18, 2024 at 07:30:53PM -0700, Kira Tubo > wrote: >> 2. In Cygwin: make vs-ide-integration >> 3. In Visual Studio, open LibreOffice.sln >> 4. Add breakpoints to a .cxx file > > To be clear, this is for the IDE integration, debuggin

Difference in a test behavior on Windows and Linux

In commit b37b299d5228beeecb913980780f463756c5a878 [1] I have tested a hung sc_stylefamilyobj problem on Windows, that was caused by a bug in IndexedStyleSheets::FindPositionsByNameAndPredicate fixed later in commit 362082b57b2d6e9119acb3fb033aefcbce8cf8bb [2]. It was introduced in 2014 [3], an

Re: [GSoC] Subpixel glyph positioning - Looking for a mentor

On 04.04.2019 19:56, Alexander Farrow wrote: > Hi Jan-Marek, > > Thank you for your reply. > >     I have added some potential mentors, which are normally also > interested in font >     rendering. As much as I could potentially do some mentoring, as I > know a share >     of Sal

Re: Gitiles VCS browser

On 05.04.2019 19:55, Guilhem Moulin wrote: > Hi Miklos, > > On Fri, 05 Apr 2019 at 09:17:01 +0200, Miklos Vajna wrote: >> One more aspect: perhaps I'm just unlucky, but on average, I found >> cgit to load much faster than these git.libreoffice.org links. > > Hmm that's interesting. That's not so

Re: Gitiles VCS browser

Hi, On 06.04.2019 1:46, Luke Benes wrote: > No one in QA and no developers have voiced a preference for gitiles. > Because it's slower, it's UI and UX is harder to read, it lacks useful > tools like search,  and the URLs are a pain to work with. It's inferior > in every way. Personally I like

Re: Gitiles VCS browser

On 06.04.2019 17:18, Luke Benes wrote: > Mike, > That is not an apples to apples comparison. In your browser open and compare > side-by-side: > > https://git.libreoffice.org/core/+/6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a > and > https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a9cf9ba2d

Re: When file truncation happens by Basic's Open statement

Hi! On 21.12.2018 20:37, Takeshi Abe wrote: > In order to tell whether the behavior reported in tdf#119102 [1] is a bug > or not, I would like to understand the specification of LibO Basic's Open > statement [2]. > > The following table summarizes what current (master) LibO does, which I read > f

Re: Libre Office Local Installation

Hi Komal! Welcome! On 23.12.2018 10:43, Komal Bharadiya wrote: > Moreover, I have directly downloaded the libre office > repository from github. Then followed the steps given on official site > of libre office. Although possibly unrelated to the problem, this is clearly wrong. Where have you rea

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

Hi, On 16.12.2018 22:57, Luke Benes wrote: > Mike, > The fix for *Bug 121685* > , > https://cgit.freedesktop.org/libreoffice/core/commit/?id=7263d223ddf4 > ​ > Is causing the core Unit Test CppunitTest_chart2_xshape to fail when you >

Re: OpenGrok for core

On 26.12.2018 16:38, Justin Luth wrote: > kompi: upgraded on xmas night (as announced to status.tdf) but > the index & history namespace changed so I had to trigger a full reindex > (which is still ongoing for core) > 11:28 Possibly core has not indexed yet (as the one > largest opengrok proje

Re: Fwd: About Build dependencies Environment setup

Hi! On 06.01.2019 21:13, Mohit Kumar wrote: > Hi, > I am trying to build dependencies in linux by following the coomand : > sudo apt-get build-dep libreoffice but it showing some error.I am > attaching the screenshot, Please Help First of all, please always mention your OS information. Next, th

Re: libreoffice pdfimport w/ poppler-0.72.0: build failure

Hi Andreas! On 08.01.2019 3:12, Andreas Sturmlechner wrote: > In git master, libreoffice fails to build with: > > sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:558:70: error: ‘const > class GooString’ has no member named ‘getCString’ > > The relevant change in poppler 0.72 release notes:

Re: Problem in running make file on Ubuntu 16.04

On 08.01.2019 10:44, Komal Bharadiya wrote: > I have been trying to setup libreoffice dev-environment lately. After > executing ./autogen.sh file, I hit make command. The execution takes > ample amount of time. It hangs my laptop, and I end up switching it off. > I have tried multiple no. of tim

Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

On 14.01.2019 11:46, Stephan Bergmann wrote: > On 13/01/2019 23:57, Дилян Палаузов wrote: >> LO 6.0.7.3 fails compiling with gcc 8.2.1 20190101 I emitting: >> >> [build SPP] scp2/source/ooo/ure >> [build SCP] scp2/source/writer/file_writer >> [build SPP] scp2/source/xsltfilter/file_xsltfilter >> [b

Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

Hi! On 15.01.2019 1:40, Дилян Палаузов wrote: > Hello, > > the LO source code requires const GooString*, but the > /usr/local/include/poppler/OutputDev.h file had no const in the > declaration of drawString. The installed poppler was newer than 0.64.0. > > The hack is, that in the past I insta

  1   2   >