Thanks for the help!
I created a followup patch that makes the strings as resources:
https://bugs.freedesktop.org/attachment.cgi?id=62063
Review:
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=34772attachment=62063
Regards,
--Muhammad
___
I created a patch to update help content:
https://bugs.freedesktop.org/attachment.cgi?id=62112
Review:
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=34772attachment=62112
Regards,
--Muhammad
___
LibreOffice mailing list
On Sat, May 26, 2012 at 9:27 PM, Ivan Timofeev timofeev@gmail.com wrote:
On 26.05.2012 22:06, Ivan Timofeev wrote:
this patch makes scrolling in writer impossible :( it always brings the
view back to the cursor
Oops, wait. That happens only if a document contains the Page Count field
I have confirmed that the word counting logic somehow focuses on the
cursor, and I'll either fix that or follow a model similar to the word
count dialog where we update in response to editing actions only.
Unfortunately I'm currently on the road for a couple of days. I'll continue
working on it
Hello.
= Bugs =
https://bugs.freedesktop.org/show_bug.cgi?id=50386
https://bugs.freedesktop.org/show_bug.cgi?id=50540
= Patch =
https://bugs.freedesktop.org/attachment.cgi?id=62532
= Patch review =
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=50386attachment=62532
= Change =
This
On 06/06/2012 12:49 PM, Michael Meeks wrote:
Right ! :-) also, any chance of a screenshot of the updated count in
the status bar we can add to your nice entry (thanks for adding that)
here: https://wiki.documentfoundation.org/ReleaseNotes/3.6 Thanks !
Michael.
Done! :)
Regards,
--Muhammad
= Bug =
https://bugs.freedesktop.org/show_bug.cgi?id=50141
= Patch =
https://bugs.freedesktop.org/attachment.cgi?id=62850
= Patch Review =
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=50141attachment=62850
= Changes =
There was a typo in the character counting code of text nodes.
= Bug =
https://bugs.freedesktop.org/show_bug.cgi?id=46757
= Patch =
https://bugs.freedesktop.org/attachment.cgi?id=62967
= Patch Review =
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=46757attachment=62967
= Changes =
We were ignoring redlined (deleted) text when counting
On Fri, Jun 15, 2012 at 5:37 PM, Caolán McNamara caol...@redhat.com wrote:
Definitely was bogus count before fix, and correct count afterwards.
Pushed to master now. Sorry for delay. I should cook up a regression
test for this.
Thanks for pushing the patch. I can add the regression test
On Fri, Jun 15, 2012 at 10:54 PM, Caolán McNamara caol...@redhat.com wrote:
What we could do with is the addition of a regression test for my
fdo#50141 error where we lost the char count for the
bullet/numbering :-). SwDoc::SetNumRule might be useful in setting some
numbering directly on some
Hello.
= Bug =
https://bugs.freedesktop.org/show_bug.cgi?id=44602
= Patch =
https://bugs.freedesktop.org/attachment.cgi?id=63423
= Patch Review =
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=44602attachment=63423
= Changes =
Gerrit change: https://gerrit.libreoffice.org/236
Regards,
--Muhammad
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
list (see
https://www.google.com/search?q=Muhammad%20Haggagsitesearch=%25%28archive_url%29s%2F#hl=entbs=cdr:1%2Ccd_min%3A1%2F1%2F2010%2Ccd_max%3A6%2F25%2F2012sclient=psy-abq=Muhammad+Haggag+site%3Ahttp%3A%2F%2Flists.freedesktop.org%2Farchives%2Flibreoffice%2Foq=Muhammad+Haggag+site:http%3A%2F
Hello.
Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=31005
Patch:
=
https://bugs.freedesktop.org/attachment.cgi?id=60462
Patch review:
===
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=31005attachment=60462
Summary:
=
Extended the number of properties
On Tue, May 1, 2012 at 5:43 PM, Caolán McNamara caol...@redhat.com wrote:
icu's string compare is very very slow when you just want to check for
equality
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ccc47b3db3eae25cc11bb709416c0b61747ca89e
Is it OK to break Unicode equivalence
Oh - and one more thing :-) as we inch closer to the feature-freeze,
it'd be great to update the 3.6 features page:
http://wiki.documentfoundation.org/ReleaseNotes/3.6
For any substantial fixes / improvements.
I'll update the release notes once I get confirmation from
On Thu, May 3, 2012 at 11:24 AM, Michael Stahl mst...@redhat.com wrote:
sorry for taking so long, but i had hoped that somebody else would
perhaps be more familiar with table autoformats and review this rather
substantial patch :)
No problem. I'm improving my knowledge of AutoFormats and
Hello.
(Ux folks, please advise on the UX/Localization section below).
Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=34772
Patch:
=
https://bugs.freedesktop.org/attachment.cgi?id=61962
Patch review:
===
On Tue, May 22, 2012 at 6:13 PM, Regina Henschel
rb.hensc...@t-online.de wrote:
Hi Muhammad,
[...]
I don't know about standard 'large' documents for testing. You can use the
document 'part1' of the ODF specification, which has 864 pages.
of w:BiDi elements before switching to RTL.
Only switch if it's non-zero.
Regards,
--Muhammad
From ed209e3a36f74f7826616deb24e7000b6216af32 Mon Sep 17 00:00:00 2001
From: Muhammad Haggag mhag...@gmail.com
Date: Wed, 1 Feb 2012 20:56:12 +0200
Subject: [PATCH] dmapper: Switch paragraphs to RTL based
On Thu, Feb 2, 2012 at 2:01 PM, Noel Power nopo...@suse.com wrote:
very nice patch, looking at the spec I agree and this looks like a
credible fix for me so pushed to master. Look forward to more like this,
thanks
Thanks for the review! If you'd pardon my absolute noobiness, do I have
access
On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag mhag...@gmail.com wrote:
On Thu, Feb 2, 2012 at 2:01 PM, Noel Power nopo...@suse.com wrote:
very nice patch, looking at the spec I agree and this looks like a
credible fix for me so pushed to master. Look forward to more like this,
thanks
Hello, folks.
begin quote from bug, comment 4
I'm investigating, and it seems to me that the current behavior is by design.
Whether that design is sensible is up for debate.
The current behavior is that a document is added to the Recent Documents list
when it's closed
Forgot to add bug link: https://bugs.freedesktop.org/show_bug.cgi?id=37775
On Thu, Feb 2, 2012 at 11:04 PM, Muhammad Haggag mhag...@gmail.com wrote:
Hello, folks.
begin quote from bug, comment 4
I'm investigating, and it seems to me that the current behavior is by
design.
Whether
Hello,
Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=37775
Patch link:
https://bugs.freedesktop.org/attachment.cgi?id=56740
Patch Review:
https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=37775attachment=56740
Changes (copied from patch):
This patch changes LO behavior so that we
Hi,
My past and present patches for LibreOffice are contributed under LGPLv3+ /
MPL 1.1.
My future patches for LibreOffice are contributed under LGPv3+ / MPL 1.1
until further notice.
Regards,
--Muhammad
___
LibreOffice mailing list
Including Ivan and list again. Dropped them accidentally.
On Sun, Feb 12, 2012 at 2:12 PM, Muhammad Haggag mhag...@gmail.com wrote:
On Sun, Feb 12, 2012 at 12:16 PM, Cor Nouws oo...@nouenoff.nl wrote:
Ivan Timofeev wrote (12-02-12 09:21)
@ux-team:
Do we really need such a feature? I mean
On Sun, Feb 12, 2012 at 3:38 PM, Cor Nouws oo...@nouenoff.nl wrote:
Korrawit Pruegsanusak wrote (12-02-12 13:30)
IMHO the case which 'file open' would be useful is already described
in the bug comment 0 and 4: saving with a new name doesn't get old
name into the list.
Yes, if that is the
On Tue, Feb 14, 2012 at 6:31 PM, Michael Meeks michael.me...@suse.com wrote:
I've merged it to master, thanks so much for your work here; do you
have another easy hack or some cleanup in your sights next ? :-) usually
things start to occur to people after they've read around the code
to know how.
On Sat, Nov 24, 2012 at 2:16 PM, Muhammad Haggag (via Code Review)
ger...@gerrit.libreoffice.org wrote:
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1156
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/corerefs/changes/56
https://gerrit.libreoffice.org/#/c/1163/
For some reason, gerrit did not send a review email. This is the help
content for this fix: https://gerrit.libreoffice.org/1156
The fix was already submitted by Bosdonnat Cedric.
Thanks,
--Muhammad
___
On Wed, Nov 28, 2012 at 1:13 PM, Miklos Vajna vmik...@suse.cz wrote:
Also, I had to fix the helpcontent2 build after your patch, did you
at least build-test your patch? If not, please always do so (along with
runtime testing if possible) before submitting it to gerrit.
Sorry for the trouble.
the paragraph id limitation in mind for the
future. Thanks, and sorry again for the trouble :)
On Thu, Nov 29, 2012 at 6:08 PM, Miklos Vajna vmik...@suse.cz wrote:
Hi Muhammad,
On Thu, Nov 29, 2012 at 05:27:32PM +0200, Muhammad Haggag mhag...@gmail.com
wrote:
Sorry for the trouble. I build and test
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Including Ivan and list again. Dropped them accidentally.
On Sun, Feb 12, 2012 at 2:12 PM, Muhammad Haggag mhag...@gmail.com wrote:
On Sun, Feb 12, 2012 at 12:16 PM, Cor Nouws oo...@nouenoff.nl wrote:
Ivan Timofeev wrote (12-02-12 09:21)
@ux-team:
Do we really need such a feature? I mean
Hello.
(Ux folks, please advise on the UX/Localization section below).
Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=34772
Patch:
=
https://bugs.freedesktop.org/attachment.cgi?id=61962
Patch review:
===
On Tue, May 22, 2012 at 6:13 PM, Regina Henschel
rb.hensc...@t-online.de wrote:
Hi Muhammad,
[...]
I don't know about standard 'large' documents for testing. You can use the
document 'part1' of the ODF specification, which has 864 pages.
Hello,
Can you guys look at this change and advise whether it's OK from a UX
perspective? Thanks!
-- Forwarded message --
From: Muhammad Haggag (via Code Review) ger...@gerrit.libreoffice.org
Date: Sat, Nov 24, 2012 at 2:16 PM
Subject: [PATCH] fdo#48317 - Support jumping to next
, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03d583bef4225409f69934f16db1854564c2db5f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Muhammad Haggag mhag...@gmail.com
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Muhammad Haggag mhag...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Muhammad Haggag has abandoned this change.
Change subject: fdo#48317 Help content for Next/Previous change navigation
..
Patch Set 1: Abandoned
Ignore this. I can't logerrit to submit a proper change in helpcontent2
46 matches
Mail list logo
