Re: [PATCH (partial)] fdo#48549 System::Beep() removal

2012-07-20 Thread Philipp Riemer
2012/7/20 Mek Otar meko.o...@gmail.com: Hi, I've written a patch that remove all call to Sound:Beep. Thomas Arnhold suggest me to replace the Sound:Beep by some error reporting mechanism. My question is: What is, in your opinion, the best way to do this? Best regards Mek Otar Hi Mek,

Re: [PATCH (partial)] fdo#48549 System::Beep() removal

2012-07-23 Thread Philipp Riemer
Hey, 2012/7/23 Mathieu Vonlanthen mat_...@fastmail.fm: Hi, Here is my license statement: - All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. -- I send a new version of the patch taking into account the last commits. I didn't

Re: Proposal/Prototype support for fill in character in Calc Number Format Strings // final patch set

2012-08-01 Thread Philipp Riemer
2012/7/31 Noel Power nopo...@suse.com: On 31/07/12 16:59, Johann Messner wrote: Please get my final patch info set for my local libreoffice-3.5.3 file tree on https://linux.jku.at/messner/LibreOffice/ (- file: patchInfo-31-Jul-2012__for_libreoffice.3.5.3.txt ) I am sure your

Re: Proposal/Prototype support for fill in character in Calc Number Format Strings // final patch set

2012-08-01 Thread Philipp Riemer
2012/8/1 Noel Power nopo...@suse.com: On 01/08/12 09:01, Philipp Riemer wrote: Hi Noel, to my eyes the diffs are below the text description in the .txt file. Correct me if I am wrong but with all comment lines starting with # it should be a valid patch file even if the file extension

Re: [PATCH] translated German comments in starmath

2012-08-03 Thread Philipp Riemer
Hi Alex, 2012/8/3 Alexander Wilms alexander.wi...@zoho.com: Hi, this is my first patch, so I don't really what the procedure is. If it's alright, can I push it? Alex Thank you very much for your contribution! I will check your patch and push it as soon as I find some time (should

[Libreoffice-commits] .: starmath/source

2012-08-03 Thread Philipp Riemer
#39468) Change-Id: If3be0db9213c405525f01c92aa4dd039e3aa6aad Reviewed-by: Philipp Riemer ruderphil...@gmail.com diff --git a/starmath/source/accessibility.cxx b/starmath/source/accessibility.cxx index a7b39bc..b271773 100644 --- a/starmath/source/accessibility.cxx +++ b/starmath/source

Re: [PATCH] translated German comments in starmath

2012-08-03 Thread Philipp Riemer
Heyhey, 2012/8/3 Alexander Wilms alexander.wi...@zoho.com: Hi Philipp, I do have commit rights, but I don't feel comfortable yet pushing stuff myself :) So thanks for the link. Here's my license statement: http://nabble.documentfoundation.org/License-statement-td3979585.html Kind

[Libreoffice-commits] .: sw/source

2012-08-03 Thread Philipp Riemer
Translate German comments in sw/source/core/crsr/ Change-Id: Ib31c6c11162053a447112d76ed4580236fde92e8 Reviewed-by: Philipp Riemer ruderphil...@gmail.com diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx index 78544a8..1c38bcc 100644 --- a/sw/source/core/crsr

Re: [PATCH] translated German comments in starmath

2012-08-03 Thread Philipp Riemer
Hey, 2012/8/3 Alexander Wilms alexander.wi...@zoho.com: Ah thanks, I'm in the design team and got the commit rights for the new templates in 3.6, so I'm not entirely new to the project :) Ah, I see ;-) I hope this isn't too off-topic: When I want to continue working, is 'git reset --hard

Re: Change in core[master]: Translate German comments in sw/source/core/docnode/ndcopy.c...

2012-08-04 Thread Philipp Riemer
Hey Bertrand, 2012/8/4 Gerrit ger...@gerrit.libreoffice.org: From Bertrand Lorentz bertrand.lore...@gmail.com: Hello Philipp Riemer, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/365 to look at the new patch set (#3). Change subject: Translate

[Libreoffice-commits] .: sw/source

2012-08-05 Thread Philipp Riemer
: Translate German comments in sw/source/core/docnode/ndcopy.cxx Change-Id: I6de2586d54d3e0938e2e9701885a043c76f686ae Reviewed-by: Philipp Riemer ruderphil...@gmail.com diff --git a/sw/source/core/docnode/ndcopy.cxx b/sw/source/core/docnode/ndcopy.cxx index fb49030..c15e6fc 100644

Re: Change in core[master]: Translate German comments in sw/source/core/docnode/ndcopy.c...

2012-08-05 Thread Philipp Riemer
Hey Bertrand, 2012/8/4 Bertrand Lorentz bertrand.lore...@gmail.com: Hi, On Sat, Aug 4, 2012 at 4:07 PM, Philipp Riemer ruderphil...@gmail.com wrote: Good work! However, I couldn't find your name on https://wiki.documentfoundation.org/Development/Developers and also no license statement

[Libreoffice-commits] .: regexp/inc sd/inc sd/source

2012-08-05 Thread Philipp Riemer
: Sun Aug 5 13:32:31 2012 +0300 Convert documents to follow the doxygen standard (fdo#44502, fdo#39468) Change-Id: I58c73f74d53b5dc2eb462fb03664be65d4500170 Reviewed-by: Philipp Riemer ruderphil...@gmail.com diff --git a/regexp/inc/regexp/reclass.hxx b/regexp/inc/regexp/reclass.hxx

[PUSHED] Re: [PATCH] translated German comments in starmath

2012-08-06 Thread Philipp Riemer
Patch was pushed, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=72778119fde55218354ee100481bfad2a1cedf35. Sorry, forgot to send a mail/change the mail subject. Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PATCH] a few lines of German translation

2012-08-09 Thread Philipp Riemer
Hey Daniel, 2012/8/9 Daniel Herde dan...@dher.de: Please review the translation of the german comments in some of the source files in dbaccess/source. More will follow. Thanks, Daniel. Thank you very much! I will take care of you patch. However, before I'll integrate it, could you please

[Libreoffice-commits] .: 2 commits - dbaccess/source

2012-08-10 Thread Philipp Riemer
95ab516729ccf847f6e588a224677314afb77b29 Author: Philipp Riemer ruderphil...@gmail.com Date: Fri Aug 10 20:53:16 2012 +0200 fdo#39468: Translate German comments in dbaccess/ Follow-up patch of b803fa2579256979bac83f0b193f2c30d524d76b. Change-Id: I86bea8483cc9a9703cc725eaef641c2df5896af0 diff

[Libreoffice-commits] .: toolkit/inc toolkit/source unotools/inc unotools/source xmloff/source

2012-08-10 Thread Philipp Riemer
toolkit/inc/toolkit/awt/vclxgraphics.hxx |3 + toolkit/inc/toolkit/awt/vclxprinter.hxx |2 - toolkit/inc/toolkit/controls/stdtabcontroller.hxx |2 - toolkit/inc/toolkit/helper/property.hxx |4 +- toolkit/source/awt/vclxcontainer.cxx | 15

[PUSHED][PATCH] fdo#39468 translate German comments, removing redundant ones

2012-08-10 Thread Philipp Riemer
2012/8/9 Oliver Günther m...@oliverguenther.de: I've translated the following core folders: toolkit, unotools, xmloff Please review the respective patch for fdo#39468 that I've attached to this post. The following reported folders (from the find-german-comments script) only yield false

[Libreoffice-commits] .: toolkit/source

2012-08-10 Thread Philipp Riemer
toolkit/source/awt/vclxwindows.cxx |2 +- toolkit/source/controls/unocontrols.cxx |2 +- toolkit/source/helper/unowrapper.cxx|4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 1e0a822fa14eb4f8d3da80cf76dd5a43df472649 Author: Philipp Riemer

[Libreoffice-commits] .: dbaccess/source

2012-08-12 Thread Philipp Riemer
dbaccess/source/ui/inc/DExport.hxx | 22 ++--- dbaccess/source/ui/inc/FieldDescControl.hxx |7 +--- dbaccess/source/ui/inc/HtmlReader.hxx| 12 +++ dbaccess/source/ui/inc/JoinExchange.hxx |2 - dbaccess/source/ui/inc/JoinTableView.hxx

[PUSHED][PATCH] more german translations in dbaccess

2012-08-12 Thread Philipp Riemer
2012/8/10 Daniel Herde dan...@dher.de: Hi, here are some more translations of german comments. Have a nice friday evening, Daniel. Thank you very much! However, I had to clean up your patch before applying it since it contained trailing whitespaces. Please take care about this when preparing

same id twice in dbaccess/source/ui/inc/FieldDescControl.hxx ?

2012-08-12 Thread Philipp Riemer
Hello, When integrating a translation patch (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=401a454c2da7560d5ec41ef07ac116403956c55a) I realized that in dbaccess/source/ui/inc/FieldDescControl.hxx there is twice the same number assigned to two different constants. Should this be that

[Libreoffice-commits] .: dbaccess/source

2012-08-12 Thread Philipp Riemer
/inc/TableFieldDescription.hxx |8 - 10 files changed, 139 insertions(+), 133 deletions(-) New commits: commit 5c293bfa9023fcc4fbb104c49e9ef28d23b38594 Author: Philipp Riemer ruderphil...@gmail.com Date: Sun Aug 12 18:22:40 2012 +0200 convert comments into doxygen style + reformat some

[Libreoffice-commits] .: 5 commits - dbaccess/source

2012-08-12 Thread Philipp Riemer
insertions(+), 190 deletions(-) New commits: commit 6bf0ea22d6198def6b59f45a93960842a3198bf9 Author: Philipp Riemer ruderphil...@gmail.com Date: Sun Aug 12 18:55:05 2012 +0200 formatted a missed comment into doxygen style This is a follow-up patch

Re: same id twice in dbaccess/source/ui/inc/FieldDescControl.hxx ?

2012-08-12 Thread Philipp Riemer
opengrok shows FIELD_FIRST_VIRTUAL_COLUMN used only in dbaccess/source/ui/tabledesign/TEditControl.cxx, where two lines read ... if( nColId FIELD_FIRST_VIRTUAL_COLUMN ) My conclusion is that the definitions are reasonable. HTH, Terry. Ok. Sorry, I did not grok for it but asked

Re: [PATCH] fdo#39468 translate German comments in core/tools

2012-08-12 Thread Philipp Riemer
Hey Oliver, 2012/8/12 Oliver Günther m...@oliverguenther.de: Hi, I finished translation all german comments in the core/tools folder. Please find the patch attached. Sorry for messing up with the whitespace, I was simply missing the approriate Vim highlights and git warnings. I hope the

[Libreoffice-commits] .: sw/source

2012-08-14 Thread Philipp Riemer
sw/source/core/docnode/ndnotxt.cxx | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) New commits: commit a6c7410c1391b67f4550dadf105c8f4979c21dcd Author: Bertrand Lorentz bertrand.lore...@gmail.com Date: Mon Aug 13 19:01:29 2012 +0200 fdo#39468: Translated

[PUSHED][PATCH] fdo#39468 translate German comments in core/tools

2012-08-14 Thread Philipp Riemer
2012/8/12 Philipp Riemer ruderphil...@gmail.com: Hey Oliver, 2012/8/12 Oliver Günther m...@oliverguenther.de: Hi, I finished translation all german comments in the core/tools folder. Please find the patch attached. Sorry for messing up with the whitespace, I was simply missing

[PATCH] fdo#39468: translate German comments (= writer)

2012-05-28 Thread Philipp Riemer
After Michael Meeks' enthusiastic talks and a digital chat (sitting side by side is no reason to not type your messages ;-) with him at LinuxTag in Berlin, I got so excited about LibreOffice that I also wanted to help and participate in this project. I do not have much spare time but as I

Re: [PATCH] fdo#39468: translate German comments (= writer)

2012-05-28 Thread Philipp Riemer
| 23 +++--- sw/source/core/undo/unsect.cxx | 32 16 files changed, 324 insertions(+), 361 deletions(-) -- Philipp 2012/5/28 Philipp Riemer ruderphil...@gmail.com: As promised, find the first few files for review attached to this mail. Btw.: I realized a lot of duplicated code

Re: [PATCH] fdo#39468: translate German comments (= writer)

2012-05-28 Thread Philipp Riemer
Of course for all my contributions the following is true: All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Philipp 2012/5/28 Philipp Riemer ruderphil...@gmail.com: As promised, find the first few files for review attached to this mail

potentially dead code in sw/source/core/undo/undel.cxx?

2012-05-30 Thread Philipp Riemer
Hi, While translating comments and cleaning up the files in sw/source/core/undo, I realized a piece of code which indentation was wrong. I tried to re-indent it but it seems as if there are too many braces in the function call... Could anyone else please also check the body of the function

Re: potentially dead code in sw/source/core/undo/undel.cxx?

2012-05-30 Thread Philipp Riemer
Ah, I see. Thank you very much for your fast answer. 2012/5/30 Lubos Lunak l.lu...@suse.cz: On Wednesday 30 of May 2012, Philipp Riemer wrote: Hi, While translating comments and cleaning up the files in sw/source/core/undo, I realized a piece of code which indentation was wrong. I tried

Re: [PATCH] [PUSHED] fdo#39468: translate German comments (= writer)

2012-05-30 Thread Philipp Riemer
Thank you. I will try that tomorrow and than re-send the patch. Philipp 2012/5/30 Tor Lillqvist t...@iki.fi: Thanks. I pushed the first one, but the second one did not apply, severa patch hunks failed. Could you please check that? Probably your source code is out of sync and you need to do a

Re: New Wiki Bug Page

2012-06-01 Thread Philipp Riemer
I love the option to have it sortable by different criteria! But please make the Bugzilla-IDs (and the description text) links to the bugtracker to provide an easy option to jump there at interest. In addition, also the field topic which indicates if it e.g. UI related or for the webpage etc.

Re: OpenGrok Search Upon Link Click

2012-06-12 Thread Philipp Riemer
2012/6/12 Joel Madero jmadero@gmail.com: Hi All, Wondering if the behavior of opengrok is what is expected. My issue is that when I click on a variable name it takes me to the search page of opengrok and puts in the name as the description instead of as a full search. This rarely

[PATCH] fdo#39468: translate German comments (= sw/source/core/inc)

2012-06-13 Thread Philipp Riemer
Hi, again I found some time to translate and clean up files in the core folder structure of Writer. In patch 0002 I deleted some code. Since I am not so firm with the code base, I asked mmeeks before and got his ACK for doing so. Find the patches of my work attached to this mail. Cheers,

Re: First translation German English

2012-06-19 Thread Philipp Riemer
Hey, I made some minor changes to that patch (all credits still go to the original author - Florian) by fixing some typos and deleting also the ASCII art. In addition, I changed the commit message to Translate German comments in sc/inc/viewopti.hxx which in my eyes is more helpful than Translated

Re: Duplication of some includes due to last commit

2012-06-21 Thread Philipp Riemer
Hey, I checked every file that was touched by commit ec5fa0164b9bae5c5bc6654f581e493206584301 by hand and created a patch that deletes all duplicates I could find. Cheers, Philipp 2012/6/21 Christophe JAILLET christophe.jail...@wanadoo.fr: Le 21/06/2012 22:52, Michael Stahl a écrit : On

Is fdo#43460 done and can be closed? Or: status of EasyHacks in Bugzilla is important too

2012-06-22 Thread Philipp Riemer
Hi, I recently skimmed through the wiki's EasyHacks page and found 43460 - Replace rtl::OUString getLength()==0 with isEmpty() etc. with status NEW https://bugs.freedesktop.org/show_bug.cgi?id=43460. As far as I understand the comments, it is completed and can either be closed or needs new input:

Re: [PUSHED] First translation German English

2012-06-22 Thread Philipp Riemer
Oh, my bad, sorry. I did not apply the patch but just added some more minus characters to stuff that could also be deleted in the patch file before re-submitting it. 2012/6/22 Michael Meeks michael.me...@suse.com: Hi Florian, On Tue, 2012-06-19 at 21:29 +0200, Philipp Riemer wrote: I made

Re: German comments translation

2012-06-23 Thread Philipp Riemer
Hello Jesso, Thank you very much and welcome to the LibreOffice mailing list! While I appreciate your work, much of it looks as if it was the output of an online translation tool... Correct me if I am wrong! I spend some time tweaking your patch but gave up somewhere at line 120 or so...

Re: German comments translation

2012-06-23 Thread Philipp Riemer
if you just duplicate work of someone else, even if it has a great learning effect... (I am an Indian programmer, currently in Saudi Arabia, so that's the reason behind the email and the blog.) - Jesso Clarence On Sat, Jun 23, 2012 at 1:06 PM, Philipp Riemer ruderphil...@gmail.com wrote: I

Re: [PATCH] fdo#39468: translate German comments (= filter/inc/filter/msfilter/msdffimp.hxx) plus questions

2012-06-25 Thread Philipp Riemer
2012/6/25 Noel Grandin n...@peralex.com: On 2012-06-25 15:32, Michael Meeks wrote: On Sat, 2012-06-23 at 20:45 +0200, Philipp Riemer wrote: (2) In addition, I was wondering if it would be possible to shorten parameters (e.g. com::sun::star::uno::Reference com::sun::star::embed::XStorage

Can #32260 and 51135 be closed? -- both: Request for account

2012-06-25 Thread Philipp Riemer
Hi, (1) I just realized that https://bugs.freedesktop.org/show_bug.cgi?id=32260 from 2010-12-09 is still open/ in NEEDINFO state. Last comment from requesting user Andrew Dent is from end of 2010 and also on the mailing list I could not find any message of him after 2010-10-24 (see

Re: [PATCH] update cppunit to version 1-13

2012-06-28 Thread Philipp Riemer
Hey Markus, Michael, all, Two minor things from my side as a newbie to the LO project: (1) In lines 288-291 of the patch you also delete the comment showing from where you got the CPPUNIT file. Might be helpful to keep the URL... (2) In addition, I was wondering why the install folder is still

Re: [PATCH][PUSHED] update cppunit to version 1-13

2012-06-28 Thread Philipp Riemer
2012/6/28 Markus Mohrhard markus.mohrh...@googlemail.com: Hellp Philipp 2012/6/28 Philipp Riemer ruderphil...@gmail.com: Hey Markus, Michael, all, Two minor things from my side as a newbie to the LO project: (1) In lines 288-291 of the patch you also delete the comment showing from where

Re: [PATCH] cleanup java code and update to Java5, including generics (36)

2012-06-29 Thread Philipp Riemer
2012/6/29 Noel Grandin noelgran...@gmail.com: On 2012-06-29 14:30, Philipp Riemer wrote: Hey Noel, I would like to offer my help for that because I have some spare time over the weekend. If it's ok with you, can you send me (better off the list, I guess) some pointers to files/folders I can

Questions regarding code peculiarities

2012-06-30 Thread Philipp Riemer
Hi, today I cleaned up the code in the directory sw/source/core/attr/ and saw some things I am not sure about. Since I guess that it will not cost much time for an experienced LO dev to look at those curious facts, I post them here on the list: (1) Where should I put documentation? At the moment

[Libreoffice-commits] .: vcl/inc

2012-07-01 Thread Philipp Riemer
vcl/inc/helpwin.hxx |4 +- vcl/inc/ilstbox.hxx | 48 +- vcl/inc/outfont.hxx | 46 - vcl/inc/salwtype.hxx | 65 +++ vcl/inc/svdata.hxx | 40

Re: [PUSHED] [PATCH] translate german comments vcl/source

2012-07-01 Thread Philipp Riemer
2012/7/1 Luc Castermans luc.casterm...@gmail.com: herewith another patch with comment translations Thank you very much! Pushed to master after additional cleanup. Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

found nearly perfect tinderbox build - but still errors due to missing files

2012-07-02 Thread Philipp Riemer
Hi, today I discovered the tinderbox master status page http://tinderbox.libreoffice.org/MASTER/status.html and I like it! But I don't know how often these are checked by other people... While glancing over the different columns I found something strange (at least for me): (1) I realized that

[Libreoffice-commits] .: sw/source

2012-07-02 Thread Philipp Riemer
sw/source/core/bastyp/swrect.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 73243adcbe99f3ebd6eb77404168f4c3f91d74cd Author: Philipp Riemer ruderphil...@gmail.com Date: Mon Jul 2 17:24:10 2012 +0200 fix coding style of previously added tmp

[Libreoffice-commits] .: embedserv/Library_emser.mk

2012-07-02 Thread Philipp Riemer
embedserv/Library_emser.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8423a74a9131087ceaf939580c14ae6514bd3c15 Author: Philipp Riemer ruderphil...@gmail.com Date: Mon Jul 2 17:56:15 2012 +0200 fixed build break by adding missing parentheses

Re: rediscovered: missing writer documentation

2012-07-05 Thread Philipp Riemer
I am currently working on a simple DOT representation... Seams to be trickier than expected. What would be in your eyes the best kind of visualization? Classical UML class diagrams? -- Philipp 2012/7/5 Michael Meeks michael.me...@suse.com: On Wed, 2012-07-04 at 21:59 +0100, Caolán McNamara

Re: rediscovered: missing writer documentation

2012-07-05 Thread Philipp Riemer
2012/7/5 David Tardon dtar...@redhat.com: On Thu, Jul 05, 2012 at 10:36:59AM +0100, Michael Meeks wrote: On Wed, 2012-07-04 at 21:59 +0100, Caolán McNamara wrote: So, I found some old class diagrams for writer which I think I got from khz who I think got them from jp. They're drawn on some

Re: RFC: where to put sorted vector template/class?

2012-07-10 Thread Philipp Riemer
2012/7/10 Noel Grandin n...@peralex.com: On 2012-07-10 15:35, Caolán McNamara wrote: How does this look? It's the bare minimum I need in a sorted_vector class. namespace o3tl { /** Represents a sorted vector of values. @tpl Value @tpl Compare comparison method */ template class

Re: Upvote important questions on ask.libreoffice.org ([Bug 51894] https://www.libreoffice.org/get-help/ misses a ask.libreoffice.org link)

2012-07-10 Thread Philipp Riemer
2012/7/10 Bjoern Michaelsen bjoern.michael...@canonical.com: Hi QA guys and gals, https://bugs.freedesktop.org/show_bug.cgi?id=51894 --- Comment #4 from Jean Spiteri beimaginativeegr...@gmail.com 2012-07-10 21:54:35 CEST --- Can you help me, please? Give me the most important questions

Re: FDO 47164 (increase backing window recent doc hot spot) Advice

2012-07-11 Thread Philipp Riemer
2012/7/11 Joel Madero jmadero@gmail.com: Hi All, I've handled FDO 47164 but need input to see if we'll actually implement. Summary: User thinks that recent documents arrow hot spot is too small on our backing window Solution: I moved the horizontal bar to the left a bit and increased

Re: Feature comparison: LibreOffice - Microsoft Office in the Wiki

2012-07-15 Thread Philipp Riemer
Hi Gerry, 2012/7/15 Gerry T. gerry.trep...@googlemail.com: Dear Philipp, [...] Thank you for your work so far! Pretty impressive! Might also help the marketing guys a lot for their next big advertisement campain (LO4?). Coming from academia, most of the texts are too long for me to read ;-)

Re: Interoperability of LibreOffice and Microsoft Office 2013

2012-07-17 Thread Philipp Riemer
2012/7/17 bfo bfo.bugm...@spamgourmet.com: Hi. Microsoft Office Professional Plus 2013 Preview Evaluation is available for download as MSI installer at http://technet.microsoft.com/en-US/evalcenter/hh973391.aspx?wt.mc_id=TEC_114_1_5 (link at the bottom of the page). Windows 7, Windows 8,

Re: C++11 in LibreOffice

2012-07-17 Thread Philipp Riemer
2012/7/17 Kohei Yoshida kohei.yosh...@gmail.com: On 07/17/2012 05:11 AM, Lubos Lunak wrote: So, as long as we require to build LO with MSVC, we can revisit the question of hard-depending on C++11 in, uhm, let's be optimistic and say 3 years. IOW, we can probably get there faster by

Re: [PUSHED] change indentation

2012-08-14 Thread Philipp Riemer
2012/8/14 Michael Meeks michael.me...@suse.com: On Sun, 2012-08-12 at 16:58 +, Gerrit wrote: Philipp Riemer has uploaded a new change for review. Change subject: change indentation Found pushed, Michael. PS. do we really need to send this lot via gerrit

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-23 Thread Philipp Riemer
That's great news! Thank you very much for your work! Unfortunately, the report currently looks pretty red... But now we have evidence and a way to trace pieces that need more tests. Philipp 2012/8/23 John Smith lbalba...@gmail.com: Hi, I just finished a first full run of lcov. There was

Re: improving from address in gerrit emails to commits list?

2012-08-23 Thread Philipp Riemer
2012/8/23 Miklos Vajna vmik...@suse.cz: On Thu, Aug 23, 2012 at 09:52:53AM +0200, Noel Grandin n...@peralex.com wrote: Is it possible to munge the From: address in the gerrit emails that go to the commit list? I got kind of used to seeing who did the commit in the from column of my email

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread Philipp Riemer
2012/8/24 John Smith lbalba...@gmail.com: On Fri, Aug 24, 2012 at 5:28 PM, Stephan Bergmann sberg...@redhat.com wrote: In a sense, even during the tests, very much of our code is executed by accident rather than due to dedicated test code calling it: Especially the subsequentcheck stuff

Re: [PATCH] fdo#39468: Translated German comments in sc/source/core/inc

2012-08-27 Thread Philipp Riemer
2012/8/27 oger000 lodevl...@ogersoft.at: Hi Some translations of german comments. Its my first patch to LO so something may be missing? gerhard Hey Gerhard, I fixed your patch and applied the changes. However, the files that you translated are in a part of the code that was not rebased

[Libreoffice-commits] core.git: sw/source

2013-03-21 Thread Philipp Riemer
+--- 5 files changed, 14 insertions(+), 29 deletions(-) New commits: commit 75eec37886157e00bb5e176b1bc2aac958aac882 Author: Philipp Riemer ruderphil...@gmail.com Date: Thu Mar 21 09:44:20 2013 + reduce space needed by comments in sw/source/core Change-Id

[Libreoffice-commits] core.git: dbaccess/source

2013-04-07 Thread Philipp Riemer
dbaccess/source/ui/querydesign/QueryTableView.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 87f185d192668d233f6a8606b1c3d77469e17e04 Author: Philipp Riemer ruderphil...@gmail.com Date: Sun Apr 7 22:50:28 2013 +0200 fix typos See https

[Libreoffice-commits] core.git: sw/source

2013-04-08 Thread Philipp Riemer
sw/source/core/doc/doclay.cxx | 11 +-- sw/source/core/doc/visiturl.cxx |4 ++-- 2 files changed, 7 insertions(+), 8 deletions(-) New commits: commit 88156809f742d95a6a59b94a657567653ea96ca8 Author: Philipp Riemer ruderphil...@gmail.com Date: Sun Apr 7 21:35:43 2013 +0200

[Libreoffice-commits] core.git: sw/source

2013-04-08 Thread Philipp Riemer
| 46 sw/source/core/doc/sortopt.cxx |6 - sw/source/core/doc/tblafmt.cxx |2 - 14 files changed, 9 insertions(+), 179 deletions(-) New commits: commit adea2a859dcc2722fc9db8acb5bddb864f40e0c4 Author: Philipp Riemer ruderphil...@gmail.com Date

[Libreoffice-commits] core.git: sw/source

2013-04-08 Thread Philipp Riemer
/source/core/doc/docnum.cxx |2 +- sw/source/core/doc/docruby.cxx |2 -- sw/source/core/doc/fmtcol.cxx |7 ++- sw/source/core/doc/number.cxx |2 -- 10 files changed, 20 insertions(+), 43 deletions(-) New commits: commit af5526cf86aa384d4f978c1d26ff69fe4a990477 Author: Philipp

[Libreoffice-commits] core.git: sw/source

2013-04-08 Thread Philipp Riemer
sw/source/core/doc/doc.cxx |4 sw/source/core/doc/doccomp.cxx |2 -- sw/source/core/doc/docfld.cxx |6 -- 3 files changed, 12 deletions(-) New commits: commit 0a3fc0130166629209e98bea178905085098a8f2 Author: Philipp Riemer ruderphil...@gmail.com Date: Sun Apr 7 21:33

[Libreoffice-commits] core.git: sw/source

2013-05-05 Thread Philipp Riemer
sw/source/filter/ww8/ww8scan.cxx | 163 ++- 1 file changed, 78 insertions(+), 85 deletions(-) New commits: commit bcb662a210f5e0c0e760bab1ba7c3d4b5d002c6c Author: Philipp Riemer ruderphil...@gmail.com Date: Sun May 5 23:18:17 2013 +0200 follow up

Re: Killing the gerrit to dev-list spam ...

2013-05-07 Thread Philipp Riemer
Hey all, so in my eyes the consensus here is the following: (1) we want to get informed about new stuff to - either react/ review it as a regular developer or - to keep up with a topic as sparetime contributor (2) too many automaticly sent mails blur the view for important messages and

Where to find the sources for the tinderbox status?

2013-05-12 Thread Philipp Riemer
Hi, when looking at http://tinderbox.libreoffice.org/MASTER/status.html, I currently see the first Android-Tinderbox in a green status -- with 3 errors! However, when checking the output on the Brief Build Log, it appears that these are all false positives. The three lines that are highlighted as

Re: Excel Function Meta Bug?

2013-05-12 Thread Philipp Riemer
Hi, I am currently cleaning up my mailbox and found this mail that is close to a year old. 2012/7/17 Joel Madero jmadero@gmail.com Nice, the updates make it quite a bit more functional. I noticed that most of the really useful functions are already well on their way to being implemented.

Re: Where to find the sources for the tinderbox status?

2013-05-12 Thread Philipp Riemer
Hey Julien, Christian, 2013/5/12 Christian Lohmaier lohmaier+libreoff...@googlemail.com Hi Philipp, On Sun, May 12, 2013 at 7:38 PM, Philipp Riemer ruderphil...@gmail.com wrote: Hi, when looking at http://tinderbox.libreoffice.org/MASTER/status.html, I currently see the first Android

Re: Where to find the sources for the tinderbox status?

2013-05-14 Thread Philipp Riemer
://www.linuxtag.org/2013/! Will you be there? 2013/5/12 Christian Lohmaier lohmaier+libreoff...@googlemail.com Hi Philipp, *, On Sun, May 12, 2013 at 9:40 PM, Philipp Riemer ruderphil...@gmail.com wrote: Thanks for the link. Uh, Perl... regular expressions would be mor or less the same in other langauges

Re: [PATCH]Comment translation vcl/win/source/window/salobj.cxx

2013-02-27 Thread Philipp Riemer
Hi Christian, thanks for your submission! I uploaded your patch to Gerrit where it can be easily reviewed approved by other contributors. You can find it under the following URL: https://gerrit.libreoffice.org/2447. However, I could not integrate it into the codebase as long as you did not

Re: [PATCH] German comment translation - vcl#2

2013-02-27 Thread Philipp Riemer
Hi Christian, thanks for your submission! I uploaded your patch to Gerrit where it can be easily reviewed approved by other contributors. You can find it under the following URL: https://gerrit.libreoffice.org/2447. However, I could not integrate it into the codebase as long as you did not

[Libreoffice-commits] core.git: bin/find-german-comments

2014-01-02 Thread Philipp Riemer
bin/find-german-comments |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 05175da8b4c1331e74b9293e3dbce8426df6a7d0 Author: Philipp Riemer ruderphil...@gmail.com Date: Thu Jan 2 18:38:55 2014 +0100 fix error in bin/find-german-comments Change-Id

Re: [Bug 72598] [Easyhack] Remove SunStudio cruft from code base

2014-01-04 Thread Philipp Riemer
Hi, In commit 9eac4a5http://cgit.freedesktop.org/libreoffice/core/commit/?id=66397a4fd222757a8bd651c0c297615319eac4a5 Jelle changed the following: diff --git a/cppu/source/uno/data.cxx b/cppu/source/uno/data.cxx index f6f7b1e..b6b4a05 100644 ---

[Libreoffice-commits] core.git: cppu/source

2014-01-05 Thread Philipp Riemer
cppu/source/uno/data.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e4a98b2b7da8e8ae0de8d489d9f9d79993db5326 Author: Philipp Riemer ruderphil...@gmail.com Date: Sat Jan 4 11:59:44 2014 +0100 remove empty or This is an additional commit

Re: LibreOffice Android

2013-06-17 Thread Philipp Riemer
Hi, I found this mail on the mailing list. However, I am not deep enough in the topic to provide helpful answers. All I found w.r.t. LibreOffice on Android is the following wiki page: https://wiki.documentfoundation.org/Android Is there any more information / report of progress available? It

[Libreoffice-commits] core.git: include/svl

2013-11-21 Thread Philipp Riemer
include/svl/filerec.hxx | 569 +--- 1 file changed, 249 insertions(+), 320 deletions(-) New commits: commit 2a46a01902bccd1f025cce92ce6d32efbabf6825 Author: Philipp Riemer ruderphil...@gmail.com Date: Tue Sep 3 19:50:10 2013 +0200 fdo#39468

[Libreoffice-commits] core.git: sw/source

2013-08-09 Thread Philipp Riemer
sw/source/core/layout/trvlfrm.cxx | 271 -- 1 file changed, 90 insertions(+), 181 deletions(-) New commits: commit 2772d52e86820579b18ceaa4241320b466bad439 Author: Philipp Riemer ruderphil...@gmail.com Date: Fri Aug 9 20:59:47 2013 +0200 Cleanup sw

[Libreoffice-commits] core.git: sw/source

2013-08-09 Thread Philipp Riemer
/tblafmt.cxx |1 - 12 files changed, 3 insertions(+), 20 deletions(-) New commits: commit cbcec9930cd6f601b1d4ebfd7ee0351d7d0a097e Author: Philipp Riemer ruderphil...@gmail.com Date: Fri Aug 9 21:27:32 2013 +0200 cleanup blank lines in sw/source/core/doc Change-Id

[Libreoffice-commits] core.git: bin/find-german-comments

2013-08-09 Thread Philipp Riemer
bin/find-german-comments | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) New commits: commit 299e6381ef8895ac8d0c762b603ab50b9cfc4441 Author: Philipp Riemer ruderphil...@gmail.com Date: Fri Aug 9 23:02:16 2013 +0200 Add a new option to bin/find-german-comments

[Libreoffice-commits] core.git: sw/source

2013-08-10 Thread Philipp Riemer
sw/source/core/doc/notxtfrm.cxx | 15 --- 1 file changed, 15 deletions(-) New commits: commit a2b4ebdf3a3fb305de76080d9b4ffbbebd1a3118 Author: Philipp Riemer ruderphil...@gmail.com Date: Sat Aug 10 22:00:39 2013 +0200 delete dead code The pJobSetup is never used

Question regarding include/svl/filerec.hxx (potential for optimization)

2013-09-02 Thread Philipp Riemer
Hi all, I am currently trying to translate German comments in some files and now I am stuck with the following (as the comments above both are identical copies): In include/svl/filerec.hxx what is the (logical) difference between SfxMulti*M*ixRecordWriter and SfxMulti*F*ixRecordWriter? Maybe

[Libreoffice-commits] core.git: 2 commits - cui/source framework/source svx/source

2013-09-02 Thread Philipp Riemer
6bb2da3f696d724117a1f3ff5e23e5a7fb3ed314 Author: Philipp Riemer ruderphil...@gmail.com Date: Mon Sep 2 22:07:55 2013 +0200 fdo#62475 - remove visual noise Change-Id: Ic944fc45aded66939a2fc1622536eb3f2d80d764 diff --git a/cui/source/dialogs/cuifmsearch.cxx b/cui/source/dialogs

[Libreoffice-commits] core.git: include/svl

2013-09-04 Thread Philipp Riemer
include/svl/filerec.hxx |4 1 file changed, 4 deletions(-) New commits: commit 5fe4829b5dd35bf2026e531ba4e634cc616fb658 Author: Philipp Riemer ruderphil...@gmail.com Date: Tue Sep 3 19:51:29 2013 +0200 delete code that was commented out Change-Id

[Libreoffice-commits] core.git: cui/inc cui/source svl/source svx/source

2013-09-04 Thread Philipp Riemer
cui/inc/pch/precompiled_cui.hxx|1 - cui/source/dialogs/cuifmsearch.cxx |1 - svl/source/items/style.cxx |1 - svx/source/form/fmsrccfg.cxx |1 - 4 files changed, 4 deletions(-) New commits: commit 387666fbd751561b53b5c7072e85551d22fced74 Author: Philipp Riemer

[Libreoffice-commits] core.git: include/svl

2013-09-04 Thread Philipp Riemer
include/svl/filerec.hxx | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) New commits: commit e1c732c1b45b07ad2fc414d85e725d6498c949a2 Author: Philipp Riemer ruderphil...@gmail.com Date: Tue Sep 3 19:50:46 2013 +0200 adjust code to layout Change

[Libreoffice-commits] core.git: sw/source

2013-09-07 Thread Philipp Riemer
|1 sw/source/core/docnode/swthreadmanager.cxx |1 19 files changed, 15 insertions(+), 143 deletions(-) New commits: commit a7c60c0e639b6cdd0c883794dbbf84596c11d77f Author: Philipp Riemer ruderphil...@gmail.com Date: Sun Aug 11 00:09:00 2013 +0200 remove/add

[Libreoffice-commits] core.git: sw/source

2013-09-07 Thread Philipp Riemer
|4 sw/source/core/docnode/retrieveinputstreamconsumer.cxx |4 sw/source/core/docnode/swthreadjoiner.cxx |4 11 files changed, 78 insertions(+), 133 deletions(-) New commits: commit 3a33d89c9728e8947f60bc6b574bf876875dc507 Author: Philipp Riemer ruderphil...@gmail.com Date

[Libreoffice-commits] core.git: sw/source

2013-09-07 Thread Philipp Riemer
(-) New commits: commit 9349f5cd7ffdf10d5be3644762d888c0fdd8ccb4 Author: Philipp Riemer ruderphil...@gmail.com Date: Mon Jul 9 04:14:47 2012 +0200 add/remove blank lines and braces (in sw/source/core/crsr/) Change-Id: I4dea8ea84d83c28eb258d0e8ddc2966476a50223 Reviewed-on: https

[Libreoffice-commits] core.git: sw/source

2013-09-30 Thread Philipp Riemer
/index/cnttab.cxx |5 + sw/source/ui/wrtsh/wrtsh1.cxx | 25 - 8 files changed, 2 insertions(+), 49 deletions(-) New commits: commit 2b8dc46ef3e6c34d86aa0803611e488b2254849b Author: Philipp Riemer ruderphil...@gmail.com Date: Sun Sep 29 19:06:02 2013

[Libreoffice-commits] core.git: sw/source

2013-10-01 Thread Philipp Riemer
sw/source/core/doc/docftn.cxx |4 sw/source/core/doc/doctxm.cxx |2 -- sw/source/core/doc/swserv.cxx |1 - 3 files changed, 7 deletions(-) New commits: commit 623f89b373114b2034319a573184fe727fb1b33d Author: Philipp Riemer ruderphil...@gmail.com Date: Thu Sep 26 13:05:22 2013

  1   2   3   >