[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM cleaning in base

2010-11-13 Thread Pierre-André Jacquod
hello, short presentation: have some C++ and java programming skills, but not used it intensively since 4-5 years... Need some refresh, hence I am starting with easy hacks... Will allow me to refresh knowledge and have a look at LibreOffice Hope I am in line with the patch policy. PS: I will

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM in base

2010-11-14 Thread Pierre-André Jacquod
hello, it seems base in now clear (this one had spaces,...) I will do a full grep regards pjacquod From 08cfa904d88460a8f90bb6c6ea87095c522e7123 Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Sun, 14 Nov 2010 17:23:18 +0100 Subject: [PATCH] RTL_CONSTASCII_USTRINGPARAM in

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM in components - customize

2010-11-14 Thread Pierre-André Jacquod
regards MPL/ GPLv3+ / LGPLv3+ pjacquod From c747bbc166d3637a37638b969908f6392cb793a0 Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Sun, 14 Nov 2010 19:55:57 +0100 Subject: [PATCH] RTL_CONSTASCII_USTRINGPARAM in components cleaning in components/cui/source/customize ---

[Libreoffice] remove some comments / dead code in calc

2010-11-14 Thread Pierre-André Jacquod
find it by chance... regards pjacquod MPL/ GPLv3+ / LGPLv3+ From 0ad93f729c3141c0f40125b04c79a2891c51bece Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Sun, 14 Nov 2010 20:36:43 +0100 Subject: [PATCH] bogus comment / code in calc.. testvba ---

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM cleaning in components - dialogs

2010-11-14 Thread Pierre-André Jacquod
regards MPL/ GPLv3+ / LGPLv3+ pjacquod From 6b4b3c28474ab96a8d938c3a5e0e1dc86415da22 Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Sun, 14 Nov 2010 21:27:39 +0100 Subject: [PATCH] RTL_CONSTASCII_USTRINGPARAM cleaing in components - dialogs

[Libreoffice] [PATCH 01/12] RTL_CONSTASCII_USTRINGPARAM in components/cui/...option

2010-11-16 Thread Pierre-André Jacquod
Hello, being off for some days, here the collection of patches I produced in between. Each patch concern the cleaning of directory, this will allow to review / descard some parts if needed. best regards pjacquod From c3b35d242fc9973d198571e19d37e7e12b746d97 Mon Sep 17 00:00:00 2001 From: pjacquod

[Libreoffice] [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-16 Thread Pierre-André Jacquod
On 11/16/2010 10:37 PM, Pierre-André Jacquod wrote: Hello, being off for some days, here the collection of patches I produced in between. Each patch concern the cleaning of directory, this will allow to review / descard some parts if needed. best regards pjacquod

[Libreoffice] [PATCH 03/12] RTL_CONSTASCII_USTRINGPARAM in components - forms

2010-11-16 Thread Pierre-André Jacquod
regards From f749c776fb979ee6700ce9477ae5b70b3b49d77c Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Mon, 15 Nov 2010 23:38:11 +0100 Subject: [PATCH 03/12] RTL_CONSTASCII_USTRINGPARAM in components - forms the whole directory components/forms/source/component should now

[Libreoffice] [PATCH 04/12] RTL_CONSTASCII_USTRINGPARAM in components - inc

2010-11-16 Thread Pierre-André Jacquod
regards From 35e91cd08c4ba6fb1078a347d8736670fe6faf13 Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Mon, 15 Nov 2010 23:44:15 +0100 Subject: [PATCH 04/12] RTL_CONSTASCII_USTRINGPARAM in components - inc components/forms/source/inc should be OK now ---

[Libreoffice] [PATCH 05/12] RTL_CONSTASCII_USTRINGPARAM in components .. submission

2010-11-16 Thread Pierre-André Jacquod
regards From ae0569887c2f327499ff060a12594f50035319ac Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Mon, 15 Nov 2010 23:52:56 +0100 Subject: [PATCH 05/12] RTL_CONSTASCII_USTRINGPARAM in components .. submission components/forms/source/xforms/submission should be OK now ---

[Libreoffice] [PATCH 06/12] RTL_CONSTASCII_USTRINGPARAM components xpathlib

2010-11-16 Thread Pierre-André Jacquod
regards From 2bf8ae72c9787a733cb2992d8c409593fb1f7bab Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Mon, 15 Nov 2010 23:57:03 +0100 Subject: [PATCH 06/12] RTL_CONSTASCII_USTRINGPARAM components xpathlib components/forms/source/xforms/xpathlib should now be OK ---

[Libreoffice] [PATCH 07/12] RTL_CONSTASCII_USTRINGPARAM components in runtime

2010-11-16 Thread Pierre-André Jacquod
regards From ab42a6a840da58f039398b7f64eaa68c4560b3cd Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Mon, 15 Nov 2010 23:59:34 +0100 Subject: [PATCH 07/12] RTL_CONSTASCII_USTRINGPARAM components in runtime components/forms/source/runtime should be OK now ---

[Libreoffice] [PATCH 08/12] RTL_CONSTASCII_USTRINGPARAM in components misc

2010-11-16 Thread Pierre-André Jacquod
regards From b82fc44186adb943a95eeaa369d49719ea47fd6c Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Tue, 16 Nov 2010 00:09:27 +0100 Subject: [PATCH 08/12] RTL_CONSTASCII_USTRINGPARAM in components misc components/forms/source/misc should be OK now ---

[Libreoffice] [PATCH 09/12] RTL_CONSTASCII_USTRINGPARAM in components - xstor

2010-11-16 Thread Pierre-André Jacquod
regards From 14c040c9a7e20c49c2edb9fdc9185a2fda93362f Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Tue, 16 Nov 2010 00:36:35 +0100 Subject: [PATCH 09/12] RTL_CONSTASCII_USTRINGPARAM in components - xstor components/package/source/xstor should be OK now ---

[Libreoffice] [PATCH 10/12] RTL_CONSTASCII_USTRINGPARAM components - zippackage

2010-11-16 Thread Pierre-André Jacquod
regards From 2f86aef63beb00992aa720ddf86c5236c6fecc26 Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Tue, 16 Nov 2010 00:40:44 +0100 Subject: [PATCH 10/12] RTL_CONSTASCII_USTRINGPARAM components - zippackage components/package/source/zippackage should be OK now ---

[Libreoffice] [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi

2010-11-16 Thread Pierre-André Jacquod
regards From 10ef6191861dab201993db7c01e5adf4d12fc415 Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Tue, 16 Nov 2010 00:43:12 +0100 Subject: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi components/package/source/zipapi should be OK now ---

[Libreoffice] [PATCH 12/12] RTL_CONSTASCII_USTRINGPARAM in components - xmlsecurity- helpd

2010-11-16 Thread Pierre-André Jacquod
regards From ed5503c8a32a6fa2d41b73e199e6184eb9e0b15b Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Tue, 16 Nov 2010 20:26:46 +0100 Subject: [PATCH 12/12] RTL_CONSTASCII_USTRINGPARAM in components - xmlsecurity- helpd remove rtl::oustring::createfromascii(foo) and code

Re: [Libreoffice] [PUSHED] Re: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi

2010-11-17 Thread Pierre-André Jacquod
On 11/17/2010 05:39 PM, Caolán McNamara wrote: On Tue, 2010-11-16 at 22:50 +0100, Pierre-André Jacquod wrote: regards heh, I had a bit of a moment when I saw file:///d:/777/Encrypted/picture in there before I realized this is someones debugging code with an if (0) around it. Anyway, that's

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-17 Thread Pierre-André Jacquod
Hello, Sharp eyes.. Just to keep you trainded..:-( No really sorry, Despite reviewing diff, I did not catch this one. Will take more care On 11/17/2010 05:18 PM, Caolán McNamara wrote: On Tue, 2010-11-16 at 22:39 +0100, Pierre-André Jacquod wrote: On 11/16/2010 10:37 PM, Pierre-André Jacquod

[Libreoffice] calc: some code deletion and comments translation

2010-11-21 Thread Pierre-André Jacquod
Hello, have done as well some small comment translations. regards From c29ea5e11ccc679166b5a0c5be2df925328465fb Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Sun, 21 Nov 2010 12:06:01 +0100 Subject: [PATCH] remove dead code in calc core data and some comments translation

[Libreoffice] further removing of dead code

2010-11-21 Thread Pierre-André Jacquod
Hello, here in components some other pieces to delete. Again some small parts in case I was to generous in deleting. regards From 1535d5e774e7d1ef08696344be8fcdfc6828f2c3 Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Sun, 21 Nov 2010 12:10:15 +0100 Subject: [PATCH 1/5]

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-21 Thread Pierre-André Jacquod
On 11/22/2010 07:16 AM, Joost Eekhoorn wrote: Hi, PROBLEM 1: I am trying to make again, but it fails on ./sc/source/ui/src/optdlg.src I did remove the unxlngx6.pro http://unxlngx6.pro in the sc, and did the build there locally and it gave: Making:ui.srs { ^ f4101:

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-22 Thread Pierre-André Jacquod
: On Mon, 2010-11-22 at 07:57 +0100, Pierre-André Jacquod wrote: hello, rm -rf * ./download Oh - that is going to waste a -lot- of time ;-) Just remove the build output, not the ( pristine ) git repos. 'make clean' should do that in the top-level. HTH

Re: [Libreoffice] [Pushed] further removing of dead code

2010-11-22 Thread Pierre-André Jacquod
Hi, thanks. Left it back, if someone would have needed to know something was there. regards On 11/22/2010 01:14 PM, Michael Meeks wrote: Hi Pierre, On Sun, 2010-11-21 at 15:28 +0100, Pierre-André Jacquod wrote: here in components some other pieces to delete. Again some small parts in case

Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

2010-11-22 Thread Pierre-André Jacquod
Hi, - Unused parameters in some methods are triggering compilation warnings. Should I fix them by removing the parameter name ? Sounds reasonable. Really though - the binfilter is not the best place to focus cleanups (though I appreciate it is fugly old code ;-) Most people

Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

2010-11-23 Thread Pierre-André Jacquod
On 11/23/2010 09:23 AM, Joachim Trémouroux wrote: Hi Michael, I will work on this. I see two possible ways: Ok Michael, then I will continue within binfilter... ::-)) But a additional question: From Norbert Thiebaud: To be consistent, I rather see them commented out i.e foo(int bar)

[Libreoffice] warnig and coding, need a little help on C++

2010-11-25 Thread Pierre-André Jacquod
Hello, as I said, still in warm up phase and getting back familiar with C++.. So cleaning is a good exercise. I got a compiler warning: filters/binfilter/bf_sw/source/core/para/sw_paratr.cxx:214:26: warning: 'nTemp' may be used uninitialized in this function for this: case MID_DROPCAP_LINES :

[Libreoffice] [PATCH 1/9] suppress warning in binfilters sc_token

2010-11-25 Thread Pierre-André Jacquod
Hello, here some patches in binfilter to remove warnings by compiling... Since some changes could (will) look strange, I submit it in little chunks, often with compiler warning in comment. This may help the reviewer. Hope I did no mistake regards Pierre-André From

[Libreoffice] [PATCH 4/9] binfilter sc_interpr4.cxx further warnings removal

2010-11-25 Thread Pierre-André Jacquod
regards From f6202b304ca7f0ffdd16cbd2886872465273852a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Tue, 23 Nov 2010 21:58:53 +0100 Subject: [PATCH 4/9] binfilter sc_interpr4.cxx further warnings removal ---

[Libreoffice] [PATCH 5/9] waring removal in binfilter core/para

2010-11-25 Thread Pierre-André Jacquod
regards From 01e9e819f9dd8f1726ddff7672f27cfcbd44760c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Thu, 25 Nov 2010 20:09:15 +0100 Subject: [PATCH 5/9] waring removal in binfilter core/para --- binfilter/bf_sw/source/core/para/sw_paratr.cxx

[Libreoffice] [PATCH 6/9] waring cleaning in sw_sw3redln.cxx

2010-11-25 Thread Pierre-André Jacquod
regards From 84e58630f70dc34f71ee34419d9843980b14b723 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Thu, 25 Nov 2010 20:18:10 +0100 Subject: [PATCH 6/9] waring cleaning in sw_sw3redln.cxx shadowing warning and unused parameters ---

[Libreoffice] [PATCH 7/9] warnings removal in binfilter sw_sw3redln.cxx

2010-11-25 Thread Pierre-André Jacquod
regards From 13a33d71df128454159d0e911f55179cddac2d72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Thu, 25 Nov 2010 20:52:47 +0100 Subject: [PATCH 7/9] warnings removal in binfilter sw_sw3redln.cxx all code deletion due to compiler warning

[Libreoffice] [PATCH 9/9] binfilter sw3io warning fixes

2010-11-25 Thread Pierre-André Jacquod
regards From d8ca0db19fdc508ebc0bf0ee42107fdea2f498b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Thu, 25 Nov 2010 21:10:27 +0100 Subject: [PATCH 9/9] binfilter sw3io warning fixes use of not initialized variables ---

Re: [Libreoffice] [PATCH 3/9] warnings in binfilters sc_interpr4.cxx

2010-11-25 Thread Pierre-André Jacquod
Quick question wouldn't it be better to have the comments in English instead of German? Sorry, !! I translate then when I can, but I did not the job to the end for this one. Not_appropriate_handling_for_me++ regards ___ LibreOffice mailing list

Re: [Libreoffice] warnig and coding, need a little help on C++

2010-11-25 Thread Pierre-André Jacquod
Thanks for helping. Heh, this also confuses cppcheck as well. cough... cough... ! I am not smarter than a machine... ! A professor I had told: this not a good point being too smart... I understand what he meant. For stepping in, not the easiest way. Once there is no waring any more when

Re: [Libreoffice] [PUSHED] Re: [PATCH 9/9] binfilter sw3io warning fixes

2010-11-26 Thread Pierre-André Jacquod
Hi, First thanks for reviewing, catching my errors and correcting. I have learned a lot. Next time I do so many errors, please reject and I will correct it myself. Michael, I will wait making less errors in changes before requesting an account, if you don't mind. Just a question for: Err, you

[Libreoffice] [PATCH 2/7] waring within binfilter - sw3io

2010-11-28 Thread Pierre-André Jacquod
regards From 0735f42a61482b094d054266ea83781ee122c91e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Fri, 26 Nov 2010 21:04:20 +0100 Subject: [PATCH 2/7] waring within binfilter - sw3io delete some compiler warning, some of them due to

[Libreoffice] [PATCH 3/7] binfilter sw3io - further shadowing warnings

2010-11-28 Thread Pierre-André Jacquod
regards From 2b6f503e9a8fc091dcfc216dc12175e646a76a68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Fri, 26 Nov 2010 22:44:38 +0100 Subject: [PATCH 3/7] binfilter sw3io - further shadowing warnings ---

[Libreoffice] [PATCH 4/7] binfilter - sw_sw3style.cxx (shadowing) warnings removal

2010-11-28 Thread Pierre-André Jacquod
regards From 0b31675885126537da8351ba747cd6c6e7ad03fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 27 Nov 2010 00:06:37 +0100 Subject: [PATCH 4/7] binfilter - sw_sw3style.cxx (shadowing) warnings removal ---

[Libreoffice] [PATCH 3/5] trivial warning fixes within binfilter bf_sw doc

2010-11-29 Thread Pierre-André Jacquod
regards From 94ae830669bfc1df7b4235c45d0a6a72def30be2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sun, 28 Nov 2010 21:09:30 +0100 Subject: [PATCH 3/5] trivial warning fixes within binfilter bf_sw doc ---

[Libreoffice] [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2)

2010-11-29 Thread Pierre-André Jacquod
regards From 09642903881c193ff01f2801461dcddeae0931ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Mon, 29 Nov 2010 22:13:22 +0100 Subject: [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2) ---

[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)

2010-11-29 Thread Pierre-André Jacquod
regards From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Mon, 29 Nov 2010 08:20:37 +0100 Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1) ---

[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)

2010-11-30 Thread Pierre-André Jacquod
regards From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Mon, 29 Nov 2010 08:20:37 +0100 Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1) ---

Re: [Libreoffice] Script to find undocumented classes

2010-12-01 Thread Pierre-André Jacquod
Beware - I am a newcomer - maybe my point of view is quite wrong due to lack of understanding. But then at least I will understand something better :- ) My first remark: stepping in seems to me to be very difficult despite the very friendly behaviour of people here. un-documented code-base is

[Libreoffice] [PATCH] making binfilter compiling again

2010-12-03 Thread Pierre-André Jacquod
Thanks to review and push it quite quickly if possible. Changes have been done (for RTL_OUSTRING_...) without looking that the namespace rtl is not declared. I did not introduced it but just corrected the entries, since I am not enough familiar to know which is the prefered situation within the

[Libreoffice] binfilter and features...

2010-12-04 Thread Pierre-André Jacquod
Hi, currently trying to reduce the number of warning coming from binfilter, I found quite a lot functions like: func(var x) {} or func(var x) { ASSERT (lksd) }. sometimes func (var x) {return false} Would someone mind if I track down the call of such functions, remove the calls and at the end

[Libreoffice] crossing strange code: a little help

2010-12-04 Thread Pierre-André Jacquod
Hi within filters/binfilter/bf_sw/source/core/txtnode/sw_thints.cxx line 955, I crossed this code construct: if() { . while (TRUE) { DBG_BF_ASSERT(0, STRIP); } } With and without debugging option on, if the if is entered, then this is an endless loop? Does it

Re: [Libreoffice] binfilter and features...

2010-12-05 Thread Pierre-André Jacquod
On 12/05/2010 12:39 PM, Caolán McNamara wrote: All true. It was just a note that it might be easier, if you have an interest in binfilter, to just take the conservative approach and silence warnings with e.g converting I was thinking of taking a 2 steps approach: first silent warning in a

[Libreoffice] [PATCH 01/16] warning variable unused fix in binfilter bf_sw attr

2010-12-05 Thread Pierre-André Jacquod
Hi, here some patches to suppress warnings within binfilter. I took a - sometimes too - conservative approach for doing this. Hope I did not harm this module regards From 3c2cd665fe8a344626265f6c8a2a3b195556441d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=

[Libreoffice] [PATCH 02/16] warning fix unused variable in binfilter bf_sw bastyp

2010-12-05 Thread Pierre-André Jacquod
regards From a03ec223cf70c17a1cd6bbf397dc954c8d9d13fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 10:25:53 +0100 Subject: [PATCH 02/16] warning fix unused variable in binfilter bf_sw bastyp ---

[Libreoffice] [PATCH 03/16] fix warning unused var in binfilter bf_sw crsr

2010-12-05 Thread Pierre-André Jacquod
regards From fe0b41fe4378e18478263caf8d09af1f3adafa28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 11:12:21 +0100 Subject: [PATCH 03/16] fix warning unused var in binfilter bf_sw crsr this is fixing warning, not optimizing.

[Libreoffice] [PATCH 04/16] warning fix for unused var in binfilter bf_sw doc

2010-12-05 Thread Pierre-André Jacquod
regards From 76026a3ef610c3b348f2fa514591e452eff3cd8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 14:56:23 +0100 Subject: [PATCH 04/16] warning fix for unused var in binfilter bf_sw doc This is warning removing, not code

[Libreoffice] [PATCH 05/16] warning fix unused var in binfilter bf_sw docnode

2010-12-05 Thread Pierre-André Jacquod
regards From dafaabb2c38990bf4141c6074e15f0ca35d7e160 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 15:19:44 +0100 Subject: [PATCH 05/16] warning fix unused var in binfilter bf_sw docnode only warning removal, not code

[Libreoffice] [PATCH 06/16] warning fix unused var in binfilter bf_sw draw

2010-12-05 Thread Pierre-André Jacquod
regards From eac219396edebdf58deba912b02edac9a7999554 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 15:30:11 +0100 Subject: [PATCH 06/16] warning fix unused var in binfilter bf_sw draw ---

[Libreoffice] [PATCH 07/16] fix warning unused var in binfilter bf_sw fields

2010-12-05 Thread Pierre-André Jacquod
regards From 0049d6aa3dd25887c742b51a764776103e67daf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 15:44:52 +0100 Subject: [PATCH 07/16] fix warning unused var in binfilter bf_sw fields still only fixes, no optimization has

[Libreoffice] [PATCH 09/16] fix warning unused var in binfilter bf_sw ole

2010-12-05 Thread Pierre-André Jacquod
regards From 5a619e9399713a488eeadc484617e630ed9d06ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 20:02:57 +0100 Subject: [PATCH 09/16] fix warning unused var in binfilter bf_sw ole ---

[Libreoffice] [PATCH 10/16] fix warning unused var in binfilter bf_sw sw3io

2010-12-05 Thread Pierre-André Jacquod
regards From 18b052aa37f4adb95f3250de4967b739bd14be11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 20:07:52 +0100 Subject: [PATCH 10/16] fix warning unused var in binfilter bf_sw sw3io ---

[Libreoffice] [PATCH 11/16] fix warning unused var in binfilter bf_sw swg

2010-12-05 Thread Pierre-André Jacquod
regards From c8861cfc5de23428356c1a5cf6aaed6d2a0eced3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 20:13:44 +0100 Subject: [PATCH 11/16] fix warning unused var in binfilter bf_sw swg ---

[Libreoffice] [PATCH 12/16] fix warning unused var binfilter bf_sw text

2010-12-05 Thread Pierre-André Jacquod
regards From 22f6a25fcbba5eb41b73436f36a9542b2f898ef4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 20:38:53 +0100 Subject: [PATCH 12/16] fix warning unused var binfilter bf_sw text ---

[Libreoffice] [PATCH 15/16] fix warning unused var in binfilter - bf_sw unocore

2010-12-05 Thread Pierre-André Jacquod
regards From 151194c8a68754f9521bd485a9124f6e08f36239 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 21:58:35 +0100 Subject: [PATCH 15/16] fix warning unused var in binfilter - bf_sw unocore trying to stay on the safe side,

[Libreoffice] [PATCH 16/16] removing code due to endless loop

2010-12-05 Thread Pierre-André Jacquod
regards From 6551d69a5fbc85f3af92cada84bf543a083d4453 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 22:05:10 +0100 Subject: [PATCH 16/16] removing code due to endless loop these part of code have been removed. The While(true)

Re: [Libreoffice] binfilter and features...

2010-12-08 Thread Pierre-André Jacquod
Hi, There is alright, a phonecon typically once a week or so. maybe we can put this topic on the agenda would be great and you could dial in if its at a suitable time. doing this during free time, I may really depend if the possibility arise or not. But basically, we could think of a kind

[Libreoffice] fighting with debug macros...

2010-12-08 Thread Pierre-André Jacquod
Hello, still trying to learn a bit the code. Compiling without DEBUG on gives some new warnings:- ) This lead me to look at some code construct. Here is in pseudo-code a typical construct I am crossing: var y = ; var x = ; code if ( y MAXVALUE) { ASSERT(x, out of range); // only use

[Libreoffice] some hints needed for fdo 42286 in calc

2011-11-01 Thread Pierre-André Jacquod
hello, I am trying to debug fdo 42286 in calc. It has to do with autofilter, where some empty lines (rows) are shown despite the filter criteria that is set. (and a strange filter behaviour). As entry point, I found sc/.. tools/queryparam.cxx dbdata.cxx but it seems that there all is Ok.

Re: [Libreoffice] some hints needed for fdo 42286 in calc

2011-11-01 Thread Pierre-André Jacquod
hello, and query information. The query is executed in ScDBDocFunc::Query and related functions. thanks I will look there come back if needed P.S. Do you know if this is a regression against 3.3? Then it might be No 3.3 available to test (and a bit short of place on HD). But happens on

Re: [Libreoffice] [PATCH] fdo 42286 in calc solved ?

2011-11-15 Thread Pierre-André Jacquod
Hello, Thanks for your hints. It took some times, but know I have clearly identified the problem , but I do not if my solution is right or could create more problems. In short, the problem is that GetAreadData is called each time the filter determines its values, instead of using the

[Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

2011-11-24 Thread Pierre-André Jacquod
hello, here attached an new patch (hopefully wiser) to solve the mentioned bug. This ensure that the call to ExtendDataArea does as commented in the code sc/source/core/tool/dbdata.cxx : // Extend the DB area to include data rows immediately below. and does not shrink the original area... So

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

2011-11-27 Thread Pierre-André Jacquod
Hi, BUT this is a workaround, to compensate the not so correct behaviour of GetDataArea :-( The behaviour in bINcludeOld = false seems me strange (ergh I think wrong but you told me to be cautious), since it removes from the side of the area that has not yet been extended above the last

Re: [Libreoffice] final and override

2011-11-28 Thread Pierre-André Jacquod
Hello, However, given that override and final will only make it into GCC 4.7 (according to http://wiki.apache.org/stdcxx/C++0xCompilerSupport), it according to gcc.gnu.org too.. but since it seems that MSCV (according the same wiki) supports it / will support it, why not just wait a bit and

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

2011-11-29 Thread Pierre-André Jacquod
Hi Eike Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to not include newly appended columns of an area. half true: the condition is exactly that the newly appended column data touch by an angle the already defined area (like C3 to B2) and that all other cells below the

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

2011-11-29 Thread Pierre-André Jacquod
Hello, sorry, I was sure there was more about it...but too early this morning, I could not sort out all points. Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to not include newly appended columns of an area. Why? by the way, this reflect the comment in void

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

2011-12-04 Thread Pierre-André Jacquod
Hello, To give you a background, this extend range downward functionality was Thanks for your explanation. Following the remark of Eicke, I ended up with 3 possible patches :-/ which all have small differences in behaviour. I have a favorite, but do not want to choose alone. Please push the

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

2011-12-18 Thread Pierre-André Jacquod
Hi Eicke, The second one: 0001-fdo42286-extend-down-but-also-shrink-if-cells-are-em.patch For consistency it makes sense to also shrink the area, as re-initializing the filter area with only one cell or one row selected . erroneously included. Please go ahead with this one. OK

Re: [Libreoffice] bug 36874 (label printing) further improvement?

2012-01-03 Thread Pierre-André Jacquod
Hello, Just to mix in the middle: from this and a previous mail from you: It would be much better if the label-definitions contain all dimensions, i.e. yes My calculation is based on the assumption (presumption?) that the page containing the labels is symmetrical, i.e. rotating the page

[Libreoffice] making binfilter aka StarOffice FileFormat read-only

2010-12-27 Thread Pierre-André Jacquod
Hello, these days, I have tried (and not really with full success) to understand how binfilter works... My goal: since it is an old legacy format, make StarOffice formats read-only, and clean binfilter component of all code used for writing files. Reason: with read-only, you will still be able

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-03 Thread Pierre-André Jacquod
Hi, Does setting #define MDDS_HASH_CONTAINER_STLPORT 1 before #include mdds/mixed_type_matrix.hpp help? I also saw someone having a similar issue in the same exact spot, which I haven't been able to reproduce. Maybe this is related. I had also a problem after having upgraded to mds

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

2011-01-14 Thread Pierre-André Jacquod
Hi, On 01/14/2011 07:33 PM, Regina Henschel wrote: Hi all, there is something wrong actually. Removing *Export*-filter is reasonable, but now in LibO RC3 I cannot *read* my SO5 files. Kind regards Regina Up to now, nothing has been committed. On trunk master, all is OK, I just tested it.

[Libreoffice] error compiling in libs-gui/canevas

2011-01-17 Thread Pierre-André Jacquod
hello, there is an error compiling canevas: the reason: in vcl/inc/vcl/sysdata.hxx there has been a change at line 125: -void* pRenderFormat; // render format for drawable +void* pXRenderFormat; // render format for drawable This produce the error (see below) in canevas compilation.

[Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-01-23 Thread Pierre-André Jacquod
Hello, from now I have started to delete within binfilter the code allowing to *save* using the StarOffice file format. The import (read) is still possible and will remain. Bye bye saving sdw, sxw This will of course not happens in one go... With this push, I have done the following

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-01-24 Thread Pierre-André Jacquod
Hello, On 01/24/2011 03:43 PM, Caolán McNamara wrote: You also needed to adjust the smoketest make check because that has a save as staroffice binary file format test in it. I noticed this failed this morning and bodged it up to work again. Oops, sorry, I was not aware of it. Could you just

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-01-24 Thread Pierre-André Jacquod
Hello, Wonderful :-) do you want help with this ? we could add an easy hack, and ask people to contact you, for impress / calc etc. Thanks for this point. I will think if this is easily feasible. But I am still myself on the (intensive) learning part, so I currently do not feel me yet

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-02-16 Thread Pierre-André Jacquod
Hello, after quite a long time, I have done a push again concerning this topic. Sorry, I was very busy at work and had barely the time to go ahead. Here is the following work in cleaning within binfilter/bf_sw the code allowing to write in StarWriter format. Without touching dependencies outside

Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config

2011-02-24 Thread Pierre-André Jacquod
On 02/24/2011 08:33 PM, Kohei Yoshida wrote: On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts of emails, but if its for a single module i would attach them all in

Re: [Libreoffice] Nonsense comments?

2011-02-25 Thread Pierre-André Jacquod
On 02/25/2011 09:46 PM, Caolán McNamara wrote: po files can have translator-comments in them to help translators about ambiguous terms/words, while the .src/.sdf format doesn't though, translation with gettext would support this with comment using key-words / tags. Key words are configurable,

Re: [Libreoffice] [PUSHED][PATCH]Cleanup comments

2011-02-28 Thread Pierre-André Jacquod
Hello, pushed, thanks, Maybe not forgetting the [patch] tag in subject will help not to miss your submission. best regards On 02/27/2011 04:51 PM, Arnaud Versini wrote: Hi, This patch remove some useless comments in msfilter. Thanks -- Arnaud Versini

Re: [Libreoffice] Remove using namespace ::rtl

2011-03-05 Thread Pierre-André Jacquod
Hello, Even if binfilters is going to be extracted from LO, doesn't it worth I am doing, this, leting it be only an import filter. to purge using namespace ::rtl from it (I think about the people I think that when cross-module cleaning is done, this is worth to do it also within binfilter: to

Re: [Libreoffice] Remove using namespace ::rtl

2011-03-06 Thread Pierre-André Jacquod
Hello, Finally since I'm not sure for the moment about what must be done on using namespace com::sun::star::uno, I did the work on binfilters. Thanks regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] [PUSHED] Easy Hacks: Translation of Comments from German to English

2011-03-06 Thread Pierre-André Jacquod
Hello, thanks, just changed a typo best regards Pierre-André On 03/06/2011 04:10 PM, Daniel Di Marco wrote: Hi, I translated some more comments. The patch is attached. Cheers, Daniel ___ LibreOffice mailing list

Re: [Libreoffice] [PUSHED] [PATCH] Remove commented out code

2011-03-08 Thread Pierre-André Jacquod
Hello, all seems to me OK, then I pushed. Thanks regards Pierre-André On 03/08/2011 12:19 PM, Bálint Dózsa wrote: Hi, I have removed some commented out code form// //xmloff/. My code is under the LGPLv3+/MPL dual license. Regards, Balint Dozsa

bug 49610 in impress: suspicious commit found, but help needed

2012-06-21 Thread Pierre-André Jacquod
hello, this bug is a bad regression. Following with debugger, I had as suspect the function void Outliner::ProvideNextTextObject (void) line 979 in sd/source/ui/view/Outliner.cxx (or something called late from this) as main suspect. After bibisect from QA the commit

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-06-21 Thread Pierre-André Jacquod
Hello, well as free time contributor with commit access to current repository, I followed this gerrit story. So not kind of surprise, but yeah, until THIS mail and posts, was me very unclear what it would mean. To say it, first I had a lot of doubt. Reading mails, entry in the wiki, looking

Re: [Libreoffice] What is bibisect? And what is it doing in my office?

2012-06-21 Thread Pierre-André Jacquod
Hi, just to say thanks for bibisect Impressive example with fdo49610 to find the problematic commit. Regards Pierre-André On 12/09/2011 02:59 PM, Bjoern Michaelsen wrote: Hi all, So I hope with this, we make regression finding some more fun and allow us -- QA and developers together -- to

Re: bug 49610 in impress: suspicious commit found, but help needed

2012-06-21 Thread Pierre-André Jacquod
that fit to my knowledge there. Or have you time to investigate it and fix it ? Sorry, this sounds not very constructive, but in this period I do not have a lot of free time, so I can not offer more. Tack regards Pierre-André On 06/20/2012 11:10 PM, Thorsten Behrens wrote: Pierre-André Jacquod

Re: Cppunit-1.13.0 released

2012-07-07 Thread Pierre-André Jacquod
hello, updated :-) http://en.wikipedia.org/wiki/CppUnit regards On 07/07/2012 04:19 AM, Markus Mohrhard wrote: Hey, after we have no longer any build issues with cppunit I have now officially tagged the 1.13.0 release of cppunit. I would like to thank everybody who helped during this release.

Re: Cppunit-1.13.0 released

2012-07-07 Thread Pierre-André Jacquod
hello, git clone git://anongit.freedesktop.org/git/libreoffice/cppunit/ or http://cgit.freedesktop.org/libreoffice/cppunit/ regards On 07/07/2012 09:40 AM, Andreas Radke wrote: Am Sat, 7 Jul 2012 04:19:39 +0200 schrieb Markus Mohrhard markus.mohrh...@googlemail.com: Hey, after we have no

[PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-04-30 Thread Pierre-André Jacquod
Hello, back again after a while. On 02/15/2012 11:30 AM, Thorsten Behrens wrote: Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you like, would be cool to chase down why in the first place the ppt import creates polygons with empty sub-paths, that looks like a worthwhile

some license statement

2012-05-05 Thread Pierre-André Jacquod
Hello, just to confirm that all of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Best regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-05-18 Thread Pierre-André Jacquod
Hello, On 05/03/2012 11:30 AM, Thorsten Behrens wrote: So what I suggest is a more defensive fix (or some larger review across the code is in order): make GetLineArrow() return the B2DPolyPolygon right away, and have *that one* be empty (i.e. not a Since I do not intend to become a specialist

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-20 Thread Pierre-André Jacquod
hello, On 05/16/2012 04:07 PM, Lubos Lunak wrote: If somebody does a developer build, there are not many good reasons why -O2 should be used - it takes noticably more time and it makes debugging miserable. I can't think of anything else than final builds and profiling as a good

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-21 Thread Pierre-André Jacquod
Hello, On 05/20/2012 11:24 PM, Norbert Thiebaud wrote: On Wed, May 16, 2012 at 11:30 PM, Pierre-André Jacquod pjacq...@alumni.ethz.ch wrote: expecting to get symbols without optimization, not wanting all asserts outputs. If you are intending to debug why wouldn't you want the misnamed

  1   2   >