[Libreoffice] [PATCH] [FDO#31252] Overwrite dialog improvement

2011-02-11 Thread Sébastien Le Ray
Hello list, Here is a patch for fdo#31252[1] which improves the overwrite dialog as described in the bug. I don't know if the second part of the bug about backuping overwritten file is relevant, awaiting your advices on this. Sebastien [1] https://bugs.freedesktop.org/show_bug.cgi?id=31252

Re: [Libreoffice] [PATCH] [FDO#31252] Overwrite dialog improvement

2011-02-11 Thread Sébastien Le Ray
Le Fri, 11 Feb 2011 19:58:42 +0100, Jan Holesovsky ke...@suse.cz a écrit : Hi Sebastien, On 2011-02-11 at 09:31 +0100, Sébastien Le Ray wrote: Here is a patch for fdo#31252[1] which improves the overwrite dialog as described in the bug. Beautiful, thank you! :-) Pushed. I don't

[Libreoffice] [PATCH] O(U)StringBuffer::toString()

2011-02-12 Thread Sébastien Le Ray
Hi list, Since the toString() method is mentioned in the O*StringBuffer documentation I thought it was a good idea to actually have it... Patch is splitted in two parts. First adds the toString() methods and second perform some cleanup in OUStringBuffer unit tests (see commit message for

Re: [Libreoffice] [PUSHED] Re: [PATCH] O(U)StringBuffer::toString()

2011-02-14 Thread Sébastien Le Ray
Le Mon, 14 Feb 2011 21:21:52 +, Caolán McNamara caol...@redhat.com a écrit : As an aside, if you're big into the sal unit tests there's probably quite a few of them potentially useful which haven't been tweaked to work again, or are behind SUBSEQUENT_TESTS but probably don't need to be

[Libreoffice] [EasyHacks] Protocol capitalization

2011-02-21 Thread Sébastien Le Ray
Hi list, Here are two patch regarding the Easy Hack Improve Autocorrect capitalize first word in sentence (on the wiki). First one improves french autocorrection for non breaking space before : when you enter a protocol. I didn't remove the code handling the :// case since INETUrlObject does not

[Libreoffice] [PATCH] Remove include of no more existent errhdl.hxx

2011-02-22 Thread Sébastien Le Ray
Hi list, This patch removes an include which prevent debug build of sw (the file has been deleted in commit 6aa93c291d18c7db6dbee73adc6c4aa1bdc88eda. Regards Sébastien diff --git a/sw/source/core/except/dbgloop.cxx b/sw/source/core/except/dbgloop.cxx index ddb3a7b..370be63 100644 ---

[Libreoffice] [PATCH][WIP] fdo#31251 - Improve default page layout

2011-02-27 Thread Sébastien Le Ray
Hi list, Attached is a patch that improves Writer page as described in fdo#31251[1]. After a quick poll on various LibreOffice user it appears that a halo on the four borders is confusing so we have a smooth shadow on two borders. There are still some little glitches and book mode is not fully

Re: [Libreoffice] OString += OString + char ... ?

2011-02-28 Thread Sébastien Le Ray
Le Mon, 28 Feb 2011 21:45:36 +, Caolán McNamara caol...@redhat.com a écrit : On Sun, 2011-02-27 at 04:27 -0500, Kevin Hunter wrote: Three possibilities I guess, 1) remove the explicit, but I'm sure its there due to some other horribly implicit conversion horror 2) add a

[Libreoffice] [PATCH] fdo#31251 - Improve default page layout

2011-03-01 Thread Sébastien Le Ray
Hi list, Here is a complete patch for fdo#31251. It adds a smooth shadow to the page. During its development, I found that SwRect::_Intersection (used in page margin painting) returns negative height/width if the two rectangles do not overlap. I don't know if it is the expected behavior or a

Re: [Libreoffice] [PUSHED] fdo#31251 - Improve default page layout

2011-03-03 Thread Sébastien Le Ray
Le Thu, 03 Mar 2011 21:35:11 +0100, Christoph Noack christ...@dogmatux.com a écrit : Hi Sébastien, hi all! Hi Am Donnerstag, den 03.03.2011, 14:16 +0100 schrieb Sébastien Le Ray: Le Thu, 03 Mar 2011 11:59:19 +, Michael Meeks michael.me...@novell.com a écrit : [...] Although I

Re: [Libreoffice] [PUSHED] fdo#31251 - Improve default page layout

2011-03-08 Thread Sébastien Le Ray
Le Thu, 03 Mar 2011 11:59:19 +, Michael Meeks michael.me...@novell.com a écrit : Hi Sebastien, On Tue, 2011-03-01 at 23:42 +0100, Sébastien Le Ray wrote: Here is a complete patch for fdo#31251. It adds a smooth shadow to the page. Wow - it is really pretty indeed :-) I just

Re: [Libreoffice] [PATCH] fdo#31251 - Improve default page layout

2011-04-16 Thread Sébastien Le Ray
Le Sat, 16 Apr 2011 13:31:58 +, Thomas Arnhold tho...@arnhold.org a écrit : Hi, I like your patches for the new smooth shadow. I looked around the other LibO apps like Impress or Draw. They have this shadow already, but it's not as width as in Writer and it's on all sides. Maybe we

Re: [Libreoffice] [PATCH] fdo#31251 - Improve default page layout

2011-04-16 Thread Sébastien Le Ray
Le Sat, 16 Apr 2011 14:58:46 +0200, Christoph Noack christ...@dogmatux.com a écrit : Hi Sébastien, Thomas, all! Am Samstag, den 16.04.2011, 14:41 +0200 schrieb Sébastien Le Ray: Le Sat, 16 Apr 2011 13:31:58 +, Thomas Arnhold tho...@arnhold.org a écrit : I like your patches

Re: [Libreoffice] [PATCH] fdo#31251 - Improve default page layout

2011-04-18 Thread Sébastien Le Ray
Le Sat, 16 Apr 2011 15:08:23 +0200, Christoph Noack christ...@dogmatux.com a écrit : Hi Sébastien! Thanks for the ultra-fast reply :-) Am Samstag, den 16.04.2011, 15:01 +0200 schrieb Sébastien Le Ray: Le Sat, 16 Apr 2011 14:58:46 +0200, [...] @ Sébastien: Would it be possible

Re: [Libreoffice] [PATCH] fdo#31251 - Improve default page layout

2011-04-19 Thread Sébastien Le Ray
Le Mon, 18 Apr 2011 23:53:56 +0200, Christoph Noack christ...@dogmatux.com a écrit : Hi Sébastien, all! Am Montag, den 18.04.2011, 22:47 +0200 schrieb Sébastien Le Ray: Le Sat, 16 Apr 2011 15:08:23 +0200, Christoph Noack christ...@dogmatux.com a écrit : [...] Am Samstag, den

Re: [Libreoffice] [PATCH] fdo#31251 Writer Impress shadow consistency

2011-05-04 Thread Sébastien Le Ray
Le Tue, 3 May 2011 14:23:44 +0200, David Tardon dtar...@redhat.com a écrit : On Sat, Apr 30, 2011 at 06:58:29PM +0200, Sébastien Le Ray wrote: if(aShadowColor != SwViewOption::GetShadowColor() ) { aShadowColor = SwViewOption::GetShadowColor(); -AlphaMask aMask( SW_RES