Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h

...@novell.com wrote: On Mon, 2011-01-03 at 21:47 +0100, Soeren Moeller wrote: Hi I have removed dependencies on tools/solar.h in some files in sc (according to http://wiki.documentfoundation.org/Easy_Hacks#write_tools.2F_pieces_out ) please review and commit. Thanks, pushed! BTW, we generally

[Libreoffice] [PATCH] Removed dependencies on tools/solar.h in waitoff.h

Another small removal of dependencies on tools/solar.h, this time in sc/inc/waitoff.h Sören Möller (LGPLv3+ / MPL) From 64383ecc28b5c4aa09ecab31fb45be93ec4aa511 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B6ren=20M=C3=B6ller?= soerenmoeller2...@gmail.com Date: Tue, 4 Jan 2011 19:41:48 +0100

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h in drawpage.hxx/.cxx

Hi and thank you for your comments 2011/1/5 Kohei Yoshida kyosh...@novell.com: Hi Sören, Thanks for the patch.  Is there a reason why this one is not an attachment? :-) It is not an attachment as I used git send-email to send it to the mailing list, but the result seems a bit wierd when

[Libreoffice] [PATCH] Changed String to OUString in ScFuncDesc

Hi Please review and apply if appropriate this patch: I have replaced four public (deprecated) String variables of ScFuncDesc in sc/inc/funcdesc.hxx by OUString and changed all uses of these variables to use OUString instead. Most places by using relevant methods for OUString, and a few places

[Libreoffice] [PATCH] Changed String to OUString in funcdesc.hxx

And here another patch for sc/inc/funcdesc.hxx and related source files, changing even more occurrences of (deprecated) String to OUString. I also changed the uses of these variables/functions to use OUString instead (using casts when forced to use String originally because of ResId). Please

[Libreoffice] Splitting up source/header files for clarity

Hi I have been working with sc/inc/funcdesc.hxx, and this header defines four closely related classes, but all the implementation of these classes is in sc/source/core/data/global.cxx together with the implementation of a number of other classes. This makes it confusing to find the

Re: [Libreoffice] Splitting up source/header files for clarity

I have now splitted the implementation of funcdesc.hxx out into a new source file funcdesc.cxx. In the process I also have extracted two new header files for classes previously defined in global.cxx. I have corrected all includes and the result compiles for me, I have added the new source file to

[Libreoffice] [PATCH] Some comments and basic cleanup in sc

Hi Attached four patches: 0001: adding comments to ScFunctionMgr and ScFunctionList in sc/inc/funcdesc.hxx 0002: removing duplicate implementation of ScFunctionMgr::fillLastRecentlyUsedFunctions 0003: adding comments to ScFunctionCategory in sc/inc/funcdesc.hxx 0004: cleaning up comments and

[Libreoffice] [PATCH] [PUSHED, partial] Some comments and basic cleanup in sc

in LibO and put it on the wiki.) Best Regards Sören 2011/1/24 Kohei Yoshida kyosh...@novell.com: Hi Soeren, On Sun, 2011-01-23 at 21:01 +0100, Soeren Moeller wrote: Hi Attached four patches: 0001: adding comments to ScFunctionMgr and ScFunctionList in sc/inc/funcdesc.hxx -  e.g. functions

[Libreoffice] Crash in master: Sum button in sc

Hi I just noticed a bug in master (pull about 1h ago): When I in calc press the sum button (shaped like a sigma), then calc crashes instantly and without any message. This seems to happen only when calc doesn't guess a sum area by itself. (E.g. if there are numbers in the cells above the marked

Re: [Libreoffice] Crash in master: Sum button in sc

problems, I will try to look into this later on, but this patch shoul at least make this use safe. Regards Sören Möller (LGPLv3+ / MPL) 2011/1/26 Kohei Yoshida kyosh...@novell.com: Hi Soeren, On Tue, 2011-01-25 at 23:13 +0100, Soeren Moeller wrote: Hi I just noticed a bug in master (pull about

Re: [Libreoffice] Patches by two persons?

Thank you for your answers, for now we will alternate the author in the git patch files, but I will mostly send the mails to this mailing list. (And we now both have send a mail, confirming that all our patches are LGPLv3+/MPL) Best regards Sören 2011/1/28 Norbert Thiebaud nthieb...@gmail.com:

Re: [Libreoffice] [PATCH] Replaced tools/list with std::vector in funcdesc.hxx / funcdesc.cxx

use tools/list anymore, so we have removed the includes. The patch compiles fine here, and scalc seems to work as expected. Regards Sören Möller 2011/1/28 Soeren Moeller soerenmoeller2...@gmail.com: Hi In the attached patches (0001 is the real patch, 0002 contains three comments missing

[Libreoffice] How to use gprof on LibO?

Hi In our effort of replacing deprecated data types from tools/ by std:: types we would like to use gprof for profiling (to choose the right data types). But unfortunately, we don't know to set the -pg flag, and where the gmon.out file would go. Has anyone of you experiences with profiling LibO,

Re: [Libreoffice] [PATCH] Replaced tools/list with std::list in ScAddInListener

Hi Now we have replaced tools/list with std::list in ScAddInListener, here we used a list, as there is adding, removing, and searching on this list, and no clear way to sort the elements. The patch comes in three files: 0001 Replacing deprecated data types from solar.h 0002 Cleaning up the

Re: [Libreoffice] How to use gprof on LibO?

, is sorted, and then there is a lot of random access, so here a vector would be better. But to find out which of these two cases we are in, profiling could help. Regards Sören 2011/1/31 Michael Meeks michael.me...@novell.com: Hi Soeren, On Sat, 2011-01-29 at 15:50 +0100, Soeren Moeller wrote

Re: Change in core[master]: Replaced deprecated tools/String with OUString in ScMatrix

I'm using gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) on x86_64 GNU/Linux (Ubuntu 12.04 LTS), which runs in a virtual machine (that hopefully shouldn't make a difference). Hopefully it doesn't happen which the next patch. Sören 2012/7/5 Eike Rathke er...@redhat.com: Hi Sören, On