Re: [Libreoffice] small utility script to handle ../bin/g and similar commands

2010-10-09 Thread Tor Lillqvist
Just to clarify: I posted the script, as I thought it might be useful to someone else. But I did not intend to commit it to git (If I did, the post to the ML would have been in the form of a patch) Sure, no problem, my reply was actually more in the context of the recent changes back and

Re: [Libreoffice] coding style

2010-10-11 Thread Tor Lillqvist
No, there is no coding style yet, but we will start to work on one soon Well, much (most?) of the existing code, inherited from OpenOffice.org, clearly uses some amount of consistent style conventions, and when editing such files, one should, IMHO, follow the style of the surrounding code.

Re: [Libreoffice] Build LO at Windows

2010-10-12 Thread Tor Lillqvist
Sorry, could you be a bit more explicit and say exactly what command you are entering, in what directory, and what the error messages are? You should follow the OpenOffice.org Windows build instructions only as far as they can be used to guide what dependencies you need to get and install.

Re: [Libreoffice] The Windows installer

2010-10-14 Thread Tor Lillqvist
I see that it's an installer that includes all the languages but i wonder if it is really necessary and if the languages are the only cause. Well, there certainly isn't hundreds (or even tens) of megabytes of new code, as far as I know, so yes, it must be the languages. Even if the

Re: [Libreoffice] ucb/source/ucb compilation error

2010-10-21 Thread Tor Lillqvist
By the way, note that the OSL_THIS_FUNC currently is quite broken. (Unless somebody has fixed it recently in the LibreOffice repo.) See http://www.openoffice.org/issues/show_bug.cgi?id=114290 , fixing it is trivialish (an EasyHack?, yeah, I need to add it there). --tml

Re: [Libreoffice] [PATCH] Created installer::languages::shorten_language_string

2010-10-21 Thread Tor Lillqvist
Any speed you can squeeze out of the install set builder would definitely be appreciated. I agree fully. It is extremely exciting to see a new contributor attack the Perl code, welcome! One thing that would be very useful is if you could actually write down what you learn about the Perl code

Re: [Libreoffice] [Pushed] Building on windows 7-64bit with Visual Studio 2010 Express

2010-10-26 Thread Tor Lillqvist
Great to see some 64bit windows compiling going on :-) Umm, he is running on a 64-bit OS, but producing 32-bit code as usual... (I have also been running a 64-bit Windows for quite some time on my development machine.) That the OS is 64-bit doesn't really show up any way in the LibreOffice

Re: [Libreoffice] [Patch] Fix for installer::languages::shorten_language_string()

2010-10-27 Thread Tor Lillqvist
Please note that your earlier MD5::Digest patch was reverted, though, because it was causing problems, so this follow-up patch which presumably depends on that earlier one can not be applied. I didn't notice the problems myself as I hadn't got that far in the build before the patch was applied

Re: [Libreoffice] [Patch] Moved wrappers for all debuginfo calls into the function itself

2010-10-27 Thread Tor Lillqvist
This patch is public domain. Does it mean LGPLv3+ / MPL as it's the prefered licence for LibreOffice? It depends on the country of the author, there is no way to make one's work immediately enter the public domain (and not just after its copyright has expired) in many countries. But sure,

Re: [Libreoffice] [Pushed] Build problem on windows 7

2010-10-27 Thread Tor Lillqvist
Patch attached! Thanks, pushed. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Make available this file [Done]

2010-10-28 Thread Tor Lillqvist
Done. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] OpenBSD patch #1

2010-10-28 Thread Tor Lillqvist
Should we change all the shell scripts that use bashisms on the upper level (from the build repo) to start with #!/usr/bin/env bash ? Is that then (finally) a good and reliable solution to the problem whether to use bash or not, and where bash is in case we do want to use it? Or is there some

Re: [Libreoffice] Windows dependancies

2010-10-29 Thread Tor Lillqvist
i.e. a script that downloads the installers, runs them and let the end-user click-through any relevant EULAs ? Do you really mean the LibreOffice end-user here? I don't think that is the case which is being discussed in this thread. We do include the VC runtime in the Windows installer, OOo

Re: [Libreoffice] LibreOffice and Java

2010-11-03 Thread Tor Lillqvist
What about the existing Java extensions? Quite a lot of people are using Java to either writer extensions or use UNO Java bridge from an external application. How hard would it be to do AOT compilation of the Java bytecode of such extensions (and the needed JRE and OOo/LO glue classes), and

Re: [Libreoffice] LibreOffice and Java

2010-11-03 Thread Tor Lillqvist
Rather than clumsily trying to convert Java-.net/mono I would rather allow to have people write in those languages in the first place. Sure. I was dreaming (having nightmares?) of converting compiled Java class files to .NET assemblies... The source code for them would thus still continue to

Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD

2010-11-12 Thread Tor Lillqvist
The outer configure.in already takes a --with-gnu-tar option and sets the GNUTAR autoconf substitution, isn't it easier to use that, and make the indicated GNU tar propagate to bin/install-artwork some way? (Sourcing bin/setup and using $GNUTAR is probably the easiest way.) Probably it would be

Re: [Libreoffice] logos..?

2010-11-14 Thread Tor Lillqvist
(To avoid getting told not to have a negative towards contributors:) But in general, any help with graphical design is appreciated, I am sure. You just have to contact the right people and coöperate with them. Hopefully they read this list. --tml

Re: [Libreoffice] (no subject)

2010-11-16 Thread Tor Lillqvist
#libreoffice developers put the #openoffice code on a diet / work-out regiment. After 6 weeks how did they do? 34,000 Lines of code lighter. But isn't a lot of this lines of code that were commented out, or inside #if 0? And how much of the change is due to changes in the OOo milestones that

Re: [Libreoffice] presenterconsole in writer ? ...

2010-11-17 Thread Tor Lillqvist
I can't see this in a fresh build of the libreoffice-3-3 branch, so possibly it was something that has been fixed in the latest OOo milestones and merged in? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] presenterconsole in writer ? ...

2010-11-17 Thread Tor Lillqvist
Oh, so there is nothing Windows-specific in this problem then? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Disable GCC optimizations when building with --enable-symbols

2010-11-18 Thread Tor Lillqvist
On a related note, what is your take on --enable-dbgutil vs. --enable-debug? Are they designed to do clearly separate things? Do people in general understand the difference? If either answer is no, should these two concepts be merged? --tml ___

Re: [Libreoffice] Disable GCC optimizations when building with --enable-symbols

2010-11-18 Thread Tor Lillqvist
* insert arbitrary debugging code that is only present in 'special' builds: #ifdef DBG_UTIL and #if OSL_DEBUG_LEVEL n Unfortunately, I think those have been mixed up in the past occasionally. When I recently tried a build with --enable-dbgutil but not --enable-debug, I came across a

Re: [Libreoffice] Issues Wiki

2010-11-22 Thread Tor Lillqvist
A place where users can report bugs, That is bugs.freedesktop.org as has been mentioned. talk about new features, etc This mailing list? For more theoretical or political discussion about product vision etc, perhaps the discuss list at the document foundation? --tml

Re: [Libreoffice] Licenses (was: Impress)

2010-11-24 Thread Tor Lillqvist
2) THIRDPARTYLICENSES.html is a concatenation of html files, including tons of .../htmlhtml... in the middle of the file. I want to see the web browser that copes with that mess. Firefox and IE seem to do fine? But yeah, it is quite ugly. --tml

Re: [Libreoffice] ucb/source/ucb compilation error

2010-11-25 Thread Tor Lillqvist
Tor was exercised about this at one stage IIRC, does the above work for you ? Sure, although I think I would prefer to keep OSL_THIS_FUNC as instead of (unknown) in the fallback case. Also, we need to find out if there really is no __func__ or similar even in MSVC2010. So, you think the

Re: [Libreoffice] Auto-detection of toolbar icon size (well, kinda)

2010-11-25 Thread Tor Lillqvist
On 2010-11-25 at 12:47, peterla...@gmail.com wrote: On Thu. 25.11.2010 10:19, Michael Meeks wrote: prompted by some complaints on too large icons on Mac, switched the icon size from 'large' to 'auto' for 3.3. Did we ever get some screenshots of the perceived problem ? I asked in some

Re: [Libreoffice] Language selection

2010-11-30 Thread Tor Lillqvist
I have installed just a few languages, but still all the wrong languages show up. When you say you have installed just a few languages, do you mean in the LibreOffice Windows installer? There you select what *user interface* languages are available, not what languages LibreOffice has writing

Re: [Libreoffice] Script to find undocumented classes

2010-12-01 Thread Tor Lillqvist
After having years of experience using a nice, intuitive and well-documented APIs (Qt,KDE), But surely you should realize the causality here? It is exactly your years of experience with them that makes Qt and KDE seem nice and intuitive. It is extremely hard, probably impossible, to come up

Re: [Libreoffice] Script to find undocumented classes

2010-12-01 Thread Tor Lillqvist
Why not drop merging from OOO after LibO 3.3? Because there is still a significant number of people working on OOo, and they are in many cases the best experts there are on the code they are working on, and they are doing significant and useful improvements? Because there is no licensing

[Libreoffice] Why BLK selection mode? (was: Re: LO status bar annoyances)

2010-12-02 Thread Tor Lillqvist
But wouldn't a better name than block selection then be rectangular selection? --tml P.S. I want a circular selection mode! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

2010-12-03 Thread Tor Lillqvist
Sure, go ahead, and link it from the Easy_Hacks's task, please; I'd think of http://wiki.documentfoundation.org/Development/Easy_Hacks/Installer Please, let's avoid potential confusion and not call the pile of Perl an installer, though. I changed the Easy Hacks page to call it an installer

Re: [Libreoffice] config.log problem

2010-12-07 Thread Tor Lillqvist
I have got a problem with config.log configuration reusing with the old build method on libreoffice-3-3 branch: When run ./autogen.sh --with-lang=en-US de hu it fr blah blah blah it stored as: --with-lang=en-US de hu it fr blah blah blah config.log is a log file. Just for information.

Re: [Libreoffice] [PATCH] installer::archivefiles - remove external find and chmod forks

2010-12-19 Thread Tor Lillqvist
Actually, I wonder what the point in making DLLs executable on Cygwin is. Whether the DLLs in quesiton seem to be executable from Cygwin's point of view (i.e. whether the emulated imaginary POSIX mode of the files have the x bits on or not) is totally irrelevant. Probably that part of the Perl

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

2010-12-22 Thread Tor Lillqvist
It seems that this patch is now in master, and it causes compilation errors on Windows (slightly edited compiler messages for brevity): sbxdec.cxx(735) : error C2065: 'n' : undeclared identifier sbxdec.cxx(749) : error C2039: 'pULong64' : is not a member of 'SbxValues' sbxdec.cxx(749) : error

[Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7

2011-10-19 Thread Tor Lillqvist
OK, so technically not possible as cherry-pick because of the git repo combination, I guess, but anyway, should this fix be cherry-picked to the 3.4 branch? It is supposed to fix the Windows build so that a 64-bit Explorer extension is also built, to get the Explorer extension also on a 64-bit OS.

[Libreoffice] Don't use plain char if you want to put negative values into it

2011-10-19 Thread Tor Lillqvist
Remember that char is either signed or unsigned, depending on platform. Sure, char being signed is the much more common thing, but for instance on ARM Linuxes it is unsigned. So code like: char nDiff = bDown ? 1 : -1; ... if( (-1 == nDiff 0 = nLevel) || (1 == nDiff MAXLEVEL - 1 = nLevel))

Re: [Libreoffice] make experts: progress information?

2011-10-20 Thread Tor Lillqvist
Honestly, I'm not.  Please don't add too much magic to make the build output nicer.  It does get in your way, sooner or later.  (And I also --disable-zenity, as it IMO just adds noise.) +1 (as they say on the AOOo list...) --tml ___ LibreOffice

Re: [Libreoffice] make experts: progress information?

2011-10-20 Thread Tor Lillqvist
 Of course; the question really is how best to do that. There is a fairly firm consensus against building our own gnumake, OTOH, we do already have our own patched gnumake sources, for those that want those new debugging options; we could relatively easily add the feature to it that it prints

[Libreoffice] unowinreg.dll usage

2011-10-23 Thread Tor Lillqvist
I can't think of any reason... :) I think the idea is that when an extension written in Java is distributed (in binary form), you are supposed to bundle this DLL, for use by the extension on Windows. Or something like that. The knee-jerk reaction OMG my Linux purity is soiled by some Windows DLL

Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7

2011-10-24 Thread Tor Lillqvist
See fdo#36950 for discussion. It doesn't seem to make sense to push a backport of the commit to the 3-4 branch, as we don't know if it actually helps the problem. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7

2011-10-25 Thread Tor Lillqvist
See fdo#36950 for discussion. It doesn't seem to make sense to push a backport of the commit to the 3-4 branch, as we don't know if it actually helps the problem. OK, now some more people have verified that the fix helps for them in the situation it actually was supposed to help. So, I guess,

Re: [Libreoffice] compilation issues of apple_remote

2011-10-26 Thread Tor Lillqvist
Please show us your complete autogen.lastrun. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] compilation issues of apple_remote

2011-10-27 Thread Tor Lillqvist
--with-macosx-version-min=10.5 I think this might be the problem. As our code doesn't use any 10.5 or later API anyway, you currently don't win anything by using this. Use --with-macosx-version-min=10.4. Also, you I think you need to use CC=gcc-4.2 and CXX=g++-4.2. Possibly add -arch i386

Re: [Libreoffice] compilation issues of apple_remote

2011-10-27 Thread Tor Lillqvist
I will give these a shot i have symbols enabled and at a certain point its complaining about missing 64bit symbols. How come for users on 10.7 we dont have a native 64bit build as 10.7 runs as 64bit out of the box? Because we don't have the required 64-bit C++/UNO bridge code. Because nobody

Re: [Libreoffice] compilation issues of apple_remote

2011-10-27 Thread Tor Lillqvist
What work would need to be done to make apple_remote something that can be disabled via autogen.sh? There is nothing much special with apple_remote, it just happens to be the first place where you encountered problems because you were using an untested experimental setup. --tml

Re: [Libreoffice] Proofing API Performance

2011-11-09 Thread Tor Lillqvist
Currently, LO seems to call the API for every word (or even letter) typed, which is incredibly wasteful as grammar checking only makes sense at sentence level. I also don't really want the whole paragraph at each call; just the last finished sentence. But what if you have an already finished

Re: [Libreoffice] iOS and convert to PDF

2011-11-10 Thread Tor Lillqvist
That's quite normal, you've read README.cross ? :-) also more concrete details on the specific problems would be good. Also, http://www.iki.fi/tml/libocon2011-xcompiling.pdf gives an overview of LibeOffice cross-compilation in general. I've had some difficulty building it. Please give more

Re: [Libreoffice] iOS and convert to PDF

2011-11-11 Thread Tor Lillqvist
I get this build error: /Users/brians/develop/libreOffice/libo/bridges/source/cpp_uno/gcc3_ios_arm/cpp2uno.cxx:491: OK, I haven't actually compiled for the device much lately, only for the simulator, so some bit rot might have happened. I suggest you just compile for the simulator for now.  

Re: [Libreoffice] iOS and convert to PDF

2011-11-11 Thread Tor Lillqvist
Entering /Users/brians/develop/libreOffice/libo/l10ntools/source Ah OK, l10ntools. That is a module it shouldn't even be building for non-desktop OSes. It contains some command-line tools that make no sense on iOS (or Android). No libraries that actual LO code would use are built in l10ntools as

Re: [Libreoffice] [PATCH] Replace command domainname by getdomainname() on Unix

2011-11-13 Thread Tor Lillqvist
For nitpickers, note that getdomainname does *not* return the DNS domain, but the NIS domain, which strictly speaking may or may not coincide. From my Solaris sysadmin experience (which is limited, and old), I'd say it is a very lucky site and/or organization if they happen to coincide. I

Re: [Libreoffice] [PATCH] Replace command domainname by getdomainname() on Unix

2011-11-13 Thread Tor Lillqvist
Seems that the original code was also broken of course, forking and execing /bin/domainname is indeed a bit stupid, and the domainname command is also specified (to the extent it is specified at all) to return the NIS domain name. But honestly, how many of the LibreOffice installations on Unix

Re: [Libreoffice] iOS and convert to PDF

2011-11-14 Thread Tor Lillqvist
I am sorry to say this, but it is fairly pointless to try to build for iOS at this stage if you are not also prepared to dig into the problems you will encounter and fix them, sorry. Nobody is actively working on the iOS port right now. (As for myself I am concentrating on the Android port at the

Re: [Libreoffice] iOS and convert to PDF

2011-11-16 Thread Tor Lillqvist
Env.Host.sh ends up with CPUNAME of ARM when I think it ought to be intel. Well, CPUNAME or CPU aren't used for any deep magic, they are just strings used to form some directory names etc. I don't think we would win much by using a separate CPU and CPUNAME string for the iOS simulator. The only

Re: [Libreoffice] iOS and convert to PDF

2011-11-17 Thread Tor Lillqvist
Is it possible that I don't need module tail_build? tail_build is a meta-module that actually builds most of the modules that have been migrated over to the new gnu make based build system. It includes all the business logic of Calc, Writer etc, so sure, stuff from it will be needed. Anyway,

Re: [Libreoffice] removing testtool it's ilk ...

2011-11-17 Thread Tor Lillqvist
Hmm, this is about the program called testtool, not the module testtools (note trailing s), right? In the latter, at least the bridgetest part is certainly useful when porting LO to new architectures. I remember running stuff from there when attempting the port to 64-bit Windows, and will soon

Re: [Libreoffice] iOS and convert to PDF

2011-11-18 Thread Tor Lillqvist
this isn't a suitable way to develop code. Indeed not. It is a way to experiment before some saner way exists, nothing more. Is that where  you got the NSEnumerator stuff? Most likely, I can't remember writing anything such myself... I guess it's an antique like all the Mac stuff. Indeed.

Re: [Libreoffice] Assertions and Logging

2011-11-21 Thread Tor Lillqvist
From what I vaguely remember it is Windows that closes those streams for GUI executables, Something like that, yes, although they are not closed in the sense that they would first be open (inherited in the Unix sense); they are never open in the first place in GUI executables, unless explicitly

Re: [Libreoffice] Assertions and Logging

2011-11-22 Thread Tor Lillqvist
Agree. The only valid reason for not having all debug tools compiled in is runtime performance and binary size. Which brings up the question: Should my attempts to use the MSVC debugging runtime (and debug code in its headers, i.e. -D_DEBUG) when using --enable-dbgutil be reverted? It currently

Re: [Libreoffice] Assertions and Logging

2011-11-22 Thread Tor Lillqvist
if the MSVC debug stuff is indeed too difficult, then just comment it out, put in a comment that says FIXME, and re-enable the --enable-dbgutil stuff, that way windows devs at last get some assertions and internal consistency checks. But you can't build it with --enable-dbgutil ...

Re: [Libreoffice] compiling with C++0x support

2011-11-23 Thread Tor Lillqvist
After I found out that M_PI is not defined when you build with -std=c++0x, I kind of lost interest for now ;-) Welcome to the world of multiple implementations of standards. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] message construction bloat ...

2011-11-23 Thread Tor Lillqvist
 Value is % SAL_PRIdINT32, n (presumably n here is then sal_Int32?) On which of the platforms that we support is %d not a proper format for sal_Int32? Even in the unlikely case that on some platform int indeed is larger (for instance 64 bits) than sal_Int32, won't the usual conversions take

Re: [Libreoffice] message construction bloat ...

2011-11-23 Thread Tor Lillqvist
On all those that use  typedef signed long sal_Int32; Ah, but it still *works*, doesn't it? int is *also* 32 bits on these platforms, isn't it? But yeah, I guess you do get a warning from gcc. --tml ___ LibreOffice mailing list

Re: [Libreoffice] windows make dev-install, was build break in smoketestoo_native : LibO_*_install-arc_en-US.zip: No such file or directory

2011-11-25 Thread Tor Lillqvist
Hmm, this is windows. I'm not altogether sure that the make dev-install suggestion makes sense for windows ? I don't think it does, no. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] concept for c++ based subsequenttests

2011-12-01 Thread Tor Lillqvist
From the point of view of porting LibreOffice (suitable parts of it) to new and exciting platforms, unit tests in C++ only are definitely preferred. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Clipboard handling on Windows

2011-12-02 Thread Tor Lillqvist
So, I'm still not understanding this fully.  Why is it that, when you use the 2nd API, you only see some of the formats, not all? One possibility might be that the first API also returns synthesized clipboard formats. For instance, if you put CF_UNICODETEXT format data on the clipboard, Windows

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-03 Thread Tor Lillqvist
Kendy (this time CC'd), please don't commit this stuff.  It breaks incremental build on Windows, making debugging Windows impossible. Hear, hear. If we want beta1 to be better than beta0, we can't require people having to make clean after each edit, and rebuild from scratch (effectively making

Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???

2011-12-03 Thread Tor Lillqvist
I thought Andras was referring to the single 8 letter/number code added to the Windows install folder name. Where does that come from? No need to know. It is just a random (or not so random) sequence of hex digits. If nothing documents it to have some significance, don't assume it to have any

Re: [Libreoffice] PostgreSQL-SDBC: Windows MacOS X porters sought

2011-12-04 Thread Tor Lillqvist
1) Cygwin has packages (but too old, not 9.0) that seem rather   unpatched and to be built with a rather plain ./configure   make. So on Windows, the internal PostgreSQL should IMHO be put   into shape to build without too much effort / problem. Note, however, that Cygwin is Unix (even if

Re: [Libreoffice] PostgreSQL-SDBC: Windows MacOS X porters sought

2011-12-04 Thread Tor Lillqvist
From what I read on the wiki, building LibreOffice on Windows requires Cygwin anyway; Yes, but only as the environment in which a Unix shell and make (and other build-time tools like Perl) run. The produced code and executables have no relation to Cygwin at all. and AFAIK, cygwin creates

Re: [Libreoffice] [PATCHES] [PUSHED] Decoview cleanup - remove unneeded header

2011-12-05 Thread Tor Lillqvist
Pushed all six patches to master, will thus be in 3.5.0. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Fix rendering of GTK combobox in RTL

2011-12-05 Thread Tor Lillqvist
Thanks, pushed to master, will thus be in 3.5. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Patch] Code review fix

2011-12-05 Thread Tor Lillqvist
The idea is that the 8-bit input range 0..255 should map to the 16-bit output range 0..65535 ... Try the original code, compared to your suggestion;) (To be honest, multiplying by 257 did sound weird to me, too, but then I realized that 257 == 65535/255 . I would perhaps write out the 65535/255

Re: [Libreoffice] [PATCH] [PUSHED] Some OSL cleanup

2011-12-07 Thread Tor Lillqvist
New version of the patch, with good versions comments and whithout compilation of getpid on recent linux. Thanks, applied to master and pushed. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] PATCH [PUSHED]: menues - menus

2011-12-07 Thread Tor Lillqvist
The patch referred some files that have been removed or renamed. Also, it changed some occurences of menues in German comments, where menues *is* correct (it is an alternative spelling of Menüs, the plural of Menü). There was also a bogus change to solenv/gbuild/extensions/post_BuildplTargets.mk .

Re: [Libreoffice] PATCH: menues - menus

2011-12-07 Thread Tor Lillqvist
this patch also changes solenv/gbuild/extensions/post_BuildplTargets.mk I noticed, and removed that part from the patch before applying. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] [PUSHED:master] Fix for bug fdo 43586 Add more room for localized strings (named ranges),

2011-12-07 Thread Tor Lillqvist
Thanks, applied and pushed to master, somebody else please cherry-pick to 3.5. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] childs - children

2011-12-08 Thread Tor Lillqvist
I think we need some discussion about this. Will some of the instances where you do the change break a stable public API? And what about German comments like wird gesetzt, wenn RequestingChilds keine Childs gestzt hat , is the word Childs really English there? Or just an English loan-word but

Re: [Libreoffice] [PUSHED] childs - children

2011-12-08 Thread Tor Lillqvist
However, there are examples, where the s in childs is a genitive s, as in: -            // Setzen des Childs, ueber Referenz, um die PagePos zu erhalten +            // Setzen des Children, ueber Referenz, um die PagePos zu erhalten Ah, good point. I cleaned that up (hopefully), and did a

Re: [Libreoffice] [PUSHED] CHILDS - CHILDREN

2011-12-08 Thread Tor Lillqvist
Pushed together with the other patch. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] Java 7 support in LO 3.4.5 (was: minutes of tech. steering call ...)

2011-12-09 Thread Tor Lillqvist
I'm new to this QA system, but wouldn't it be useful to know when (date/time) this was added? Added where? You need to realise that we use a *distributed* version control system, git, and time stamps are not important, as far as I understand it. Sure, in our case there are central repositories

Re: [Libreoffice] [Libreoffice-qa] Java 7 support in LO 3.4.5 (was: minutes of tech. steering call ...)

2011-12-09 Thread Tor Lillqvist
I'm interest in the time a change was committed to the central repository by a developer But developers don't commit to the central repository. They commit to their local clones of it, and then at some (much) later stage push outstanding commits to the central repository. And then there are

Re: [Libreoffice] bug in Jar_ScriptProviderForJava.mk?

2011-12-09 Thread Tor Lillqvist
I ran into the same problem today, and I think I fixed it by using a variable called T_CP instead of CLASSPATH in gbuild to collect the -cp option to be passed to javac. (Which is cleaner, too, as the Java CLASSPATH concept and the -cp option to the Java compiler are different things.) Pushed to

Re: [Libreoffice] postresql-sdbc bits out of minutes of tech. steering call

2011-12-09 Thread Tor Lillqvist
Well, as a system lib I understand it can be installed nearly anywhere Er... huh? Isn't the very definition of a system library one that is installed in a fixed known location, as part of the operating system? --tml ___ LibreOffice mailing list

Re: [Libreoffice] build failed in lingucomponent on Mac

2011-12-14 Thread Tor Lillqvist
.mm files are objective-C specific header files. I would convert them to c++ Er, no. .mm is the conventional extension for Objective-C++ source files. (Plain Objective-C files have the conventional extension .m, and Objective-C headers the extension .h.) This is documented in man gcc even, at

Re: [Libreoffice] Fwd: InterFace 1.2.0 - New Open Source Social Network as Chat Messenger Addon

2011-12-19 Thread Tor Lillqvist
What about to add this Messenger to Libre Office? Feel free to submit patches. I don't personally see any reason for this, though, but hey, I just work here. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Build problems (and some solutions) in Mac OSX

2011-12-20 Thread Tor Lillqvist
You fail to give useful information to help you with your problems... - What version of MacOSX are you running? What Xcode? - What branch of the source code are you building? - What exact error messages do you see, at what point in the build? - How exactly did you configure your build? What does

Re: [Libreoffice] Build problems (and some solutions) in Mac OSX

2011-12-20 Thread Tor Lillqvist
Anyway, I forgot to say: Welcome to hacking on LibreOffice! We will try to help you in all ways we can. Especially for Mac OS X, many of the system APIs used by the code are slightly obsolete, to put it mildly. It would be very much welcome, if you are a Mac expert, if you could help in

Re: [Libreoffice] [MacOS] Horizontal cursor positioning in justified text

2011-12-22 Thread Tor Lillqvist
Sorry, I don't know the code related to the problem you describe; just some other comments here. The cursor positioning in writer Just a nitpick: You mean caret, not cursor. (The cursor is the thing that you move around with your pointing device, the caret is the text insertion cursor. But

Re: [Libreoffice] [BUG] Hide system pkg-config, to avoid finding stray freetype.

2011-12-22 Thread Tor Lillqvist
This is a protection-from-contaminated-system But in general, a system can be contaminamed in arbitrary ways. Should/can we really protect against arbitrary, unknown, ways in which a system might have been changed by helpful 3rd-party software or misguided sysadmins/users to not correspond to a

Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency

2011-12-22 Thread Tor Lillqvist
And +1 from me. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-5] sequence of unfortunate writer ole object in headers problems

2012-01-05 Thread Tor Lillqvist
+1 --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Tor Lillqvist
IMO this doesn't make any sense: if your PC is low spec you don't _want_ this; if your PC is high spec you don't _need_ this I can't believe it. Finally somebody who agrees with me on this (and I am not being ironic), and it's Pedro even! This is a good start of the year. --tml

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Tor Lillqvist
Quickstart feature is installed by default but it is not run by default. My opinion is that we should just kill the feature (code) completely;) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] unnecessary building basegfx twice ?

2012-01-06 Thread Tor Lillqvist
Maybe the easiest way out would be to turn pdfimport from an .oxt extension into an (optionally installable) part of LO. Makes a lot of sense, I think. Ditto for other extensions included in the source code. --tml ___ LibreOffice mailing list

Re: [Libreoffice] unnecessary building basegfx twice ?

2012-01-06 Thread Tor Lillqvist
in the case of pdfimport, isn't there a potential licensing problem because it uses GPL-licensed xpdf/poppler code? Ah OK. IANAL, so maybe indeed keeping it as an oxt then is relevant. Still, what prevents us from saying that a particular build of this extension as shipped with LO x.y, works

Re: [Libreoffice] [Libreoffice-ux-advise] UI disaster on Windows: soffice -h

2012-01-09 Thread Tor Lillqvist
I'll also try what Stephan suggested, i.e. if we can print to stdout in Windows, too. Note that one layer of silly wrapping could probably be dropped by using AttachConsole(ATTACH_PARENT_PROCESS) followed by freopen()ing stdout and stderr to CONOUT$. AttachConsole() is present on XP and later.

Re: [Libreoffice] [Libreoffice-ux-advise] UI disaster on Windows: soffice -h

2012-01-10 Thread Tor Lillqvist
If that AttachConsole(ATTACH_PARENT_PROCESS) is executed by soffice.bin, it probably is the case that as already soffice.exe is a gui executable, soffice.exe doesn't have a console, and thus for its child process, soffice.bin, there is no parent process console to attach to. Try having also

Re: [Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Tor Lillqvist
I don't even think we use server fonts at all). Funnily enough, we have a type called ServerFont... vcl/inc/generic/glyphcache.hxx , but that name is probably historical, and what it actually means nowadays is the exact opposite;) --tml ___

Re: [Libreoffice] Android bitlets ...

2012-01-18 Thread Tor Lillqvist
       * size of /data too small: (default seems to be 54Mb or so) I think 54 MB is just enough for the default applications; the LO ucalc unit test app will certainly not fit in that as the LibreOfficeQA-SC-debug.apk file itself is already something like 68 MB... I use -partition-size 500 when

Re: [Libreoffice] Test script patch review request (1)

2011-01-04 Thread Tor Lillqvist
Eek, I wrote: while read fn /tmp/tabs.auto.filelist.txt; do sed 's/ //g' $fn /tmp/notabfile mv /tmp/notabfile $fn done But that is wrong... it will read the first line from file line over and over again, it seems. The correct syntax would be: while read fn; do sed 's/

  1   2   3   4   5   6   7   8   9   10   >