Re: [Libreoffice] [REVIEW 3-4] Related: fdo#33463 (writerfilter)
Miklos Vajna píše v So 31. 12. 2011 v 14:51 +0100: Hi, In https://bugs.freedesktop.org/show_bug.cgi?id=33463#c25 Michael stated Unfortunately, it seems to provoke a (prolly) unrelated import problem, such that comments end up with some double-strike-out style if you re-import them ;-) but at least there is no data loss. I don't have a -3-4 checkout around - could someone check if commit 52f51f57287fc955fd83b521c80519beb5c923bf in master is what fixes the double strike-though problem? If yes, I think it would make sense to backport that one to -3-4 as well. The fix makes perfect sense. The same check is used for other attributes, e.g. LN_CFStrike, LN_CFBold, LN_CFCaps = I have pushed it to the libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/filters/commit/?h=libreoffice-3-4id=9dcc765e88bf23418ffbf66345e4eaa4c36005e4 We need two more approvals for the 3-4-5 branch. Unfortunately, I am not able to reproduce the original problem with the double striked format = I am not sure if it fixes the problem. Michael? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW 3-4] Related: fdo#33463 (writerfilter)
On Monday 02 of January 2012, Petr Mladek wrote: Miklos Vajna píše v So 31. 12. 2011 v 14:51 +0100: I don't have a -3-4 checkout around - could someone check if commit 52f51f57287fc955fd83b521c80519beb5c923bf in master is what fixes the double strike-though problem? If yes, I think it would make sense to backport that one to -3-4 as well. The fix makes perfect sense. The same check is used for other attributes, e.g. LN_CFStrike, LN_CFBold, LN_CFCaps = I have pushed it to the libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/filters/commit/?h=libreoffice-3-4i d=9dcc765e88bf23418ffbf66345e4eaa4c36005e4 Yes, it's correct. We need two more approvals for the 3-4-5 branch. One. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW 3-4] Related: fdo#33463 (writerfilter)
On Mon, 02 Jan 2012 18:29:15 +0100, Lubos Lunak l.lu...@suse.cz wrote: On Monday 02 of January 2012, Petr Mladek wrote: Miklos Vajna píše v So 31. 12. 2011 v 14:51 +0100: I don't have a -3-4 checkout around - could someone check if commit 52f51f57287fc955fd83b521c80519beb5c923bf in master is what fixes the double strike-though problem? If yes, I think it would make sense to backport that one to -3-4 as well. The fix makes perfect sense. The same check is used for other attributes, e.g. LN_CFStrike, LN_CFBold, LN_CFCaps = I have pushed it to the libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/filters/commit/?h=libreoffice-3-4i d=9dcc765e88bf23418ffbf66345e4eaa4c36005e4 Yes, it's correct. We need two more approvals for the 3-4-5 branch. One. please hurry up since today is 3.4.5 commit deadline :-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW 3-4] Related: fdo#33463 (writerfilter)
Hi, In https://bugs.freedesktop.org/show_bug.cgi?id=33463#c25 Michael stated Unfortunately, it seems to provoke a (prolly) unrelated import problem, such that comments end up with some double-strike-out style if you re-import them ;-) but at least there is no data loss. I don't have a -3-4 checkout around - could someone check if commit 52f51f57287fc955fd83b521c80519beb5c923bf in master is what fixes the double strike-though problem? If yes, I think it would make sense to backport that one to -3-4 as well. Thanks, Miklos pgp85Q43YFqza.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
