Re: [PATCH] Unify OUTPATH values

2012-05-30 Thread Stephan Bergmann
On 05/26/2012 12:59 PM, Francois Tigeot wrote: I don't think there's any good reason to have wildly different OUTPATH names for each specific platform variant. The various names also lead to unnecessary work when packaging, just to correctly handle LD_LIBRARY_PATH. The attached patch reduces OU

Re: [PATCH] Unify OUTPATH values

2012-05-29 Thread Norbert Thiebaud
On Tue, May 29, 2012 at 2:37 PM, Michael Stahl wrote: > > unfortunately that only worked with setsolar, not with configure based > builds, because the names of the set_soenv shell output files collided. > then i actually fixed that in CWS gnumake4, but now we have a single > config_host.mk again :

Re: [PATCH] Unify OUTPATH values

2012-05-29 Thread Michael Stahl
On 29/05/12 22:26, Caolán McNamara wrote: > On Tue, 2012-05-29 at 21:37 +0200, Michael Stahl wrote: >> On 29/05/12 21:21, Eike Rathke wrote: >>> One could even have only one checkout and natively compile all platforms >>> from it, which was how it was done in Sun Hamburg labs. >> >> unfortunately t

Re: [PATCH] Unify OUTPATH values

2012-05-29 Thread Caolán McNamara
On Tue, 2012-05-29 at 21:37 +0200, Michael Stahl wrote: > On 29/05/12 21:21, Eike Rathke wrote: > > One could even have only one checkout and natively compile all platforms > > from it, which was how it was done in Sun Hamburg labs. > > unfortunately that only worked with setsolar, not with config

Re: [PATCH] Unify OUTPATH values

2012-05-29 Thread Michael Stahl
On 29/05/12 21:21, Eike Rathke wrote: > Hi Francois, > > On Saturday, 2012-05-26 13:47:45 +0200, Francois Tigeot wrote: > >> I didn't think cross-compiling could be done this way; in my mind, separate >> git clones were used for each destination platform. > > One could even have only one checkou

Re: [PATCH] Unify OUTPATH values

2012-05-29 Thread Eike Rathke
Hi Francois, On Saturday, 2012-05-26 13:47:45 +0200, Francois Tigeot wrote: > I didn't think cross-compiling could be done this way; in my mind, separate > git clones were used for each destination platform. One could even have only one checkout and natively compile all platforms from it, which

Re: [PATCH] Unify OUTPATH values

2012-05-29 Thread Francois Tigeot
Hi, On Tue, May 29, 2012 at 09:07:06PM +0200, Eike Rathke wrote: > > On Saturday, 2012-05-26 12:59:32 +0200, Francois Tigeot wrote: > > > The attached patch reduces OUTPATH to two possible values: unx and wnt. > > In addition to what others already said regarding cross-platform builds > and suc

Re: [PATCH] Unify OUTPATH values

2012-05-29 Thread Eike Rathke
Hi Michael, On Saturday, 2012-05-26 12:15:51 +0100, Michael Meeks wrote: > [ admittedly the names are > highly non-intuitive, and hard to write when explaining to others, and I > don't believe the parallel .pro / non-pro distinctions is necessary ;-) > ] When I worked on performance I usua

Re: [PATCH] Unify OUTPATH values

2012-05-29 Thread Eike Rathke
Hi Francois, On Saturday, 2012-05-26 12:59:32 +0200, Francois Tigeot wrote: > The attached patch reduces OUTPATH to two possible values: unx and wnt. In addition to what others already said regarding cross-platform builds and such, there are source directories named 'unx' within some modules, i.

Re: [PATCH] Unify OUTPATH values

2012-05-27 Thread David Tardon
Hi, On Sat, May 26, 2012 at 01:47:45PM +0200, Francois Tigeot wrote: > Hey Michael, > > The .pro extension may not be present in all cases; iirc it disappears when > some debug options are enabled. The option is --enable-dbgutil . D. ___ LibreOffice m

Re: [PATCH] Unify OUTPATH values

2012-05-26 Thread Norbert Thiebaud
On Sat, May 26, 2012 at 5:59 AM, Francois Tigeot wrote: > Hi, > > I don't think there's any good reason to have wildly different OUTPATH names > for each specific platform variant. > > The various names also lead to unnecessary work when packaging, just to > correctly handle LD_LIBRARY_PATH. > > T

Re: [PATCH] Unify OUTPATH values

2012-05-26 Thread Michael Meeks
On Sat, 2012-05-26 at 13:47 +0200, Francois Tigeot wrote: > I didn't think cross-compiling could be done this way; in my mind, separate > git clones were used for each destination platform. Right; but currently we build both the native platform tools necessary for doing the cross-compilin

Re: [PATCH] Unify OUTPATH values

2012-05-26 Thread Francois Tigeot
Hey Michael, On Sat, May 26, 2012 at 12:15:51PM +0100, Michael Meeks wrote: > > On Sat, 2012-05-26 at 12:59 +0200, Francois Tigeot wrote: > > The attached patch reduces OUTPATH to two possible values: unx and wnt. > > Since > > it is potentially intrusive, I prefer to show it here for review ins

Re: [PATCH] Unify OUTPATH values

2012-05-26 Thread Michael Meeks
Hi Francois, On Sat, 2012-05-26 at 12:59 +0200, Francois Tigeot wrote: > I don't think there's any good reason to have wildly different OUTPATH names > for each specific platform variant. :-) > The various names also lead to unnecessary work when packaging, just to > correctly handle LD_

[PATCH] Unify OUTPATH values

2012-05-26 Thread Francois Tigeot
bject: [PATCH] Unify OUTPATH values * unx for Unix platforms, wnt for Windows ones * this move reduces path lengths and simplifies packaging Change-Id: I480a729c5bd25518dab09d89d52c104054d461c0 --- configure.in | 48 ++-- 1 file changed, 14 insertions(+),