[PATCH] Remove unused code

2013-04-17 Thread Michael Dunphy (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3447 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3447/1 Remove unused code Change-Id: Id4ce1d003db61374ba68f807090860595178b562 --- M

[PATCH] remove unused code.

2013-04-02 Thread navin patidar (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3167 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3167/1 remove unused code. A request (rReq) having anyone of following SID SID_ATTR_CHAR_FONTHEIGHT,

[PATCH] remove unused code svtools/bmpmaker

2013-03-20 Thread David Ostrovsky (via Code Review)
David Ostrovsky has created a new patch set by issuing a rebase in Gerrit (#4). Change subject: remove unused code svtools/bmpmaker .. remove unused code svtools/bmpmaker Investigated the usage of bmpmaker for fdo#39445,

[PATCH] Remove unused code

2012-09-23 Thread Olivier Hallot (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/682 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/682/1 Remove unused code According to unusedcode.easy Change-Id: I31edd26d8ee7934b47ed7bf5ec6c07e1b8c5c5e9 --- M

[PATCH] remove unused code

2012-08-30 Thread Gerrit
From Babati Bence b.baa...@gmail.com: Babati Bence has uploaded a new change for review. Change subject: remove unused code .. remove unused code Change-Id: I49e84449a0ea1f77ff4d14b3631aeb7670d4f4e7 --- M sd/inc/pglink.hxx M

Re: [PUSHED][PATCH] Remove unused code (24)

2012-04-30 Thread Caolán McNamara
On Sun, 2012-04-29 at 16:16 +0800, Elton Chung wrote: Hi there, This patch removes 1 unused method. Looks good to me, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] Remove unused code (24)

2012-04-29 Thread Elton Chung
Hi there, This patch removes 1 unused method. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com

Re: [PATCH] Remove unused code (ImpSvtData)

2012-04-25 Thread Caolán McNamara
On Wed, 2012-04-25 at 05:16 -0700, Javier Catala wrote: Hi everyone, This patch removes unused destructor in the ImpSvtData class, as listed in unusedcode.easy Yeah, but see unusedcode.README and f. If the constructor used, but the destructor is unused. Then its probably a leak and we

Re: [RESOLVED][PATCH] Remove unused code (ImpSvtData)

2012-04-25 Thread Caolán McNamara
On Wed, 2012-04-25 at 13:47 +0100, Caolán McNamara wrote: We should try and fix the leak and call the destructor somewhere rather than removing the destructor. Refactored now to not leave that gotcha in the unusedcode.easy list. Fixed. C. ___

Re: [PUSHED] PATCH: Remove unused code from editing

2012-04-24 Thread Vicente Rafael Estévez Vacas
: Remove unused code from editing On Mon, 2012-04-23 at 17:13 +0100, Vicente Rafael Estévez Vacas wrote: Asunto: PATCH: Remove unused code from editing Basically good. Though you need to build after your make your changes to pick up that there's a small mixup between the unused sdr::contact

Re: [PUSHED][PATCH] Remove unused code in dpitemdata

2012-04-24 Thread Caolán McNamara
On Mon, 2012-04-23 at 19:27 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code

2012-04-24 Thread Caolán McNamara
On Sun, 2012-04-22 at 20:48 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed. Thanks for this. It bothers me a little that there was a addListener and a removeListener where the addListener is used while removeListener is unused. It

Re: [PUSHED][PATCH] Remove unused code (sc)

2012-04-24 Thread Caolán McNamara
On Mon, 2012-04-23 at 19:39 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] Remove unused code (ImpSvtData)

2012-04-24 Thread Javier Catala
Hi everyone, this patch removes the unused destructor in the ImpSvtData class, as listed in unusedcode.easy From bdfc550685d238a62602a4f93da0ab804d77b2f6 Mon Sep 17 00:00:00 2001 From: Javier Catala j_cat...@yahoo.com Date: Tue, 24 Apr 2012 20:24:17 +0200 Subject: [PATCH] Remove unused

PATCH: Remove unused code from editeng

2012-04-23 Thread Ferran Vidal i Marginet
Hello, These is the patch that I've created. Is my first patch, so I hope this will be correct. If you detect any problem, please let me know.Thanks!Licence: made available under the MPL/LGPLv3+ Ferran Vidal From 553d11cbb902cf30f499c27e834d0f5c26c4f134 Mon

PATCH: Remove unused code from editing

2012-04-23 Thread Vicente Rafael Estévez Vacas
code from editing Thanks 0001-PATCH-Remove-unused-code-from-editing.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (sc)

2012-04-23 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] PATCH: Remove unused code from editing

2012-04-23 Thread Caolán McNamara
On Mon, 2012-04-23 at 17:13 +0100, Vicente Rafael Estévez Vacas wrote: Asunto: PATCH: Remove unused code from editing Basically good. Though you need to build after your make your changes to pick up that there's a small mixup between the unused sdr::contact::ViewObjectContactOfUnoControl

[PATCH] Remove unused code

2012-04-22 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sw.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

PATCH: Remove unused code

2012-04-22 Thread Ferran Vidal i Marginet
: Ferran Vidal vidalmargi...@hotmail.com Date: Sun, 22 Apr 2012 21:10:08 +0200 Subject: [PATCH] Remove unused code --- sc/inc/dbdata.hxx |1 - sc/source/core/tool/dbdata.cxx |5 - unusedcode.easy|1 - 3 files changed, 0 insertions(+), 7 deletions

[PATCH] Remove unused code (vlc)

2012-04-22 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-vlc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Pushed] [PATCH] Remove unused code (vlc)

2012-04-22 Thread Muthu Subramanian K
Thank you! On 04/23/2012 02:06 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Pushed] PATCH: Remove unused code

2012-04-22 Thread Muthu Subramanian K
Pushed. Thank you! On 04/23/2012 12:44 AM, Ferran Vidal i Marginet wrote: Hello, These is the patch that I've created. Licence: made available under the MPL/LGPLv3+ Ferran Vidal ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

PATCH: Remove unused code from Spreadsheet-application-code

2012-04-21 Thread Ferran Vidal i Marginet
Date: Sat, 21 Apr 2012 18:08:11 +0200 Subject: [PATCH] Remove unused code from Spreadsheet application code --- sc/inc/cell.hxx |1 - sc/source/core/data/cell.cxx |5 - unusedcode.easy |2 -- 3 files changed, 0 insertions(+), 8 deletions(-) diff --git

Re: [PUSHED] PATCH: Remove unused code from Spreadsheet-application-code

2012-04-21 Thread Caolán McNamara
On Sat, 2012-04-21 at 17:20 +0100, Ferran Vidal i Marginet wrote: Hello, These is the patch that I've created. Looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] Remove unused code (sc)

2012-04-16 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code (sd)

2012-04-16 Thread Caolán McNamara
On Sat, 2012-04-14 at 20:14 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code (connectivity)

2012-04-16 Thread Caolán McNamara
On Sat, 2012-04-14 at 19:34 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code (sc)

2012-04-16 Thread Caolán McNamara
On Mon, 2012-04-16 at 20:10 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] Remove unused code (connectivity)

2012-04-14 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-connectivity.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (sd)

2012-04-14 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sd.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (oox)

2012-04-12 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-oox.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code (oox)

2012-04-10 Thread Caolán McNamara
On Sun, 2012-04-08 at 21:56 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Yup, pushed now. Well, actually Julien removed the same code and got in first. C. ___ LibreOffice mailing list

[PATCH] Remove unused code (oox)

2012-04-08 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-oox.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re: [PATCH] Remove unused code (vcl)

2012-04-06 Thread Matúš Kukan
Hello, On 4 April 2012 17:14, Thomas Collerton tom.col...@gmail.com wrote: Hello all, this patch removes unused code in the Slider class as listed in unusedcode.easy Looks good = pushed Thanks, Matúš ___ LibreOffice mailing list

Re: [Pushed] [PATCH] Remove unused code (svx)

2012-04-05 Thread Muthu Subramanian K
Pushed. Thank you! On 04/05/2012 12:10 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PUSHED] Re: [PATCH] remove unused code (oox)

2012-04-05 Thread Jan Holesovsky
Hi Petr, Petr Vorel píše v Po 02. 04. 2012 v 16:18 +0200: removed unused classes from oox. Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=07ff032c805835355ff0dff75b8ad534dfb770e9 Thank you! :-) Regards, Kendy ___ LibreOffice

[PATCH] Remove unused code (vcl)

2012-04-04 Thread Thomas Collerton
Hello all, this patch removes unused code in the Slider class as listed in unusedcode.easy 0001-Remove-unused-code-vcl.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] remove unused code (oox)

2012-04-02 Thread Petr Vorel
Hi there, removed unused classes from oox. Regards, Petr From b4350501d1fe85da2cce5750b480e33eb6409301 Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Mon, 2 Apr 2012 11:40:06 +0200 Subject: [PATCH] remove unused code (oox) --- oox/inc/oox/dump/dumperbase.hxx | 18

Re: [PUSHED][PATCH] Remove unused code in sqlnode

2012-03-29 Thread Caolán McNamara
On Wed, 2012-03-28 at 21:31 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Look good, pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code (connectivity)

2012-03-29 Thread Caolán McNamara
On Wed, 2012-03-28 at 21:51 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] remove unused code (oox)

2012-03-29 Thread Petr Vorel
Hi there, removed unused methods, hope better this time. Regards, Petr From 2d8c47fede9ec6842a98663f16c4efa70f833e22 Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Thu, 29 Mar 2012 11:54:36 +0200 Subject: [PATCH] remove unused code (oox) --- oox/inc/oox/dump/dffdumper.hxx

Re: [PUSHED][PATCH] remove unused code (oox)

2012-03-29 Thread Caolán McNamara
On Thu, 2012-03-29 at 15:23 +0200, Petr Vorel wrote: Hi there, removed unused methods pushed, thanks for these C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] remove unused code (oox, sc)

2012-03-28 Thread Petr Vorel
Hi there, yet another remove unused code patch. Regards, Petr From 38a7f343736f7049d28aae132307eba02a019f27 Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Wed, 28 Mar 2012 11:20:18 +0200 Subject: [PATCH] remove unused code (oox, sc) --- oox/inc/oox/drawingml

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-28 Thread Caolán McNamara
On Wed, 2012-03-28 at 16:23 +0200, Petr Vorel wrote: Hi there, yet another remove unused code patch. Pushed now, thanks for this. FWIW, if a class has only one constructor and that constructor is unused then it indicates that the whole class (except perhaps for any static methods it might

[PATCH] Remove unused code in sqlnode

2012-03-28 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 75344c3cb19be787fce45bd06ad93a971e0b5292 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Wed, 28 Mar 2012 21:28:07 +0200 Subject: [PATCH] Remove unused code in sqlnode --- connectivity/inc/connectivity

[PATCH] Remove unused code (connectivity)

2012-03-28 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-connectiviy.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-28 Thread Petr Vorel
FWIW, if a class has only one constructor and that constructor is unused then it indicates that the whole class (except perhaps for any static methods it might have) should be possible to be removed. Sorry, I'll think more next time. Petr ___

[PATCH] remove unused code (oox, sc)

2012-03-27 Thread Petr Vorel
Hi there, another bits of unused code removed. Regards, Petr From e31c211d2ebb7cde8a260ec0bcef5359c0c1db8f Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Tue, 27 Mar 2012 11:03:09 +0200 Subject: [PATCH] remove unused code (oox, sc) --- oox/inc/oox/dump/dumperbase.hxx

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-27 Thread Caolán McNamara
On Tue, 2012-03-27 at 16:27 +0200, Petr Vorel wrote: Hi there, another bits of unused code removed. looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] Remove unused code (l10ntools)

2012-03-27 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 85de68332e5419fbf2ef58957a9c11f588fad6c1 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Tue, 27 Mar 2012 21:16:50 +0200 Subject: [PATCH] Remove unused code in l10ntools. --- l10ntools/inc/xmlparse.hxx

Re: [PUSHED][PATCH] Remove unused code (l10ntools)

2012-03-27 Thread Caolán McNamara
On Tue, 2012-03-27 at 21:20 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code (scaddins)

2012-03-26 Thread Caolán McNamara
On Fri, 2012-03-23 at 21:42 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code (vlc)

2012-03-26 Thread Caolán McNamara
On Fri, 2012-03-23 at 22:07 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code (xmloff)

2012-03-26 Thread Caolán McNamara
On Sat, 2012-03-24 at 01:03 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy great, pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] remove unused code (oox)

2012-03-26 Thread Caolán McNamara
On Sun, 2012-03-25 at 20:43 +0200, Petr Vorel wrote: Hi there, removed some code from oox. Pushed, looks good. I suspect that this will have a bit of a cascade effect and a pile more stuff will become available for removal on the next run. C. ___

[PATCH] Remove unused code (svtools)

2012-03-25 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 08525faa466535c5f10bcd413199351f5d953975 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Sun, 25 Mar 2012 18:24:32 +0200 Subject: [PATCH] Remove unused code in svtools. --- svtools/source/filter/wmf

[PATCH] remove unused code (oox)

2012-03-25 Thread Petr Vorel
Hi there, removed some code from oox. Regards, Petr From e04049e2554a94ce80dc21dfe390e91c8fd8bc41 Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Thu, 22 Mar 2012 20:14:13 +0100 Subject: [PATCH] remove unused code (oox) --- oox/source/ole/vbaprojectfilter.cxx | 13

[PATCH] Remove unused code (scaddins)

2012-03-23 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 00975e8dec9da11e13b4523d1d9e918bac5f5222 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Fri, 23 Mar 2012 21:37:59 +0100 Subject: [PATCH] Remove unused code in scaddins. --- scaddins/source/datefunc

[PATCH] Remove unused code (vlc)

2012-03-23 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 8d0dca528f9cb12dc8e5cdb2f2c1dcaf2270a04f Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Fri, 23 Mar 2012 22:05:00 +0100 Subject: [PATCH] Remove unused code in vlc. --- unusedcode.easy |1

[PATCH] Remove unused code (xmloff)

2012-03-23 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From a934503727e8f8970695d3a61f78e7e2d66ce137 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Sat, 24 Mar 2012 01:01:49 +0100 Subject: [PATCH] Remove unused code in xmloff. --- unusedcode.easy

Re: [PUSHED][PATCH] Remove unused code

2012-03-20 Thread Caolán McNamara
On Fri, 2012-03-16 at 20:20 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-20 Thread Caolán McNamara
On Sun, 2012-03-18 at 14:40 +0100, Petr Vorel wrote: Hi there, some unused code removed (oox, sc). Looks good to me, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code

2012-03-20 Thread Caolán McNamara
On Sat, 2012-03-17 at 15:34 +0100, Chr. Rossmanith wrote: Hi, I had a look at unusedcode.easy (sdext/presenter) and removed a little bit more than mentioned there: as there are no end callbacks added (AddEndCallback() was unused), there is no need to run them - RunEndCallbacks() could be

Re: [PUSHED][PATCH] Remove unused code (sdext)

2012-03-20 Thread Caolán McNamara
On Sat, 2012-03-17 at 21:03 +0100, Chr. Rossmanith wrote: Hi, some more code removal. Looks good, pushed this now. Probably the private variable maTransform can be removed as well: it is initialized with the identity transform and never changed afterwards. Does that suggest that the

Re: [PUSHED][PATCH] Remove unused code (sdext)

2012-03-20 Thread Chr. Rossmanith
Hi, Probably the private variable maTransform can be removed as well: it is initialized with the identity transform and never changed afterwards. Does that suggest that the actual call to mxSprite-transform(maTransform) is actually a no-op ? At least it doesn't change the position of mxSprite.

Re: [PUSHED][PATCH] Remove unused code

2012-03-20 Thread Caolán McNamara
On Tue, 2012-03-20 at 13:54 +, Caolán McNamara wrote: Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator ctor is never called, and its the only constructor, so one is never instantiated, so you can remove the whole thing without loss of functionality. Whoops, its

Re: [PUSHED][PATCH] Remove unused code (sdext)

2012-03-20 Thread Caolán McNamara
On Tue, 2012-03-20 at 15:24 +0100, Chr. Rossmanith wrote: At least it doesn't change the position of mxSprite. Only the cpu is a little less idle :-) Then I'll continue to remove maTransform? Or should it be kept for future use? I'm not a fan of some day we'll use it, ditch it if it

Re: [PUSHED][PATCH] Remove unused code (sdext)

2012-03-20 Thread Michael Meeks
On Tue, 2012-03-20 at 15:07 +, Caolán McNamara wrote: I've a shed full of stuff I can't throw out just in case some day we need it. Not that removing stuff from sdext will give me more space in my shed I suppose. :-) I have a similar shed - I can't get into it either ;-) but I

[PATCH] remove unused code (oox, sc)

2012-03-18 Thread Petr Vorel
Hi there, some unused code removed (oox, sc). Regards, Petr From 3c03ddd6eb8e0cefa229f3874e3da35bd0a57788 Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Sat, 17 Mar 2012 20:25:52 +0100 Subject: [PATCH 1/2] remove unused code (oox, sc) --- oox/inc/oox/dump/dumperbase.hxx

[PATCH] Remove unused code

2012-03-17 Thread Chr. Rossmanith
Hi, I had a look at unusedcode.easy (sdext/presenter) and removed a little bit more than mentioned there: as there are no end callbacks added (AddEndCallback() was unused), there is no need to run them - RunEndCallbacks() could be removed as well. Same logic for start callbacks. Finally

[PATCH] Remove unused code (sdext)

2012-03-17 Thread Chr. Rossmanith
...@web.de Date: Sat, 17 Mar 2012 20:57:16 +0100 Subject: [PATCH] Remove unused code (sdext) --- sdext/source/presenter/PresenterController.cxx |5 - sdext/source/presenter/PresenterController.hxx |1 - sdext/source/presenter/PresenterGeometryHelper.cxx | 19

[PATCH] Remove unused code

2012-03-16 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From e2ce9edf1b94bff6443257b875fa13255ac71e81 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Fri, 16 Mar 2012 20:12:53 +0100 Subject: [PATCH] Remove unused code as listed in unusedcode.easy --- .../source

[PATCH] remove unused code (oox, sd)

2012-03-15 Thread Petr Vorel
Hi there, remove some unused code in oox and sd. Regards, Petr From 2cc831282d53c3a14dd10fc8cb190f1d15df3354 Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Thu, 15 Mar 2012 11:40:15 +0100 Subject: [PATCH] remove unused code (oox, sd) --- oox/inc/oox/helper

Re: [PUSHED][PATCH] Remove unused code in drawingml

2012-03-14 Thread Caolán McNamara
On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: Hi! These patches remove unused code as listed in unusedcode.easy Looks good, pushed now. Thanks for these. If I'm not wrong, this is you first submission ? If so, can you add yourself to

Re: [PUSHED][PATCH] Remove unused code in drawingml

2012-03-14 Thread Mariana Marasoiu
On Wed, Mar 14, 2012 at 6:46 PM, Caolán McNamara caol...@redhat.com wrote: On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: Hi! These patches remove unused code as listed in unusedcode.easy Looks good, pushed now. Thanks for these. If I'm not wrong, this is you first submission ?

[PATCH] Remove unused code in drawingml

2012-03-13 Thread Mariana Marasoiu
Hi! These patches remove unused code as listed in unusedcode.easy Mariana Marasoiu From 2fa32c691f2af987bb32bff8b9b3f940c90b08aa Mon Sep 17 00:00:00 2001 From: Mariana Marasoiu mariana.maras...@gmail.com Date: Wed, 14 Mar 2012 01:07:16 +0200 Subject: [PATCH 1/4] Remove unused code in drawingml.

[PATCH] Remove unused code

2012-03-12 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 1d2ad5f05d4b415df6ff636c7f62c9ba1ea4a1bf Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Mon, 12 Mar 2012 19:04:03 +0100 Subject: [PATCH] Remove unused code in dpcache --- sc/inc/dpcache.hxx

[PATCH] Remove unused code in dptabres

2012-03-12 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 2552218909dbee683a87c3052d1c4dd85b4a58fe Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Mon, 12 Mar 2012 19:22:44 +0100 Subject: [PATCH] Remove unused code in dptabres --- sc/inc/dptabres.hxx

[PATCH] Remove unused code in dpitemdata

2012-03-12 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 585721f333baa53199ab2dbe36964e5759b3089a Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Mon, 12 Mar 2012 20:38:51 +0100 Subject: [PATCH] Remove unused code in dpitemdata --- sc/inc/dpitemdata.hxx

Re: [PUSHED][PATCH] remove unused code

2012-03-11 Thread Ivan Timofeev
Hi Petr, On 09.03.2012 11:39, Petr Vorel wrote: another patch removing unused code. Actually I need an advice this time. Is method oox::core::XmlFilterBase::getChartConverter() really unused / unwanted? As it's used in Shape::finalizeXShape (oox/source/drawingml/shape.cxx). So feel free to drop

[PATCH] remove unused code

2012-03-08 Thread Petr Vorel
really rely on the tool which generates unusedcode.easy? Regards, Petr From 94f6485cdfd7e87af6c432708c16aed061a8c2cb Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Thu, 8 Mar 2012 16:11:03 +0100 Subject: [PATCH] remove unused code --- oox/inc/oox/core/xmlfilterbase.hxx

[PATCH] Remove unused code

2012-03-07 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 7b4e4199bdf631796f69813e60c296b0a0561e0c Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Wed, 7 Mar 2012 20:32:25 +0100 Subject: [PATCH] Remove unused code --- connectivity/inc/connectivity/dbcharset.hxx

[PATCH] Remove unused code in vbahelper

2012-03-07 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.eas From 4299bf917c9ac0c02dd5aecc8b40e09e775136f6 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Wed, 7 Mar 2012 20:54:46 +0100 Subject: [PATCH] Remove unused code in vbahelper --- unusedcode.easy

[PATCH] Remove unused code(2)

2012-03-07 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 19f0c3ee363967fdd01601d640aff69c705b0303 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Wed, 7 Mar 2012 21:32:29 +0100 Subject: [PATCH] Remove unused code in vbahelper --- unusedcode.easy

[PATCH] Remove unused code(3)

2012-03-07 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 5ad94b05322b615da580027ed99e8a4e7ca68a51 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Wed, 7 Mar 2012 21:46:11 +0100 Subject: [PATCH] Remove unused code as listed in unusedcode.easy --- sc/source/ui/vba

Re: [Pushed] [PATCH] Remove unused code in vbahelper

2012-03-07 Thread Muthu Subramanian K
Pushed. On 03/08/2012 01:27 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.eas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Pushed] [PATCH] Remove unused code

2012-03-07 Thread Muthu Subramanian K
Pushed. On 03/08/2012 01:05 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Pushed] [PATCH] Remove unused code(3)

2012-03-07 Thread Muthu Subramanian K
Pushed. On 03/08/2012 02:19 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Pushed] [PATCH] Remove unused code(2)

2012-03-07 Thread Muthu Subramanian K
Pushed. On 03/08/2012 02:07 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (23)

2012-03-05 Thread Elton Chung
Hi, This patch removes 2 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email: el...@layerjet.com

[PATCH] Remove unused code (22)

2012-03-04 Thread Elton Chung
Hi, This patch removes 12 unused methods. Best Regards, Elton Remove-unused-code-22.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] remove unused code

2012-03-04 Thread Petr Vorel
Another unused code removed. From 226fccc7f2fd022ed9d329ac9c6bb373fbeff265 Mon Sep 17 00:00:00 2001 From: Petr Vorel petr.vo...@gmail.com Date: Sat, 3 Mar 2012 02:16:31 +0100 Subject: [PATCH] remove unused code --- oox/inc/oox/helper/binaryinputstream.hxx |4 oox/inc/oox/helper

[PATCH] Remove unused code (21)

2012-03-01 Thread Elton Chung
Hi, This patch removes 5 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com

Re: [PUSHED][PATCH] Remove unused code in BiffObjLineModel

2012-02-28 Thread Caolán McNamara
On Mon, 2012-02-27 at 20:10 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code in BiffInputStream

2012-02-28 Thread Caolán McNamara
On Mon, 2012-02-27 at 21:10 +0100, Santiago Martinez wrote: Hi, i'm not sure if this patch is correct so please review. I deleted BiffInputStream::sizeBase(), skipByteString(bool) and skipUniString() methods listed in unusedcode.easy. But also deleted another two methods (skipUniStringBody and

[PATCH] Remove unused code in BiffObjLineModel

2012-02-27 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 038875906820927ecb026f16db40ab3621e8a58d Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Mon, 27 Feb 2012 20:07:47 +0100 Subject: [PATCH] Remove unused code in BiffObjLineModel. --- oox/inc/oox/xls

[PATCH] Remove unused code (19)

2012-02-24 Thread Elton Chung
Hi, This patch removes 14 unused methods. Best Regards, Elton Remove-unused-code-19.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (20)

2012-02-24 Thread Elton Chung
Hi, This patch removes 20 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email: el...@layerjet.com

[PATCH] Remove unused code in ScUserList

2012-02-22 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 6c990c918ee985ee22ab432aa46f51823ed0ef24 Mon Sep 17 00:00:00 2001 From: Santiago Martinez smvar...@gmail.com Date: Wed, 22 Feb 2012 21:38:16 +0100 Subject: [PATCH] Remove unused code in ScUserList --- sc/inc/userlist.hxx

  1   2   >