Re: CppunitTest_sw_filters_test failing on x86 Linux, std::exception -> uno::RuntimeException

[Stephan Bergmann]

On 10/04/18 10:12, Stephan Bergmann wrote:

On 10/04/18 09:14, Stephan Bergmann wrote:

I'll take care.


 "Adapt remaining cpp_uno bridges 
to #i114635#"


...and 
 
" Revert '32bit Linux tests fail'"

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: CppunitTest_sw_filters_test failing on x86 Linux, std::exception -> uno::RuntimeException

[Stephan Bergmann]

On 10/04/18 09:14, Stephan Bergmann wrote:

I'll take care.


 "Adapt remaining cpp_uno bridges 
to #i114635#"

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: CppunitTest_sw_filters_test failing on x86 Linux, std::exception -> uno::RuntimeException

[Stephan Bergmann]

On 09/04/18 17:06, Caolán McNamara wrote:

On Wed, 2018-04-04 at 21:37 +, Luke Benes wrote:

After commit https://cgit.freedesktop.org/libreoffice/core/commit/?id
=975884fbbc3f80a634258ee562037688a42027a9

ofz#7110 ensure join is called on std::exceptions as well as
uno::Exception

Both gcc and clang are failing on my 32 bit Fedora box.


huh, I was unaware of that. Seems that tinderbox isn't the mailing
kind. Works under x86_64 (obviously, passed ci) so I don't quite know
what's going on there. For the moment does simply removing that test
case make it pass again (https://gerrit.libreoffice.org/#/c/52643/) ?

caolanm->sberg: that should have worked, right ? I see gcc3_linux_x86-
64/uno2cpp.cxx has explicit catch (std::exception) from
0166b35fc660911c02d56852fca79f89e7cede5c #i114635# handle non-UNO
exceptions in C++ UNO bridge, for unxlngx6, rest to follow.

Is it the case that the x86 bridge never got extended the same way
after all ?


Calling cppu::getCaughtException on non-UNO exceptions (and relying on 
the C++ UNO bridge called internally by that to translate those to 
RuntimeException) is a bit of a stretch.  And it turns out 
 "C++ UNO bridge 
should convert non-UNO exceptions into RuntimeException" had indeed 
never been implemented at least for 
bridges/source/cpp_uno/gcc3_linux_intel.  But the current state is a 
convincing argument to port that trivial fix also to the bridge variants 
that are still missing it.  I'll take care.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: CppunitTest_sw_filters_test failing on x86 Linux, std::exception -> uno::RuntimeException

[Caolán McNamara]

On Wed, 2018-04-04 at 21:37 +, Luke Benes wrote:
> After commit https://cgit.freedesktop.org/libreoffice/core/commit/?id
> =975884fbbc3f80a634258ee562037688a42027a9
> 
> ofz#7110 ensure join is called on std::exceptions as well as
> uno::Exception
> 
> Both gcc and clang are failing on my 32 bit Fedora box.

huh, I was unaware of that. Seems that tinderbox isn't the mailing
kind. Works under x86_64 (obviously, passed ci) so I don't quite know
what's going on there. For the moment does simply removing that test
case make it pass again (https://gerrit.libreoffice.org/#/c/52643/) ?

caolanm->sberg: that should have worked, right ? I see gcc3_linux_x86-
64/uno2cpp.cxx has explicit catch (std::exception) from
0166b35fc660911c02d56852fca79f89e7cede5c #i114635# handle non-UNO
exceptions in C++ UNO bridge, for unxlngx6, rest to follow. 

Is it the case that the x86 bridge never got extended the same way
after all ?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

CppunitTest_sw_filters_test failing on x86 Linux

[Luke Benes]

After commit 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=975884fbbc3f80a634258ee562037688a42027a9

ofz#7110 ensure join is called on std::exceptions as well as uno::Exception

Both gcc and clang are failing on my 32 bit Fedora box. The x86 Tinderboxes 
have also been failing since this commit. For a sample tinderbox log: 
https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER=1522779601.11309


The following is my build log: 

Testing file:///home/luke/core/sw/qa/core/data/ooxml/fail/EDB-36788-1.docx:
Tested file:///home/luke/core/sw/qa/core/data/ooxml/fail/EDB-36788-1.docx: Fail 
(277ms)
Testing file:///home/luke/core/sw/qa/core/data/ooxml/fail/ofz4825-1.docx:

No core file identified in directory 
/home/luke/core/workdir/CppunitTest/sw_filters_test.test.core
To show backtraces for crashes during test execution,
enable core files with:

   ulimit -c unlimited


Error: a unit test failed, please do one of:

make CppunitTest_sw_filters_test CPPUNITTRACE="gdb --args"
# for interactive debugging on Linux

/home/luke/core/solenv/gbuild/CppunitTest.mk:114: recipe for target 
'/home/luke/core/workdir/CppunitTest/sw_filters_test.test' failed
make[1]: *** [/home/luke/core/workdir/CppunitTest/sw_filters_test.test] Error 1
Makefile:282: recipe for target 'build' failed
make: *** [build] Error 2

Note after several hours, I had to manually kill the CppunitTest processes as 
it appeared to be stuck in an infinite loop. Not sure if the Tinderboxes have a 
watchdog or are failing differently. 




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice