Re: [GSoC 2012][Collaboration] unit test story
Hi Matúš, On Thursday, 2012-07-26 09:39:43 +0200, Matúš Kukan wrote: I thought that 1-1 collaboration works quite like expected (you get a file on start.. now also you see contacts dialog updated when someone goes on/offline (both does not seem to work for gmail accounts though!)), So I was going to work on MUC collaboration but found out that it does not work at all. Then found out it's the same for 1-1. Huh, it looked like it worked but didn't? ;-) I have tried to install .service and .client files at some time and they broke it, I need to investigate why. In unit test we use different service name. So - I'd like to change this and revert 5edcd7fa12c69c5b27d6b317f380f266f292008d Eike, would that be fine ? I am not sure what for was that.. to be able to run unit test while real LibO is running ? Yes, shouldn't be used in any other case. Would we want that ? Well, apparently I needed it somehow during that time.. problem is you can't register two instances for the same DBus name, so I had to shut down real instance to run test, fire up again, ... probably was tired of that ;-) So yes, you can revert that commit, but check the LIBO_DTUBE_SERVICE name definition, after reverting instead of org.libreoffice.calc it would be something ending in LibreOfficeTeleTest that surely is not correct :) And we may need TeleManager::getFullObjectPath() that would be removed as well when reverting. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgprx9epzKIxN.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSoC 2012][Collaboration] unit test story
Hi Matúš, On Thursday, 2012-07-26 11:17:41 +0200, Eike Rathke wrote: I am not sure what for was that.. to be able to run unit test while real LibO is running ? Yes, shouldn't be used in any other case. Would we want that ? Well, apparently I needed it somehow during that time.. problem is you can't register two instances for the same DBus name There's one reason why to keep this or a similar mechanism: the build would fail in the unit test when you have a Telepathy enabled office running. Which in future might be the default case ;-) Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpfO2qd0L6kO.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSoC 2012][Collaboration] unit test story
On 26 July 2012 11:23, Eike Rathke er...@redhat.com wrote: I am not sure what for was that.. to be able to run unit test while real LibO is running ? Yes, shouldn't be used in any other case. Would we want that ? Well, apparently I needed it somehow during that time.. problem is you can't register two instances for the same DBus name There's one reason why to keep this or a similar mechanism: the build would fail in the unit test when you have a Telepathy enabled office running. Which in future might be the default case ;-) That's unfortunate ;-( Then how can we test something we are currently using ? I guess I will keep it's functionality but not use it for now, I am not sure what's best now. Thanks, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSoC 2012][Collaboration] unit test story
Hi Matúš, On Thursday, 2012-07-26 12:04:03 +0200, Matúš Kukan wrote: There's one reason why to keep this or a similar mechanism: the build would fail in the unit test when you have a Telepathy enabled office running. Which in future might be the default case ;-) That's unfortunate ;-( Then how can we test something we are currently using ? I guess I will keep it's functionality but not use it for now, I am not sure what's best now. I think we can get away with keeping the functionality but adding a suffix in the test only if a suffix define is passed to the test, that could depend on the presence of an installed liboapprover or org.freedesktop.Telepathy.Client.LibreOffice.service file. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpF8AO10sOE8.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
