Re: [Libreoffice] [PATCH] Bug 39168

2011-08-11 Thread Noel Power
On 10/08/11 18:44, Jenei Gábor wrote: Hello Noel, Well, I just like more if{ linefeedcodelinefeed } form even is code is just one line long, but you are right there are no rules about this, but it is the convention to at least follow the pattern already used in the source file otherwise

Re: [Libreoffice] [PATCH] Bug 39168

2011-08-10 Thread Noel Power
Hi Jenei On 08/08/11 11:06, Jenei Gábor wrote: Hello, I would like to inform everyone that I attached my purposed patch that fixes the bug 39168 in our bug report page, since it causes an already mentioned problem in the overwriting dialog's popup I don't consider it as something stable,

Re: [Libreoffice] [PATCH] Bug 39168

2011-08-10 Thread Jenei Gábor
Hello Noel, Well, I just like more if{ linefeedcodelinefeed } form even is code is just one line long, but you are right, it still works(and maybe also nicer to leave it) without { and } As for the other comments, probably you're right that it's not the best solution, I just haven't