Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String

2012-01-17 Thread Caolán McNamara
On Tue, 2012-01-17 at 11:06 +0100, Chr. Rossmanith wrote: Hi, an excursion from vcl to unotools was necessary. Could someone please review this little patch? xub_StrLen is replaced as well with sal_Int32. You'll have to change the callers of RecodeString

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String

2012-01-17 Thread Stephan Bergmann
On 01/17/2012 11:06 AM, Chr. Rossmanith wrote: an excursion from vcl to unotools was necessary. Could someone please review this little patch? xub_StrLen is replaced as well with sal_Int32. Two things about the patch: -void ConvertChar::RecodeString( String rStr, xub_StrLen nIndex,

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String

2012-01-17 Thread Chr. Rossmanith
Hi Caolan and Stephan, Am 17.01.2012 13:40, schrieb Caolán McNamara: On Tue, 2012-01-17 at 11:06 +0100, Chr. Rossmanith wrote: an excursion from vcl to unotools was necessary. Could someone please review this little patch? xub_StrLen is replaced as well with sal_Int32. You'll have to change

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String

2012-01-17 Thread Chr. Rossmanith
Hi, this is a modified version of the previous patch which takes into account improvements suggested by Caolan and Stephan. Please don't push yet because the caller of RecodeString() has to be touched as well. Does that modification have to be contained in the same patch or do I just have to

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String

2012-01-17 Thread Stephan Bergmann
On 01/17/2012 09:45 PM, Chr. Rossmanith wrote: this is a modified version of the previous patch which takes into account improvements suggested by Caolan and Stephan. Please don't push yet because the caller of RecodeString() has to be touched as well. Does that modification have to be contained

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-04 Thread Stephan Bergmann
On 10/03/2011 04:48 PM, Chr. Rossmanith wrote: One improvement suggested by Norbert on IRC: using OUString instead of ::rtl::OUString. What is the preferred syntax using ::rtl::OUString at the beginning of the file and OUString throughout the remaining source code or ::rtl::OUString

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-03 Thread Michael Meeks
Hi Christina, On Sun, 2011-10-02 at 20:52 +0200, Chr. Rossmanith wrote: could someone please review this small patch. I'll extend the replacement (and push on my own) but want to be sure that there are no mistakes. At least it seems to build :-) Looks great to me :-)

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-03 Thread Caolán McNamara
On Mon, 2011-10-03 at 10:07 +0100, Michael Meeks wrote: Hi Christina, On Sun, 2011-10-02 at 20:52 +0200, Chr. Rossmanith wrote: could someone please review this small patch. I'll extend the replacement (and push on my own) but want to be sure that there are no mistakes. At least it

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-03 Thread Chr. Rossmanith
One improvement suggested by Norbert on IRC: using OUString instead of ::rtl::OUString. What is the preferred syntax using ::rtl::OUString at the beginning of the file and OUString throughout the remaining source code or ::rtl::OUString everywhere in the source code. Christina Am

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-03 Thread Norbert Thiebaud
On Mon, Oct 3, 2011 at 9:48 AM, Chr. Rossmanith chrrossman...@gmx.de wrote: One improvement suggested by Norbert on IRC: using OUString instead of ::rtl::OUString. What is the preferred syntax Note: I don't know what is the 'preferred' way, I just noticed that there was a mix of the 2 notations