Re: [Libreoffice] [PATCH] new BUG 36594

2011-09-02 Thread Eike Rathke
Hi Jenei, On Thursday, 2011-09-01 22:08:33 +0200, Jenei Gábor wrote: LibreOffice Base if you turn on running SQL query in SQL edit view it will pass the SQL query directly to HSQL without any type of modification, or check, so if you push this button it should work totally as a HSQL prompt.

Re: [Libreoffice] [PATCH] new BUG 36594

2011-09-02 Thread Jenei Gábor
well, yes I forgot about that query even may change in translate statement, so to store the positions is not always a good solution, you are right. Maybe we could simply put the comments after the query string, still the user is able to store comments, and the query is ok, however the original

Re: [Libreoffice] [PATCH] new BUG 36594

2011-09-02 Thread Eike Rathke
Hi Jenei, On Friday, 2011-09-02 10:40:11 +0200, Jenei Gábor wrote: well, yes I forgot about that query even may change in translate statement, so to store the positions is not always a good solution, you are right. Maybe we could simply put the comments after the query string, still the user

Re: [Libreoffice] [PATCH] new BUG 36594

2011-09-01 Thread Eike Rathke
Hi Jenei, On Wednesday, 2011-08-31 12:59:06 +0200, Jenei Gábor wrote: Hello Eike, I made the changes you said, and I resolved the no linefeed issue also, I hope it is ok now, and can be pushed, actually for me worked fine with all types of comments. Also I tried to follow the principals

Re: [Libreoffice] [PATCH] new BUG 36594

2011-09-01 Thread Jenei Gábor
Well, as I know for HSQL -- and // are equal, so // is like one line comment in C++. Well,thanks for your work on the other hand :) Gabor 2011. 09. 01. 20:15 keltezéssel, Eike Rathke írta: Hi Jenei, On Wednesday, 2011-08-31 12:59:06 +0200, Jenei Gábor wrote: Hello Eike, I made the changes

Re: [Libreoffice] [PATCH] new BUG 36594

2011-09-01 Thread Eike Rathke
Hi Jenei, On Thursday, 2011-09-01 20:31:11 +0200, Jenei Gábor wrote: Well, as I know for HSQL -- and // are equal, so // is like one line comment in C++. Hmm.. ok. Btw, this +if(sCopy[i]=='\n' || i==nQueryLen-1){ +nCommentLen++; +

Re: [Libreoffice] [PATCH] new BUG 36594

2011-09-01 Thread Jenei Gábor
Well, if you are using linux you could get mysql and its client from apt on Debian based systems(I guess on redhat based systems you can use yum), well, the plus linefeed is not really intentional but does not cause any problem, so I didn't mind too much. But also in LibreOffice Base if you