Re: [Libreoffice] [PUSHED] Re: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi
On Wed, 2010-11-17 at 21:58 +0100, Pierre-André Jacquod wrote: Hello, I saw it too, this allow me to rize a question. My firt though was to remove this one - since commentted out - but I left it there not knowing if this was a way to handle this here.? For my taste, I would have remove it. - Debug it at home, not on public branch... Your input? Yeah. Though for perfection I'd like to see a cppunit test that gets build and executed at runtime to always test whatever that wants to test. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi
Hello, I saw it too, this allow me to rize a question. My firt though was to remove this one - since commentted out - but I left it there not knowing if this was a way to handle this here.? For my taste, I would have remove it. - Debug it at home, not on public branch... Your input? regards On 11/17/2010 05:39 PM, Caolán McNamara wrote: On Tue, 2010-11-16 at 22:50 +0100, Pierre-André Jacquod wrote: regards heh, I had a bit of a moment when I saw file:///d:/777/Encrypted/picture in there before I realized this is someones debugging code with an if (0) around it. Anyway, that's beside the point. Your changes were good, thanks for them, now pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
