Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-10 Thread Norbert Thiebaud
On Sat, Sep 10, 2011 at 12:52 AM, Korrawit Pruegsanusak wrote: > Hello all, > > On Fri, Sep 9, 2011 at 14:03, Fridrich Strba > wrote: >> On Fri, 2011-09-09 at 07:23 +0200, Herbert Duerr wrote: >>> getting rid of the related UNO API would also be a good idea if there >>> wasn't the "UNO API semper

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-09 Thread Korrawit Pruegsanusak
Hello all, On Fri, Sep 9, 2011 at 14:03, Fridrich Strba wrote: > On Fri, 2011-09-09 at 07:23 +0200, Herbert Duerr wrote: >> getting rid of the related UNO API would also be a good idea if there >> wasn't the "UNO API semper fi" mantra. > > No such mantra in the LibreOffice world I guess :) So so

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-09 Thread Fridrich Strba
Hello, Herbert, On Fri, 2011-09-09 at 07:23 +0200, Herbert Duerr wrote: > getting rid of the related UNO API would also be a good idea if there > wasn't the "UNO API semper fi" mantra. No such mantra in the LibreOffice world I guess :) F. ___ LibreO

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Herbert Duerr
Hi, (a.nChar1 < b.nChar1) || ((a.nChar1 == a.nChar2) && (a.nChar2 < b.nChar2)) ? Somehow, that expression still looks suspicious. (At least, it does not implement a lexicographical less-than relation. Not sure whether it should or not, however.) It should not indeed. On the other hand Output

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Korrawit Pruegsanusak
Hello Eike, Stephan, * On Thu, Sep 8, 2011 at 17:23, Eike Rathke wrote: > It didn't occur to me that the original expression > actually would had been wrong at two places.. Also for me too. My bad for didn't notice it. > On Thursday, 2011-09-08 08:40:24 +0200, Stephan Bergmann wrote: >> Now act

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Eike Rathke
Hi Stephan, On Thursday, 2011-09-08 08:40:24 +0200, Stephan Bergmann wrote: > On 09/08/2011 08:18 AM, Stephan Bergmann wrote: > >Korrawit, Eike, did you check the context to verify that it should > >really read > > > >a.nChar1 == a.nChar2 > > > >instead of > > > >a.nChar1 == b.nChar1 > > > >in th

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-07 Thread Stephan Bergmann
On 09/08/2011 08:18 AM, Stephan Bergmann wrote: On 09/08/2011 01:44 AM, Eike Rathke wrote: Hi Korrawit, On Wednesday, 2011-09-07 22:01:09 +0700, Korrawit Pruegsanusak wrote: Attached patch will clear the cppcheck warning for duplicate expression on both sides of '<'. Yup, good catch! http:/

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-07 Thread Stephan Bergmann
On 09/08/2011 01:44 AM, Eike Rathke wrote: Hi Korrawit, On Wednesday, 2011-09-07 22:01:09 +0700, Korrawit Pruegsanusak wrote: Attached patch will clear the cppcheck warning for duplicate expression on both sides of '<'. Yup, good catch! http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-07 Thread Eike Rathke
Hi Korrawit, On Wednesday, 2011-09-07 22:01:09 +0700, Korrawit Pruegsanusak wrote: > Attached patch will clear the cppcheck warning for duplicate > expression on both sides of '<'. Yup, good catch! http://cgit.freedesktop.org/libreoffice/core/commit/?id=a58ed493e572fef2c503bd329e924bb062ba9c96