Re: [Libreoffice] Possible little code simplification

2011-11-29 Thread Ivan Timofeev
2011/11/28 Michael Stahl mst...@redhat.com: On 25/11/11 19:05, Ivan Timofeev wrote: Well, another possible memory optimization is to merge SwSortedObjsImpl into SwSortedObjs. What is the reason to use the pImpl pattern here? usually pImpl is a good idea because it is the only way to get

Re: [Libreoffice] Possible little code simplification

2011-11-28 Thread Michael Stahl
On 25/11/11 19:05, Ivan Timofeev wrote: Hello Michael, 2011/11/25 Michael Stahl mst...@redhat.com: On 24/11/11 19:07, Ivan Timofeev wrote: [...] What do you think about changing the code so that pSortedObjs will be alive every time? We will be able to return a reference to pSortedObjs in

Re: [Libreoffice] Possible little code simplification

2011-11-25 Thread Ivan Timofeev
Hello Michael, 2011/11/25 Michael Stahl mst...@redhat.com: On 24/11/11 19:07, Ivan Timofeev wrote: [...] What do you think about changing the code so that pSortedObjs will be alive every time? We will be able to return a reference to pSortedObjs in GetSortedObjs() instead of a pointer and