Re: [Libreoffice-commits] core.git: new uno sidebar api tdf#91806

2015-08-24 Thread Laurent Godard
Hi stephan Le 21/08/2015 14:46, Stephan Bergmann a écrit : I'm sorry this is a little late. But I think we're still fine, as this should until now only have hit master towards LO 5.1, and not any libreoffice-5-0 or earlier. here are the changes https://gerrit.libreoffice.org/#/c/17952/ i

Re: [Libreoffice-commits] core.git: new uno sidebar api tdf#91806

2015-08-21 Thread Stephan Bergmann
On 08/21/2015 03:25 PM, Laurent Godard wrote: +*/ +void setTitle( [in] string newTitle ); Is setTitle necessary and/or useful? (At least, none of the code in this commit appears to use it.) -- it allow changing the Deck title (as named) -- in UnoDeck.hxx

Re: [Libreoffice-commits] core.git: new uno sidebar api tdf#91806

2015-08-21 Thread Stephan Bergmann
I'm sorry this is a little late. But I think we're still fine, as this should until now only have hit master towards LO 5.1, and not any libreoffice-5-0 or earlier. On 06/22/2015 06:59 AM, Laurent Godard wrote: commit a64999511ae654131d997eec9a3d78478cfc1c75 Author: Laurent Godard

Re: [Libreoffice-commits] core.git: new uno sidebar api tdf#91806

2015-08-21 Thread Laurent Godard
Hi * about setTitle What I mean is: Is it supposed to be useful functionality that a client that has access to an XDeck instance can change its title? Or should the title rather be immutable and attached to the XDeck instance when it is created? I often wonder this when I see UNO interfaces

Re: [Libreoffice-commits] core.git: new uno sidebar api tdf#91806

2015-08-21 Thread Laurent Godard
Hi Stephan Thanks a lot for your review I'm sorry this is a little late. But I think we're still fine, as this should until now only have hit master towards LO 5.1, and not any libreoffice-5-0 or earlier. right I'll correct all of your points with (@since LibreOffice 5.1)