On Thu, 2012-02-23 at 13:03 +0000, Michael Meeks wrote: > Any thoughts Caolan ?
callcatcher is right, this is a *pure* virtual, i.e. the = 0 of virtual void dispose() = 0; Everything that inherits from it has to implement a ::dispose so there's a virtual method slot created for "dispose" and everything that inherits from it has to implement a ::dispose which'll be a virtual method. Typically you don't provide an implementation of a pure virtual, because you're forcing the inheritors to provide one, but if you *do* then that implementation itself isn't actually a virtual, and if you want to call it you have to explicitly call it. So, in this case, no one has explicitly called the baseclass pure virtual implementation, so the bodies can go, but to be safe the pure virtual declarations themselves should stay, i.e. http://cgit.freedesktop.org/libreoffice/core/commit/?id=84cc2688f429ef915810a3799f46ae98293096a6 C. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
