Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
Hi Matus, On Wed, 2012-02-15 at 01:05 +0100, Matúš Kukan wrote: > It's going quite well. With tml's patch [1] we can add more. > He is doing great job, mostly in the android branch as he already said. Cool :-) yep, I saw. > Current tail_build "blocker" is connectivity/. Peter was working on it > [2] but I don't know what's the status now. > Of course there are also lot more. Ah - ok, good to know. > Well, I think there is already (or will be in the near future) quite much. > What do you intend to do with libmerged ? You are asking on the status > quite often. What's your next move ? :) Well, I'm building and running with it myself on Linux; so far it seems that libmergedlo.so is only 5.1Mb - which surprises me, since my libsvx* are both rather huge. As/when we have really a lot of code in there, I was going to poke Jan H. again to see if we could borrow some more of his cycles wrt. LTO on it - but for that I'd like to have something impressive ;-) "world's biggest shared library" is nearly that (perhaps). Anyhow - that was my plan ;-) Thoughts ? Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
Hi Tor, On Tue, 2012-02-14 at 19:23 +0200, Tor Lillqvist wrote: > In the feature/android branch I have added the fw[eiklm], sfx, sb, svt > and tk libraries to libmerged. Working on verifying that the last > addition didn't break anything; I found a nice direct reference to the > name "tk" in > http://opengrok.libreoffice.org/xref/core/vcl/source/app/svapp.cxx#1541 :-) right; one of those beautiful things the toolkit does. > ... Still haven't been able to get a master MSVC build with > --enable-mergelibs and an enlarged merging to complete, but unsure > whether merging is something we want on Windows or not anyway, there > seems to be differing opinons... Ok. > I also merged sal and sal_textenc (in the --enable-mergelibs case). Hmm - I think we did this to death already. I guess we want a "one library" case, that does the things like this that will only ever make sense on iOS (in the one big library) world. It brings only slowness for everything else. Anyhow - thanks ! Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
> I wasn't sure about the status of --enable-mergelibs, whether it is only > something Android-specific or whether it is also used to enable that general > merge/LTO endeavor. I don't know either, really. But anyway, I will make the sal_textenc+sal merge Android-specific and not mergelibs-specific;) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
On 02/15/2012 03:11 PM, Tor Lillqvist wrote: I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, Well, --enable-mergelibs is probably actually intended for Android only, I think? I wasn't sure about the status of --enable-mergelibs, whether it is only something Android-specific or whether it is also used to enable that general merge/LTO endeavor. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
> I'm not sure this is not counter-productive. For Android and iOS it might > be vital to get sal_textenc merged, Well, --enable-mergelibs is probably actually intended for Android only, I think? But sure, I can change the condition to check $(OS) instead. We desperately need to reduce the number of shared libraries used for Android thanks to the silly limit of 128 handled by the system dynamic loader, and sal_textenc seemed like a low-hanging fruit. (For iOS all our libraries are static archives anyway, merging has no meaning.) (Yes, that means UNO components won't be "loaded" in the current sense, but linked statically. Work in progress.) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
On 02/14/2012 06:23 PM, Tor Lillqvist wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, to reduce the overall number of dynamic libraries. But for other platforms, it was a deliberate move to break sal_textenc out of sal to reduce start up time. As it stands, sal_textenc requires lots of relocations in data segments that have to be done by loaders upfront at load time. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
> It was something more than this: ? Umm, no, that was it. Now I am confused, why don't I see that in my master checkout after merging the branch to master? Git is a mystery. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
On 15 February 2012 13:35, Tor Lillqvist wrote: > On 14 February 2012 19:23, Tor Lillqvist wrote: > >> I also merged sal and sal_textenc (in the --enable-mergelibs case). > > Hmm, I experimented with this but apparently didn't commit and then > did a git reset and lost the changes, or something. Will have a look > again if I still have the stuff in Emacs buffers... It was something more than this: ? http://cgit.freedesktop.org/libreoffice/core/commit/?h=feature/android&id=4866737a489d66fc2dc2153641390b609e1d5905 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
On 14 February 2012 19:23, Tor Lillqvist wrote: > I also merged sal and sal_textenc (in the --enable-mergelibs case). Hmm, I experimented with this but apparently didn't commit and then did a git reset and lost the changes, or something. Will have a look again if I still have the stuff in Emacs buffers... --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
On 14 February 2012 18:12, Michael Meeks wrote: > Nice ;-) I was wondering - how are we doing wrt. getting more of the > libraries into tail_build and libmerged ? :-) I wonder could we get > 'basic' into that ? svtools ? some of the 'helper' libraries ? :-) It's going quite well. With tml's patch [1] we can add more. He is doing great job, mostly in the android branch as he already said. [1] http://cgit.freedesktop.org/libreoffice/core/diff/sfx2/source/appl/appbas.cxx?id=25f8330004409edf8007df0cc80ef540c03d18da 'Helper' libraries would have to wait for more patches. > Presumably there are other choke-point modules blocking others from > being introduced into tail_build too ? Current tail_build "blocker" is connectivity/. Peter was working on it [2] but I don't know what's the status now. Of course there are also lot more. [2] http://cgit.freedesktop.org/libreoffice/core/log/?h=feature/gbuild_conversions Well, I think there is already (or will be in the near future) quite much. What do you intend to do with libmerged ? You are asking on the status quite often. What's your next move ? :) Best, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
> I was wondering - how are we doing wrt. getting more of the > libraries into tail_build and libmerged ? In the feature/android branch I have added the fw[eiklm], sfx, sb, svt and tk libraries to libmerged. Working on verifying that the last addition didn't break anything; I found a nice direct reference to the name "tk" in http://opengrok.libreoffice.org/xref/core/vcl/source/app/svapp.cxx#1541 ... Still haven't been able to get a master MSVC build with --enable-mergelibs and an enlarged merging to complete, but unsure whether merging is something we want on Windows or not anyway, there seems to be differing opinons... I also merged sal and sal_textenc (in the --enable-mergelibs case). --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
On Mon, 2012-02-13 at 23:21 +0100, Matúš Kukan wrote: > I'd like to push attached patch. Hopefully it will work also for > others and there is nothing wrong with removing TestExtension.rdb from > TestExtension.oxt. Nice ;-) I was wondering - how are we doing wrt. getting more of the libraries into tail_build and libmerged ? :-) I wonder could we get 'basic' into that ? svtools ? some of the 'helper' libraries ? :-) Presumably there are other choke-point modules blocking others from being introduced into tail_build too ? Anyhow - it's great to see your work there, Thanks ! Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?
On 02/13/2012 11:21 PM, Matúš Kukan wrote: On 12 February 2012 23:51, Matúš Kukan wrote: Do not push them without improvement, make check fails for me. Attached diff solves one problem but still there is something wrong. Well, I was fooled by smoketest/com/sun/star/comp/smoketest/makefile.mk There is javamaker involved, but the produced .class file does not end up in TestExtension.jar So the call to javamaker it's pointless ..whatever. Then I also tried to remove TestExtension.rdb from TestExtension.oxt and make check was also successful. So, can I remove TestExtension.idl file ? Anybody has opinion about this ? The TestExtension.rdb type library and the TestExtension.idl new-style service definition should indeed be unnecessary. The only use of the corresponding service is via BASIC createUnoService. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
