Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Tor Lillqvist
Tor - I had a feeling you were looking at some (MathML ?) detection issue that may be related to this (and/or fixed it already); Don't think so; the problem I looked at was caused by the MathML filter detecting *any* XML file as MathML, but then obviously failing to actually load it

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Kohei Yoshida
On Wed, Aug 15, 2012 at 12:40 AM, Kohei Yoshida kyosh...@novell.com wrote: On Tue, Aug 14, 2012 at 3:15 PM, Michael Meeks michael.me...@suse.com wrote: Thoughts ? It appears that the type detection asks SwFilterDetect::detect() to detect its type, and it returns empty handed, which

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Kohei Yoshida
On 08/15/2012 11:05 AM, Kohei Yoshida wrote: I'll go a little deeper in the type detection chain (I'm at SwIoSystem::IsFileFilter at the moment) to confirm this theory. I've now deduced it to aHdr.Load( *pStream ) (aHdr being StgHeader) in Storage::IsStorageFile() failing with Large-Word.doc,

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Kohei Yoshida
On 08/15/2012 12:02 PM, Kohei Yoshida wrote: On 08/15/2012 11:05 AM, Kohei Yoshida wrote: I'll go a little deeper in the type detection chain (I'm at SwIoSystem::IsFileFilter at the moment) to confirm this theory. I've now deduced it to aHdr.Load( *pStream ) (aHdr being StgHeader) in

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Kohei Yoshida
On 08/15/2012 12:05 PM, Kohei Yoshida wrote: On 08/15/2012 12:02 PM, Kohei Yoshida wrote: On 08/15/2012 11:05 AM, Kohei Yoshida wrote: I'll go a little deeper in the type detection chain (I'm at SwIoSystem::IsFileFilter at the moment) to confirm this theory. I've now deduced it to aHdr.Load(

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Kohei Yoshida
On 08/15/2012 12:12 PM, Kohei Yoshida wrote: Ah. Now I know. Ultimately the failure is due to StgHeader::Check() returning false on Large-Word.doc. http://opengrok.libreoffice.org/xref/core/sot/source/sdstor/stgelem.cxx#186 Changing this method to always return true leads to Writer loading

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Kohei Yoshida
On 08/15/2012 12:26 PM, Kohei Yoshida wrote: On 08/15/2012 12:12 PM, Kohei Yoshida wrote: Ah. Now I know. Ultimately the failure is due to StgHeader::Check() returning false on Large-Word.doc. http://opengrok.libreoffice.org/xref/core/sot/source/sdstor/stgelem.cxx#186 Changing this method

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Ivan Timofeev
Hi Kohei, On 15.08.2012 21:00, Kohei Yoshida wrote: On 08/15/2012 12:26 PM, Kohei Yoshida wrote: On 08/15/2012 12:12 PM, Kohei Yoshida wrote: Ah. Now I know. Ultimately the failure is due to StgHeader::Check() returning false on Large-Word.doc.

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-15 Thread Kohei Yoshida
On 08/15/2012 01:19 PM, Ivan Timofeev wrote: first 109 sectors are in the header anyway and nMaster are in FAT (if needed). nMaster should not be checked for 109. Hi Ivan, Thanks. Pushed the change to master. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: 3.6.0 regression: non-deterministic filter selection ...

2012-08-14 Thread Kohei Yoshida
On Tue, Aug 14, 2012 at 3:15 PM, Michael Meeks michael.me...@suse.com wrote: Thoughts ? It appears that the type detection asks SwFilterDetect::detect() to detect its type, and it returns empty handed, which eventually leads to it being detected as ascii text. I've tried a simple Word