Hi,
On Fri, Nov 08, 2019 at 09:05:12AM +0100, Stephan Bergmann wrote:
> Ah. What I'd meant was something like
>
> > #if ...
> > using AtomicCounter = std::atomic>;
> > static_assert(AtomicCounter::is_always_lock_free);
> > #else
> > using AtomicCounter = volatile std::make_unsigned_t;
> > #endif
On 07/11/2019 17:56, Rene Engelhard wrote:
On Thu, Nov 07, 2019 at 10:18:06AM +0100, Stephan Bergmann wrote:
I don't understand your "Given the introduced AtomicCounter is used
later..." reasoning above, but commented at
Obviously I meant
static AtomicCounter gnEnterCount;
which comes later
Hi,
On Thu, Nov 07, 2019 at 10:18:06AM +0100, Stephan Bergmann wrote:
> On 06/11/2019 18:39, Rene Engelhard wrote:
> > Given the introduced AtomicCounter is used later, too I tried the simplified
> >
> > diff --git a/vcl/inc/opengl/zone.hxx b/vcl/inc/opengl/zone.hxx
> > index 3210186c3096..13ac3b
On 06/11/2019 18:39, Rene Engelhard wrote:
Given the introduced AtomicCounter is used later, too I tried the simplified
diff --git a/vcl/inc/opengl/zone.hxx b/vcl/inc/opengl/zone.hxx
index 3210186c3096..13ac3bf6793e 100644
--- a/vcl/inc/opengl/zone.hxx
+++ b/vcl/inc/opengl/zone.hxx
@@ -36,7 +36,
Hi,
On Wed, Nov 06, 2019 at 09:26:53AM +0100, Stephan Bergmann wrote:
> > +// gnEnterCount and gnLeaveCount are accessed both from multiple
> > threads (cf.
> > +// OpenGLWatchdogThread::execute; so need to be of atomic type) and
> > from signal handlers (cf.
> > +// VCLExceptionSign
On 06/11/2019 10:47, rene.engelh...@mailbox.org wrote:
Am 6. November 2019 09:26:53 MEZ schrieb Stephan Bergmann :
, you could add an appropriate #if/else
(with
a useful comment) around the definition of AtomicCounter and the
accompanying static_assert.
Can do, yes, although I would like it mo
Hi,
Am 6. November 2019 09:26:53 MEZ schrieb Stephan Bergmann :
>don't make things worse than they originally were if we fall back to
>that type again on armel. So if the original code happened to work
>well
>enough on armel in practice
It built. No more data ;-)
, you could add an appropriat
[assuming
Cc: "libreoffice@lists.freedesktop.org Stephan Bergmann"
was a typo, and the original mail was meant to be sent to
libreoffice@lists.freedesktop.org]
On 06/11/2019 07:05, Rene Engelhard wrote:
LibreOffice 6.4.0 alpha1 was just accepted into Debian experimental and failed
on arm
