Re: Gerrit supports inline edit feature now

Agreed - thanks a bunch, I really appreciate the efforts you all put into maintaining and improving our gerrit and Jenkins experiences :-) Chris > On 8 Mar 2016, at 4:23 AM, Thorsten Behrens > wrote: > > David Ostrovsky wrote: >> Yesterday, the right Gerrit

Re: Gerrit supports inline edit feature now

David Ostrovsky wrote: > Yesterday, the right Gerrit version was deployed on gerrit.l.o. > Thanks a whole lot - to all of you for making this happen in the end. Way cool! :) Cheers, -- Thorsten signature.asc Description: Digital signature ___

Re: Gerrit supports inline edit feature now

Hi David, On Thu, Dec 18, 2014 at 09:34:24AM +0100, David Ostrovsky d.ostrov...@gmx.de wrote: I am looking forward to see Gerrit @ LibreOffice upgraded to upcoming 2.11 release that contains inline edit feature. We expect that contributors build their changes, test it manually and also run

Re: Gerrit supports inline edit feature now

On Thu, 2014-12-18 at 10:49 +0100, Miklos Vajna wrote: On Thu, Dec 18, 2014 at 09:34:24AM +0100, David Ostrovsky d.ostrov...@gmx.de wrote: I am looking forward to see Gerrit @ LibreOffice upgraded to upcoming 2.11 release that contains inline edit feature. We expect that contributors

Re: Gerrit supports inline edit feature now

Hi, On Thu, Dec 18, 2014 at 10:19:08AM +, Michael Meeks wrote: - // that sounds like a stupid idea + // actually this is really cool for small changes Also - we have various solutions to allow central compilation coming - right. ;-) Yes, inline editing is an

Re: Gerrit supports inline edit feature now

Hey, On Thu, Dec 18, 2014 at 11:47 AM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: Hi, On Thu, Dec 18, 2014 at 10:19:08AM +, Michael Meeks wrote: - // that sounds like a stupid idea + // actually this is really cool for small changes Also - we have

Re: Gerrit supports inline edit feature now

Hi, On Thu, Dec 18, 2014 at 11:55:35AM +0100, Markus Mohrhard wrote: IMHO our reviewers are already one of the weakest link in our development process as reviewing is normally only done by the people who have been working on the code for a long time and know the code quite well. So, if

Re: Gerrit supports inline edit feature now

On 18.12.2014 11:55, Markus Mohrhard wrote: Hey, On Thu, Dec 18, 2014 at 11:47 AM, Bjoern Michaelsen bjoern.michael...@canonical.com mailto:bjoern.michael...@canonical.com wrote: Hi, On Thu, Dec 18, 2014 at 10:19:08AM +, Michael Meeks wrote: - // that sounds like

Re: Gerrit supports inline edit feature now

On 12/18/2014 12:44 PM, Michael Stahl wrote: i disagree with your assessment of the feature. it will make things easier for reviewers, because if you spot a trivial typo in a patch you can just quickly fix it, you don't have to decide between downloading the patch and editing it offline and