Re: Review backlog

2015-08-17 Thread Eike Rathke
Hi, On Sunday, 2015-08-16 20:01:24 +1000, Luke Deller wrote: Another issue, is that for one review I had a +2 review and flattering comment, I was disappointed to realize that just rebasing (without any changes to the patch) clears the review status! Gerrit has a configuration option

Re: Review backlog

2015-08-17 Thread Ashod Nakashian
On Mon, Aug 17, 2015 at 10:57 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Mon, Aug 17, 2015 at 4:27 AM, Eike Rathke er...@redhat.com wrote: Hi, On Sunday, 2015-08-16 20:01:24 +1000, Luke Deller wrote: Another issue, is that for one review I had a +2 review and flattering

Re: Review backlog

2015-08-17 Thread Norbert Thiebaud
On Mon, Aug 17, 2015 at 4:27 AM, Eike Rathke er...@redhat.com wrote: Hi, On Sunday, 2015-08-16 20:01:24 +1000, Luke Deller wrote: Another issue, is that for one review I had a +2 review and flattering comment, I was disappointed to realize that just rebasing (without any changes to the

Re: Review backlog

2015-08-17 Thread Luke Deller
On 16 Aug 2015, at 9:34 am, Ashod Nakashian ashnak...@gmail.com wrote: Another issue, is that for one review I had a +2 review and flattering comment, I was disappointed to realize that just rebasing (without any changes to the patch) clears the review status! Gerrit has a

Re: Review backlog

2015-08-16 Thread Norbert Thiebaud
On Sun, Aug 16, 2015 at 10:48 AM, Ashod Nakashian ashnak...@gmail.com wrote: On Sun, Aug 16, 2015 at 1:14 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Sat, Aug 15, 2015 at 6:34 PM, Ashod Nakashian ashnak...@gmail.com wrote: In the past I've had a much better response upon

Re: Review backlog

2015-08-16 Thread Ashod Nakashian
On Sun, Aug 16, 2015 at 1:14 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Sat, Aug 15, 2015 at 6:34 PM, Ashod Nakashian ashnak...@gmail.com wrote: In the past I've had a much better response upon submitting patches, so I'm inclined to think everyone is busy (which I highly

Re: Review backlog

2015-08-16 Thread Ashod Nakashian
Thanks Norbert and Thorsten for great responses. All makes sense. On Sun, Aug 16, 2015 at 2:57 PM, Thorsten Behrens t...@documentfoundation.org wrote: Ashod Nakashian wrote: This is a point I'd like to address. At certain times jenkins acts up and fails builds randomly. Sure, happens

Re: Review backlog

2015-08-16 Thread Thorsten Behrens
Ashod Nakashian wrote: This is a point I'd like to address. At certain times jenkins acts up and fails builds randomly. Sure, happens (and sometimes master is broken on certain platforms) - but as I said, just rebase your patch then to force a new build. Perhaps check

Re: Review backlog

2015-08-15 Thread Norbert Thiebaud
On Sat, Aug 15, 2015 at 6:34 PM, Ashod Nakashian ashnak...@gmail.com wrote: In the past I've had a much better response upon submitting patches, so I'm inclined to think everyone is busy (which I highly appreciate,) even though my patches are closer to 1 month old as I write this. This is

Re: Review backlog

2015-08-15 Thread Ashod Nakashian
On Sat, Aug 15, 2015 at 3:42 PM, Thorsten Behrens t...@documentfoundation.org wrote: speaking for myself - I tend to wait for jenkins builds to succeed before having any closer look, so I'd strive for that first (simply rebasing will trigger a new build, should there have been a broken

Re: Review backlog

2015-08-15 Thread Thorsten Behrens
Ashod Nakashian wrote: I have a handful of patches myself on different fixes that didn't get enough interest. Is there a better way to make a review more accessible to reviewers and save their time? Hi Ashod, speaking for myself - I tend to wait for jenkins builds to succeed before having