Re: [libssh2] constness of API parameters

2007-04-18 Thread Dan Fandrich
On Wed, Apr 18, 2007 at 10:11:13PM +0200, Guenter Knauf wrote: > that was all; with this patch compilation works again... Thanks--I've checked this in along with a few more constantifications (no, it's not in the dictionary) I found. >>> Dan -- http://www.MoveAnnouncer.com The web c

Re: [libssh2] constness of API parameters

2007-04-18 Thread Guenter Knauf
Hi Dan, > On Wed, Apr 18, 2007 at 12:32:08AM +0200, Guenter Knauf wrote: >> just commit, and I report back if any problems > I've just checked in the const API changes--I'll assume no news is good > news! --- kex.c.orig Wed Apr 18 21:58:10 2007 +++ kex.c Wed Apr 18 22:08:28 2007 @@ -11

Re: [libssh2] constness of API parameters

2007-04-18 Thread Guenter Knauf
Hi Dan, > On Wed, Apr 18, 2007 at 12:32:08AM +0200, Guenter Knauf wrote: >> just commit, and I report back if any problems > I've just checked in the const API changes--I'll assume no news is good > news! mwccnlm -O2 -DNDEBUG -DNETWARE -nostdinc -DLIBSSH2DEBUG -msgstyle gcc -gccinc - inline

Re: [libssh2] constness of API parameters

2007-04-18 Thread Dan Fandrich
On Wed, Apr 18, 2007 at 12:32:08AM +0200, Guenter Knauf wrote: > just commit, and I report back if any problems I've just checked in the const API changes--I'll assume no news is good news! >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let w

Re: [libssh2] constness of API parameters

2007-04-17 Thread Guenter Knauf
Hi, > There are a number of function calls in the API that have parameters > that should be declared as 'const' but aren't. Making these changes > should not be noticed by any clients (except potentially for > the LIBSSH2_X11_OPEN_FUNC callback, but that would just show a > client bug), but it con

Re: [libssh2] constness of API parameters

2007-04-17 Thread Daniel Stenberg
On Tue, 17 Apr 2007, Dan Fandrich wrote: > There are a number of function calls in the API that have parameters that > should be declared as 'const' but aren't. Making these changes should not > be noticed by any clients (except potentially for the LIBSSH2_X11_OPEN_FUNC > callback, but that wo

Re: [libssh2] constness of API parameters

2007-04-17 Thread James Housley
On Apr 17, 2007, at 3:21 PM, Dan Fandrich wrote: > There are a number of function calls in the API that have parameters > that should be declared as 'const' but aren't. Making these changes > should not be noticed by any clients (except potentially for > the LIBSSH2_X11_OPEN_FUNC callback, but t

[libssh2] constness of API parameters

2007-04-17 Thread Dan Fandrich
There are a number of function calls in the API that have parameters that should be declared as 'const' but aren't. Making these changes should not be noticed by any clients (except potentially for the LIBSSH2_X11_OPEN_FUNC callback, but that would just show a client bug), but it constitute an API