Re: libssh2_knownhost_*

2009-05-28 Thread Daniel Stenberg
On Thu, 28 May 2009, Alexander Lamaison wrote: > Oh dear. That's a shame :( I had a look at this article > http://msdn.microsoft.com/en-us/library/ms235460.aspx and it says the > problem only occurs when libssh2 or its client is linked to the CRT > statically (/MT). Although I imagine this is

RE: libssh2_knownhost_*

2009-05-28 Thread Neil Gierman
> From: Alexander Lamaison [mailto:sw...@lammy.co.uk] > Oh dear. That's a shame :( I had a look at this article > http://msdn.microsoft.com/en-us/library/ms235460.aspx and it says the > problem only occurs when libssh2 or its client is linked to the CRT > statically (/MT). Although I imagine thi

Re: libssh2_knownhost_*

2009-05-28 Thread Alexander Lamaison
2009/5/28 Daniel Stenberg : > On Thu, 28 May 2009, Alexander Lamaison wrote: > >> filename parameters:  The knownhost_*file functions take a const char* >> filename parameter which they proceed to open and use.  While this is common >> in APIs, I would argue that it is better to take a FILE* and al

Re: libssh2_knownhost_*

2009-05-28 Thread Peter Stuge
Alexander Lamaison wrote: > libssh2_knownhost_dumpfile: The name of this function implies > something related to debugging but it isn't. I would suggest > something like knownhost_persistfile, knownhost_writefile, or > knownhost_savefile. 'persist' has the advantage of making it > appear next to

Re: libssh2_knownhost_*

2009-05-28 Thread Daniel Stenberg
On Thu, 28 May 2009, Simon Josefsson wrote: Something is missing? ssh2_exec.c:146: error: ‘LIBSSH2_KNOWNHOST_TYPE_DEFAULT’ undeclared (first use in this function) Ah yes, I removed that define but I didn't yet commit my updated example since I have a lot of local test-changes in there too.

Re: libssh2_knownhost_*

2009-05-28 Thread Daniel Stenberg
On Thu, 28 May 2009, Alexander Lamaison wrote: > Thanks for all the great work Daniel. I'm very pleased to see this API > appear. After a quick skim of the code a few issues came to mind: Thanks for your feedback! > libssh2_knownhost_dumpfile: The name of this function implies something > r

Re: libssh2_knownhost_*

2009-05-28 Thread Simon Josefsson
Daniel Stenberg writes: > Hello friends, > > I've just pushed my initial 7 man pages for the known hosts API I've been > working on recently. I'm very interested in comments and feedback on its > functionality. Something is missing? ssh2_exec.c:146: error: ‘LIBSSH2_KNOWNHOST_TYPE_DEFAULT’ und

Re: libssh2_knownhost_*

2009-05-28 Thread Alexander Lamaison
2009/5/28 Daniel Stenberg : > > I've just pushed my initial 7 man pages for the known hosts API I've been > working on recently. I'm very interested in comments and feedback on its > functionality. > > The seven functions are: > >        libssh2_knownhost_add        - adds a known host >        lib