Hi all,
I want to suggest this (shamlessly stolen from libcurl, hehe):
--- libssh2.h.orig Tue Jul 10 00:47:32 2007
+++ libssh2.h Sat Jul 14 21:44:32 2007
@@ -79,7 +79,31 @@
typedef long long libssh2_int64_t;
#endif
--- libssh2.h.orig Sat Jul 14 21:53:48 2007
+++ libssh2.h Sat Jul
On Sat, 14 Jul 2007, CVS commit messages for libssh2 wrote:
> For now make LIBSSH2_APINO a long, some compilers make constants an int it
> seems.
[...]
> -#define LIBSSH2_APINO 200706151200
> +#define LIBSSH2_APINO 200706151200L
On cur
On Sat, 14 Jul 2007, CVS commit messages for libssh2 wrote:
> -hostaddr = inet_addr(argv[1]);
> + hostaddr = inet_addr(argv[1]);
Oops, my (emacs) macro made this into a TAB instead of space since that was
what we once used. Did we agree on using spaces instead or where did we end
up
On Jul 14, 2007, at 5:01 PM, Daniel Stenberg wrote:
> On Sat, 14 Jul 2007, CVS commit messages for libssh2 wrote:
>
>> -hostaddr = inet_addr(argv[1]);
>> +hostaddr = inet_addr(argv[1]);
>
> Oops, my (emacs) macro made this into a TAB instead of space since
> that was
> what we once u
On Jul 14, 2007, at 3:51 PM, Guenter Knauf wrote:
> Hi all,
> I want to suggest this (shamlessly stolen from libcurl, hehe):
>
> --- libssh2.h.origTue Jul 10 00:47:32 2007
> +++ libssh2.h Sat Jul 14 21:44:32 2007
> @@ -79,7 +79,31 @@
> typedef long long libssh2_int64_t;
> #endif
>
> --- libs
On Jul 14, 2007, at 4:04 PM, Daniel Stenberg wrote:
> On Sat, 14 Jul 2007, CVS commit messages for libssh2 wrote:
>
>> For now make LIBSSH2_APINO a long, some compilers make constants
>> an int it
>> seems.
>
> [...]
>
>> -#define LIBSSH2_APINO 200706151200
>> +#def
On Sat, 14 Jul 2007, Guenter Knauf wrote:
> I want to suggest this (shamlessly stolen from libcurl, hehe):
Perhaps not too suprisingly, I'm in favour! ;-)
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express
On Jul 14, 2007, at 5:28 PM, CVS commit messages for libssh2 wrote:
> Update of /cvsroot/libssh2/libssh2
> In directory sc8-pr-cvs6.sourceforge.net:/tmp/cvs-serv5605
>
> Modified Files:
> Makefile.am
> Added Files:
> HACKING
> Log Message:
> Metion the current code style in the new fil
On Sat, 14 Jul 2007, James Housley wrote:
>> - keep source lines shorter than 80 columns
> All of the work I did all the code is less then 132 columns.
>
> I tried to keep it as close to 80 as was reasonable without breaking the
> lines in too many places so that the code became unreadable in,
> On Sat, 14 Jul 2007, CVS commit messages for libssh2 wrote:
>> -hostaddr = inet_addr(argv[1]);
>> +hostaddr = inet_addr(argv[1]);
> Oops, my (emacs) macro made this into a TAB instead of space since that
> was
> what we once used. Did we agree on using spaces instead or where did we
>> On current 32 bit systems, ints and longs are the same size: 32 bit.
>> 200706151200 is a value that doesn't fit in 32 bits, be it int or
>> long.
>>
>> 2^32 is 4294967296, and this APINO define is almost 47 times larger...
> You are right, it would need to be a LONG LONG, which is not fully
>
On Jul 14, 2007, at 5:38 PM, Daniel Stenberg wrote:
> On Sat, 14 Jul 2007, James Housley wrote:
>
>>> - keep source lines shorter than 80 columns
>
>> All of the work I did all the code is less then 132 columns.
>>
>> I tried to keep it as close to 80 as was reasonable without
>> breaking the
On Jul 14, 2007, at 5:48 PM, Guenter Knauf wrote:
>>> On current 32 bit systems, ints and longs are the same size: 32 bit.
>>> 200706151200 is a value that doesn't fit in 32 bits, be it int or
>>> long.
>>>
>>> 2^32 is 4294967296, and this APINO define is almost 47 times
>>> larger...
>
>> You a
Hey
I just noticed that 'make dist' broke sometime after July 9 as both mine and
Simon's automated snapshots are no longer made due to that... (and I'm off to
bed)
-
This SF.net email is sponsored by DB2 Express
Download DB
On Sat, Jul 14, 2007 at 05:34:40PM -0400, James Housley wrote:
> On Jul 14, 2007, at 5:28 PM, CVS commit messages for libssh2 wrote:
> > Metion the current code style in the new file called HACKING. In
> > this, we
> > could also add descriptions on how to send us patches and bug
> > reports et
15 matches
Mail list logo
