Re: Add missing sysroot to library path ?
On 31/01/2024 17:15, Joakim Tjernlund wrote: Has some variant of https://lists.gnu.org/archive/html/libtool-patches/2022-04/msg00010.html been discussed/considered ? Joakim The patchset seems good, and that particular patch was most likely forgotten about. I'll look through the thread and the older mailing list discussions and see what the concerns were. I'm currently waiting to do an alpha, so I wouldn't merge it in and/or fix it until after that. On an unrelated note, while looking at the patches I discovered the interesting mix of spaces and tabs throughout ltmain.in. Somehow, I'd previously missed that. -- Ileana Dumitrescu GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354 OpenPGP_0x6570EA01146F7354.asc Description: OpenPGP public key OpenPGP_signature.asc Description: OpenPGP digital signature
Add missing sysroot to library path ?
Has some variant of https://lists.gnu.org/archive/html/libtool-patches/2022-04/msg00010.html been discussed/considered ? Joakim
[PATCH v2 08/12] ltmain.in: Add missing sysroot to library path
From: Khem Raj When using a sysroot we should append it to libdir, which is helpful in cross builds as the system is staged in the sysroot. For normal builds, i.e. when lt_sysroot is not set, it will still behave the same and add -L/usr/lib to the relink command. Signed-off-by: Richard Purdie --- build-aux/ltmain.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in index a4175d99..2fa055ef 100644 --- a/build-aux/ltmain.in +++ b/build-aux/ltmain.in @@ -6503,7 +6503,7 @@ func_mode_link () fi else # We cannot seem to hardcode it, guess we'll fake it. - add_dir=-L$libdir + add_dir="-L$lt_sysroot$libdir" # Try looking first in the location we're being installed to. if test -n "$inst_prefix_dir"; then case $libdir in -- 2.35.1
[PATCH 03/12] ltmain.in: Add missing sysroot to library path
From: Khem Raj When using a sysroot we should append it to libdir, which is helpful in cross builds as the system is staged in the sysroot. For normal builds, i.e. when lt_sysroot is not set, it will still behave the same and add -L/usr/lib to the relink command. Signed-off-by: Richard Purdie --- build-aux/ltmain.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in index 3d5dcd0a..2c994612 100644 --- a/build-aux/ltmain.in +++ b/build-aux/ltmain.in @@ -6475,7 +6475,7 @@ func_mode_link () fi else # We cannot seem to hardcode it, guess we'll fake it. - add_dir=-L$libdir + add_dir="-L$lt_sysroot$libdir" # Try looking first in the location we're being installed to. if test -n "$inst_prefix_dir"; then case $libdir in -- 2.25.1
