argz whitespace

2008-05-20 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 FYI: I committed a patch that kills the trailing whitespace in argz.{c,m4} to match gnulib's change: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=a0bdb06#patch10 Also, would anyone be interested in a patch that renames argz_.h to

Re: argz whitespace

2008-05-20 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 5/20/2008 6:32 AM: | Also, would anyone be interested in a patch that renames argz_.h to | argz.in.h to match gnulib? Gnulib recently changed to avoid _ in file | names where possible, and these days, platforms that don't

Re: argz whitespace

2008-05-20 Thread Bob Friesenhahn
On Tue, 20 May 2008, Eric Blake wrote: Also, would anyone be interested in a patch that renames argz_.h to argz.in.h to match gnulib? Gnulib recently changed to avoid _ in file names where possible, and these days, platforms that don't handle two . in a file name are generally not worth porting

Re: argz whitespace

2008-05-20 Thread Bob Friesenhahn
On Tue, 20 May 2008, Eric Blake wrote: According to Eric Blake on 5/20/2008 6:32 AM: | Also, would anyone be interested in a patch that renames argz_.h to | argz.in.h to match gnulib? Gnulib recently changed to avoid _ in file | names where possible, and these days, platforms that don't handle

Re: argz whitespace

2008-05-20 Thread Bob Friesenhahn
On Tue, 20 May 2008, Bob Friesenhahn wrote: There is a palpable cost to renaming libltdl/argz_.h and the cost should be carefully considered before renaming files. Have you considered the cost? What is the value behind this change and is the value obtained greater than the cumulative cost?

Re: [PATCH] [mingw] Add cross-compile support to cwrapper

2008-05-20 Thread Roumen Petrov
No answer from wine-developers ( http://www.winehq.org/pipermail/wine-devel/2008-May/065695.html ) As expected you patch pass my test :). Lets go upstream. Roumen Roumen Petrov wrote: Charles Wilson wrote: Roumen Petrov wrote: Charles Wilson wrote: [mingw] Add cross-compile support to

Re: argz whitespace

2008-05-20 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bob Friesenhahn on 5/20/2008 10:14 AM: | On Tue, 20 May 2008, Eric Blake wrote: | Also, would anyone be interested in a patch that renames argz_.h to | argz.in.h to match gnulib? Gnulib recently changed to avoid _ in file | names where

Re: argz whitespace

2008-05-20 Thread Bob Friesenhahn
On Tue, 20 May 2008, Eric Blake wrote: | What qualifies a platform as not being worth porting to? It's somewhat subjective. The gnulib mailing list has come up with an ad-hoc definition of any platform released within the last 3-5 years, and preferably where the vendor has not declared the

Re: [PATCH] [mingw] Add cross-compile support to cwrapper

2008-05-20 Thread Charles Wilson
Roumen Petrov wrote: No answer from wine-developers ( http://www.winehq.org/pipermail/wine-devel/2008-May/065695.html ) As expected you patch pass my test :). That's good to know. Except for one issue [1], I'm of the opinion that my current patch is pedantically correct -- but slow, while

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-20 Thread Charles Wilson
Eric Blake wrote: Eric Blake ebb9 at byu.net writes: | + /* otherwise ... */ | + newargz[++newargc] = xstrdup (argv[i]); Shouldn't you handle -- as the end of wrapper options, in case the user really wants to pass --lt-env-* as the first option to the wrapped executable? This