Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-28 22:09 skrev Ralf Wildenhues: Hello Peter, * Peter Rosin wrote on Tue, Sep 28, 2010 at 08:08:13PM CEST: Ok to push? Avoiding assert doesn't seem like a scalable solution: lots of packages use assert for testing. assert is ANSI C. We use assert in slist.at. Is there a way

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Charles Wilson
On 9/29/2010 4:06 AM, Peter Rosin wrote: Cygwin is always running with this error mode (I think), MSYS is not. Cygwin no longer supports Win9x, MSYS does. Will this patch cause any issues if people try to use libtool + MSYS on a Win9x system? -- Chuck

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-29 15:47 skrev Charles Wilson: On 9/29/2010 4:06 AM, Peter Rosin wrote: Cygwin is always running with this error mode (I think), MSYS is not. Cygwin no longer supports Win9x, MSYS does. Will this patch cause any issues if people try to use libtool + MSYS on a Win9x system? I

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Charles Wilson
On 9/29/2010 10:15 AM, Peter Rosin wrote: Den 2010-09-29 15:47 skrev Charles Wilson: Will this patch cause any issues if people try to use libtool + MSYS on a Win9x system? I don't foresee any problems, because SetErrorMode is really old. You were worrying about the entry point not being

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Den 2010-09-29 17:00 skrev Charles Wilson: On 9/29/2010 10:15 AM, Peter Rosin wrote: Den 2010-09-29 15:47 skrev Charles Wilson: Will this patch cause any issues if people try to use libtool + MSYS on a Win9x system? I don't foresee any problems, because SetErrorMode is really old. You were

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Wed, Sep 29, 2010 at 10:06:00AM CEST: Ok to push this one? I don't mind it, but I'll note that the patch will cause testsuite failures when no wrapper is actually used. This can happen - with --disable-shared passed toplevel, or on static-only systems, - on

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-09-29 Thread Peter Rosin
Hi Ralf, Den 2010-09-29 21:01 skrev Ralf Wildenhues: * Peter Rosin wrote on Wed, Sep 29, 2010 at 10:06:00AM CEST: Ok to push this one? I don't mind it, but I'll note that the patch will cause testsuite failures when no wrapper is actually used. This can happen - with --disable-shared