Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Den 2010-10-05 13:33 skrev Peter Rosin: Den 2010-09-30 09:44 skrev Peter Rosin: Maybe the shopt isn't needed after all. If the SetErrorMode call checks if the SEM_FAILCRITICALERRORS is already set, that could be used to determine if the CREATE_DEFAULT_ERROR_MODE flag should be added in

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Gary V. Vaughan
Hi Peter, On 20 Oct 2010, at 13:31, Peter Rosin wrote: Den 2010-10-05 13:33 skrev Peter Rosin: Den 2010-09-30 09:44 skrev Peter Rosin: Maybe the shopt isn't needed after all. If the SetErrorMode call checks if the SEM_FAILCRITICALERRORS is already set, that could be used to determine if the

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Hi Gary, Den 2010-10-20 08:55 skrev Gary V. Vaughan: On 20 Oct 2010, at 13:31, Peter Rosin wrote: Den 2010-10-05 13:33 skrev Peter Rosin: Den 2010-09-30 09:44 skrev Peter Rosin: Maybe the shopt isn't needed after all. If the SetErrorMode call checks if the SEM_FAILCRITICALERRORS is already

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Charles Wilson
On 10/20/2010 2:31 AM, Peter Rosin wrote: Den 2010-10-05 13:33 skrev Peter Rosin: I have implemented exactly that and just posted this to the MinGW patch tracker: http://sourceforge.net/tracker/index.php?func=detailaid=3081421group_id=2435atid=302435 The silence is deafening. Chuck,

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Den 2010-10-20 17:55 skrev Charles Wilson: On 10/20/2010 2:31 AM, Peter Rosin wrote: Den 2010-10-05 13:33 skrev Peter Rosin: I have implemented exactly that and just posted this to the MinGW patch tracker: http://sourceforge.net/tracker/index.php?func=detailaid=3081421group_id=2435atid=302435

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Peter Rosin
Den 2010-10-20 18:53 skrev Peter Rosin: Den 2010-10-20 17:55 skrev Charles Wilson: if we (MSYS) want to preserve existing popup-showing behavior at all -- which I think we do. MAYBE the following (pseudo-bat-code, where MSYS_NOPOP is set based on --no-popups arg to .bat file): if

Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.

2010-10-20 Thread Cesar Strauss
On 10/20/2010 02:53 PM, Peter Rosin wrote: Den 2010-10-20 17:55 skrev Charles Wilson: On 10/20/2010 2:31 AM, Peter Rosin wrote: Den 2010-10-05 13:33 skrev Peter Rosin: I have implemented exactly that and just posted this to the MinGW patch tracker: