Hi/2. Peter Rosin wrote: > Hi! > > On 2016-02-22 12:21, Pavel Raiskup wrote: >> KO Myung-Hun, thanks for this patch but I need to see a bit deeper >> reasoning for this change as I do not understand the code properly. >> >> As the $file_list_spec is used in libtool under special circumstances, can >> you describe what are the values of important variables (or could you post >> a full libtool output with shell debugging output)? >> >> Maybe other committers can help with the review? > > Stepping up to the plate... > > The first hunk is for gnu ld on os2, and I believe '@' is correct there. > > The second hunk is for the system linker on os2, whatever that is but I > would guess link.exe or something such. If that's true and this link.exe is > compatible with microsoft link.exe, '@' is also correct. Two big ifs though. > I'm not even sure if it is sensible to talk about a system linker on os2, > but it is not gnu ld (it would have been handled by the first hunk in that > case). >
All the linker on OS/2 accept '@'. > The third hunk is for everything C++, and maybe libtool only works for > g++ anyway on os2? I don't know, but if that is the case, '@' is ok. > C++ as well. > I don't know if anything but gnu tools ever worked with libtool on os2? > emx tools. ^^ > Cheers, > Peter > >> On Wednesday 16 of December 2015 12:59:17 KO Myung-Hun wrote: >>> Creating and linking reloadable objects sometimes fail. >>> >>> * m4/libtool.m4 (_LT_LINKER_SHLIBS, _LT_LANG_CXX_CONFIG) <os2-*>: >>> Set file_list_spec to '@'. >>> --- >>> m4/libtool.m4 | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/m4/libtool.m4 b/m4/libtool.m4 >>> index 2e8c3cf..c01f8fb 100644 >>> --- a/m4/libtool.m4 >>> +++ b/m4/libtool.m4 >>> @@ -5169,6 +5169,7 @@ _LT_EOF >>> emximp -o $lib $output_objdir/$libname.def' >>> _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o >>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' >>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes >>> + _LT_TAGVAR(file_list_spec, $1)='@' >>> ;; >>> >>> interix[[3-9]]*) >>> @@ -5874,6 +5875,7 @@ _LT_EOF >>> emximp -o $lib $output_objdir/$libname.def' >>> _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o >>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' >>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes >>> + _LT_TAGVAR(file_list_spec, $1)='@' >>> ;; >>> >>> osf3*) >>> @@ -6743,6 +6745,7 @@ if test yes != "$_lt_caught_CXX_error"; then >>> emximp -o $lib $output_objdir/$libname.def' >>> _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o >>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' >>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes >>> + _LT_TAGVAR(file_list_spec, $1)='@' >>> ;; >>> >>> dgux*) >>> >> >> -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr