Re: [PATCH v2 01/12] ltmain.sh: Fix sysroot paths being encoded into RPATHs

2022-04-16 Thread Alex Ameen
This was all green down the line on the test suite on multiple systems ( don't get too excited yet ) until I found bugs in the testsuite... I see how this flew under the radar previously though - currently there are no tests which attempt to check RPATH or RUNPATH entries. I'll definitely be

Re: [PATCH v2 00/12] Rebased version of Yocto patches

2022-04-16 Thread Alex Ameen
My bad I just saw the follow up emails. You're all good. On Sat, Apr 16, 2022, 1:29 PM Alex Ameen wrote: > Can you separate the flag changes from the others? > Since that's not backwards compatible it needs to be shelved for a future > major release. There's similar flag changes I've been

Re: [PATCH v2 00/12] Rebased version of Yocto patches

2022-04-16 Thread Alex Ameen
Can you separate the flag changes from the others? Since that's not backwards compatible it needs to be shelved for a future major release. There's similar flag changes I've been organizing into a pile. On Sat, Apr 16, 2022, 12:58 PM Sam James wrote: > Done after discussion w/ Alex (thanks!).

[PATCH v2 12/12] libtool: Fix support for NIOS2 processor

2022-04-16 Thread Sam James
From: Marek Vasut The name of the system contains the string "nios2". This string is caught by the some of the greedy checks for OS/2 in libtool, in particular the *os2* branches of switch statements match for the nios2 string, which results in incorrect behavior of libtool. This patch adds an

[PATCH v2 09/12] libtool.m4: Handle "/" as a sysroot correctly

2022-04-16 Thread Sam James
From: Richard Purdie Update libtool.m4 to resolve a problem with lt_sysroot not being properly updated if the option '--with[-libtool]-sysroot' is not provided when running the 'configure' script for a package so that "/" as a sysroot is handled correctly by libtool. Signed-off-by: Richard

[PATCH v2 10/12] ltmain.in: Handle prefix-map compiler options correctly

2022-04-16 Thread Sam James
From: Richard Purdie If lto is enabled, we need the prefix-map variables to be passed to the linker. Add these to the list of options libtool passes through. Signed-off-by: Richard Purdie --- build-aux/ltmain.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 06/12] Makefile.am: make sure autoheader run before autoconf

2022-04-16 Thread Sam James
From: Mingli Yu autoheader will update ../libtool-2.4.6/libltdl/config-h.in which autoconf needs, so there comes a race sometimes as below: | configure.ac:45: error: required file 'config-h.in' not found | touch '../libtool-2.4.6/libltdl/config-h.in' So make sure autoheader run before

[PATCH v2 04/12] ltmain.in: Don't encode RATHS which match default linker paths

2022-04-16 Thread Sam James
From: Richard Purdie We don't want to add RPATHS which match default linker search paths, they're a waste of space. This patch filters libtools list of paths to encoode and removes the ones we don't need. Libtool may be passed link paths of the form "/usr/lib/../lib" so normalize the paths

[PATCH v2 11/12] Makefile.am: make sure autoheader run before automake

2022-04-16 Thread Sam James
From: Mingli Yu When use automake to generate Makefile.in from Makefile.am, there comes below race: | configure.ac:45: error: required file 'config-h.in' not found It is because the file config-h.in in updating process by autoheader, so make automake run after autoheader to avoid the above

[PATCH v2 07/12] libtool: Check for static libs for internal compiler libraries

2022-04-16 Thread Sam James
From: Khem Raj Libtool checks only for libraries linked as -l* when trying to find internal compiler libraries. Clang, however uses the absolute path to link its internal libraries e.g. compiler_rt. This patch handles clang's statically linked libraries when finding internal compiler libraries.

[PATCH v2 08/12] ltmain.in: Add missing sysroot to library path

2022-04-16 Thread Sam James
From: Khem Raj When using a sysroot we should append it to libdir, which is helpful in cross builds as the system is staged in the sysroot. For normal builds, i.e. when lt_sysroot is not set, it will still behave the same and add -L/usr/lib to the relink command. Signed-off-by: Richard Purdie

[PATCH v2 01/12] ltmain.sh: Fix sysroot paths being encoded into RPATHs

2022-04-16 Thread Sam James
From: Richard Purdie There is a bug where RPATHs could end up containing sysroot values when cross compiling which is obviously incorrect. Strip out sysroot components from libdir when building RPATH values to avoid this. Signed-off-by: Richard Purdie --- build-aux/ltmain.in | 14

[PATCH v2 03/12] libtool.m4: For reproducibility stop encoding hostname in libtool script

2022-04-16 Thread Sam James
From: Richard Purdie For reproducibilty, stop encoding the hostname into the libtool script, this isn't really adding much to debugging and most distros are carrying such a patch now as reproducibility is important. Signed-off-by: Richard Purdie --- m4/libtool.m4 | 1 - 1 file changed, 1

[PATCH v2 05/12] libtool.m4: Rename the --with-sysroot option to avoid conflict with gcc/binutils

2022-04-16 Thread Sam James
From: Khem Raj This patch renames the --with-sysroot option to --with-libtool-sysroot to avoid namespace conflict with binutils, gcc and other toolchain components since these componets also add that option to configure and this becomes confusing and conflicting otherwise. Signed-off-by:

[PATCH v2 02/12] ltmain.in: Handle trailing slashes on install commands correctly

2022-04-16 Thread Sam James
From: Richard Purdie A command like: libtool --mode=install /usr/bin/install -c gck-roots-store-standalone.la '/image/usr/lib/gnome-keyring/standalone/' where the path ends with a trailing slash currently fails. This occurs in software like gnome-keyring or pulseaudio and is because the

[PATCH v2 00/12] Rebased version of Yocto patches

2022-04-16 Thread Sam James
Done after discussion w/ Alex (thanks!). Rebased on master after 2.4.7 release. Khem Raj (3): libtool.m4: Rename the --with-sysroot option to avoid conflict with gcc/binutils libtool: Check for static libs for internal compiler libraries ltmain.in: Add missing sysroot to library path