On 2012-10-07 11:59, Roumen Petrov wrote:
Peter Rosin wrote:
On 2012-09-19 23:02, Roumen Petrov wrote:
What about to skip test only if DLL_EXPORT is in pic_flag ?
Since the patch has already been pushed and it is only a test
that may be skipped on some other platforms, I'm going to
wait for
Peter Rosin wrote:
On 2012-09-19 23:02, Roumen Petrov wrote:
Peter Rosin wrote:
SNIP]
So, what do you mean?
On woe libtool define -DDLL_EXPORT as pic flag . So the value is
pic_flag= -DDLL_EXPORT -DPIC
On some other platform PIC default. I don't have asses to
those platforms and I could guess
* tests/with-pic.at: Windows uses -DDLL_EXPORT -DPIC as the pic
flag, but never applies it to static libraries. Cater for this
and skip if no real pic flag is in use.
Signed-off-by: Peter Rosin p...@lysator.liu.se
---
tests/with-pic.at | 11 ++-
1 files changed, 10 insertions(+), 1
Hi Peter,
On 19 ก.ย. 2012, at 15:56, Peter Rosin p...@lysator.liu.se wrote:
* tests/with-pic.at: Windows uses -DDLL_EXPORT -DPIC as the pic
flag, but never applies it to static libraries. Cater for this
and skip if no real pic flag is in use.
[[...]]
Ok to push?
Yes, with nit below
On 2012-09-19 11:20, Gary V. Vaughan wrote:
Hi Peter,
On 19 ก.ย. 2012, at 15:56, Peter Rosin p...@lysator.liu.se wrote:
* tests/with-pic.at: Windows uses -DDLL_EXPORT -DPIC as the pic
flag, but never applies it to static libraries. Cater for this
and skip if no real pic flag is in use.
Peter Rosin wrote:
* tests/with-pic.at: Windows uses -DDLL_EXPORT -DPIC as the pic
flag, but never applies it to static libraries. Cater for this
and skip if no real pic flag is in use.
I'm not sure that this test is suitable for mingw host.
Signed-off-by: Peter Rosin p...@lysator.liu.se
---
On 2012-09-19 21:43, Roumen Petrov wrote:
Peter Rosin wrote:
* tests/with-pic.at: Windows uses -DDLL_EXPORT -DPIC as the pic
flag, but never applies it to static libraries. Cater for this
and skip if no real pic flag is in use.
I'm not sure that this test is suitable for mingw host.
Peter Rosin wrote:
On 2012-09-19 21:43, Roumen Petrov wrote:
Peter Rosin wrote:
* tests/with-pic.at: Windows uses -DDLL_EXPORT -DPIC as the pic
flag, but never applies it to static libraries. Cater for this
and skip if no real pic flag is in use.
I'm not sure that this test is suitable for
On 2012-09-19 23:02, Roumen Petrov wrote:
Peter Rosin wrote:
On 2012-09-19 21:43, Roumen Petrov wrote:
Peter Rosin wrote:
* tests/with-pic.at: Windows uses -DDLL_EXPORT -DPIC as the pic
flag, but never applies it to static libraries. Cater for this
and skip if no real pic flag is in use.